226347 2021-05-27 11:25:35 -0700 [CMake] Add check for timingsafe_bcmp 2021-05-27 14:36:01 -0700 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 don.olmstead don.olmstead annulen benjamin cdumez cmarcelo ews-watchlist gyuyoung.kim ryuan.choi sergio oldest_to_newest 1764425 0 don.olmstead 2021-05-27 11:25:35 -0700 Safer to do a check in CMake and set the default in PlatformHave.h. 1764437 1 429907 don.olmstead 2021-05-27 11:45:02 -0700 Created attachment 429907 Patch 1764443 2 429907 cdumez 2021-05-27 11:54:31 -0700 Comment on attachment 429907 Patch r=me if the bots are happy 1764507 3 ews-feeder 2021-05-27 14:35:58 -0700 Committed r278178 (238221@main): <https://commits.webkit.org/238221@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429907. 429907 2021-05-27 11:45:02 -0700 2021-05-27 14:36:00 -0700 Patch bug-226347.diff text/plain 3718 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA2Yjc1YzUzNjcwNTQuLmU4 NmY2YzMxNGYzMyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDIxLTA1LTI3ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5j b20+CisKKyAgICAgICAgW0NNYWtlXSBBZGQgY2hlY2sgZm9yIHRpbWluZ3NhZmVfYmNtcAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2MzQ3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkcyBhIHN5bWJv bCBjaGVjayBmb3IgdGltaW5nc2FmZV9iY21wIGFuZCBzZXRzIEhBVkVfVElNSU5HU0FGRV9CQ01Q IGFjY29yZGluZ2x5IGluIHRoZQorICAgICAgICBjbWFrZWNvbmZpZy5oLgorCisgICAgICAgICog U291cmNlL2NtYWtlL09wdGlvbnNDb21tb24uY21ha2U6CisKIDIwMjEtMDUtMjcgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2Vk LiBbV1BFXSBCdW1wIHZlcnNpb24gbnVtYmVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi9DaGFu Z2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCAyNTg5ZWVlYmE0MmIuLjcxZTBiYzVj NjdkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dURi9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAyMS0wNS0yNyAgRG9uIE9sbXN0ZWFkICA8ZG9u Lm9sbXN0ZWFkQHNvbnkuY29tPgorCisgICAgICAgIFtDTWFrZV0gQWRkIGNoZWNrIGZvciB0aW1p bmdzYWZlX2JjbXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyNjM0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFVzZSBIQVZFKFRJTUlOR1NBRkVfQkNNUCkgaW4gQ3J5cHRvZ3JhcGhpY1V0aWxpdGllcyBj b2RlLiBTZXQgaXRzIHZhbHVlIGluIFBsYXRmb3JtSGF2ZSBmb3IKKyAgICAgICAgcGxhdGZvcm1z IG5vdCB1c2luZyBDTWFrZS4KKworICAgICAgICAqIHd0Zi9DcnlwdG9ncmFwaGljVXRpbGl0aWVz LmNwcDoKKyAgICAgICAgKiB3dGYvQ3J5cHRvZ3JhcGhpY1V0aWxpdGllcy5oOgorICAgICAgICAq IHd0Zi9QbGF0Zm9ybUhhdmUuaDoKKwogMjAyMS0wNS0yNyAgRGV2aW4gUm91c3NvICA8ZHJvdXNz b0BhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIGBOU0xvY2FsZWAgU1BJIGZvciBjb21wYXJpbmcg bGFuZ3VhZ2UgaWRlbnRpZmllcnMgaW5zdGVhZCBvZiBzdHJpbmcgY29tcGFyaXNvbgpkaWZmIC0t Z2l0IGEvU291cmNlL1dURi93dGYvQ3J5cHRvZ3JhcGhpY1V0aWxpdGllcy5jcHAgYi9Tb3VyY2Uv V1RGL3d0Zi9DcnlwdG9ncmFwaGljVXRpbGl0aWVzLmNwcAppbmRleCAyZjQyMDZiZTAxYWQuLmFj NmFkZGYzMDczYiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQ3J5cHRvZ3JhcGhpY1V0aWxp dGllcy5jcHAKKysrIGIvU291cmNlL1dURi93dGYvQ3J5cHRvZ3JhcGhpY1V0aWxpdGllcy5jcHAK QEAgLTI4LDcgKzI4LDcgQEAKIAogbmFtZXNwYWNlIFdURiB7CiAKLSNpZiAhUExBVEZPUk0oQ09D T0EpICYmICFPUyhPUEVOQlNEKSAmJiAhT1MoRlJFRUJTRCkKKyNpZiAhSEFWRShUSU1JTkdTQUZF X0JDTVApCiBORVZFUl9JTkxJTkUgaW50IGNvbnN0YW50VGltZU1lbWNtcChjb25zdCB2b2lkKiB2 b2lkQSwgY29uc3Qgdm9pZCogdm9pZEIsIHNpemVfdCBsZW5ndGgpCiB7CiAgICAgY29uc3QgdWlu dDhfdCogYSA9IHN0YXRpY19jYXN0PGNvbnN0IHVpbnQ4X3QqPih2b2lkQSk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL3d0Zi9DcnlwdG9ncmFwaGljVXRpbGl0aWVzLmggYi9Tb3VyY2UvV1RGL3d0 Zi9DcnlwdG9ncmFwaGljVXRpbGl0aWVzLmgKaW5kZXggMWI3N2U2MDdkMTg1Li43MjE1NWQyZjg1 NDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0NyeXB0b2dyYXBoaWNVdGlsaXRpZXMuaAor KysgYi9Tb3VyY2UvV1RGL3d0Zi9DcnlwdG9ncmFwaGljVXRpbGl0aWVzLmgKQEAgLTMwLDcgKzMw LDcgQEAKIG5hbWVzcGFjZSBXVEYgewogCiAvLyBSZXR1cm5zIHplcm8gaWYgYXJyYXlzIGFyZSBl cXVhbCwgYW5kIG5vbi16ZXJvIG90aGVyd2lzZS4gRXhlY3V0aW9uIHRpbWUgZG9lcyBub3QgZGVw ZW5kIG9uIGFycmF5IGNvbnRlbnRzLgotI2lmIFBMQVRGT1JNKENPQ09BKSB8fCBPUyhPUEVOQlNE KSB8fCBPUyhGUkVFQlNEKQorI2lmIEhBVkUoVElNSU5HU0FGRV9CQ01QKQogaW5saW5lIGludCBj b25zdGFudFRpbWVNZW1jbXAoY29uc3Qgdm9pZCogdm9pZEEsIGNvbnN0IHZvaWQqIHZvaWRCLCBz aXplX3QgbGVuZ3RoKQogewogICAgIHJldHVybiB0aW1pbmdzYWZlX2JjbXAodm9pZEEsIHZvaWRC LCBsZW5ndGgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm1IYXZlLmggYi9T b3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUhhdmUuaAppbmRleCA0M2JmNGYwYjE3YzAuLjZjNzJjNTAw NTU3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUGxhdGZvcm1IYXZlLmgKKysrIGIvU291 cmNlL1dURi93dGYvUGxhdGZvcm1IYXZlLmgKQEAgLTkzLDYgKzkzLDEwIEBACiAjZGVmaW5lIEhB VkVfQUNDRVNTSUJJTElUWSAxCiAjZW5kaWYKIAorI2lmICFkZWZpbmVkKEhBVkVfVElNSU5HU0FG RV9CQ01QKSAmJiAoUExBVEZPUk0oQ09DT0EpIHx8IE9TKE9QRU5CU0QpIHx8IE9TKEZSRUVCU0Qp KQorI2RlZmluZSBIQVZFX1RJTUlOR1NBRkVfQkNNUCAxCisjZW5kaWYKKwogI2lmICFkZWZpbmVk KEhBVkVfU1REX0ZJTEVTWVNURU0pCiAjaWYgX19oYXNfaW5jbHVkZSg8ZmlsZXN5c3RlbT4pCiAj ZGVmaW5lIEhBVkVfU1REX0ZJTEVTWVNURU0gMQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09w dGlvbnNDb21tb24uY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQppbmRl eCBmODMwOGU1ZjdkZjIuLjZjNDBmMjM4YWI3NyAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09w dGlvbnNDb21tb24uY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNDb21tb24uY21ha2UK QEAgLTE0NCw4ICsxNDQsOSBAQCBXRUJLSVRfQ0hFQ0tfSEFWRV9GVU5DVElPTihIQVZFX1ZBU1BS SU5URiB2YXNwcmludGYpCiAjIENoZWNrIGZvciBzeW1ib2xzCiBXRUJLSVRfQ0hFQ0tfSEFWRV9T WU1CT0woSEFWRV9SRUdFWF9IIHJlZ2V4ZWMgcmVnZXguaCkKIGlmIChOT1QgKCR7Q01BS0VfU1lT VEVNX05BTUV9IFNUUkVRVUFMICJEYXJ3aW4iKSkKLVdFQktJVF9DSEVDS19IQVZFX1NZTUJPTChI QVZFX1BUSFJFQURfTUFJTl9OUCBwdGhyZWFkX21haW5fbnAgcHRocmVhZF9ucC5oKQorICAgIFdF QktJVF9DSEVDS19IQVZFX1NZTUJPTChIQVZFX1BUSFJFQURfTUFJTl9OUCBwdGhyZWFkX21haW5f bnAgcHRocmVhZF9ucC5oKQogZW5kaWYgKCkKK1dFQktJVF9DSEVDS19IQVZFX1NZTUJPTChIQVZF X1RJTUlOR1NBRkVfQkNNUCB0aW1pbmdzYWZlX2JjbXAgc3RyaW5nLmgpCiAjIFdpbmRvd3MgaGFz IHNpZ25hbC5oIGJ1dCBpcyBtaXNzaW5nIHN5bWJvbHMgdGhhdCBhcmUgdXNlZCBpbiBjYWxscyB0 byBzaWduYWwuCiBXRUJLSVRfQ0hFQ0tfSEFWRV9TWU1CT0woSEFWRV9TSUdOQUxfSCBTSUdUUkFQ IHNpZ25hbC5oKQogCg==