226324 2021-05-27 04:43:16 -0700 [css-flexbox] Sanitize the aspect ratio handling code 2021-06-04 01:03:46 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 svillar svillar changseok esprehn+autocc ews-watchlist glenn jfernandez kondapallykalyan pdr rego webkit-bug-importer zalan oldest_to_newest 1764290 0 svillar 2021-05-27 04:43:16 -0700 [css-flexbox] Refactor the aspect ratio handling code 1764292 1 429868 svillar 2021-05-27 04:50:56 -0700 Created attachment 429868 Patch 1765928 2 svillar 2021-06-02 03:41:01 -0700 Ping reviewers 1766347 3 webkit-bug-importer 2021-06-03 04:44:27 -0700 <rdar://problem/78808779> 1766502 4 429868 jfernandez 2021-06-03 13:40:51 -0700 Comment on attachment 429868 Patch r=me 1766708 5 svillar 2021-06-04 01:03:46 -0700 Committed r278450 (238470@main): <https://commits.webkit.org/238470@main> 429868 2021-05-27 04:50:56 -0700 2021-06-03 13:41:01 -0700 Patch bug-226324-20210527135055.patch text/plain 7575 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTM5ODA0MzRmOWQzOTIw YTI4Y2ZiMmJkYmFkNWMzZjkyOTI2NDQ2MS4uOTE2OTVhYjY5Y2Y0ZTViYzYyMzFjYTQwOTRkNjAw ZDAwYzgzMTZkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDIxLTA1LTI3ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZmxl eGJveF0gU2FuaXRpemUgdGhlIGFzcGVjdCByYXRpbyBoYW5kbGluZyBjb2RlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjYzMjQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTYW5pdGl6ZWQgdGhlIGNvZGUg dGhhdCBkZXRlY3RzIHdoZXRoZXIgYXNwZWN0IHJhdGlvIHNob3VsZCBiZSB1c2VkIHRvIGNvbXB1 dGUgc2l6ZXMuIFRoZQorICAgICAgICB1c2VDaGlsZEFzcGVjdFJhdGlvKCkgbWV0aG9kIHdhcyBy ZW1vdmVkIGFzIGl0IHdhcyB2ZXJ5IG1pc2xlYWRpbmcsIHRoZSBuYW1lIHdhcyBhIGJhZCBjaG9p Y2UKKyAgICAgICAgYW5kIGl0IHdhcyB2ZXJ5IGNvbmZ1c2luZy4gQSBuZXcgbWV0aG9kIGNoaWxk SGFzQ29tcHV0YWJsZUFzcGVjdFJhdGlvKCkgd2FzIGFkZGVkLiBJdCB2ZXJpZmllcworICAgICAg ICB3aGV0aGVyIHRoZSBpdGVtIGhhcyBhbiBhc3BlY3QgcmF0aW8gKG9mIGFueSB0eXBlKSBhbmQg d2hldGhlciB3ZSBjb3VsZCBjb21wdXRlIGl0LgorCisgICAgICAgIEFsc28gdHdvIGNhbGxzIHRv IGRldGVjdCB3aGV0aGVyIHRoZSBjcm9zcyBzaXplIHdhcyBkZWZpbml0ZSAob3IgY29uc2lkZXJl ZCBkZWZpbml0ZSkgd2VyZQorICAgICAgICB1bmlmaWVkIGluIGEgc2luZ2xlIG1ldGhvZC4KKwor ICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhlcmUgaXMgbm8gY2hhbmdlIGluIGJlaGF2aW91ci4K KworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJGbGV4aWJsZUJveDo6Y2hpbGRIYXNDb21wdXRhYmxlQXNwZWN0UmF0aW8g Y29uc3QpOiBOZXcgbWV0aG9kIHdoaWNoIHRha2VzIHRoZQorICAgICAgICBjaGVja3MgZnJvbSB1 c2VDaGlsZEFzcGVjdFJhdGlvLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmxleGlibGVCb3g6 OmNoaWxkSGFzQ29tcHV0YWJsZUFzcGVjdFJhdGlvQW5kQ3Jvc3NTaXplSXNDb25zaWRlcmVkRGVm aW5pdGUpOgorICAgICAgICBOZXcgbWV0aG9kIGRvaW5nIDMgZGlmZmVyZW50IGNoZWNrcy4KKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlckZsZXhpYmxlQm94OjpjaGlsZENyb3NzU2l6ZVNob3VsZFVz ZUNvbnRhaW5lckNyb3NzU2l6ZSBjb25zdCk6IFJlbW92ZWQgdGhlIGFzcGVjdAorICAgICAgICBy YXRpbyBjaGVja3Mgd2hpY2ggbWFrZSBubyBzZW5zZSB0aGVyZS4KKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlckZsZXhpYmxlQm94Ojpjb21wdXRlSW5uZXJGbGV4QmFzZVNpemVGb3JDaGlsZCk6IFVz ZSB0aGUgbmV3IG1ldGhvZC4KKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZsZXhpYmxlQm94Ojph ZGp1c3RDaGlsZFNpemVGb3JNaW5BbmRNYXgpOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckZsZXhpYmxlQm94Ojp1c2VDaGlsZEFzcGVjdFJhdGlvKTogRGVsZXRlZC4KKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guaDoKKwogMjAyMS0wNS0yNyAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgU3VwcG9ydCBIMjY0IHByb2ZpbGVz IGluIE1lZGlhUmVjb3JkZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJGbGV4aWJsZUJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxl eGlibGVCb3guY3BwCmluZGV4IGU5MGRjMWE4YWQyYzEyNDA4ZDgwMjY0ZmZkMTdiY2E5MGQyYTky MzkuLjM4NTdiZTc2MTA5MjQwMmE2YWY5NTdkOTkyMDRiMjA5M2I4MWMxNWMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcApAQCAtNzkxLDE3ICs3 OTEsNiBAQCBMZW5ndGggUmVuZGVyRmxleGlibGVCb3g6Om1haW5TaXplTGVuZ3RoRm9yQ2hpbGQo U2l6ZVR5cGUgc2l6ZVR5cGUsIGNvbnN0IFJlbmRlcgogICAgIHJldHVybiB7IH07CiB9CiAKLWJv b2wgUmVuZGVyRmxleGlibGVCb3g6OnVzZUNoaWxkQXNwZWN0UmF0aW8oY29uc3QgUmVuZGVyQm94 JiBjaGlsZCkKLXsKLSAgICBpZiAoIWNoaWxkSGFzQXNwZWN0UmF0aW8oY2hpbGQpKQotICAgICAg ICByZXR1cm4gZmFsc2U7Ci0gICAgaWYgKCFjaGlsZC5pbnRyaW5zaWNTaXplKCkuaGVpZ2h0KCkg JiYgIWNoaWxkLnN0eWxlKCkuaGFzQXNwZWN0UmF0aW8oKSkgewotICAgICAgICAvLyBXZSBjYW4n dCBjb21wdXRlIGEgcmF0aW8gaW4gdGhpcyBjYXNlLgotICAgICAgICByZXR1cm4gZmFsc2U7Ci0g ICAgfQotICAgIHJldHVybiBjaGlsZENyb3NzU2l6ZUlzRGVmaW5pdGUoY2hpbGQsIGNyb3NzU2l6 ZUxlbmd0aEZvckNoaWxkKE1haW5PclByZWZlcnJlZFNpemUsIGNoaWxkKSk7Ci19Ci0KIC8vIEZJ WE1FOiBjb21wdXRlTWFpblNpemVGcm9tQXNwZWN0UmF0aW9Vc2luZyBtYXkgbmVlZCB0byByZXR1 cm4gYW4gT3B0aW9uYWw8TGF5b3V0VW5pdD4gaW4gdGhlIGZ1dHVyZQogLy8gcmF0aGVyIHRoYW4g cmV0dXJuaW5nIGluZGVmaW5pdGUgc2l6ZXMgYXMgMC8tMS4KIExheW91dFVuaXQgUmVuZGVyRmxl eGlibGVCb3g6OmNvbXB1dGVNYWluU2l6ZUZyb21Bc3BlY3RSYXRpb1VzaW5nKGNvbnN0IFJlbmRl ckJveCYgY2hpbGQsIExlbmd0aCBjcm9zc1NpemVMZW5ndGgpIGNvbnN0CkBAIC04ODIsMTUgKzg3 MSwyMSBAQCBib29sIFJlbmRlckZsZXhpYmxlQm94OjpjaGlsZE1haW5TaXplSXNEZWZpbml0ZShj b25zdCBSZW5kZXJCb3gmIGNoaWxkLCBjb25zdCBMZQogICAgIHJldHVybiB0cnVlOwogfQogCi1i b29sIFJlbmRlckZsZXhpYmxlQm94OjpjaGlsZENyb3NzU2l6ZVNob3VsZFVzZUNvbnRhaW5lckNy b3NzU2l6ZShjb25zdCBSZW5kZXJCb3gmIGNoaWxkKSBjb25zdAorYm9vbCBSZW5kZXJGbGV4aWJs ZUJveDo6Y2hpbGRIYXNDb21wdXRhYmxlQXNwZWN0UmF0aW8oY29uc3QgUmVuZGVyQm94JiBjaGls ZCkgY29uc3QKIHsKICAgICBpZiAoIWNoaWxkSGFzQXNwZWN0UmF0aW8oY2hpbGQpKQogICAgICAg ICByZXR1cm4gZmFsc2U7Ci0gICAgaWYgKCFjaGlsZC5pbnRyaW5zaWNTaXplKCkuaGVpZ2h0KCkg JiYgIWNoaWxkLnN0eWxlKCkuaGFzQXNwZWN0UmF0aW8oKSkgewotICAgICAgICAvLyBXZSBjYW4n dCBjb21wdXRlIGEgcmF0aW8gaW4gdGhpcyBjYXNlLgotICAgICAgICByZXR1cm4gZmFsc2U7Ci0g ICAgfQorICAgIHJldHVybiBjaGlsZC5pbnRyaW5zaWNTaXplKCkuaGVpZ2h0KCkgfHwgY2hpbGQu c3R5bGUoKS5oYXNBc3BlY3RSYXRpbygpOworfQorCitib29sIFJlbmRlckZsZXhpYmxlQm94Ojpj aGlsZEhhc0NvbXB1dGFibGVBc3BlY3RSYXRpb0FuZENyb3NzU2l6ZUlzQ29uc2lkZXJlZERlZmlu aXRlKGNvbnN0IFJlbmRlckJveCYgY2hpbGQpCit7CisgICAgcmV0dXJuIGNoaWxkSGFzQ29tcHV0 YWJsZUFzcGVjdFJhdGlvKGNoaWxkKQorICAgICAgICAmJiAoY2hpbGRDcm9zc1NpemVJc0RlZmlu aXRlKGNoaWxkLCBjcm9zc1NpemVMZW5ndGhGb3JDaGlsZChNYWluT3JQcmVmZXJyZWRTaXplLCBj aGlsZCkpIHx8IGNoaWxkQ3Jvc3NTaXplU2hvdWxkVXNlQ29udGFpbmVyQ3Jvc3NTaXplKGNoaWxk KSk7Cit9CiAKK2Jvb2wgUmVuZGVyRmxleGlibGVCb3g6OmNoaWxkQ3Jvc3NTaXplU2hvdWxkVXNl Q29udGFpbmVyQ3Jvc3NTaXplKGNvbnN0IFJlbmRlckJveCYgY2hpbGQpIGNvbnN0Cit7CiAgICAg Ly8gOS44IGh0dHBzOi8vZHJhZnRzLmNzc3dnLm9yZy9jc3MtZmxleGJveC8jZGVmaW5pdGUtc2l6 ZXMKICAgICAvLyAxLiBJZiBhIHNpbmdsZS1saW5lIGZsZXggY29udGFpbmVyIGhhcyBhIGRlZmlu aXRlIGNyb3NzIHNpemUsIHRoZSBhdXRvbWF0aWMgcHJlZmVycmVkIG91dGVyIGNyb3NzIHNpemUg b2YgYW55CiAgICAgLy8gc3RyZXRjaGVkIGZsZXggaXRlbXMgaXMgdGhlIGZsZXggY29udGFpbmVy J3MgaW5uZXIgY3Jvc3Mgc2l6ZSAoY2xhbXBlZCB0byB0aGUgZmxleCBpdGVtJ3MgbWluIGFuZCBt YXggY3Jvc3Mgc2l6ZSkKQEAgLTk1Miw3ICs5NDcsNyBAQCBMYXlvdXRVbml0IFJlbmRlckZsZXhp YmxlQm94Ojpjb21wdXRlSW5uZXJGbGV4QmFzZVNpemVGb3JDaGlsZChSZW5kZXJCb3gmIGNoaWxk LAogICAgIGlmIChjaGlsZE1haW5TaXplSXNEZWZpbml0ZShjaGlsZCwgZmxleEJhc2lzKSkKICAg ICAgICAgcmV0dXJuIHN0ZDo6bWF4KDBfbHUsIGNvbXB1dGVNYWluQXhpc0V4dGVudEZvckNoaWxk KGNoaWxkLCBNYWluT3JQcmVmZXJyZWRTaXplLCBmbGV4QmFzaXMpLnZhbHVlKCkpOwogCi0gICAg aWYgKHVzZUNoaWxkQXNwZWN0UmF0aW8oY2hpbGQpIHx8IGNoaWxkQ3Jvc3NTaXplU2hvdWxkVXNl Q29udGFpbmVyQ3Jvc3NTaXplKGNoaWxkKSkgeworICAgIGlmIChjaGlsZEhhc0NvbXB1dGFibGVB c3BlY3RSYXRpb0FuZENyb3NzU2l6ZUlzQ29uc2lkZXJlZERlZmluaXRlKGNoaWxkKSkgewogICAg ICAgICBjb25zdCBMZW5ndGgmIGNyb3NzU2l6ZUxlbmd0aCA9IGNyb3NzU2l6ZUxlbmd0aEZvckNo aWxkKE1haW5PclByZWZlcnJlZFNpemUsIGNoaWxkKTsKICAgICAgICAgcmV0dXJuIGFkanVzdENo aWxkU2l6ZUZvckFzcGVjdFJhdGlvQ3Jvc3NBeGlzTWluQW5kTWF4KGNoaWxkLCBjb21wdXRlTWFp blNpemVGcm9tQXNwZWN0UmF0aW9Vc2luZyhjaGlsZCwgY3Jvc3NTaXplTGVuZ3RoKSk7CiAgICAg fQpAQCAtMTIyNSw3ICsxMjIwLDcgQEAgTGF5b3V0VW5pdCBSZW5kZXJGbGV4aWJsZUJveDo6YWRq dXN0Q2hpbGRTaXplRm9yTWluQW5kTWF4KFJlbmRlckJveCYgY2hpbGQsIExheW8KICAgICAgICAg Ly8gZW5zdXJlIGl0J3MgdmFsaWQgdGhyb3VnaCB0aGUgdmlydHVhbCBjYWxscyBvZiBjb21wdXRl SW50cmluc2ljTG9naWNhbENvbnRlbnRIZWlnaHRVc2luZy4KICAgICAgICAgTGF5b3V0VW5pdCBj b250ZW50U2l6ZTsKICAgICAgICAgTGVuZ3RoIGNoaWxkQ3Jvc3NTaXplTGVuZ3RoID0gY3Jvc3NT aXplTGVuZ3RoRm9yQ2hpbGQoTWFpbk9yUHJlZmVycmVkU2l6ZSwgY2hpbGQpOwotICAgICAgICBp ZiAoY2hpbGQuaXNSZW5kZXJSZXBsYWNlZCgpICYmIHVzZUNoaWxkQXNwZWN0UmF0aW8oY2hpbGQp KQorICAgICAgICBpZiAoY2hpbGQuaXNSZW5kZXJSZXBsYWNlZCgpICYmIGNoaWxkSGFzQ29tcHV0 YWJsZUFzcGVjdFJhdGlvKGNoaWxkKSAmJiBjaGlsZENyb3NzU2l6ZUlzRGVmaW5pdGUoY2hpbGQs IGNoaWxkQ3Jvc3NTaXplTGVuZ3RoKSkKICAgICAgICAgICAgIGNvbnRlbnRTaXplID0gY29tcHV0 ZU1haW5TaXplRnJvbUFzcGVjdFJhdGlvVXNpbmcoY2hpbGQsIGNoaWxkQ3Jvc3NTaXplTGVuZ3Ro KTsKICAgICAgICAgZWxzZQogICAgICAgICAgICAgY29udGVudFNpemUgPSBjb21wdXRlTWFpbkF4 aXNFeHRlbnRGb3JDaGlsZChjaGlsZCwgTWluU2l6ZSwgTGVuZ3RoKExlbmd0aFR5cGU6Ok1pbkNv bnRlbnQpKS52YWx1ZU9yKDApOwpAQCAtMTI0Miw3ICsxMjM3LDcgQEAgTGF5b3V0VW5pdCBSZW5k ZXJGbGV4aWJsZUJveDo6YWRqdXN0Q2hpbGRTaXplRm9yTWluQW5kTWF4KFJlbmRlckJveCYgY2hp bGQsIExheW8KICAgICAgICAgICAgIHJldHVybiBzdGQ6Om1heChjaGlsZFNpemUsIHN0ZDo6bWlu KHNwZWNpZmllZFNpemUsIGNvbnRlbnRTaXplKSk7CiAgICAgICAgIH0KIAotICAgICAgICBpZiAo Y2hpbGQuaXNSZW5kZXJSZXBsYWNlZCgpICYmICh1c2VDaGlsZEFzcGVjdFJhdGlvKGNoaWxkKSB8 fCBjaGlsZENyb3NzU2l6ZVNob3VsZFVzZUNvbnRhaW5lckNyb3NzU2l6ZShjaGlsZCkpKSB7Cisg ICAgICAgIGlmIChjaGlsZC5pc1JlbmRlclJlcGxhY2VkKCkgJiYgY2hpbGRIYXNDb21wdXRhYmxl QXNwZWN0UmF0aW9BbmRDcm9zc1NpemVJc0NvbnNpZGVyZWREZWZpbml0ZShjaGlsZCkpIHsKICAg ICAgICAgICAgIExheW91dFVuaXQgdHJhbnNmZXJyZWRTaXplID0gY29tcHV0ZU1haW5TaXplRnJv bUFzcGVjdFJhdGlvVXNpbmcoY2hpbGQsIGNoaWxkQ3Jvc3NTaXplTGVuZ3RoKTsKICAgICAgICAg ICAgIHRyYW5zZmVycmVkU2l6ZSA9IGFkanVzdENoaWxkU2l6ZUZvckFzcGVjdFJhdGlvQ3Jvc3NB eGlzTWluQW5kTWF4KGNoaWxkLCB0cmFuc2ZlcnJlZFNpemUpOwogICAgICAgICAgICAgcmV0dXJu IHN0ZDo6bWF4KGNoaWxkU2l6ZSwgc3RkOjptaW4odHJhbnNmZXJyZWRTaXplLCBjb250ZW50U2l6 ZSkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxl Qm94LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guaAppbmRl eCA2NGJhODY3OTJlYTJiOTYzNzk0NzBlMTUxNTAwZTMxNjE4OTI5YmQwLi43MTQ0ZWM3NWQzMjhk MGM3NGU1OTY1MTdjMjg0NzM4NzQ2Y2E5MjY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyRmxleGlibGVCb3guaApAQCAtMTQyLDcgKzE0Miw4IEBAIHByaXZhdGU6CiAgICAg TGF5b3V0VW5pdCBjcm9zc0F4aXNTY3JvbGxiYXJFeHRlbnQoKSBjb25zdDsKICAgICBMYXlvdXRV bml0IGNyb3NzQXhpc1Njcm9sbGJhckV4dGVudEZvckNoaWxkKGNvbnN0IFJlbmRlckJveCYgY2hp bGQpIGNvbnN0OwogICAgIExheW91dFBvaW50IGZsb3dBd2FyZUxvY2F0aW9uRm9yQ2hpbGQoY29u c3QgUmVuZGVyQm94JiBjaGlsZCkgY29uc3Q7Ci0gICAgYm9vbCB1c2VDaGlsZEFzcGVjdFJhdGlv KGNvbnN0IFJlbmRlckJveCYgY2hpbGQpOworICAgIGJvb2wgY2hpbGRIYXNDb21wdXRhYmxlQXNw ZWN0UmF0aW8oY29uc3QgUmVuZGVyQm94JikgY29uc3Q7CisgICAgYm9vbCBjaGlsZEhhc0NvbXB1 dGFibGVBc3BlY3RSYXRpb0FuZENyb3NzU2l6ZUlzQ29uc2lkZXJlZERlZmluaXRlKGNvbnN0IFJl bmRlckJveCYpOwogICAgIGJvb2wgY2hpbGRDcm9zc1NpemVTaG91bGRVc2VDb250YWluZXJDcm9z c1NpemUoY29uc3QgUmVuZGVyQm94JiBjaGlsZCkgY29uc3Q7CiAgICAgTGF5b3V0VW5pdCBjb21w dXRlTWFpblNpemVGcm9tQXNwZWN0UmF0aW9Vc2luZyhjb25zdCBSZW5kZXJCb3gmIGNoaWxkLCBM ZW5ndGggY3Jvc3NTaXplTGVuZ3RoKSBjb25zdDsKICAgICB2b2lkIHNldEZsb3dBd2FyZUxvY2F0 aW9uRm9yQ2hpbGQoUmVuZGVyQm94JiBjaGlsZCwgY29uc3QgTGF5b3V0UG9pbnQmKTsK