226309 2021-05-26 17:55:38 -0700 [Win] Remove unused GraphicsContext::hdc() 2021-06-01 14:05:20 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii andersca webkit-bug-importer oldest_to_newest 1764151 0 fujii 2021-05-26 17:55:38 -0700 [Win] Remove unused GraphicsContext::hdc() 1764153 1 429820 fujii 2021-05-26 17:56:59 -0700 Created attachment 429820 Patch 1764177 2 429820 fujii 2021-05-26 19:44:08 -0700 Comment on attachment 429820 Patch AppleWin EWS failed. It is still used. C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebKitLegacy\win\Plugins\PluginViewWin.cpp(557,8): error C2039: 'hdc': is not a member of 'WebCore::GraphicsContext' [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] 1765319 3 fujii 2021-05-30 21:16:09 -0700 (In reply to Fujii Hironori from comment #2) > AppleWin EWS failed. It is still used. r278265 removed the code. 1765444 4 430212 fujii 2021-05-31 13:52:53 -0700 Created attachment 430212 Patch 1765732 5 430286 fujii 2021-06-01 13:27:42 -0700 Created attachment 430286 Patch for landing 1765750 6 ews-feeder 2021-06-01 14:04:44 -0700 Committed r278328 (238361@main): <https://commits.webkit.org/238361@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430286. 1765751 7 webkit-bug-importer 2021-06-01 14:05:20 -0700 <rdar://problem/78731782> 429820 2021-05-26 17:56:59 -0700 2021-05-31 13:52:44 -0700 Patch bug-226309-20210527095658.patch text/plain 2336 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2MyZWUyMjQyOWZjZjAz YmViOTdlNzZiNTRlZThlMzUwMWVmOTNkNC4uOTQxZmZhODlmOGUyMGE3ZmNkMTliYjY3MGU5ZDk0 OWVhNjY5NjBlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTA1LTI2ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dIFJl bW92ZSB1bnVzZWQgR3JhcGhpY3NDb250ZXh0OjpoZGMoKQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2MzA5CisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9HcmFwaGljc0NvbnRleHQuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93 aW4vR3JhcGhpY3NDb250ZXh0V2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29u dGV4dDo6aGRjIGNvbnN0KTogRGVsZXRlZC4KKwogMjAyMS0wNS0yNiAgV2Vuc29uIEhzaWVoICA8 d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbbWFjT1NdIFN1cHBvcnQgcGFpbnRp bmcgZGF0YSBkZXRlY3RvciBoaWdobGlnaHRzIGluc2lkZSBpbWFnZSBvdmVybGF5cwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0Lmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaAppbmRl eCBiNzMxNzM3NzE4MDQxYjlkODcyNTM4MjRjMDcyYmZkMTcyZTNlNTc1Li5hNTFiNWVhN2YyZjI5 ODE4MDkxOTc1ZDhmMzY4YjM2MmRhMjViYmU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaApAQCAtNTMzLDcgKzUzMyw2IEBAIHB1 YmxpYzoKICNpZiBPUyhXSU5ET1dTKQogICAgIEhEQyBnZXRXaW5kb3dzQ29udGV4dChjb25zdCBJ bnRSZWN0JiwgYm9vbCBzdXBwb3J0QWxwaGFCbGVuZCk7IC8vIFRoZSBwYXNzZWQgaW4gcmVjdCBp cyB1c2VkIHRvIGNyZWF0ZSBhIGJpdG1hcCBmb3IgY29tcG9zaXRpbmcgaW5zaWRlIHRyYW5zcGFy ZW5jeSBsYXllcnMuCiAgICAgdm9pZCByZWxlYXNlV2luZG93c0NvbnRleHQoSERDLCBjb25zdCBJ bnRSZWN0JiwgYm9vbCBzdXBwb3J0QWxwaGFCbGVuZCk7IC8vIFRoZSBwYXNzZWQgaW4gSERDIHNo b3VsZCBiZSB0aGUgb25lIGhhbmRlZCBiYWNrIGJ5IGdldFdpbmRvd3NDb250ZXh0LgotICAgIEhE QyBoZGMoKSBjb25zdDsKIAogICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCBub3QgZXhpc3Q7IHdl IG5lZWQgYSBkaWZmZXJlbnQgcGxhY2UgdG8KICAgICAvLyBwdXQgY29kZSBzaGFyZWQgYmV0d2Vl biBXaW5kb3dzIENHIGFuZCBXaW5kb3dzIENhaXJvIGJhY2tlbmRzLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0dyYXBoaWNzQ29udGV4dFdpbi5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vR3JhcGhpY3NDb250ZXh0V2lu LmNwcAppbmRleCA3N2RhZmUzMjBiYjA3MzA4OTAxMDBkN2M0YWYxMDQxNjM2OWU3MjM0Li5mOGY5 MDQzZTUxYzBhZmI3YTEyNjBkNjg0OTQxYzE1NjM2NTk3YTc4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vR3JhcGhpY3NDb250ZXh0V2luLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vR3JhcGhpY3NDb250ZXh0V2lu LmNwcApAQCAtMTM4LDE0ICsxMzgsNiBAQCBIREMgR3JhcGhpY3NDb250ZXh0OjpnZXRXaW5kb3dz Q29udGV4dChjb25zdCBJbnRSZWN0JiBkc3RSZWN0LCBib29sIHN1cHBvcnRBbHBoYQogICAgIHJl dHVybiBkZXByZWNhdGVkUHJpdmF0ZUNvbnRleHQoKS0+bV9oZGM7CiB9CiAKLUhEQyBHcmFwaGlj c0NvbnRleHQ6OmhkYygpIGNvbnN0Ci17Ci0gICAgaWYgKCFkZXByZWNhdGVkUHJpdmF0ZUNvbnRl eHQoKSkKLSAgICAgICAgcmV0dXJuIG51bGxwdHI7Ci0KLSAgICByZXR1cm4gZGVwcmVjYXRlZFBy aXZhdGVDb250ZXh0KCktPm1faGRjOwotfQotCiAjaWYgUExBVEZPUk0oV0lOKSAmJiAhVVNFKERJ UkVDVDJEKQogdm9pZCBHcmFwaGljc0NvbnRleHRQbGF0Zm9ybVByaXZhdGU6OnNhdmUoKQogewo= 430212 2021-05-31 13:52:53 -0700 2021-06-01 13:27:39 -0700 Patch bug-226309-20210601055251.patch text/plain 2307 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDJkMzJkNjNiYzM0OTk2 NTU3Njk1NjgxMTcxZDkwN2NmNjZiMjA3ZS4uZjRmYWViOGY3YzMxNzY1MmU2MjJmOThkZGIwMzM5 MTRlZjE4MWJiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTA1LTMxICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dIFJl bW92ZSB1bnVzZWQgR3JhcGhpY3NDb250ZXh0OjpoZGMoKQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2MzA5CisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9HcmFwaGljc0NvbnRleHQuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93 aW4vR3JhcGhpY3NDb250ZXh0V2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29u dGV4dDo6aGRjIGNvbnN0KTogRGVsZXRlZC4KKwogMjAyMS0wNC0yOSAgU2VyZ2lvIFZpbGxhciBT ZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBFbmFibGUgPHN1bW1hcnk+IHRv IGJlIGEgZmxleCBjb250YWluZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvR3JhcGhpY3NDb250ZXh0LmgKaW5kZXggYzA0YjAxZTdlOGZlODg5NjU1MzhmNWJlYzFi MTFlOWU1MWMyMjc3Ni4uNWQxNDFiOWJjM2VhNDM0NjgyMWYzOGVkYzFkMTA0NTEzMmZmNmVlYSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250 ZXh0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250 ZXh0LmgKQEAgLTUzMyw3ICs1MzMsNiBAQCBwdWJsaWM6CiAjaWYgT1MoV0lORE9XUykKICAgICBI REMgZ2V0V2luZG93c0NvbnRleHQoY29uc3QgSW50UmVjdCYsIGJvb2wgc3VwcG9ydEFscGhhQmxl bmQpOyAvLyBUaGUgcGFzc2VkIGluIHJlY3QgaXMgdXNlZCB0byBjcmVhdGUgYSBiaXRtYXAgZm9y IGNvbXBvc2l0aW5nIGluc2lkZSB0cmFuc3BhcmVuY3kgbGF5ZXJzLgogICAgIHZvaWQgcmVsZWFz ZVdpbmRvd3NDb250ZXh0KEhEQywgY29uc3QgSW50UmVjdCYsIGJvb2wgc3VwcG9ydEFscGhhQmxl bmQpOyAvLyBUaGUgcGFzc2VkIGluIEhEQyBzaG91bGQgYmUgdGhlIG9uZSBoYW5kZWQgYmFjayBi eSBnZXRXaW5kb3dzQ29udGV4dC4KLSAgICBIREMgaGRjKCkgY29uc3Q7CiAKICAgICAvLyBGSVhN RTogVGhpcyBzaG91bGQgbm90IGV4aXN0OyB3ZSBuZWVkIGEgZGlmZmVyZW50IHBsYWNlIHRvCiAg ICAgLy8gcHV0IGNvZGUgc2hhcmVkIGJldHdlZW4gV2luZG93cyBDRyBhbmQgV2luZG93cyBDYWly byBiYWNrZW5kcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3dpbi9HcmFwaGljc0NvbnRleHRXaW4uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvd2luL0dyYXBoaWNzQ29udGV4dFdpbi5jcHAKaW5kZXggOGI4MDdmOGYwMzViNTczZjQ0 NzQ4OTdjMjVlMGIwNDcyMTBjNGRiZi4uZjUxM2YwYzZlNzEwYmM1Yzg4NzZlNzRjYzRiNTVlMDI4 MWYxMDdlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2lu L0dyYXBoaWNzQ29udGV4dFdpbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvd2luL0dyYXBoaWNzQ29udGV4dFdpbi5jcHAKQEAgLTEwNCwxNCArMTA0LDYgQEAgSERD IEdyYXBoaWNzQ29udGV4dDo6Z2V0V2luZG93c0NvbnRleHQoY29uc3QgSW50UmVjdCYgZHN0UmVj dCwgYm9vbCBzdXBwb3J0QWxwaGEKICAgICByZXR1cm4gZGVwcmVjYXRlZFByaXZhdGVDb250ZXh0 KCktPm1faGRjOwogfQogCi1IREMgR3JhcGhpY3NDb250ZXh0OjpoZGMoKSBjb25zdAotewotICAg IGlmICghZGVwcmVjYXRlZFByaXZhdGVDb250ZXh0KCkpCi0gICAgICAgIHJldHVybiBudWxscHRy OwotCi0gICAgcmV0dXJuIGRlcHJlY2F0ZWRQcml2YXRlQ29udGV4dCgpLT5tX2hkYzsKLX0KLQog I2lmIFBMQVRGT1JNKFdJTikgJiYgIVVTRShESVJFQ1QyRCkKIHZvaWQgR3JhcGhpY3NDb250ZXh0 UGxhdGZvcm1Qcml2YXRlOjpzYXZlKCkKIHsK 430286 2021-06-01 13:27:42 -0700 2021-06-01 14:04:44 -0700 Patch for landing bug-226309-20210602052741.patch text/plain 2386 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2VhYWQ0YzVmMWU0YjQy ODBhNDA5MzgxZGE0ZmEwOTQyZDI0NmUxZi4uYWM3OTQ5OTZlMGU4ZmFiMTE4ODMxODI2ZGQ2OWNk OGFmNTMzMzNlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA2LTAxICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dIFJl bW92ZSB1bnVzZWQgR3JhcGhpY3NDb250ZXh0OjpoZGMoKQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2MzA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg QW5kZXJzIENhcmxzc29uLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3ND b250ZXh0Lmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0dyYXBoaWNzQ29udGV4 dFdpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OmhkYyBjb25zdCk6 IERlbGV0ZWQuCisKIDIwMjEtMDYtMDEgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlA c29ueS5jb20+CiAKICAgICAgICAgW1dpbkNhaXJvXSBHcmFwaGljc0NvbnRleHRDYWlybzo6R3Jh cGhpY3NDb250ZXh0Q2Fpcm8oSERDLCBib29sKSBsZWFrcyBjYWlyb190CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5oCmluZGV4IGMwNGIw MWU3ZThmZTg4OTY1NTM4ZjViZWMxYjExZTllNTFjMjI3NzYuLjVkMTQxYjliYzNlYTQzNDY4MjFm MzhlZGMxZDEwNDUxMzJmZjZlZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5oCkBAIC01MzMsNyArNTMzLDYgQEAgcHVibGljOgog I2lmIE9TKFdJTkRPV1MpCiAgICAgSERDIGdldFdpbmRvd3NDb250ZXh0KGNvbnN0IEludFJlY3Qm LCBib29sIHN1cHBvcnRBbHBoYUJsZW5kKTsgLy8gVGhlIHBhc3NlZCBpbiByZWN0IGlzIHVzZWQg dG8gY3JlYXRlIGEgYml0bWFwIGZvciBjb21wb3NpdGluZyBpbnNpZGUgdHJhbnNwYXJlbmN5IGxh eWVycy4KICAgICB2b2lkIHJlbGVhc2VXaW5kb3dzQ29udGV4dChIREMsIGNvbnN0IEludFJlY3Qm LCBib29sIHN1cHBvcnRBbHBoYUJsZW5kKTsgLy8gVGhlIHBhc3NlZCBpbiBIREMgc2hvdWxkIGJl IHRoZSBvbmUgaGFuZGVkIGJhY2sgYnkgZ2V0V2luZG93c0NvbnRleHQuCi0gICAgSERDIGhkYygp IGNvbnN0OwogCiAgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIG5vdCBleGlzdDsgd2UgbmVlZCBh IGRpZmZlcmVudCBwbGFjZSB0bwogICAgIC8vIHB1dCBjb2RlIHNoYXJlZCBiZXR3ZWVuIFdpbmRv d3MgQ0cgYW5kIFdpbmRvd3MgQ2Fpcm8gYmFja2VuZHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vR3JhcGhpY3NDb250ZXh0V2luLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9HcmFwaGljc0NvbnRleHRXaW4uY3BwCmlu ZGV4IDhiODA3ZjhmMDM1YjU3M2Y0NDc0ODk3YzI1ZTBiMDQ3MjEwYzRkYmYuLmY1MTNmMGM2ZTcx MGJjNWM4ODc2ZTc0Y2M0YjU1ZTAyODFmMTA3ZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9HcmFwaGljc0NvbnRleHRXaW4uY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9HcmFwaGljc0NvbnRleHRXaW4uY3BwCkBA IC0xMDQsMTQgKzEwNCw2IEBAIEhEQyBHcmFwaGljc0NvbnRleHQ6OmdldFdpbmRvd3NDb250ZXh0 KGNvbnN0IEludFJlY3QmIGRzdFJlY3QsIGJvb2wgc3VwcG9ydEFscGhhCiAgICAgcmV0dXJuIGRl cHJlY2F0ZWRQcml2YXRlQ29udGV4dCgpLT5tX2hkYzsKIH0KIAotSERDIEdyYXBoaWNzQ29udGV4 dDo6aGRjKCkgY29uc3QKLXsKLSAgICBpZiAoIWRlcHJlY2F0ZWRQcml2YXRlQ29udGV4dCgpKQot ICAgICAgICByZXR1cm4gbnVsbHB0cjsKLQotICAgIHJldHVybiBkZXByZWNhdGVkUHJpdmF0ZUNv bnRleHQoKS0+bV9oZGM7Ci19Ci0KICNpZiBQTEFURk9STShXSU4pICYmICFVU0UoRElSRUNUMkQp CiB2b2lkIEdyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZTo6c2F2ZSgpCiB7Cg==