226302 2021-05-26 15:54:08 -0700 REGRESSION (r278082?): ASSERTION FAILED: !isCompilationThread() in JSC::Profiler::Database::addCompilation() 2021-05-26 17:36:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=226207 InRadar P2 Normal --- 1 ryanhaddad tzagallo saam tzagallo webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1764096 0 ryanhaddad 2021-05-26 15:54:08 -0700 Seeing the following assert with many tests on the Catalina Debug JSC bot with many profiler-test.yaml/tests/sunspider-1.0 tests ASSERTION FAILED: !isCompilationThread() ./profiler/ProfilerDatabase.cpp(92) : void JSC::Profiler::Database::addCompilation(JSC::CodeBlock *, Ref<JSC::Profiler::Compilation> &&) 1 0x10c89c269 WTFCrash 2 0x10d12b79b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x10e17412a JSC::Profiler::Database::addCompilation(JSC::CodeBlock*, WTF::Ref<JSC::Profiler::Compilation, WTF::RawPtrTraits<JSC::Profiler::Compilation> >&&) 4 0x10de864b4 JSC::JIT::link() 5 0x10de84abb JSC::JIT::compileAndLinkWithoutFinalizing(JSC::JITCompilationEffort) 6 0x10de57e90 JSC::BaselineJITPlan::compileInThreadImpl() 7 0x10df18b3c JSC::JITPlan::compileInThread(JSC::JITWorklistThread*) 8 0x10df8a0f5 JSC::JITWorklist::enqueue(WTF::Ref<JSC::JITPlan, WTF::RawPtrTraits<JSC::JITPlan> >) 9 0x10dfc711e JSC::LLInt::jitCompileAndSetHeuristics(JSC::VM&, JSC::CodeBlock*, JSC::BytecodeIndex) 10 0x10dfc65bd JSC::LLInt::entryOSR(JSC::CodeBlock*, char const*, JSC::LLInt::EntryKind) 11 0x10dfc6772 llint_entry_osr_function_for_call 12 0x10ce99d7f llint_entry 13 0x10ceb8122 llint_entry 14 0x10ceb8122 llint_entry 15 0x10ceb81ca llint_entry 16 0x10ceb81ca llint_entry 17 0x10ce95ef0 vmEntryToJavaScript 18 0x10de3aadb JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) 19 0x10de3a0cd JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::JSGlobalObject*, JSC::JSObject*) 20 0x10e292597 JSC::evaluate(JSC::JSGlobalObject*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) 21 0x10c723ca1 runWithOptions(GlobalObject*, CommandLine&, bool&) 22 0x10c6dad68 jscmain(int, char**)::$_8::operator()(JSC::VM&, GlobalObject*, bool&) const 23 0x10c6ae8d3 int runJSC<jscmain(int, char**)::$_8>(CommandLine const&, bool, jscmain(int, char**)::$_8 const&) 24 0x10c6abfee jscmain(int, char**) 25 0x10c6abd33 main 26 0x7fff6bda1cc9 start https://build.webkit.org/#/builders/17/builds/592/steps/9/logs/stdio 1764097 1 webkit-bug-importer 2021-05-26 15:54:22 -0700 <rdar://problem/78537378> 1764098 2 ryanhaddad 2021-05-26 15:55:34 -0700 Regression range: https://trac.webkit.org/log/webkit/?action=stop_on_copy&mode=stop_on_copy&rev=278092&stop_rev=278080&limit=100&verbose=on 1764099 3 ryanhaddad 2021-05-26 15:56:23 -0700 https://trac.webkit.org/changeset/278082/webkit was the only JSC change in that range 1764114 4 429813 tzagallo 2021-05-26 16:40:38 -0700 Created attachment 429813 Patch 1764143 5 ews-feeder 2021-05-26 17:36:12 -0700 Committed r278139 (238184@main): <https://commits.webkit.org/238184@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429813. 429813 2021-05-26 16:40:38 -0700 2021-05-26 17:36:13 -0700 Patch bug-226302-20210526164036.patch text/plain 1708 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 MmM4ZGQ4NTQ2M2FiZGJjODMzYzMxNzIyZGFmOWY0MzM3NDI0MTg0Li4xMzMwMzljZTUwOWE0NDcz ZDkyODZmMGY2NzRlNzc3MjcxNWEyNGY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAyMS0wNS0yNiAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBSRUdSRVNTSU9OOiBBU1NFUlRJT04gRkFJTEVEOiAhaXNDb21waWxhdGlv blRocmVhZCgpIGluIEpTQzo6UHJvZmlsZXI6OkRhdGFiYXNlOjphZGRDb21waWxhdGlvbigpCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjYzMDIKKyAg ICAgICAgPHJkYXI6Ly83ODUzNzM3OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBXZSBzdGFydGVkIGxpbmtpbmcgdGhlIEpJVCBjb2RlIGluIHRoZSBj b21waWxlciB0aHJlYWQsIHdoaWNoIG5vdyB0cmlnZ2VycyB0aGlzIGFzc2VydGlvbi4KKyAgICAg ICAgVGhlIGFzc2VydGlvbiB3YXMgaW50cm9kdWNlIGJlZm9yZSBhIGxvY2sgd2FzIGhlbGQgdG8g bW9kaWZ5IHRoZSBkYXRhIHN0cnVjdHVyZXMgaW4gdGhlCisgICAgICAgIHByb2ZpbGVyIGRhdGFi YXNlLCBidXQgaXQncyBzYWZlIHRvIHJlbW92ZSBpdCBub3cuCisKKyAgICAgICAgKiBwcm9maWxl ci9Qcm9maWxlckRhdGFiYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6UHJvZmlsZXI6OkRhdGFiYXNl OjphZGRDb21waWxhdGlvbik6CisKIDIwMjEtMDUtMjYgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFw cGxlLmNvbT4KIAogICAgICAgICBVc2UgVW5jaGVja2VkTG9jayBldmVuIGxlc3MgaW4gSmF2YVNj cmlwdENvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wcm9maWxlci9Qcm9m aWxlckRhdGFiYXNlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wcm9maWxlci9Qcm9maWxl ckRhdGFiYXNlLmNwcAppbmRleCAyZDI2ZWUxYTBkNzYzNjJhOTdhY2FiZWZjMjNjZGFiYjU4N2Y5 OTU5Li40MWI0M2ZiMDcyYWMxNjJkOTFmYTZmYjVmNjc5ZGMzNWFhNTc5MDI4IDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcHJvZmlsZXIvUHJvZmlsZXJEYXRhYmFzZS5jcHAKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Byb2ZpbGVyL1Byb2ZpbGVyRGF0YWJhc2UuY3BwCkBA IC04OSw3ICs4OSw2IEBAIHZvaWQgRGF0YWJhc2U6Om5vdGlmeURlc3RydWN0aW9uKENvZGVCbG9j ayogY29kZUJsb2NrKQogdm9pZCBEYXRhYmFzZTo6YWRkQ29tcGlsYXRpb24oQ29kZUJsb2NrKiBj b2RlQmxvY2ssIFJlZjxDb21waWxhdGlvbj4mJiBjb21waWxhdGlvbikKIHsKICAgICBMb2NrZXIg bG9ja2VyIHsgbV9sb2NrIH07Ci0gICAgQVNTRVJUKCFpc0NvbXBpbGF0aW9uVGhyZWFkKCkpOwog CiAgICAgbV9jb21waWxhdGlvbnMuYXBwZW5kKGNvbXBpbGF0aW9uLmNvcHlSZWYoKSk7CiAgICAg bV9jb21waWxhdGlvbk1hcC5zZXQoY29kZUJsb2NrLCBXVEZNb3ZlKGNvbXBpbGF0aW9uKSk7Cg==