<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>226300</bug_id>
          
          <creation_ts>2021-05-26 15:37:03 -0700</creation_ts>
          <short_desc>Cleanup temporary directory after TestWTF&apos;s FileSystemTests</short_desc>
          <delta_ts>2021-05-26 17:36:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Stephan Szabo">stephan.szabo</reporter>
          <assigned_to name="Stephan Szabo">stephan.szabo</assigned_to>
          <cc>cdumez</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1764084</commentid>
    <comment_count>0</comment_count>
    <who name="Stephan Szabo">stephan.szabo</who>
    <bug_when>2021-05-26 15:37:03 -0700</bug_when>
    <thetext>Some tests like FileSystemTest.moveFile, the m_tempEmptyFolderPath is used as a destination and may not get cleaned if the file still exists at the end of the test since it&apos;s no longer empty, so move to using deleteNonEmptyDirectory during cleanup.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1764086</commentid>
    <comment_count>1</comment_count>
      <attachid>429804</attachid>
    <who name="Stephan Szabo">stephan.szabo</who>
    <bug_when>2021-05-26 15:39:45 -0700</bug_when>
    <thetext>Created attachment 429804
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1764090</commentid>
    <comment_count>2</comment_count>
      <attachid>429804</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2021-05-26 15:47:14 -0700</bug_when>
    <thetext>Comment on attachment 429804
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1764142</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-05-26 17:35:47 -0700</bug_when>
    <thetext>Committed r278138 (238183@main): &lt;https://commits.webkit.org/238183@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429804.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1764144</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-05-26 17:36:19 -0700</bug_when>
    <thetext>&lt;rdar://problem/78542451&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>429804</attachid>
            <date>2021-05-26 15:39:45 -0700</date>
            <delta_ts>2021-05-26 17:35:48 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>226300.1.diff</filename>
            <type>text/plain</type>
            <size>1302</size>
            <attacher name="Stephan Szabo">stephan.szabo</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzNDM5
NTNmYzc2NmYuLjU0YTQwYjc5MGExMyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi
L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTA1LTI2ICBTdGVwaGFuIFN6
YWJvICA8c3RlcGhhbi5zemFib0Bzb255LmNvbT4KKworICAgICAgICBDbGVhbnVwIHRlbXBvcmFy
eSBkaXJlY3RvcnkgYWZ0ZXIgVGVzdFdURidzIEZpbGVTeXN0ZW1UZXN0cworICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2MzAwCisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3Rz
L1dURi9GaWxlU3lzdGVtLmNwcDogbW92ZSB0byBkZWxldGVOb25FbXB0eURpcmVjdG9yeSBkdXJp
bmcgdGVzdCBjbGVhbnVwCisKIDIwMjEtMDUtMjYgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5A
YXBwbGUuY29tPgogCiAgICAgICAgIERvIG5vdCBza2lwIFNldENvbW1pdFF1ZXVlTWludXNGbGFn
T25QYXRjaCBzdGVwIG9uIEVXUyB0ZXN0IGluc3RhbmNlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVz
dFdlYktpdEFQSS9UZXN0cy9XVEYvRmlsZVN5c3RlbS5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJ
L1Rlc3RzL1dURi9GaWxlU3lzdGVtLmNwcAppbmRleCA1ZDEwMzhjYWFkNTAuLjlkZmFiYTcwNGVm
YSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvRmlsZVN5c3RlbS5j
cHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvRmlsZVN5c3RlbS5jcHAKQEAg
LTkxLDcgKzkxLDcgQEAgcHVibGljOgogICAgIHsKICAgICAgICAgRmlsZVN5c3RlbTo6ZGVsZXRl
RmlsZShtX3RlbXBGaWxlUGF0aCk7CiAgICAgICAgIEZpbGVTeXN0ZW06OmRlbGV0ZUZpbGUobV90
ZW1wRmlsZVN5bWxpbmtQYXRoKTsKLSAgICAgICAgRmlsZVN5c3RlbTo6ZGVsZXRlRW1wdHlEaXJl
Y3RvcnkobV90ZW1wRW1wdHlGb2xkZXJQYXRoKTsKKyAgICAgICAgRmlsZVN5c3RlbTo6ZGVsZXRl
Tm9uRW1wdHlEaXJlY3RvcnkobV90ZW1wRW1wdHlGb2xkZXJQYXRoKTsKICAgICAgICAgRmlsZVN5
c3RlbTo6ZGVsZXRlRmlsZShtX3RlbXBFbXB0eUZvbGRlclN5bWxpbmtQYXRoKTsKICAgICAgICAg
RmlsZVN5c3RlbTo6ZGVsZXRlRmlsZShtX3RlbXBFbXB0eUZpbGVQYXRoKTsKICAgICAgICAgRmls
ZVN5c3RlbTo6ZGVsZXRlRmlsZShtX3NwYWNlQ29udGFpbmluZ0ZpbGVQYXRoKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>