226289 2021-05-26 13:36:42 -0700 Do not skip SetCommitQueueMinusFlagOnPatch step on EWS test instances 2021-05-26 14:06:21 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1764030 0 aakash_jain 2021-05-26 13:36:42 -0700 SetCommitQueueMinusFlagOnPatch step does two things: 1) set cq- flag on bugzilla bug 2) mark the build as completed Since r273090, this step is skipped on EWS test instances (e.g.: ews-build.webkit-uat.org). However, skipping the part about marking the build complete, causes the build to run extra steps which it shouldn't be running (e.g.: step 20 in https://ews-build.webkit-uat.org/#/builders/34/builds/31441). We shouldn't skip the entire SetCommitQueueMinusFlagOnPatch step on EWS test instances, we should only skip relevant portion about Bugzilla interaction. 1764031 1 429790 aakash_jain 2021-05-26 13:39:06 -0700 Created attachment 429790 [fast-cq] Patch 1764033 2 aakash_jain 2021-05-26 13:40:17 -0700 Sample run: https://ews-build.webkit-uat.org/#/builders/34/builds/31444 1764039 3 ews-feeder 2021-05-26 14:05:24 -0700 Committed r278124 (238174@main): <https://commits.webkit.org/238174@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429790. 1764040 4 webkit-bug-importer 2021-05-26 14:06:21 -0700 <rdar://problem/78531277> 429790 2021-05-26 13:39:06 -0700 2021-05-26 14:05:25 -0700 [fast-cq] Patch bug-226289-20210526163905.patch text/plain 1803 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3ODEyMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTA1LTI2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBEbyBub3Qgc2tpcCBTZXRDb21taXRRdWV1ZU1pbnVzRmxhZ09uUGF0Y2gg c3RlcCBvbiBFV1MgdGVzdCBpbnN0YW5jZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIyNjI4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAg ICAgKFNldENvbW1pdFF1ZXVlTWludXNGbGFnT25QYXRjaC5zdGFydCk6CisgICAgICAgIChTZXRD b21taXRRdWV1ZU1pbnVzRmxhZ09uUGF0Y2guZG9TdGVwSWYpOiBEZWxldGVkLgorCiAyMDIxLTA1 LTI2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBbcnVu LXdlYmtpdC10ZXN0c10gU3RyaXAgcGhwIHN1cHBvcnQgZnJvbSB3ZWJzZXJ2ZXIgKEFwYWNoZSkK SW5kZXg6IFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjc4MTIyKQorKysg VG9vbHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtMTAy OCw3ICsxMDI4LDkgQEAgY2xhc3MgU2V0Q29tbWl0UXVldWVNaW51c0ZsYWdPblBhdGNoKGJ1aQog ICAgICAgICBwYXRjaF9pZCA9IHNlbGYuZ2V0UHJvcGVydHkoJ3BhdGNoX2lkJywgJycpCiAgICAg ICAgIGJ1aWxkX2ZpbmlzaF9zdW1tYXJ5ID0gc2VsZi5nZXRQcm9wZXJ0eSgnYnVpbGRfZmluaXNo X3N1bW1hcnknLCBOb25lKQogCi0gICAgICAgIHJjID0gc2VsZi5zZXRfY3FfbWludXNfZmxhZ19v bl9wYXRjaChwYXRjaF9pZCkKKyAgICAgICAgcmMgPSBTS0lQUEVECisgICAgICAgIGlmIENVUlJF TlRfSE9TVE5BTUUgPT0gRVdTX0JVSUxEX0hPU1ROQU1FOgorICAgICAgICAgICAgcmMgPSBzZWxm LnNldF9jcV9taW51c19mbGFnX29uX3BhdGNoKHBhdGNoX2lkKQogICAgICAgICBzZWxmLmZpbmlz aGVkKHJjKQogICAgICAgICBpZiBidWlsZF9maW5pc2hfc3VtbWFyeToKICAgICAgICAgICAgIHNl bGYuYnVpbGQuYnVpbGRGaW5pc2hlZChbYnVpbGRfZmluaXNoX3N1bW1hcnldLCBGQUlMVVJFKQpA QCAtMTA0MSw5ICsxMDQzLDYgQEAgY2xhc3MgU2V0Q29tbWl0UXVldWVNaW51c0ZsYWdPblBhdGNo KGJ1aQogICAgICAgICAgICAgcmV0dXJuIGJ1aWxkc3RlcC5CdWlsZFN0ZXAuZ2V0UmVzdWx0U3Vt bWFyeShzZWxmKQogICAgICAgICByZXR1cm4geydzdGVwJzogJ0ZhaWxlZCB0byBzZXQgY3EtIGZs YWcgb24gcGF0Y2gnfQogCi0gICAgZGVmIGRvU3RlcElmKHNlbGYsIHN0ZXApOgotICAgICAgICBy ZXR1cm4gQ1VSUkVOVF9IT1NUTkFNRSA9PSBFV1NfQlVJTERfSE9TVE5BTUUKLQogCiBjbGFzcyBS ZW1vdmVGbGFnc09uUGF0Y2goYnVpbGRzdGVwLkJ1aWxkU3RlcCwgQnVnemlsbGFNaXhpbik6CiAg ICAgbmFtZSA9ICdyZW1vdmUtZmxhZ3MtZnJvbS1wYXRjaCcK