226286 2021-05-26 12:43:35 -0700 Add release logging in WebPage::runJavaScriptInFrameInScriptWorld() 2021-05-26 13:40:21 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson darin ggaren kkinnunen webkit-bug-importer youennf oldest_to_newest 1764011 0 cdumez 2021-05-26 12:43:35 -0700 Add release logging in WebPage::runJavaScriptInFrameInScriptWorld(). We have logging on UIProcess side but not on WebProcess side. It makes it hard to determine if the WebProcess processed the request to run JS or not. 1764013 1 429784 cdumez 2021-05-26 12:44:36 -0700 Created attachment 429784 Patch 1764023 2 429784 ggaren 2021-05-26 13:23:27 -0700 Comment on attachment 429784 Patch r=me 1764032 3 ews-feeder 2021-05-26 13:39:19 -0700 Committed r278123 (238173@main): <https://commits.webkit.org/238173@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429784. 1764034 4 webkit-bug-importer 2021-05-26 13:40:21 -0700 <rdar://problem/78529898> 429784 2021-05-26 12:44:36 -0700 2021-05-26 13:39:20 -0700 Patch bug-226286-20210526124435.patch text/plain 3088 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MDkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ4YmE5MzRlZWRiMWY0OTcx ZTJmZTcwOTQ2YTc0ZjJhZTUyZmI0MGYuLmJmMjMzODFjZTFiZWI2YTk2ODU4NzFjMzE2ZjNhNGJi MGIzOGE4NGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDUtMjYgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgcmVsZWFzZSBsb2dnaW5nIGlu IFdlYlBhZ2U6OnJ1bkphdmFTY3JpcHRJbkZyYW1lSW5TY3JpcHRXb3JsZCgpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjYyODYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgcmVsZWFzZSBsb2dnaW5n IGluIFdlYlBhZ2U6OnJ1bkphdmFTY3JpcHRJbkZyYW1lSW5TY3JpcHRXb3JsZCgpLiBXZSBoYXZl IGxvZ2dpbmcgb24gVUlQcm9jZXNzIHNpZGUgYnV0IG5vdCBvbgorICAgICAgICBXZWJQcm9jZXNz IHNpZGUuIEl0IG1ha2VzIGl0IGhhcmQgdG8gZGV0ZXJtaW5lIGlmIHRoZSBXZWJQcm9jZXNzIHBy b2Nlc3NlZCB0aGUgcmVxdWVzdCB0byBydW4gSlMgb3Igbm90LgorCisgICAgICAgICogV2ViUHJv Y2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpydW5K YXZhU2NyaXB0SW5GcmFtZUluU2NyaXB0V29ybGQpOgorCiAyMDIxLTA1LTI1ICBMYXVybyBNb3Vy YSAgPGxtb3VyYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGFub3RoZXIgR0ND OCBidWlsZCBmaXggYWZ0ZXIgcjI3ODAzNQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJQYWdlLmNwcAppbmRleCA5NjgyZjA5M2FlMGQ0NGNkZWM4Njk5MWNkMDQ5ZjcyZmJl ZTcxNzhhLi40YWEzNTNmNTBlZDg0ZDRjMTAwZDhjMDBkNGFlNjdhMmExZTIyOGE5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcApAQCAtMzcxNyw2ICsz NzE3LDcgQEAgdm9pZCBXZWJQYWdlOjpydW5KYXZhU2NyaXB0KFdlYkZyYW1lKiBmcmFtZSwgUnVu SmF2YVNjcmlwdFBhcmFtZXRlcnMmJiBwYXJhbWV0ZXIKIAogdm9pZCBXZWJQYWdlOjpydW5KYXZh U2NyaXB0SW5GcmFtZUluU2NyaXB0V29ybGQoUnVuSmF2YVNjcmlwdFBhcmFtZXRlcnMmJiBwYXJh bWV0ZXJzLCBPcHRpb25hbDxXZWJDb3JlOjpGcmFtZUlkZW50aWZpZXI+IGZyYW1lSUQsIGNvbnN0 IHN0ZDo6cGFpcjxDb250ZW50V29ybGRJZGVudGlmaWVyLCBTdHJpbmc+JiB3b3JsZERhdGEsIENv bXBsZXRpb25IYW5kbGVyPHZvaWQoY29uc3QgSVBDOjpEYXRhUmVmZXJlbmNlJiwgY29uc3QgT3B0 aW9uYWw8V2ViQ29yZTo6RXhjZXB0aW9uRGV0YWlscz4mKT4mJiBjb21wbGV0aW9uSGFuZGxlcikK IHsKKyAgICBSRUxFQVNFX0xPR19JRl9BTExPV0VEKFByb2Nlc3MsICJydW5KYXZhU2NyaXB0SW5G cmFtZUluU2NyaXB0V29ybGQ6IGZyYW1lSUQ9JSIgUFJJdTY0LCBmcmFtZUlELnZhbHVlT3IoV2Vi Q29yZTo6RnJhbWVJZGVudGlmaWVyIHsgfSkudG9VSW50NjQoKSk7CiAgICAgYXV0byB3ZWJGcmFt ZSA9IG1ha2VSZWZQdHIoZnJhbWVJRCA/IFdlYlByb2Nlc3M6OnNpbmdsZXRvbigpLndlYkZyYW1l KCpmcmFtZUlEKSA6ICZtYWluV2ViRnJhbWUoKSk7CiAKICAgICBpZiAoYXV0byogbmV3V29ybGQg PSBtX3VzZXJDb250ZW50Q29udHJvbGxlci0+YWRkQ29udGVudFdvcmxkKHdvcmxkRGF0YSkpIHsK QEAgLTM3MjUsNyArMzcyNiwxMyBAQCB2b2lkIFdlYlBhZ2U6OnJ1bkphdmFTY3JpcHRJbkZyYW1l SW5TY3JpcHRXb3JsZChSdW5KYXZhU2NyaXB0UGFyYW1ldGVycyYmIHBhcmFtZQogICAgICAgICAg ICAgZnJhbWUtPmxvYWRlcigpLmNsaWVudCgpLmRpc3BhdGNoR2xvYmFsT2JqZWN0QXZhaWxhYmxl KGNvcmVXb3JsZCk7CiAgICAgfQogCi0gICAgcnVuSmF2YVNjcmlwdCh3ZWJGcmFtZS5nZXQoKSwg V1RGTW92ZShwYXJhbWV0ZXJzKSwgd29ybGREYXRhLmZpcnN0LCBXVEZNb3ZlKGNvbXBsZXRpb25I YW5kbGVyKSk7CisgICAgcnVuSmF2YVNjcmlwdCh3ZWJGcmFtZS5nZXQoKSwgV1RGTW92ZShwYXJh bWV0ZXJzKSwgd29ybGREYXRhLmZpcnN0LCBbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYo KnRoaXMpLCBjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpXShj b25zdCBJUEM6OkRhdGFSZWZlcmVuY2UmIHJlc3VsdCwgY29uc3QgT3B0aW9uYWw8V2ViQ29yZTo6 RXhjZXB0aW9uRGV0YWlscz4mIGV4Y2VwdGlvbikgbXV0YWJsZSB7CisgICAgICAgIGlmIChleGNl cHRpb24pCisgICAgICAgICAgICBSRUxFQVNFX0xPR19FUlJPUl9JRl9BTExPV0VEKFByb2Nlc3Ms ICJydW5KYXZhU2NyaXB0SW5GcmFtZUluU2NyaXB0V29ybGQ6IFJlcXVlc3QgdG8gcnVuIEphdmFT Y3JpcHQgZmFpbGVkIHdpdGggZXJyb3IgJXtwcml2YXRlfXMiLCBleGNlcHRpb24tPm1lc3NhZ2Uu dXRmOCgpLmRhdGEoKSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIFJFTEVBU0VfTE9HX0lG X0FMTE9XRUQoUHJvY2VzcywgInJ1bkphdmFTY3JpcHRJbkZyYW1lSW5TY3JpcHRXb3JsZDogUmVx dWVzdCB0byBydW4gSmF2YVNjcmlwdCBzdWNjZWVkZWQiKTsKKyAgICAgICAgY29tcGxldGlvbkhh bmRsZXIocmVzdWx0LCBleGNlcHRpb24pOworICAgIH0pOwogfQogCiB2b2lkIFdlYlBhZ2U6Omdl dENvbnRlbnRzQXNTdHJpbmcoQ29udGVudEFzU3RyaW5nSW5jbHVkZXNDaGlsZEZyYW1lcyBpbmNs dWRlQ2hpbGRGcmFtZXMsIENvbXBsZXRpb25IYW5kbGVyPHZvaWQoY29uc3QgU3RyaW5nJik+JiYg Y2FsbGJhY2spCg==