226284 2021-05-26 12:26:26 -0700 Unreviewed test gardening, remove some outdated test expectations. 2021-05-26 21:21:24 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=180633 InRadar P2 Normal --- 1 crzwdjk webkit-unassigned ap dpino lmoura webkit-bug-importer oldest_to_newest 1764003 0 crzwdjk 2021-05-26 12:26:26 -0700 Unreviewed test gardening, remove some outdated test expectations. 1764004 1 429781 crzwdjk 2021-05-26 12:26:56 -0700 Created attachment 429781 Patch 1764132 2 429781 ap 2021-05-26 17:09:30 -0700 Comment on attachment 429781 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429781&action=review The change is good, however I think that commit queue won't be able to land it without "Unreviewed" line in the ChangeLog. Marking cq+ anyway for it to comment with some detail. > LayoutTests/ChangeLog:3 > + Unreviewed test gardening, remove some outdated test expectations. Checking one of these, I see that it progressed in r277391. I'm guessing that all of them did? It would be good to explain the history for anyone curious. 1764148 3 ews-feeder 2021-05-26 17:41:01 -0700 Committed r278142 (238186@main): <https://commits.webkit.org/238186@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429781. 1764150 4 webkit-bug-importer 2021-05-26 17:42:16 -0700 <rdar://problem/78542724> 1764202 5 ap 2021-05-26 21:21:24 -0700 I guess it doesn't need that now! 429781 2021-05-26 12:26:56 -0700 2021-05-26 17:41:02 -0700 Patch bug-226284-20210526152655.patch text/plain 2777 crzwdjk U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MDkzCmRpZmYgLS1naXQgTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIExheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBiOTgxNDEzZDEyZTdkMGZmOTE0MGFiMDlk NWYwYzQzOTA3ZWY5YTMyLi5kZTM4NWZkODljODY5MWQwNzBjN2E4MDEwY2MzYTJlNTZjMWIxMGM1 IDEwMDY0NAotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxMCBAQAorMjAyMS0wNS0yNiAgQXJjYWR5IEdvbGRtaW50cy1PcmxvdiAg PGFnb2xkbWludHNAaWdhbGlhLmNvbT4KKworICAgICAgICBVbnJldmlld2VkIHRlc3QgZ2FyZGVu aW5nLCByZW1vdmUgc29tZSBvdXRkYXRlZCB0ZXN0IGV4cGVjdGF0aW9ucy4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjI4NAorCisgICAgICAgICog VGVzdEV4cGVjdGF0aW9uczoKKwogMjAyMS0wNS0yNiAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFy ZEBhcHBsZS5jb20+CiAKICAgICAgICAgW0xheW91dFRlc3RzXSBEZWxldGUgcGhwIHRlc3RzIGZy b20gaW1wb3J0ZWQvYmxpbmsKZGlmZiAtLWdpdCBMYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25z IExheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggMWQwODlkMmY0OGIzNmEzMzM5OGJj MTczNTZmNzU2YzgyZmFjZDEwOS4uZWUyZmMxZTEwNWRhNzQxZjYwM2ZjZWM1MzIyNmVhOGU4MGFi M2ViNSAxMDA2NDQKLS0tIExheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKKysrIExheW91dFRl c3RzL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTM1OTQsMTQgKzM1OTQsOCBAQCB3ZWJraXQub3JnL2Iv MjA5MDgwIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy13cml0aW5nLW1v ZGVzL2Ficy1wbwogd2Via2l0Lm9yZy9iLzIwOTA4MCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL2Nzcy9jc3Mtd3JpdGluZy1tb2Rlcy9hYnMtcG9zLW5vbi1yZXBsYWNlZC1pY2Itdmxy LTAzMy54aHQgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8yMDkwODAgaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLXdyaXRpbmctbW9kZXMvYWJzLXBvcy1u b24tcmVwbGFjZWQtaWNiLXZybC0wMDIueGh0IFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQu b3JnL2IvMjA5MDgwIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy13cml0 aW5nLW1vZGVzL2Ficy1wb3Mtbm9uLXJlcGxhY2VkLWljYi12cmwtMDA0LnhodCBbIEltYWdlT25s eUZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzIwOTA4MCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL2Nzcy9jc3Mtd3JpdGluZy1tb2Rlcy9hYnMtcG9zLW5vbi1yZXBsYWNlZC1pY2ItdnJs LTAwNi54aHQgWyBJbWFnZU9ubHlGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8yMDkwODAgaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLXdyaXRpbmctbW9kZXMvYWJzLXBvcy1u b24tcmVwbGFjZWQtaWNiLXZybC0wMDgueGh0IFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQu b3JnL2IvMjA5MDgwIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy13cml0 aW5nLW1vZGVzL2Ficy1wb3Mtbm9uLXJlcGxhY2VkLWljYi12cmwtMDEwLnhodCBbIEltYWdlT25s eUZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzIwOTA4MCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL2Nzcy9jc3Mtd3JpdGluZy1tb2Rlcy9hYnMtcG9zLW5vbi1yZXBsYWNlZC1pY2ItdnJs LTAxMi54aHQgWyBJbWFnZU9ubHlGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8yMDkwODAgaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLXdyaXRpbmctbW9kZXMvYWJzLXBvcy1u b24tcmVwbGFjZWQtaWNiLXZybC0wMTQueGh0IFsgSW1hZ2VPbmx5RmFpbHVyZSBdCi13ZWJraXQu b3JnL2IvMjA5MDgwIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy13cml0 aW5nLW1vZGVzL2Ficy1wb3Mtbm9uLXJlcGxhY2VkLWljYi12cmwtMDE2LnhodCBbIEltYWdlT25s eUZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzIwOTA4MCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL2Nzcy9jc3Mtd3JpdGluZy1tb2Rlcy9hYnMtcG9zLW5vbi1yZXBsYWNlZC1pY2ItdnJs LTAxOC54aHQgWyBJbWFnZU9ubHlGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8yMDkwODAgaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLXdyaXRpbmctbW9kZXMvYWJzLXBvcy1u b24tcmVwbGFjZWQtaWNiLXZybC0wMjAueGh0IFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQu b3JnL2IvMjA5MDgwIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy13cml0 aW5nLW1vZGVzL2Ficy1wb3Mtbm9uLXJlcGxhY2VkLWljYi12cmwtMDMwLnhodCBbIEltYWdlT25s eUZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzIwOTA4MCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL2Nzcy9jc3Mtd3JpdGluZy1tb2Rlcy9hYnMtcG9zLW5vbi1yZXBsYWNlZC12bHItMDk1 LnhodCBbIEltYWdlT25seUZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzIwOTA4MCBpbXBvcnRlZC93 M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3Mtd3JpdGluZy1tb2Rlcy9hYnMtcG9zLW5vbi1y ZXBsYWNlZC12bHItMTA5LnhodCBbIEltYWdlT25seUZhaWx1cmUgXQo=