226275 2021-05-26 08:54:26 -0700 #ifdef out transformToColorSpace() in ImageBuffer and subclasses to make it clear it is only needed for non-CG ports 2021-06-02 08:55:19 -0700 1 1 1 Unclassified WebKit Platform Other Unspecified Unspecified NEW InRadar P2 Normal --- 1 sam webkit-unassigned webkit-bug-importer oldest_to_newest 1763930 0 sam 2021-05-26 08:54:26 -0700 We currently have no-op implementations of transformToColorSpace() in ImageBuffer and its CG subclasses. I think we should make it clear it is not intended to work for CG by making it impossible to call via #ifdef. 1763931 1 sam 2021-05-26 08:56:45 -0700 Really, we should have a better macro for this. Maybe ENABLE_IMAGE_BUFFER_SUPPORTS_COLOR_SPACE? 1763932 2 sam 2021-05-26 09:05:23 -0700 ENABLE_IMAGE_BUFFER_SUPPORTS_COLOR_SPACE is not great, because it will be really confusing to see: #if !ENABLE(IMAGE_BUFFER_SUPPORTS_COLOR_SPACE) maskerData->maskImage->transformToColorSpace(colorSpace); #endif Perhaps the real answer is that we need to replace transformToColorSpace() with something that makes it clear it is not really correct. Like a function that just does a getPixelBuffer -> colorSpace transformation > setPixelBuffer(), though that would obviously be less efficient so not a good idea. 1766015 3 webkit-bug-importer 2021-06-02 08:55:19 -0700 <rdar://problem/78765976>