226264 2021-05-26 04:31:15 -0700 [JSC] cloop again broken on 32-bit big endian in 2.32.x 2021-05-27 02:57:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Other Linux RESOLVED FIXED InRadar P2 Normal --- 1 nina webkit-unassigned aperez ews-watchlist keith_miller mark.lam msaboff saam ticaiolima tzagallo webkit-bug-importer oldest_to_newest 1763872 0 nina 2021-05-26 04:31:15 -0700 It seems a change was missed. Patch incoming. 1763873 1 429747 nina 2021-05-26 04:32:23 -0700 Created attachment 429747 patch patch 1763881 2 429747 ticaiolima 2021-05-26 05:39:47 -0700 Comment on attachment 429747 patch r=me 1763882 3 ticaiolima 2021-05-26 05:42:55 -0700 I’m a bit surprised that we are running JSC on 32-bits big endian platforms. Maybe we should add a post-commit buildbot at some point? There’s a couple of places I worked on 32-bits LLInt where I considered little-endian only, so we might have other bugs like that around. Also, without test feedback, it will be quite likely that we will introduce bugs like that in the future. 1763884 4 nina 2021-05-26 05:55:12 -0700 i'll definitely run the tests at one point (on powerpc 64le, 64be, 32be) though at this point the big endian platforms are a best-effort thing in my distribution, so i'm not able to invest more time than right now into them... but yeah things are known to work okay currently (at very least, it never crashes the web process, there may be buggy javascript on some sites - e.g. google maps js throws exceptions when trying to render tiles right now - but some quite complex webapps are known to work okay) 1763935 5 aperez 2021-05-26 09:20:49 -0700 Should we cq+ this? 1764267 6 429747 aperez 2021-05-27 02:53:26 -0700 Comment on attachment 429747 patch Setting cq+ to land in trunk, so I can backport it to the release branch 1764268 7 ews-feeder 2021-05-27 02:56:59 -0700 Committed r278157 (238201@main): <https://commits.webkit.org/238201@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429747. 1764269 8 webkit-bug-importer 2021-05-27 02:57:16 -0700 <rdar://problem/78560223> 429747 2021-05-26 04:32:23 -0700 2021-05-27 02:57:00 -0700 patch 0001-JSC-Fix-crash-on-32-bit-big-endian-systems.patch text/plain 2001 nina RnJvbSAzYWYyZWM0YTNhYmNkZjQzODZjMjAyYWE4MGM1YzQ1NjkxNjAwNTk4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYW5pZWwgS29sZXNhIDxka29sZXNhQGlnYWxpYS5jb20+CkRh dGU6IFdlZCwgMjYgTWF5IDIwMjEgMTM6MjM6NDggKzAyMDAKU3ViamVjdDogW1BBVENIXSBbSlND XSBGaXggY3Jhc2ggb24gMzItYml0IGJpZyBlbmRpYW4gc3lzdGVtcy4KClRoaXMgaXMgYW4gaW5z dGFuY2Ugd2hlcmUgcHJvcGVybHkgb2Zmc2V0dGluZyB3YXMgbWlzc2VkIHNpbmNlCnRoZSBpc3N1 ZSB3YXMgbm90IHByZXNlbnQgaW4gMi4zMCBzZXJpZXMgYW5kIHRoZXJlZm9yZSBub3QgZml4ZWQK YnkgcjI3MzEwNC4KLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAg ICAgICAgICAgICAgfCAxMyArKysrKysrKysrKysrCiAuLi4vbGxpbnQvTG93TGV2ZWxJbnRlcnBy ZXRlcjMyXzY0LmFzbSAgICAgICAgICAgICAgfCAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAxNCBp bnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXgg MjdiZmMwODE2ZjcwLi43MjE0YzdlNjZiNWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE2IEBACisyMDIxLTA1LTI2ICBEYW5pZWwgS29sZXNhICA8ZGtvbGVzYUBpZ2FsaWEu Y29tPgorCisgICAgICAgIFtKU0NdIEZpeCBjcmFzaCBvbiAzMi1iaXQgYmlnIGVuZGlhbiBzeXN0 ZW1zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2 MjY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhp cyBpcyBhbiBpbnN0YW5jZSB3aGVyZSBwcm9wZXJseSBvZmZzZXR0aW5nIHdhcyBtaXNzZWQgc2lu Y2UKKyAgICAgICAgdGhlIGlzc3VlIHdhcyBub3QgcHJlc2VudCBpbiAyLjMwIHNlcmllcyBhbmQg dGhlcmVmb3JlIG5vdCBmaXhlZAorICAgICAgICBieSByMjczMTA0LgorCisgICAgICAgICogbGxp bnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbToKKwogMjAyMS0wNS0yNSAgRnVqaWkgSGly b25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBDbGFuZyBjYW4ndCBj b21waWxlIE9wdGlvbmFsPEdQUlRlbXBvcmFyeT4gc2luY2UgcjI3ODAzNSBiZWNhdXNlIEdQUlRl bXBvcmFyeSBoYXMgbm9uLWNvbnN0IGNvcHkgY29uc3RydWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyMzJfNjQuYXNtIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KaW5k ZXggZWMxYTk1OWFlNTY4Li5lNDJiOGIyNWRjYjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyMzJfNjQuYXNtCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyMzJfNjQuYXNtCkBAIC00MjUs NyArNDI1LDcgQEAgZW5kKQogb3AobGxpbnRfZ2V0X2hvc3RfY2FsbF9yZXR1cm5fdmFsdWUsIG1h Y3JvICgpCiAgICAgZnVuY3Rpb25Qcm9sb2d1ZSgpCiAgICAgcHVzaENhbGxlZVNhdmVzKCkKLSAg ICBsb2FkcCBDYWxsZWVbY2ZyXSwgdDAKKyAgICBsb2FkcCBDYWxsZWUgKyBQYXlsb2FkT2Zmc2V0 W2Nmcl0sIHQwCiAgICAgY29udmVydENhbGxlZVRvVk0odDApCiAgICAgbG9hZGkgVk06OmVuY29k ZWRIb3N0Q2FsbFJldHVyblZhbHVlICsgVGFnT2Zmc2V0W3QwXSwgdDEKICAgICBsb2FkaSBWTTo6 ZW5jb2RlZEhvc3RDYWxsUmV0dXJuVmFsdWUgKyBQYXlsb2FkT2Zmc2V0W3QwXSwgdDAKLS0gCjIu MzAuMgoK