226261 2021-05-26 02:26:00 -0700 ANGLE Metal translator should always collect variables 2021-05-28 00:16:20 -0700 1 1 1 Unclassified WebKit ANGLE Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 kkinnunen kkinnunen dino ews-watchlist graouts johncunningham kkinnunen kondapallykalyan webkit-bug-importer oldest_to_newest 1763857 0 kkinnunen 2021-05-26 02:26:00 -0700 ANGLE Metal translator should always collect variables RemoveInactiveInterfaceVariables helper function needs the variables to be collected. Normal operation invokes this as a side-effect of passing SH_VARIABLES compile option. However, some tests might not pass the compile option, but Metal translator still removes the inactive interface variables. Thus we need to always collect the variables. 1763859 1 429741 kkinnunen 2021-05-26 02:32:20 -0700 Created attachment 429741 Patch 1763860 2 ews-watchlist 2021-05-26 02:33:11 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1764160 3 429741 johncunningham 2021-05-26 18:30:43 -0700 Comment on attachment 429741 Patch LGTM 1764702 4 ews-feeder 2021-05-28 00:15:50 -0700 Committed r278192 (238235@main): <https://commits.webkit.org/238235@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429741. 1764703 5 webkit-bug-importer 2021-05-28 00:16:20 -0700 <rdar://problem/78607455> 429741 2021-05-26 02:32:20 -0700 2021-05-28 00:15:50 -0700 Patch bug-226261-20210526123219.patch text/plain 1945 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MDAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMTlmZDFkODlkZjgxMmM1OTU3ZDI1YjVhMGEwZDRkM2I4ZTQzZjhiMC4uYTNiYzY0ZDQxMjc4 NTk2N2FlOTdjZWY5ZTdmMjVmOTVjMGE2MjE0MyAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA1LTI2ICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5l bkBhcHBsZS5jb20+CisKKyAgICAgICAgQU5HTEUgTWV0YWwgdHJhbnNsYXRvciBzaG91bGQgYWx3 YXlzIGNvbGxlY3QgdmFyaWFibGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMjYyNjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBbHdheXMgY29sbGVjdCB0aGUgdmFyaWFibGVzIHdoZW4gdHJhbnNsYXRp bmcgR0xTTCB0byBNZXRhbC4KKyAgICAgICAgVGhpcyB3YXkgdGVzdHMgdGhhdCBpbnZva2UgdHJh bnNsYXRpb24gd2l0aG91dCBTSF9WQVJJQUJMRVMgc3RpbGwKKyAgICAgICAgd29yay4KKworICAg ICAgICAqIHNyYy9jb21waWxlci90cmFuc2xhdG9yL1RyYW5zbGF0b3JNZXRhbERpcmVjdC5jcHA6 CisgICAgICAgIChzaDo6VHJhbnNsYXRvck1ldGFsRGlyZWN0Ojp0cmFuc2xhdGVJbXBsKToKKyAg ICAgICAgKiBzcmMvY29tcGlsZXIvdHJhbnNsYXRvci9UcmFuc2xhdG9yTWV0YWxEaXJlY3QuaDoK KwogMjAyMS0wNS0yNiAgS2ltbW8gS2lubnVuZW4gIDxra2lubnVuZW5AYXBwbGUuY29tPgogCiAg ICAgICAgIEFOR0xFIGNvdWxkIGJlIGNvbXBpbGVkIHdpdGggImFnZ3Jlc3NpdmUgdW5pbml0aWFs aXNlZCB2YXJpYWJsZSIgc2V0dGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5H TEUvc3JjL2NvbXBpbGVyL3RyYW5zbGF0b3IvVHJhbnNsYXRvck1ldGFsRGlyZWN0LmggYi9Tb3Vy Y2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvdHJhbnNsYXRvci9UcmFuc2xhdG9yTWV0 YWxEaXJlY3QuaAppbmRleCA2NjRiOTRmY2NhMzVlZDE5ZDA1NTY0NWJkNDJmOTRjZWMwZDAyYTky Li5hODA1NzVmMmE4Y2RhZWY5MjhiOGVlMTUyMjVjZTRlZDk2OGM4YjQyIDEwMDY0NAotLS0gYS9T b3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvdHJhbnNsYXRvci9UcmFuc2xhdG9y TWV0YWxEaXJlY3QuaAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIv dHJhbnNsYXRvci9UcmFuc2xhdG9yTWV0YWxEaXJlY3QuaApAQCAtMTYwLDYgKzE2MCw5IEBAIGNs YXNzIFRyYW5zbGF0b3JNZXRhbERpcmVjdCA6IHB1YmxpYyBUQ29tcGlsZXIKICAgICAgICAgICAg ICAgICAgICBTaENvbXBpbGVPcHRpb25zIGNvbXBpbGVPcHRpb25zLAogICAgICAgICAgICAgICAg ICAgIFBlcmZvcm1hbmNlRGlhZ25vc3RpY3MgKnBlcmZEaWFnbm9zdGljcykgb3ZlcnJpZGU7CiAK KyAgICAvLyBOZWVkIHRvIGNvbGxlY3QgdmFyaWFibGVzIHNvIHRoYXQgUmVtb3ZlSW5hY3RpdmVJ bnRlcmZhY2VWYXJpYWJsZXMgd29ya3MuCisgICAgYm9vbCBzaG91bGRDb2xsZWN0VmFyaWFibGVz KFNoQ29tcGlsZU9wdGlvbnMgY29tcGlsZU9wdGlvbnMpIG92ZXJyaWRlIHsgcmV0dXJuIHRydWU7 IH0KKwogICAgIEFOR0xFX05PX0RJU0NBUkQgYm9vbCB0cmFuc2xhdGVJbXBsKFRJbnRlcm1CbG9j ayAmcm9vdCwgU2hDb21waWxlT3B0aW9ucyBjb21waWxlT3B0aW9ucyk7CiAKICAgICBBTkdMRV9O T19ESVNDQVJEIGJvb2wgc2hvdWxkRmxhdHRlblByYWdtYVN0ZGdsSW52YXJpYW50QWxsKCkgb3Zl cnJpZGU7Cg==