226250 2021-05-25 16:37:51 -0700 Stop using UncheckedLock in MediaElementAudioSourceNode 2021-05-25 22:01:21 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen calvaris changseok darin eric.carlson esprehn+autocc ews-watchlist ggaren glenn gyuyoung.kim jer.noble peng.liu6 philipj sam sergio webkit-bug-importer oldest_to_newest 1763752 0 cdumez 2021-05-25 16:37:51 -0700 Stop using UncheckedLock in MediaElementAudioSourceNode as it is being phased out in favor of Lock, which supports clang thread safety analysis. 1763773 1 429714 cdumez 2021-05-25 17:24:43 -0700 Created attachment 429714 Patch 1763814 2 429714 darin 2021-05-25 20:39:00 -0700 Comment on attachment 429714 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429714&action=review > Source/WebCore/html/HTMLMediaElement.cpp:6635 > + Optional<Locker<Lock>> audioSourceNodeLocker; In new code you should write std::optional, not Optional. 1763822 3 cdumez 2021-05-25 22:00:55 -0700 Committed r278077 (238156@main): <https://commits.webkit.org/238156@main> 1763823 4 webkit-bug-importer 2021-05-25 22:01:21 -0700 <rdar://problem/78494211> 429714 2021-05-25 17:24:43 -0700 2021-05-25 20:38:39 -0700 Patch bug-226250-20210525172442.patch text/plain 3968 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MDU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjEwNzhlMzdiNGQ2ZjBm NDI4OGEzMzE2MTU4YmZkMzg4YzNhOTg4OS4uNDkwZDIwY2FlYWU4Y2M0OWU2NmY3ZTBhYzdmM2Nl NmVhNGE5NmRmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA1LTI1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU3RvcCB1c2luZyBVbmNoZWNr ZWRMb2NrIGluIE1lZGlhRWxlbWVudEF1ZGlvU291cmNlTm9kZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2MjUwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3RvcCB1c2luZyBVbmNoZWNrZWRMb2NrIGlu IE1lZGlhRWxlbWVudEF1ZGlvU291cmNlTm9kZSBhcyBpdCBpcyBiZWluZyBwaGFzZWQgb3V0IGlu IGZhdm9yIG9mCisgICAgICAgIExvY2ssIHdoaWNoIHN1cHBvcnRzIGNsYW5nIHRocmVhZCBzYWZl dHkgYW5hbHlzaXMuCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL01lZGlhRWxlbWVudEF1 ZGlvU291cmNlTm9kZS5oOgorICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisK IDIwMjEtMDUtMjUgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBb R1N0cmVhbWVyXSBTdG9wIHVzaW5nIFVuY2hlY2tlZExvY2sgaW4gV2ViS2l0Q29tbW9uRW5jcnlw dGlvbkRlY3J5cHRvckdTdHJlYW1lcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxl cy93ZWJhdWRpby9NZWRpYUVsZW1lbnRBdWRpb1NvdXJjZU5vZGUuaCBiL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvd2ViYXVkaW8vTWVkaWFFbGVtZW50QXVkaW9Tb3VyY2VOb2RlLmgKaW5kZXggMDZm ZTUxZDk0NGQwYjhlOWM4ZGI2MTQ2N2QxYTE4NmM1ZGRmNDE0Yy4uNGIyOGQ3N2E0ZWZmYTYwN2Rh MDMzYjJiYTA4MGZkMThmNGM4NzljMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxl cy93ZWJhdWRpby9NZWRpYUVsZW1lbnRBdWRpb1NvdXJjZU5vZGUuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL3dlYmF1ZGlvL01lZGlhRWxlbWVudEF1ZGlvU291cmNlTm9kZS5oCkBAIC01 NCw3ICs1NCw3IEBAIHB1YmxpYzoKICAgICAvLyBBdWRpb1NvdXJjZVByb3ZpZGVyQ2xpZW50CiAg ICAgdm9pZCBzZXRGb3JtYXQoc2l6ZV90IG51bWJlck9mQ2hhbm5lbHMsIGZsb2F0IHNhbXBsZVJh dGUpIG92ZXJyaWRlOwogCi0gICAgVW5jaGVja2VkTG9jayYgcHJvY2Vzc0xvY2soKSB7IHJldHVy biBtX3Byb2Nlc3NMb2NrOyB9CisgICAgTG9jayYgcHJvY2Vzc0xvY2soKSBXVEZfUkVUVVJOU19M T0NLKG1fcHJvY2Vzc0xvY2spIHsgcmV0dXJuIG1fcHJvY2Vzc0xvY2s7IH0KIAogcHJpdmF0ZToK ICAgICBNZWRpYUVsZW1lbnRBdWRpb1NvdXJjZU5vZGUoQmFzZUF1ZGlvQ29udGV4dCYsIFJlZjxI VE1MTWVkaWFFbGVtZW50PiYmKTsKQEAgLTcwLDcgKzcwLDcgQEAgcHJpdmF0ZToKICAgICBib29s IHdvdWxkVGFpbnRPcmlnaW4oKTsKIAogICAgIFJlZjxIVE1MTWVkaWFFbGVtZW50PiBtX21lZGlh RWxlbWVudDsKLSAgICBVbmNoZWNrZWRMb2NrIG1fcHJvY2Vzc0xvY2s7CisgICAgTG9jayBtX3By b2Nlc3NMb2NrOwogCiAgICAgdW5zaWduZWQgbV9zb3VyY2VOdW1iZXJPZkNoYW5uZWxzIHsgMCB9 OwogICAgIGRvdWJsZSBtX3NvdXJjZVNhbXBsZVJhdGUgeyAwIH07CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCA2NDFkMDRkMjJlMDY3NTk0OWM3ZjcwYzI5ZTQy ZGRkYjgyZDBlZWEzLi5jMmZmNmZkODgyYWViZTdhODYxMzFlOTBlMGUyNmJlMTMxYzM5NTgyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTUwOTYsNyArNTA5 Niw5IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6bWVkaWFQbGF5ZXJFbmdpbmVVcGRhdGVkKCkK ICAgICBzY2hlZHVsZU1lZGlhRW5naW5lV2FzVXBkYXRlZCgpOwogfQogCi12b2lkIEhUTUxNZWRp YUVsZW1lbnQ6Om1lZGlhUGxheWVyV2lsbEluaXRpYWxpemVNZWRpYUVuZ2luZSgpCisvLyBVc2Ug V1RGX0lHTk9SRVNfVEhSRUFEX1NBRkVUWV9BTkFMWVNJUyBzaW5jZSB0aGlzIGZ1bmN0aW9uIGRv ZXMgY29uZGl0aW9uYWwgbG9ja2luZywgd2hpY2ggaXMgbm90CisvLyBzdXBwb3J0ZWQgYnkgYW5h bHlzaXMuCit2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6Om1lZGlhUGxheWVyV2lsbEluaXRpYWxpemVN ZWRpYUVuZ2luZSgpIFdURl9JR05PUkVTX1RIUkVBRF9TQUZFVFlfQU5BTFlTSVMKIHsKICAgICBB U1NFUlQoaXNNYWluVGhyZWFkKCkpOwogI2lmIEVOQUJMRShXRUJfQVVESU8pCkBAIC01MTA2LDcg KzUxMDgsOSBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6Om1lZGlhUGxheWVyV2lsbEluaXRpYWxp emVNZWRpYUVuZ2luZSgpCiAjZW5kaWYKIH0KIAotdm9pZCBIVE1MTWVkaWFFbGVtZW50OjptZWRp YVBsYXllckRpZEluaXRpYWxpemVNZWRpYUVuZ2luZSgpCisvLyBVc2UgV1RGX0lHTk9SRVNfVEhS RUFEX1NBRkVUWV9BTkFMWVNJUyBzaW5jZSB0aGlzIGZ1bmN0aW9uIGRvZXMgY29uZGl0aW9uYWwg dW5sb2NraW5nLCB3aGljaCBpcyBub3QKKy8vIHN1cHBvcnRlZCBieSBhbmFseXNpcy4KK3ZvaWQg SFRNTE1lZGlhRWxlbWVudDo6bWVkaWFQbGF5ZXJEaWRJbml0aWFsaXplTWVkaWFFbmdpbmUoKSBX VEZfSUdOT1JFU19USFJFQURfU0FGRVRZX0FOQUxZU0lTCiB7CiAgICAgQVNTRVJUKGlzTWFpblRo cmVhZCgpKTsKICNpZiBFTkFCTEUoV0VCX0FVRElPKQpAQCAtNjYxOCw3ICs2NjIyLDkgQEAgdm9p ZCBIVE1MTWVkaWFFbGVtZW50OjptYXJrQ2FwdGlvbkFuZFN1YnRpdGxlVHJhY2tzQXNVbmNvbmZp Z3VyZWQoUmVjb25maWd1cmVNb2QKICAgICAgICAgc2NoZWR1bGVDb25maWd1cmVUZXh0VHJhY2tz KCk7CiB9CiAKLXZvaWQgSFRNTE1lZGlhRWxlbWVudDo6Y3JlYXRlTWVkaWFQbGF5ZXIoKQorLy8g VXNlIFdURl9JR05PUkVTX1RIUkVBRF9TQUZFVFlfQU5BTFlTSVMgYmVjYXVzZSB0aGlzIGZ1bmN0 aW9uIGRvZXMgY29uZGl0aW9uYWwgbG9ja2luZyBvZiBtX2F1ZGlvU291cmNlTm9kZS0+cHJvY2Vz c0xvY2soKQorLy8gd2hpY2ggYW5hbHlzaXMgZG9lc24ndCBzdXBwb3J0Lgordm9pZCBIVE1MTWVk aWFFbGVtZW50OjpjcmVhdGVNZWRpYVBsYXllcigpIFdURl9JR05PUkVTX1RIUkVBRF9TQUZFVFlf QU5BTFlTSVMKIHsKICAgICBJTkZPX0xPRyhMT0dJREVOVElGSUVSKTsKIApAQCAtNjYyNiw3ICs2 NjMyLDkgQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50OjpjcmVhdGVNZWRpYVBsYXllcigpCiAKICNp ZiBFTkFCTEUoV0VCX0FVRElPKQogICAgIGF1dG8gcHJvdGVjdGVkQXVkaW9Tb3VyY2VOb2RlID0g bWFrZVJlZlB0cihtX2F1ZGlvU291cmNlTm9kZSk7Ci0gICAgTG9ja2VyIGF1ZGlvU291cmNlTm9k ZUxvY2tlcihtX2F1ZGlvU291cmNlTm9kZSA/ICZtX2F1ZGlvU291cmNlTm9kZS0+cHJvY2Vzc0xv Y2soKSA6IG51bGxwdHIpOworICAgIE9wdGlvbmFsPExvY2tlcjxMb2NrPj4gYXVkaW9Tb3VyY2VO b2RlTG9ja2VyOworICAgIGlmIChtX2F1ZGlvU291cmNlTm9kZSkKKyAgICAgICAgYXVkaW9Tb3Vy Y2VOb2RlTG9ja2VyLmVtcGxhY2UobV9hdWRpb1NvdXJjZU5vZGUtPnByb2Nlc3NMb2NrKCkpOwog I2VuZGlmCiAKICNpZiBFTkFCTEUoTUVESUFfU09VUkNFKQo=