226247 2021-05-25 16:06:06 -0700 [iOS] ASSERTION FAILED: !isMainThread() in WebCore::SpeechRecognitionCaptureSourceImpl::audioSamplesAvailable 2021-05-25 16:17:42 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=226131 InRadar P2 Normal --- 1 ryanhaddad cdumez cdumez sihui_liu webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1763723 0 ryanhaddad 2021-05-25 16:06:06 -0700 Seeing the assert below on iOS simulator debug bots with a few speechrecognition layout tests fast/speechrecognition/ios/audio-capture.html fast/speechrecognition/ios/restart-recognition-after-stop.html fast/speechrecognition/ios/start-recognition-then-stop.html ASSERTION FAILED: !isMainThread() ./Modules/speech/SpeechRecognitionCaptureSourceImpl.cpp(131) : virtual void WebCore::SpeechRecognitionCaptureSourceImpl::audioSamplesAvailable(const WTF::MediaTime &, const WebCore::PlatformAudioData &, const WebCore::AudioStreamDescription &, size_t) 1 0x108496d99 WTFCrash 2 0x12af5a4eb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x12d4541c2 WebCore::SpeechRecognitionCaptureSourceImpl::audioSamplesAvailable(WTF::MediaTime const&, WebCore::PlatformAudioData const&, WebCore::AudioStreamDescription const&, unsigned long) 4 0x12f563ce9 WebCore::RealtimeMediaSource::audioSamplesAvailable(WTF::MediaTime const&, WebCore::PlatformAudioData const&, WebCore::AudioStreamDescription const&, unsigned long) 5 0x111b72e8f WebKit::SpeechRecognitionRemoteRealtimeMediaSource::remoteAudioSamplesAvailable(WTF::MediaTime, unsigned long long) 6 0x111b73643 WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager::remoteAudioSamplesAvailable(WTF::ObjectIdentifier<WebCore::RealtimeMediaSourceIdentifierType>, WTF::MediaTime const&, unsigned long long) 7 0x110fb4475 void IPC::callMemberFunctionImpl<WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager, void (WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager::*)(WTF::ObjectIdentifier<WebCore::RealtimeMediaSourceIdentifierType>, WTF::MediaTime const&, unsigned long long), std::__1::tuple<WTF::ObjectIdentifier<WebCore::RealtimeMediaSourceIdentifierType>, WTF::MediaTime, unsigned long long>, 0ul, 1ul, 2ul>(WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager*, void (WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager::*)(WTF::ObjectIdentifier<WebCore::RealtimeMediaSourceIdentifierType>, WTF::MediaTime const&, unsigned long long), std::__1::tuple<WTF::ObjectIdentifier<WebCore::RealtimeMediaSourceIdentifierType>, WTF::MediaTime, unsigned long long>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul>) 8 0x110fb2e20 void IPC::callMemberFunction<WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager, void (WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager::*)(WTF::ObjectIdentifier<WebCore::RealtimeMediaSourceIdentifierType>, WTF::MediaTime const&, unsigned long long), std::__1::tuple<WTF::ObjectIdentifier<WebCore::RealtimeMediaSourceIdentifierType>, WTF::MediaTime, unsigned long long>, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul> >(std::__1::tuple<WTF::ObjectIdentifier<WebCore::RealtimeMediaSourceIdentifierType>, WTF::MediaTime, unsigned long long>&&, WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager*, void (WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager::*)(WTF::ObjectIdentifier<WebCore::RealtimeMediaSourceIdentifierType>, WTF::MediaTime const&, unsigned long long)) 9 0x110fb2268 void IPC::handleMessage<Messages::SpeechRecognitionRemoteRealtimeMediaSourceManager::RemoteAudioSamplesAvailable, WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager, void (WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager::*)(WTF::ObjectIdentifier<WebCore::RealtimeMediaSourceIdentifierType>, WTF::MediaTime const&, unsigned long long)>(IPC::Decoder&, WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager*, void (WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager::*)(WTF::ObjectIdentifier<WebCore::RealtimeMediaSourceIdentifierType>, WTF::MediaTime const&, unsigned long long)) 10 0x110fb2046 WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 11 0x110d10304 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 12 0x111ad3bde WebKit::AuxiliaryProcessProxy::dispatchMessage(IPC::Connection&, IPC::Decoder&) 13 0x111dc839f WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 14 0x1107f14b4 IPC::Connection::dispatchMessage(IPC::Decoder&) 15 0x1107f1c9c IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 16 0x1107f0410 IPC::Connection::dispatchIncomingMessages() 17 0x110813542 IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_12::operator()() 18 0x11081344e WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_12, void>::call() 19 0x1084c44e2 WTF::Function<void ()>::operator()() const 20 0x1085495e5 WTF::RunLoop::performWork() 21 0x10854dea1 WTF::RunLoop::performWork(void*) 22 0x1215feede __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 23 0x1215fedd6 __CFRunLoopDoSource0 24 0x1215fe29e __CFRunLoopDoSources0 25 0x1215f89f7 __CFRunLoopRun 26 0x1215f81a7 CFRunLoopRunSpecific 27 0x120dfe204 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 28 0x105b9130e WTR::TestController::platformRunUntil(bool&, WTF::Seconds) 29 0x105b54baf WTR::TestController::runUntil(bool&, WTF::Seconds) 30 0x105b5ae95 WTR::TestController::statisticsResetToConsistentState() 31 0x105b59ee9 WTR::TestController::resetStateToConsistentValues(WTR::TestOptions const&, WTR::TestController::ResetStage) https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=fast%2Fspeechrecognition%2Fios%2Faudio-capture.html&test=fast%2Fspeechrecognition%2Fios%2Frestart-recognition-after-stop.html&test=fast%2Fspeechrecognition%2Fios%2Fstart-recognition-then-stop.html 1763724 1 webkit-bug-importer 2021-05-25 16:06:21 -0700 <rdar://problem/78481513> 1763725 2 cdumez 2021-05-25 16:06:38 -0700 Looking now. 1763726 3 cdumez 2021-05-25 16:07:48 -0700 It is a new assertion I added. I guess I was wrong about this function always running on the audio thread 1763736 4 429708 cdumez 2021-05-25 16:16:07 -0700 Created attachment 429708 Patch 1763738 5 429708 cdumez 2021-05-25 16:17:39 -0700 Comment on attachment 429708 Patch Clearing flags on attachment: 429708 Committed r278056 (238140@main): <https://commits.webkit.org/238140@main> 1763739 6 cdumez 2021-05-25 16:17:42 -0700 All reviewed patches have been landed. Closing bug. 429708 2021-05-25 16:16:07 -0700 2021-05-25 16:17:39 -0700 Patch bug-226247-20210525161606.patch text/plain 3072 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmIxMjgxNzQ2NTkwYzc0 NjI4NzI2OThiMjA1NjNiMGZmNjhhNjY1ZC4uYjQyN2RmNTA4OTczZmRhMGIyOTYyMzc5YWJjMzJh NTFhMjI5MWNkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA1LTI1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gQVNTRVJUSU9OIEZB SUxFRDogIWlzTWFpblRocmVhZCgpIGluIFdlYkNvcmU6OlNwZWVjaFJlY29nbml0aW9uQ2FwdHVy ZVNvdXJjZUltcGw6OmF1ZGlvU2FtcGxlc0F2YWlsYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2MjQ3CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS83ODQ4MTUxMz4KKworICAgICAgICBVbnJldmlld2VkLCBkcm9wIHRocmVhZGluZyBhc3NlcnRp b25zIEkgYWRkZWQgaW4gcjI3NzkyMSBhcyBteSB1bmRlcnN0YW5kaW5nIHdhcyB3cm9uZworICAg ICAgICBhYm91dCB3aGljaCB0aHJlYWQgdGhlIGZ1bmN0aW9ucyBydW4gb24gYW5kIHRoZXkgYXJl IGhpdHRpbmcgb24gdGhlIGJvdHMuCisKKyAgICAgICAgKiBNb2R1bGVzL3NwZWVjaC9TcGVlY2hS ZWNvZ25pdGlvbkNhcHR1cmVTb3VyY2VJbXBsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNwZWVj aFJlY29nbml0aW9uQ2FwdHVyZVNvdXJjZUltcGw6OnVwZGF0ZURhdGFTb3VyY2UpOgorICAgICAg ICAqIE1vZHVsZXMvc3BlZWNoL1NwZWVjaFJlY29nbml0aW9uQ2FwdHVyZVNvdXJjZUltcGwuaDoK KwogMjAyMS0wNS0yNSAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGxlLmNvbT4KIAogICAgICAg ICBNYWtlIGVycm9yIHJldHVybmVkIGJ5IFNRTGl0ZUlEQkJhY2tpbmdTdG9yZTo6Z2V0T3JFc3Rh Ymxpc2hEYXRhYmFzZUluZm8gbW9yZSBkZXRhaWxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9zcGVlY2gvU3BlZWNoUmVjb2duaXRpb25DYXB0dXJlU291cmNlSW1wbC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3NwZWVjaC9TcGVlY2hSZWNvZ25pdGlvbkNhcHR1cmVT b3VyY2VJbXBsLmNwcAppbmRleCA5YzNlNmY5MDM2ZDM2YTE0YTZkMDQwN2QyODA4MjljZDU5YzVl MjgxLi5lNDg1NTk0YjgxMjJiMDc2ZmVlMWQ0ZGFhMDcyMjMyMTA3ZTI3N2JiIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3NwZWVjaC9TcGVlY2hSZWNvZ25pdGlvbkNhcHR1cmVT b3VyY2VJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3NwZWVjaC9TcGVlY2hS ZWNvZ25pdGlvbkNhcHR1cmVTb3VyY2VJbXBsLmNwcApAQCAtODMsOCArODMsNiBAQCBTcGVlY2hS ZWNvZ25pdGlvbkNhcHR1cmVTb3VyY2VJbXBsOjp+U3BlZWNoUmVjb2duaXRpb25DYXB0dXJlU291 cmNlSW1wbCgpCiAjaWYgUExBVEZPUk0oQ09DT0EpCiBib29sIFNwZWVjaFJlY29nbml0aW9uQ2Fw dHVyZVNvdXJjZUltcGw6OnVwZGF0ZURhdGFTb3VyY2UoY29uc3QgQ0FBdWRpb1N0cmVhbURlc2Ny aXB0aW9uJiBhdWRpb0Rlc2NyaXB0aW9uKQogewotICAgIEFTU0VSVCghaXNNYWluVGhyZWFkKCkp OwotCiAgICAgaWYgKCFtX2RhdGFTb3VyY2VMb2NrLnRyeUxvY2soKSkKICAgICAgICAgcmV0dXJu IGZhbHNlOwogCkBAIC0xMjgsNyArMTI2LDYgQEAgdm9pZCBTcGVlY2hSZWNvZ25pdGlvbkNhcHR1 cmVTb3VyY2VJbXBsOjpwdWxsU2FtcGxlc0FuZENhbGxEYXRhQ2FsbGJhY2soY29uc3QgTWUKIC8v IEZJWE1FOiBJdCBpcyB1bmNsZWFyIHdoeSBpdCBpcyBzYWZlIHRvIHVzZSBtX2RhdGFTb3VyY2Ug d2l0aG91dCBsb2NraW5nIGluIHRoaXMgZnVuY3Rpb24uCiB2b2lkIFNwZWVjaFJlY29nbml0aW9u Q2FwdHVyZVNvdXJjZUltcGw6OmF1ZGlvU2FtcGxlc0F2YWlsYWJsZShjb25zdCBNZWRpYVRpbWUm IHRpbWUsIGNvbnN0IFBsYXRmb3JtQXVkaW9EYXRhJiBkYXRhLCBjb25zdCBBdWRpb1N0cmVhbURl c2NyaXB0aW9uJiBkZXNjcmlwdGlvbiwgc2l6ZV90IHNhbXBsZUNvdW50KSBXVEZfSUdOT1JFU19U SFJFQURfU0FGRVRZX0FOQUxZU0lTCiB7Ci0gICAgQVNTRVJUKCFpc01haW5UaHJlYWQoKSk7CiAj aWYgUExBVEZPUk0oQ09DT0EpCiAgICAgRGlzYWJsZU1hbGxvY1Jlc3RyaWN0aW9uc0ZvckN1cnJl bnRUaHJlYWRTY29wZSBzY29wZTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9zcGVlY2gvU3BlZWNoUmVjb2duaXRpb25DYXB0dXJlU291cmNlSW1wbC5oIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9zcGVlY2gvU3BlZWNoUmVjb2duaXRpb25DYXB0dXJlU291cmNlSW1wbC5o CmluZGV4IGMyYzA2NGI3ZGNiOWEwNzY1OTRkNTNhNGRiNzY2YzZhNjMxZjc1NzEuLmIxNDA4YjY1 ZTEwOGU2MmZiMWY1MTg3ZDFlY2QxZmE0MGZmZmY5OGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvc3BlZWNoL1NwZWVjaFJlY29nbml0aW9uQ2FwdHVyZVNvdXJjZUltcGwuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3NwZWVjaC9TcGVlY2hSZWNvZ25pdGlvbkNhcHR1 cmVTb3VyY2VJbXBsLmgKQEAgLTc3LDcgKzc3LDcgQEAgcHJpdmF0ZToKICAgICBSZWY8UmVhbHRp bWVNZWRpYVNvdXJjZT4gbV9zb3VyY2U7CiAKICNpZiBQTEFURk9STShDT0NPQSkKLSAgICBSZWZQ dHI8QXVkaW9TYW1wbGVEYXRhU291cmNlPiBtX2RhdGFTb3VyY2UgV1RGX0dVQVJERURfQllfTE9D SyhtX2RhdGFTb3VyY2VMb2NrKTsgLy8gT25seSBtb2RpZmllZCBvbiB0aGUgYXVkaW8gdGhyZWFk IGJ1dCBtYXkgZ2V0IHVzZWQgb24gdGhlIG1haW4gdGhyZWFkLgorICAgIFJlZlB0cjxBdWRpb1Nh bXBsZURhdGFTb3VyY2U+IG1fZGF0YVNvdXJjZSBXVEZfR1VBUkRFRF9CWV9MT0NLKG1fZGF0YVNv dXJjZUxvY2spOwogICAgIExvY2sgbV9kYXRhU291cmNlTG9jazsKICNlbmRpZgogfTsK