226244 2021-05-25 15:31:31 -0700 [WPE][GTK] Support building against uClibc 2021-06-01 06:40:41 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Linux RESOLVED FIXED InRadar P2 Normal --- 210068 225099 1 aperez aperez benjamin cdumez cgarcia cmarcelo ews-watchlist keith_miller mark.lam mcatanzaro msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1763707 0 aperez 2021-05-25 15:31:31 -0700 After the fixes from bug #210068 and bug #225099 it's *almost* possible to build the GTK and WPE ports against uClibc—the Musl fixes also benefited uClibc :) There are a couple of things to fix for uClibc, though. 1763713 1 429702 aperez 2021-05-25 15:37:54 -0700 Created attachment 429702 Patch 1765583 2 429702 mcatanzaro 2021-06-01 05:27:55 -0700 Comment on attachment 429702 Patch Unfortunately we're almost guaranteed to have unknown glibc-specific assumptions that will result in incorrect behavior at runtime hidden throughout WebKit. I guess the first step to finding them is to make it build. E.g. one fun problem we used to have was gspawn relied on malloc being async-signal-safe, so subprocess launching would randomly fail with other C libraries , but only if you're sufficiently unlucky. That was eventually fixed in fairly recent versions of glib. Point is: similar problems will be out there.... 1765589 3 ews-feeder 2021-06-01 06:01:09 -0700 Committed r278302 (238339@main): <https://commits.webkit.org/238339@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429702. 1765590 4 webkit-bug-importer 2021-06-01 06:02:20 -0700 <rdar://problem/78711308> 1765594 5 aperez 2021-06-01 06:40:41 -0700 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 429702 [details] > Patch > > Unfortunately we're almost guaranteed to have unknown glibc-specific > assumptions that will result in incorrect behavior at runtime hidden > throughout WebKit. I guess the first step to finding them is to make it > build. > > E.g. one fun problem we used to have was gspawn relied on malloc being > async-signal-safe, so subprocess launching would randomly fail with other C > libraries , but only if you're sufficiently unlucky. That was eventually > fixed in fairly recent versions of glib. Point is: similar problems will be > out there.... While I had *not* done a full run of layout tests with an uClibc build, I did submit this patch to Buildroot and did an ARM64 build which I smoke tested for a while without issues. The recent changes that were done for Musl also helped for uClibc, as a matter of fact, and while it is likely that some tests would fail with an uClibc build, it seems usable in practice. Here's the Buildroot patches needed to have the WPE and GTK ports built with uClibc, for reference: https://patchwork.ozlabs.org/project/buildroot/patch/20210526182416.2798443-1-aperez@igalia.com/ https://patchwork.ozlabs.org/project/buildroot/patch/20210526183839.3062697-1-aperez@igalia.com/ :) 429702 2021-05-25 15:37:54 -0700 2021-06-01 06:01:11 -0700 Patch bug-226244-20210526013753.patch text/plain 3013 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MDUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 YTA5MTQ4MzJmODk5NGY2M2E5MjAwZjQ0NjYwYThjMmQwZWM0ZWE2Li5iYjA5YWU5NjczM2U5YjZl YjU3ZWZhNGExZTZhOTgwMzc2ZTJjNDI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMS0wNS0yNSAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBp Z2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdW0dUS10gU3VwcG9ydCBidWlsZGluZyBhZ2FpbnN0 IHVDbGliYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjI2MjQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NC5jcHA6CisgICAgICAgIChnZXRhdXh2YWwp OiBQcm92aWRlIGEgZmFsbGJhY2sgaW1wbGVtZW50YXRpb24gb2YgZ2V0YXV4dmFsKCkgZm9yCisg ICAgICAgIHN5c3RlbXMgd2hpY2ggZG8gbm90IHByb3ZpZGUgPHN5cy9hdXh2Lmg+LCBsaWtlIHRo b3NlIHVzaW5nIHVDbGliYworICAgICAgICBhcyB0aGVpciBDIGxpYnJhcnkuCisKIDIwMjEtMDUt MjQgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFN3aXRjaCBmcm9t IFdURjo6T3B0aW9uYWwgdG8gc3RkOjpvcHRpb25hbApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCBiY2MxYWU4MjA3OThkMzQ3MWE2 ZTRlYjU4NWZiN2NjMTBjM2ZhZGZkLi4zNjliMWQ5ZmI3NWFhMjBhNjc3NTY4NTA2M2Y4YmFlMzk1 YzQ5MTY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV1RG L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA1LTI1ICBBZHJpYW4gUGVyZXogZGUg Q2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dQRV1bR1RLXSBTdXBwb3J0 IGJ1aWxkaW5nIGFnYWluc3QgdUNsaWJjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjYyNDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybVJlZ2lzdGVycy5oOiBVc2UgdGhlIDxzeXMv dWNvbnRleHQuaD4gaGVhZGVyIGluc3RlYWQgb2YKKyAgICAgICAgPHVjb250ZXh0Lmg+LCB3aGlj aCBpcyBlbm91Z2ggdG8gZ2FpbiBhY2Nlc3MgdG8gdGhlIHR5cGUgZGVmaW5pdGlvbnMKKyAgICAg ICAgZm9yIENQVSByZWdpc3RlcnMgYW5kIGlzIGF2YWlsYWJsZSBvbiBldmVyeSBsaWJjLiBPbiB0 aGUgb3RoZXIgaGFuZCwKKyAgICAgICAgdUNsaWJjIGRvZXMgbm90IGhhdmUgPHVjb250ZXh0Lmg+ LCBzbyB0aGlzIGZpeGVzIHRoZSBidWlsZCBpbiB0aGF0CisgICAgICAgIGNhc2UuCisKIDIwMjEt MDUtMjQgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFN3aXRjaCBm cm9tIFdURjo6T3B0aW9uYWwgdG8gc3RkOjpvcHRpb25hbApkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0LmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NC5jcHAKaW5kZXggMGEz MjgxNGIyY2UwNjQyOTlmOTI5MzVjMTllMzJmZGE1M2JlMTI0MC4uZGRiNDUxNDk1YjkxOTljNGM1 OWFmMmI4ZDY1ZjBhZWZhMTQxZTQ2NyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuY3BwCkBAIC0zNCw3ICszNCwyNSBA QAogCiAjaWYgT1MoTElOVVgpCiAjaW5jbHVkZSA8YXNtL2h3Y2FwLmg+CisjaWYgX19oYXNfaW5j bHVkZSg8c3lzL2F1eHYuaD4pCiAjaW5jbHVkZSA8c3lzL2F1eHYuaD4KKyNlbHNlCisjaW5jbHVk ZSA8bGludXgvYXV4dmVjLmg+CisvLyBQcm92aWRlIGFuIGltcGxlbWVudGF0aW9uIGZvciBDIGxp YnJhcmllcyB3aGljaCBkbyBub3Qgc2hpcCBvbmUuCitzdGF0aWMgdW5zaWduZWQgbG9uZyBnZXRh dXh2YWwodW5zaWduZWQgbG9uZyB0eXBlKQoreworICAgIGNoYXIqKiBlbnYgPSBlbnZpcm9uOwor ICAgIHdoaWxlICgqZW52KyspIHsgLyogbm8tb3AgKi8gfQorCisgICAgZm9yIChhdXRvKiBhdXh2 ID0gcmVpbnRlcnByZXRfY2FzdDx1bnNpZ25lZCBsb25nKj4oZW52KTsgKmF1eHYgIT0gQVRfTlVM TDsgYXV4diArPSAyKSB7CisgICAgICAgIGlmICgqYXV4diA9PSB0eXBlKQorICAgICAgICAgICAg cmV0dXJuIGF1eHZbMV07CisgICAgfQorCisgICAgZXJybm8gPSBFTk9FTlQ7CisgICAgcmV0dXJu IDA7Cit9CisjZW5kaWYKICNlbmRpZgogCiBuYW1lc3BhY2UgSlNDIHsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XVEYvd3RmL1BsYXRmb3JtUmVnaXN0ZXJzLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9y bVJlZ2lzdGVycy5oCmluZGV4IGQyNmVmOTg1MTY5NDZlMmViM2ZlMTUzMjdmZTQ5MjcyMzViNzQz ZDUuLmU3ZjE1YjdlYjYyZDZjZGQyZmU3ZDI3NWE3YTU5N2NlMDQ4NmE0MDQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtUmVnaXN0ZXJzLmgKKysrIGIvU291cmNlL1dURi93dGYv UGxhdGZvcm1SZWdpc3RlcnMuaApAQCAtMzUsNyArMzUsNyBAQAogI2VsaWYgT1MoV0lORE9XUykK ICNpbmNsdWRlIDx3aW5kb3dzLmg+CiAjZWxzZQotI2luY2x1ZGUgPHVjb250ZXh0Lmg+CisjaW5j bHVkZSA8c3lzL3Vjb250ZXh0Lmg+CiAjZW5kaWYKIAogbmFtZXNwYWNlIFdURiB7Cg==