226208 2021-05-24 19:32:36 -0700 Stop using UncheckedLock in DatabaseTracker 2021-05-25 08:27:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen darin ggaren kkinnunen sam webkit-bug-importer oldest_to_newest 1763390 0 cdumez 2021-05-24 19:32:36 -0700 Stop using UncheckedLock in DatabaseTracker. 1763392 1 429613 cdumez 2021-05-24 19:35:43 -0700 Created attachment 429613 Patch 1763404 2 429613 sam 2021-05-24 20:11:20 -0700 Comment on attachment 429613 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429613&action=review > Source/WebCore/ChangeLog:14 > + In this particular instance, I have opted to annotate the functions that gave out > + warning with WTF_IGNORES_THREAD_SAFETY_ANALYSIS. I initially tried to use proper > + annotations (WTF_ACQUIRES_LOCK() / WTF_RELEASES_LOCK()). However, the call sites are > + Objective C functions and I am unable to annotate those. I think adding a comment to the code explaining this would be helpful for future readers. 1763407 3 429619 cdumez 2021-05-24 20:13:50 -0700 Created attachment 429619 Patch 1763516 4 ews-feeder 2021-05-25 08:26:54 -0700 Committed r278008 (238121@main): <https://commits.webkit.org/238121@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429619. 1763517 5 webkit-bug-importer 2021-05-25 08:27:19 -0700 <rdar://problem/78457503> 429613 2021-05-24 19:35:43 -0700 2021-05-24 20:13:48 -0700 Patch bug-226208-20210524193542.patch text/plain 3378 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3OTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2U4ZDlkMmI4ZjhiNjY5 OTRiN2U1MjczZDdmMWI2YTcxM2ZmZjUzZC4uYzc0OGJkM2JlOTNlNmI2ZTc1YjBlYTg2Y2VjYTc2 MTdiNDZlMTQ5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTA1LTI0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU3RvcCB1c2luZyBVbmNoZWNr ZWRMb2NrIGluIERhdGFiYXNlVHJhY2tlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjI2MjA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU3RvcCB1c2luZyBVbmNoZWNrZWRMb2NrIGluIERhdGFiYXNlVHJh Y2tlci4gVGhpcyBpcyBhIHN0ZXAgdG93YXJkcyBwaGFzaW5nIG91dCB0aGUKKyAgICAgICAgVW5j aGVja2VkTG9jayBpbiBmYXZvciBvZiB0aGUgcmVndWxhciBMb2NrIHdoaWNoIHN1cHBvcnQgQ2xh bmcgdGhyZWFkIHNhZmV0eSBhbmFseXNpcy4KKworICAgICAgICBJbiB0aGlzIHBhcnRpY3VsYXIg aW5zdGFuY2UsIEkgaGF2ZSBvcHRlZCB0byBhbm5vdGF0ZSB0aGUgZnVuY3Rpb25zIHRoYXQgZ2F2 ZSBvdXQKKyAgICAgICAgd2FybmluZyB3aXRoIFdURl9JR05PUkVTX1RIUkVBRF9TQUZFVFlfQU5B TFlTSVMuIEkgaW5pdGlhbGx5IHRyaWVkIHRvIHVzZSBwcm9wZXIKKyAgICAgICAgYW5ub3RhdGlv bnMgKFdURl9BQ1FVSVJFU19MT0NLKCkgLyBXVEZfUkVMRUFTRVNfTE9DSygpKS4gSG93ZXZlciwg dGhlIGNhbGwgc2l0ZXMgYXJlCisgICAgICAgIE9iamVjdGl2ZSBDIGZ1bmN0aW9ucyBhbmQgSSBh bSB1bmFibGUgdG8gYW5ub3RhdGUgdGhvc2UuCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYmRhdGFi YXNlL0RhdGFiYXNlVHJhY2tlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEYXRhYmFzZVRyYWNr ZXI6Om9wZW5EYXRhYmFzZU11dGV4KToKKyAgICAgICAgKiBNb2R1bGVzL3dlYmRhdGFiYXNlL0Rh dGFiYXNlVHJhY2tlci5oOgorCiAyMDIxLTA1LTI0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CiAKICAgICAgICAgU3RvcCB1c2luZyBVbmNoZWNrZWRMb2NrIGluIGh0bWwvY2FudmFz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL0RhdGFiYXNl VHJhY2tlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL0RhdGFiYXNl VHJhY2tlci5jcHAKaW5kZXggYTlmMjgwYjljNTlmNDhiZGIyOGRhNzMwMTUzNzY0M2U5NGRkNjU2 MC4uMGI2NDJmZDUyOGU1YTA1OTI5Y2U4OGE2MjE4MTI4YzExZDQzY2U3ZSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJkYXRhYmFzZS9EYXRhYmFzZVRyYWNrZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0YWJhc2UvRGF0YWJhc2VUcmFja2VyLmNw cApAQCAtMTI4NSwyMCArMTI4NSwyMCBAQCBib29sIERhdGFiYXNlVHJhY2tlcjo6ZGVsZXRlRGF0 YWJhc2VGaWxlSWZFbXB0eShjb25zdCBTdHJpbmcmIHBhdGgpCiAgICAgcmV0dXJuIFNRTGl0ZUZp bGVTeXN0ZW06OmRlbGV0ZURhdGFiYXNlRmlsZShwYXRoKTsKIH0KIAotc3RhdGljIFVuY2hlY2tl ZExvY2sgb3BlbkRhdGFiYXNlTG9jazsKLVVuY2hlY2tlZExvY2smIERhdGFiYXNlVHJhY2tlcjo6 b3BlbkRhdGFiYXNlTXV0ZXgoKQorc3RhdGljIExvY2sgb3BlbkRhdGFiYXNlTG9jazsKK0xvY2sm IERhdGFiYXNlVHJhY2tlcjo6b3BlbkRhdGFiYXNlTXV0ZXgoKQogewogICAgIHJldHVybiBvcGVu RGF0YWJhc2VMb2NrOwogfQogCi12b2lkIERhdGFiYXNlVHJhY2tlcjo6ZW1wdHlEYXRhYmFzZUZp bGVzUmVtb3ZhbFRhc2tXaWxsQmVTY2hlZHVsZWQoKQordm9pZCBEYXRhYmFzZVRyYWNrZXI6OmVt cHR5RGF0YWJhc2VGaWxlc1JlbW92YWxUYXNrV2lsbEJlU2NoZWR1bGVkKCkgV1RGX0lHTk9SRVNf VEhSRUFEX1NBRkVUWV9BTkFMWVNJUwogewogICAgIC8vIExvY2sgdGhlIGRhdGFiYXNlIGZyb20g b3BlbmluZyBhbnkgZGF0YWJhc2UgdW50aWwgd2UgYXJlIGRvbmUgd2l0aCBzY2FubmluZyB0aGUg ZmlsZSBzeXN0ZW0gZm9yCiAgICAgLy8gemVybyBieXRlIGRhdGFiYXNlIGZpbGVzIHRvIHJlbW92 ZS4KICAgICBvcGVuRGF0YWJhc2VMb2NrLmxvY2soKTsKIH0KIAotdm9pZCBEYXRhYmFzZVRyYWNr ZXI6OmVtcHR5RGF0YWJhc2VGaWxlc1JlbW92YWxUYXNrRGlkRmluaXNoKCkKK3ZvaWQgRGF0YWJh c2VUcmFja2VyOjplbXB0eURhdGFiYXNlRmlsZXNSZW1vdmFsVGFza0RpZEZpbmlzaCgpIFdURl9J R05PUkVTX1RIUkVBRF9TQUZFVFlfQU5BTFlTSVMKIHsKICAgICBvcGVuRGF0YWJhc2VMb2NrLnVu bG9jaygpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJkYXRhYmFz ZS9EYXRhYmFzZVRyYWNrZXIuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0YWJhc2Uv RGF0YWJhc2VUcmFja2VyLmgKaW5kZXggNWRkN2ZlZTUxMDA3ZTc3YmVjNDBhMzcyNDcxZTFkYTY0 Zjc4YmNlMi4uNzBjYzIyYjY4ZGRjNTA5NTI1OGY5ZWQwMTBkY2Q2NjM0M2VkNzdhMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJkYXRhYmFzZS9EYXRhYmFzZVRyYWNrZXIu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL0RhdGFiYXNlVHJhY2tl ci5oCkBAIC0xMDQsNyArMTA0LDcgQEAgcHVibGljOgogICAgIC8vIE1vYmlsZVNhZmFyaSB3aWxs IGdyYWIgdGhpcyBtdXRleCBvbiB0aGUgbWFpbiB0aHJlYWQgYmVmb3JlIGRpc3BhdGNoaW5nIHRo ZSB0YXNrIHRvIAogICAgIC8vIGNsZWFuIHVwIHplcm8gYnl0ZSBkYXRhYmFzZSBmaWxlcy4gIEFu eSBvcGVyYXRpb25zIHRvIG9wZW4gbmV3IGRhdGFiYXNlIHdpbGwgaGF2ZSB0bwogICAgIC8vIHdh aXQgZm9yIHRoYXQgdGFzayB0byBmaW5pc2ggYnkgd2FpdGluZyBvbiB0aGlzIG11dGV4LgotICAg IHN0YXRpYyBVbmNoZWNrZWRMb2NrJiBvcGVuRGF0YWJhc2VNdXRleCgpOworICAgIHN0YXRpYyBM b2NrJiBvcGVuRGF0YWJhc2VNdXRleCgpOwogICAgIAogICAgIFdFQkNPUkVfRVhQT1JUIHN0YXRp YyB2b2lkIGVtcHR5RGF0YWJhc2VGaWxlc1JlbW92YWxUYXNrV2lsbEJlU2NoZWR1bGVkKCk7CiAg ICAgV0VCQ09SRV9FWFBPUlQgc3RhdGljIHZvaWQgZW1wdHlEYXRhYmFzZUZpbGVzUmVtb3ZhbFRh c2tEaWRGaW5pc2goKTsK 429619 2021-05-24 20:13:50 -0700 2021-05-25 08:26:55 -0700 Patch bug-226208-20210524201350.patch text/plain 3702 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3OTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjg5ZmZlMGYwYjA5ZTNk Y2EyOGMzNmQxZTcwYjBiYmQwODcyMDMwMy4uMGQyZDExMjc4MTE4N2RiODRlYmIyNTc4YjAzYTky NmM2YjQ0ZGJjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTA1LTI0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU3RvcCB1c2luZyBVbmNoZWNr ZWRMb2NrIGluIERhdGFiYXNlVHJhY2tlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjI2MjA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5p Zy4KKworICAgICAgICBTdG9wIHVzaW5nIFVuY2hlY2tlZExvY2sgaW4gRGF0YWJhc2VUcmFja2Vy LiBUaGlzIGlzIGEgc3RlcCB0b3dhcmRzIHBoYXNpbmcgb3V0IHRoZQorICAgICAgICBVbmNoZWNr ZWRMb2NrIGluIGZhdm9yIG9mIHRoZSByZWd1bGFyIExvY2sgd2hpY2ggc3VwcG9ydCBDbGFuZyB0 aHJlYWQgc2FmZXR5IGFuYWx5c2lzLgorCisgICAgICAgIEluIHRoaXMgcGFydGljdWxhciBpbnN0 YW5jZSwgSSBoYXZlIG9wdGVkIHRvIGFubm90YXRlIHRoZSBmdW5jdGlvbnMgdGhhdCBnYXZlIG91 dAorICAgICAgICB3YXJuaW5nIHdpdGggV1RGX0lHTk9SRVNfVEhSRUFEX1NBRkVUWV9BTkFMWVNJ Uy4gSSBpbml0aWFsbHkgdHJpZWQgdG8gdXNlIHByb3BlcgorICAgICAgICBhbm5vdGF0aW9ucyAo V1RGX0FDUVVJUkVTX0xPQ0soKSAvIFdURl9SRUxFQVNFU19MT0NLKCkpLiBIb3dldmVyLCB0aGUg Y2FsbCBzaXRlcyBhcmUKKyAgICAgICAgT2JqZWN0aXZlIEMgZnVuY3Rpb25zIGFuZCBJIGFtIHVu YWJsZSB0byBhbm5vdGF0ZSB0aG9zZS4KKworICAgICAgICAqIE1vZHVsZXMvd2ViZGF0YWJhc2Uv RGF0YWJhc2VUcmFja2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRhdGFiYXNlVHJhY2tlcjo6 b3BlbkRhdGFiYXNlTXV0ZXgpOgorICAgICAgICAqIE1vZHVsZXMvd2ViZGF0YWJhc2UvRGF0YWJh c2VUcmFja2VyLmg6CisKIDIwMjEtMDUtMjQgIFNhbSBXZWluaWcgIDx3ZWluaWdAYXBwbGUuY29t PgogCiAgICAgICAgIENvbnZlcnQgRGVzdGluYXRpb25Db2xvclNwYWNlIGZyb20gYW4gZW51bSB0 byBjbGFzcyB3cmFwcGluZyBhIHBsYXRmb3JtIGNvbG9yIHNwYWNlIChDR0NvbG9yU3BhY2VSZWYg Zm9yIENHIHBvcnRzLCBldGMuKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93 ZWJkYXRhYmFzZS9EYXRhYmFzZVRyYWNrZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93 ZWJkYXRhYmFzZS9EYXRhYmFzZVRyYWNrZXIuY3BwCmluZGV4IGE5ZjI4MGI5YzU5ZjQ4YmRiMjhk YTczMDE1Mzc2NDNlOTRkZDY1NjAuLmZjODE5MmY5NGUyYWYxNDJhM2M0Y2UwYjUxZmVlZjMyOWVj ZjYzNjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0YWJhc2UvRGF0 YWJhc2VUcmFja2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNl L0RhdGFiYXNlVHJhY2tlci5jcHAKQEAgLTEyODUsMjAgKzEyODUsMjIgQEAgYm9vbCBEYXRhYmFz ZVRyYWNrZXI6OmRlbGV0ZURhdGFiYXNlRmlsZUlmRW1wdHkoY29uc3QgU3RyaW5nJiBwYXRoKQog ICAgIHJldHVybiBTUUxpdGVGaWxlU3lzdGVtOjpkZWxldGVEYXRhYmFzZUZpbGUocGF0aCk7CiB9 CiAKLXN0YXRpYyBVbmNoZWNrZWRMb2NrIG9wZW5EYXRhYmFzZUxvY2s7Ci1VbmNoZWNrZWRMb2Nr JiBEYXRhYmFzZVRyYWNrZXI6Om9wZW5EYXRhYmFzZU11dGV4KCkKK3N0YXRpYyBMb2NrIG9wZW5E YXRhYmFzZUxvY2s7CitMb2NrJiBEYXRhYmFzZVRyYWNrZXI6Om9wZW5EYXRhYmFzZU11dGV4KCkK IHsKICAgICByZXR1cm4gb3BlbkRhdGFiYXNlTG9jazsKIH0KIAotdm9pZCBEYXRhYmFzZVRyYWNr ZXI6OmVtcHR5RGF0YWJhc2VGaWxlc1JlbW92YWxUYXNrV2lsbEJlU2NoZWR1bGVkKCkKKy8vIFdl IGFyZSBub3QgdXNpbmcgV1RGX0FDUVVJUkVTX0xPQ0sob3BlbkRhdGFiYXNlTG9jaykgYmVjYXVz ZSB0aGUgY2FsbCBzaXRlcyBhcmUgT2JqQyBmdW5jdGlvbnMgYW5kIGNhbm5vdCBiZSBhbm5vdGF0 ZWQuCit2b2lkIERhdGFiYXNlVHJhY2tlcjo6ZW1wdHlEYXRhYmFzZUZpbGVzUmVtb3ZhbFRhc2tX aWxsQmVTY2hlZHVsZWQoKSBXVEZfSUdOT1JFU19USFJFQURfU0FGRVRZX0FOQUxZU0lTCiB7CiAg ICAgLy8gTG9jayB0aGUgZGF0YWJhc2UgZnJvbSBvcGVuaW5nIGFueSBkYXRhYmFzZSB1bnRpbCB3 ZSBhcmUgZG9uZSB3aXRoIHNjYW5uaW5nIHRoZSBmaWxlIHN5c3RlbSBmb3IKICAgICAvLyB6ZXJv IGJ5dGUgZGF0YWJhc2UgZmlsZXMgdG8gcmVtb3ZlLgogICAgIG9wZW5EYXRhYmFzZUxvY2subG9j aygpOwogfQogCi12b2lkIERhdGFiYXNlVHJhY2tlcjo6ZW1wdHlEYXRhYmFzZUZpbGVzUmVtb3Zh bFRhc2tEaWRGaW5pc2goKQorLy8gV2UgYXJlIG5vdCB1c2luZyBXVEZfUkVMRUFTRVNfTE9DSyhv cGVuRGF0YWJhc2VMb2NrKSBiZWNhdXNlIHRoZSBjYWxsIHNpdGVzIGFyZSBPYmpDIGZ1bmN0aW9u cyBhbmQgY2Fubm90IGJlIGFubm90YXRlZC4KK3ZvaWQgRGF0YWJhc2VUcmFja2VyOjplbXB0eURh dGFiYXNlRmlsZXNSZW1vdmFsVGFza0RpZEZpbmlzaCgpIFdURl9JR05PUkVTX1RIUkVBRF9TQUZF VFlfQU5BTFlTSVMKIHsKICAgICBvcGVuRGF0YWJhc2VMb2NrLnVubG9jaygpOwogfQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJkYXRhYmFzZS9EYXRhYmFzZVRyYWNrZXIu aCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0YWJhc2UvRGF0YWJhc2VUcmFja2VyLmgK aW5kZXggNWRkN2ZlZTUxMDA3ZTc3YmVjNDBhMzcyNDcxZTFkYTY0Zjc4YmNlMi4uNzBjYzIyYjY4 ZGRjNTA5NTI1OGY5ZWQwMTBkY2Q2NjM0M2VkNzdhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy93ZWJkYXRhYmFzZS9EYXRhYmFzZVRyYWNrZXIuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL0RhdGFiYXNlVHJhY2tlci5oCkBAIC0xMDQsNyArMTA0 LDcgQEAgcHVibGljOgogICAgIC8vIE1vYmlsZVNhZmFyaSB3aWxsIGdyYWIgdGhpcyBtdXRleCBv biB0aGUgbWFpbiB0aHJlYWQgYmVmb3JlIGRpc3BhdGNoaW5nIHRoZSB0YXNrIHRvIAogICAgIC8v IGNsZWFuIHVwIHplcm8gYnl0ZSBkYXRhYmFzZSBmaWxlcy4gIEFueSBvcGVyYXRpb25zIHRvIG9w ZW4gbmV3IGRhdGFiYXNlIHdpbGwgaGF2ZSB0bwogICAgIC8vIHdhaXQgZm9yIHRoYXQgdGFzayB0 byBmaW5pc2ggYnkgd2FpdGluZyBvbiB0aGlzIG11dGV4LgotICAgIHN0YXRpYyBVbmNoZWNrZWRM b2NrJiBvcGVuRGF0YWJhc2VNdXRleCgpOworICAgIHN0YXRpYyBMb2NrJiBvcGVuRGF0YWJhc2VN dXRleCgpOwogICAgIAogICAgIFdFQkNPUkVfRVhQT1JUIHN0YXRpYyB2b2lkIGVtcHR5RGF0YWJh c2VGaWxlc1JlbW92YWxUYXNrV2lsbEJlU2NoZWR1bGVkKCk7CiAgICAgV0VCQ09SRV9FWFBPUlQg c3RhdGljIHZvaWQgZW1wdHlEYXRhYmFzZUZpbGVzUmVtb3ZhbFRhc2tEaWRGaW5pc2goKTsK