226206 2021-05-24 19:10:22 -0700 Stop using UncheckedLock in WTF::RecursiveLock 2021-05-24 21:00:18 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen benjamin cmarcelo darin ews-watchlist ggaren kkinnunen saam sam webkit-bug-importer oldest_to_newest 1763382 0 cdumez 2021-05-24 19:10:22 -0700 Stop using UncheckedLock in WTF::RecursiveLock and use a regular Lock instead. This is a step towards phasing out UncheckedLock. 1763385 1 429611 cdumez 2021-05-24 19:12:53 -0700 Created attachment 429611 Patch 1763405 2 429611 sam 2021-05-24 20:13:10 -0700 Comment on attachment 429611 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429611&action=review > Source/WTF/wtf/RecursiveLockAdapter.h:38 > + void lock() WTF_IGNORES_THREAD_SAFETY_ANALYSIS I think a comment explaining why this is being added would go a long way here. 1763410 3 429620 cdumez 2021-05-24 20:20:28 -0700 Created attachment 429620 Patch 1763423 4 ews-feeder 2021-05-24 20:59:56 -0700 Committed r277995 (238108@main): <https://commits.webkit.org/238108@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429620. 1763424 5 webkit-bug-importer 2021-05-24 21:00:18 -0700 <rdar://problem/78434523> 429611 2021-05-24 19:12:53 -0700 2021-05-24 20:20:26 -0700 Patch bug-226206-20210524191252.patch text/plain 2078 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3OTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDQ5OGIwMzJjNDRmOTkyMDgzNmU1ODNk Zjg1NDAwMTM2MTQ1MWE3MzIuLjI0OTE2ZTVmMDYxZjYzZjkxZmE1NWNkYTk2YzNmYWMwMzcyYzRj ZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDUtMjQgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KKworICAgICAgICBTdG9wIHVzaW5nIFVuY2hlY2tlZExvY2sgaW4gV1RGOjpS ZWN1cnNpdmVMb2NrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjYyMDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBTdG9wIHVzaW5nIFVuY2hlY2tlZExvY2sgaW4gV1RGOjpSZWN1cnNpdmVMb2NrIGFuZCB1 c2UgYSByZWd1bGFyIExvY2sgaW5zdGVhZC4KKyAgICAgICAgVGhpcyBpcyBhIHN0ZXAgdG93YXJk cyBwaGFzaW5nIG91dCBVbmNoZWNrZWRMb2NrLgorCisgICAgICAgIE5vdGUgdGhhdCBkZXNwaXRl IHRoaXMgY2hhbmdlLCBSZWN1cnNpdmVMb2NrIHN0aWxsIGRvZXNuJ3QgYmVuZWZpdCBmcm9tCisg ICAgICAgIENsYW5nIHRocmVhZCBzYWZldHkgYW5hbHlzaXMuIEkgYW0gbm90IHN1cmUgaXQgaXMg ZmVhc2libGUgdG8gbWFrZSBhbmFseXNpcworICAgICAgICB3b3JrIHdpdGggYSAqcmVjdXJzaXZl KiBsb2NrLgorCisgICAgICAgICogd3RmL1JlY3Vyc2l2ZUxvY2tBZGFwdGVyLmg6CisKIDIwMjEt MDUtMjQgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBTdG9wIHVz aW5nIFVuY2hlY2tlZExvY2sgaW4gaHRtbC9jYW52YXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYv d3RmL1JlY3Vyc2l2ZUxvY2tBZGFwdGVyLmggYi9Tb3VyY2UvV1RGL3d0Zi9SZWN1cnNpdmVMb2Nr QWRhcHRlci5oCmluZGV4IGNhN2JjNDU1NDQ3YjE1MjIwN2NlMWFiN2YwY2I0NGQ0ZWQxOGU4ZGUu Ljk2MDc1YmM3ZTRlMjhmMTU2OTE2ZTFlMGQ2NjdkMGYzYjUyNmVlMzUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XVEYvd3RmL1JlY3Vyc2l2ZUxvY2tBZGFwdGVyLmgKKysrIGIvU291cmNlL1dURi93dGYv UmVjdXJzaXZlTG9ja0FkYXB0ZXIuaApAQCAtMzUsNyArMzUsNyBAQCBjbGFzcyBSZWN1cnNpdmVM b2NrQWRhcHRlciB7CiBwdWJsaWM6CiAgICAgUmVjdXJzaXZlTG9ja0FkYXB0ZXIoKSA9IGRlZmF1 bHQ7CiAKLSAgICB2b2lkIGxvY2soKQorICAgIHZvaWQgbG9jaygpIFdURl9JR05PUkVTX1RIUkVB RF9TQUZFVFlfQU5BTFlTSVMKICAgICB7CiAgICAgICAgIFRocmVhZCYgbWUgPSBUaHJlYWQ6OmN1 cnJlbnQoKTsKICAgICAgICAgaWYgKCZtZSA9PSBtX293bmVyKSB7CkBAIC01MCw3ICs1MCw3IEBA IHB1YmxpYzoKICAgICAgICAgbV9yZWN1cnNpb25Db3VudCA9IDE7CiAgICAgfQogICAgIAotICAg IHZvaWQgdW5sb2NrKCkKKyAgICB2b2lkIHVubG9jaygpIFdURl9JR05PUkVTX1RIUkVBRF9TQUZF VFlfQU5BTFlTSVMKICAgICB7CiAgICAgICAgIGlmICgtLW1fcmVjdXJzaW9uQ291bnQpCiAgICAg ICAgICAgICByZXR1cm47CkBAIC01OCw3ICs1OCw3IEBAIHB1YmxpYzoKICAgICAgICAgbV9sb2Nr LnVubG9jaygpOwogICAgIH0KICAgICAKLSAgICBib29sIHRyeUxvY2soKQorICAgIGJvb2wgdHJ5 TG9jaygpIFdURl9JR05PUkVTX1RIUkVBRF9TQUZFVFlfQU5BTFlTSVMKICAgICB7CiAgICAgICAg IFRocmVhZCYgbWUgPSBUaHJlYWQ6OmN1cnJlbnQoKTsKICAgICAgICAgaWYgKCZtZSA9PSBtX293 bmVyKSB7CkBAIC04OSw3ICs4OSw3IEBAIHByaXZhdGU6CiAgICAgTG9ja1R5cGUgbV9sb2NrOwog fTsKIAotdXNpbmcgUmVjdXJzaXZlTG9jayA9IFJlY3Vyc2l2ZUxvY2tBZGFwdGVyPFVuY2hlY2tl ZExvY2s+OwordXNpbmcgUmVjdXJzaXZlTG9jayA9IFJlY3Vyc2l2ZUxvY2tBZGFwdGVyPExvY2s+ OwogCiB9IC8vIG5hbWVzcGFjZSBXVEYKIAo= 429620 2021-05-24 20:20:28 -0700 2021-05-24 20:59:57 -0700 Patch bug-226206-20210524202027.patch text/plain 3014 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3OTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDkwNDYxMTUwMDk0NGRlZTc4MjUxOTVl Y2YwMGZkMTBjZTY2ZDQwYTEuLmU2ZmI5YjgwOGFmZWQyZjJiNTA2NTI2YjVhYmRlMDEzODczOTJj M2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjEtMDUtMjQgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KKworICAgICAgICBTdG9wIHVzaW5nIFVuY2hlY2tlZExvY2sgaW4gV1RGOjpS ZWN1cnNpdmVMb2NrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjYyMDYKKworICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgorCisgICAgICAg IFN0b3AgdXNpbmcgVW5jaGVja2VkTG9jayBpbiBXVEY6OlJlY3Vyc2l2ZUxvY2sgYW5kIHVzZSBh IHJlZ3VsYXIgTG9jayBpbnN0ZWFkLgorICAgICAgICBUaGlzIGlzIGEgc3RlcCB0b3dhcmRzIHBo YXNpbmcgb3V0IFVuY2hlY2tlZExvY2suCisKKyAgICAgICAgTm90ZSB0aGF0IGRlc3BpdGUgdGhp cyBjaGFuZ2UsIFJlY3Vyc2l2ZUxvY2sgc3RpbGwgZG9lc24ndCBiZW5lZml0IGZyb20KKyAgICAg ICAgQ2xhbmcgdGhyZWFkIHNhZmV0eSBhbmFseXNpcy4gSXRzIGZ1bmN0aW9ucyBkbyBjb25kaXRp b25hbCBsb2NraW5nIC8gdW5sb2NraW5nCisgICAgICAgIHdoaWNoIGFyZSBub3QgY3VycmVudGx5 IHN1cHBvcnRlZCBieSBhbmFseXNpcy4gRXZlbiBpZiB0aGV5IHdlcmUsIHdlJ2QgbmVlZAorICAg ICAgICBhIHRlbXBsYXRlIHNwZWNpYWxpemF0aW9uIGZvciBSZWN1cnNpdmVMb2NrQWRhcHRlcjxM b2NrPiBzaW5jZQorICAgICAgICBSZWN1cnNpdmVMb2NrQWRhcHRlciBtYXkgd3JhcCBvdGhlciB0 eXBlcyBvZiBMb2NrIHdoaWNoIGRvIG5vdCBzdXBwb3J0IGFuYWx5c2lzLgorCisgICAgICAgICog d3RmL1JlY3Vyc2l2ZUxvY2tBZGFwdGVyLmg6CisKIDIwMjEtMDUtMjQgIERhcmluIEFkbGVyICA8 ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBTdHJpbmdCdWlsZGVyOjphcHBlbmRM aXRlcmFsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9SZWN1cnNpdmVMb2NrQWRhcHRlci5o IGIvU291cmNlL1dURi93dGYvUmVjdXJzaXZlTG9ja0FkYXB0ZXIuaAppbmRleCBjYTdiYzQ1NTQ0 N2IxNTIyMDdjZTFhYjdmMGNiNDRkNGVkMThlOGRlLi42Yzg3ZDdkN2M2N2FiZDc0YjJkZDFjZTY0 NDJjMDdlYTAyMjJkNjA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9SZWN1cnNpdmVMb2Nr QWRhcHRlci5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1JlY3Vyc2l2ZUxvY2tBZGFwdGVyLmgKQEAg LTM1LDcgKzM1LDEwIEBAIGNsYXNzIFJlY3Vyc2l2ZUxvY2tBZGFwdGVyIHsKIHB1YmxpYzoKICAg ICBSZWN1cnNpdmVMb2NrQWRhcHRlcigpID0gZGVmYXVsdDsKIAotICAgIHZvaWQgbG9jaygpCisg ICAgLy8gVXNlIFdURl9JR05PUkVTX1RIUkVBRF9TQUZFVFlfQU5BTFlTSVMgYmVjYXVzZSB0aGUg ZnVuY3Rpb24gZG9lcyBjb25kaXRpb25hbCBsb2NraW5nLCB3aGljaCBpcworICAgIC8vIG5vdCBz dXBwb3J0ZWQgYnkgYW5hbHlzaXMuIEFsc28gUmVjdXJzaXZlTG9ja0FkYXB0ZXIgbWF5IHdyYXAg YSBsb2NrIHR5cGUgYmVzaWRlcyBXVEY6OkxvY2sKKyAgICAvLyB3aGljaCBkb2Vzbid0IHN1cHBv cnQgYW5hbHlzaXMuCisgICAgdm9pZCBsb2NrKCkgV1RGX0lHTk9SRVNfVEhSRUFEX1NBRkVUWV9B TkFMWVNJUwogICAgIHsKICAgICAgICAgVGhyZWFkJiBtZSA9IFRocmVhZDo6Y3VycmVudCgpOwog ICAgICAgICBpZiAoJm1lID09IG1fb3duZXIpIHsKQEAgLTUwLDcgKzUzLDEwIEBAIHB1YmxpYzoK ICAgICAgICAgbV9yZWN1cnNpb25Db3VudCA9IDE7CiAgICAgfQogICAgIAotICAgIHZvaWQgdW5s b2NrKCkKKyAgICAvLyBVc2UgV1RGX0lHTk9SRVNfVEhSRUFEX1NBRkVUWV9BTkFMWVNJUyBiZWNh dXNlIHRoZSBmdW5jdGlvbiBkb2VzIGNvbmRpdGlvbmFsIHVubG9ja2luZywgd2hpY2ggaXMKKyAg ICAvLyBub3Qgc3VwcG9ydGVkIGJ5IGFuYWx5c2lzLiBBbHNvIFJlY3Vyc2l2ZUxvY2tBZGFwdGVy IG1heSB3cmFwIGEgbG9jayB0eXBlIGJlc2lkZXMgV1RGOjpMb2NrCisgICAgLy8gd2hpY2ggZG9l c24ndCBzdXBwb3J0IGFuYWx5c2lzLgorICAgIHZvaWQgdW5sb2NrKCkgV1RGX0lHTk9SRVNfVEhS RUFEX1NBRkVUWV9BTkFMWVNJUwogICAgIHsKICAgICAgICAgaWYgKC0tbV9yZWN1cnNpb25Db3Vu dCkKICAgICAgICAgICAgIHJldHVybjsKQEAgLTU4LDcgKzY0LDEwIEBAIHB1YmxpYzoKICAgICAg ICAgbV9sb2NrLnVubG9jaygpOwogICAgIH0KICAgICAKLSAgICBib29sIHRyeUxvY2soKQorICAg IC8vIFVzZSBXVEZfSUdOT1JFU19USFJFQURfU0FGRVRZX0FOQUxZU0lTIGJlY2F1c2UgdGhlIGZ1 bmN0aW9uIGRvZXMgY29uZGl0aW9uYWwgbG9ja2luZywgd2hpY2ggaXMKKyAgICAvLyBub3Qgc3Vw cG9ydGVkIGJ5IGFuYWx5c2lzLiBBbHNvIFJlY3Vyc2l2ZUxvY2tBZGFwdGVyIG1heSB3cmFwIGEg bG9jayB0eXBlIGJlc2lkZXMgV1RGOjpMb2NrCisgICAgLy8gd2hpY2ggZG9lc24ndCBzdXBwb3J0 IGFuYWx5c2lzLgorICAgIGJvb2wgdHJ5TG9jaygpIFdURl9JR05PUkVTX1RIUkVBRF9TQUZFVFlf QU5BTFlTSVMKICAgICB7CiAgICAgICAgIFRocmVhZCYgbWUgPSBUaHJlYWQ6OmN1cnJlbnQoKTsK ICAgICAgICAgaWYgKCZtZSA9PSBtX293bmVyKSB7CkBAIC04OSw3ICs5OCw3IEBAIHByaXZhdGU6 CiAgICAgTG9ja1R5cGUgbV9sb2NrOwogfTsKIAotdXNpbmcgUmVjdXJzaXZlTG9jayA9IFJlY3Vy c2l2ZUxvY2tBZGFwdGVyPFVuY2hlY2tlZExvY2s+OwordXNpbmcgUmVjdXJzaXZlTG9jayA9IFJl Y3Vyc2l2ZUxvY2tBZGFwdGVyPExvY2s+OwogCiB9IC8vIG5hbWVzcGFjZSBXVEYKIAo=