226198 2021-05-24 16:26:28 -0700 Stop using UncheckedLock in Condition API tests 2021-05-24 20:17:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen darin ggaren kkinnunen sam webkit-bug-importer oldest_to_newest 1763313 0 cdumez 2021-05-24 16:26:28 -0700 Stop using UncheckedLock in Condition API tests. This is a step towards phasing out UncheckedLock in favor the Lock so that we can benefit from Clang Thread Safety Analysis. 1763314 1 429585 cdumez 2021-05-24 16:27:36 -0700 Created attachment 429585 Patch 1763408 2 ews-feeder 2021-05-24 20:16:59 -0700 Committed r277992 (238105@main): <https://commits.webkit.org/238105@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429585. 1763409 3 webkit-bug-importer 2021-05-24 20:17:18 -0700 <rdar://problem/78432963> 429585 2021-05-24 16:27:36 -0700 2021-05-24 20:17:00 -0700 Patch bug-226198-20210524162736.patch text/plain 4014 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3OTY0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2M0MzYxYTNhY2FkMTMzNDAxODI3ODgxM2ZiM2I2MDVj ZDZmNmVmMC4uZWMzZWRlYzg1Yjc2MGE1YzBmMDMyZjc1YjEwZWI5ODRlMjJiZWQzNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIxLTA1LTI0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgU3RvcCB1c2luZyBVbmNoZWNrZWRMb2NrIGluIENvbmRpdGlvbiBBUEkgdGVzdHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjE5OAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0b3AgdXNpbmcgVW5j aGVja2VkTG9jayBpbiBDb25kaXRpb24gQVBJIHRlc3RzLiBUaGlzIGlzIGEgc3RlcCB0b3dhcmRz IHBoYXNpbmcgb3V0IFVuY2hlY2tlZExvY2sKKyAgICAgICAgaW4gZmF2b3IgdGhlIExvY2sgc28g dGhhdCB3ZSBjYW4gYmVuZWZpdCBmcm9tIENsYW5nIFRocmVhZCBTYWZldHkgQW5hbHlzaXMuCisK KyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9Db25kaXRpb24uY3BwOgorCiAyMDIx LTA1LTI0ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAg ICBVbnJldmlld2VkLCByZXZlcnRpbmcgcjI3Nzk0MC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvV1RGL0NvbmRpdGlvbi5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dURi9Db25kaXRpb24uY3BwCmluZGV4IGZiOTljMjRiNzkyYTVjYWU2MzE3ZTcwZGQyYjI0 NjcxZGMzZmIwNDQuLmFjNDczYTRhNDFmYzEzNDQxNjFhYTExY2ExNTNkZDljZTA4YTA0YzYgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0NvbmRpdGlvbi5jcHAKKysr IGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvQ29uZGl0aW9uLmNwcApAQCAtMzgsNiAr MzgsNyBAQCBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSSB7CiAKIG5hbWVzcGFjZSB7CiAKK3N0YXRp YyBMb2NrIGxvY2s7CiBzdGF0aWMgY29uc3RleHByIGJvb2wgdmVyYm9zZSA9IGZhbHNlOwogCiBl bnVtIE5vdGlmeVN0eWxlIHsKQEAgLTQ2LDIwICs0NywyMCBAQCBlbnVtIE5vdGlmeVN0eWxlIHsK IH07CiAKIHRlbXBsYXRlPHR5cGVuYW1lIEZ1bmN0b3I+Ci12b2lkIHdhaXQoVW5jaGVja2VkQ29u ZGl0aW9uJiBjb25kaXRpb24sIHN0ZDo6dW5pcXVlX2xvY2s8VW5jaGVja2VkTG9jaz4mIGxvY2tl ciwgY29uc3QgRnVuY3RvciYgcHJlZGljYXRlLCBTZWNvbmRzIHRpbWVvdXQpCit2b2lkIHdhaXQo Q29uZGl0aW9uJiBjb25kaXRpb24sIGNvbnN0IEZ1bmN0b3ImIHByZWRpY2F0ZSwgU2Vjb25kcyB0 aW1lb3V0KSBXVEZfUkVRVUlSRVNfTE9DSyhsb2NrKQogewogICAgIGlmICh0aW1lb3V0ID09IFNl Y29uZHM6OmluZmluaXR5KCkpCi0gICAgICAgIGNvbmRpdGlvbi53YWl0KGxvY2tlciwgcHJlZGlj YXRlKTsKKyAgICAgICAgY29uZGl0aW9uLndhaXQobG9jaywgcHJlZGljYXRlKTsKICAgICBlbHNl IHsKICAgICAgICAgLy8gVGhpcyB0ZXN0cyB0aW1lb3V0cyBpbiB0aGUgc2Vuc2UgdGhhdCBpdCB2 ZXJpZmllcyB0aGF0IHdlIGNhbiBjYWxsIHdhaXQoKSBhZ2FpbiBhZnRlciBhCiAgICAgICAgIC8v IHRpbWVvdXQgaGFwcGVuZWQuIFRoYXQncyBhIG5vbi10cml2aWFsIHBpZWNlIG9mIGZ1bmN0aW9u YWxpdHkgc2luY2UgdXBvbiB0aW1lb3V0IHRoZQogICAgICAgICAvLyBQYXJraW5nTG90IGhhcyB0 byByZW1vdmUgdXMgZnJvbSB0aGUgcXVldWUuCiAgICAgICAgIHdoaWxlICghcHJlZGljYXRlKCkp Ci0gICAgICAgICAgICBjb25kaXRpb24ud2FpdEZvcihsb2NrZXIsIHRpbWVvdXQsIHByZWRpY2F0 ZSk7CisgICAgICAgICAgICBjb25kaXRpb24ud2FpdEZvcihsb2NrLCB0aW1lb3V0LCBwcmVkaWNh dGUpOwogICAgIH0KIH0KIAotdm9pZCBub3RpZnkoTm90aWZ5U3R5bGUgbm90aWZ5U3R5bGUsIFVu Y2hlY2tlZENvbmRpdGlvbiYgY29uZGl0aW9uLCBib29sIHNob3VsZE5vdGlmeSkKK3ZvaWQgbm90 aWZ5KE5vdGlmeVN0eWxlIG5vdGlmeVN0eWxlLCBDb25kaXRpb24mIGNvbmRpdGlvbiwgYm9vbCBz aG91bGROb3RpZnkpCiB7CiAgICAgc3dpdGNoIChub3RpZnlTdHlsZSkgewogICAgIGNhc2UgQWx3 YXlzTm90aWZ5T25lOgpAQCAtODMsOSArODQsOCBAQCB2b2lkIHJ1blRlc3QoCiB7CiAgICAgRGVx dWU8dW5zaWduZWQ+IHF1ZXVlOwogICAgIGJvb2wgc2hvdWxkQ29udGludWUgPSB0cnVlOwotICAg IFVuY2hlY2tlZExvY2sgbG9jazsKLSAgICBVbmNoZWNrZWRDb25kaXRpb24gZW1wdHlDb25kaXRp b247Ci0gICAgVW5jaGVja2VkQ29uZGl0aW9uIGZ1bGxDb25kaXRpb247CisgICAgQ29uZGl0aW9u IGVtcHR5Q29uZGl0aW9uOworICAgIENvbmRpdGlvbiBmdWxsQ29uZGl0aW9uOwogCiAgICAgVmVj dG9yPFJlZjxUaHJlYWQ+PiBjb25zdW1lclRocmVhZHM7CiAgICAgVmVjdG9yPFJlZjxUaHJlYWQ+ PiBwcm9kdWNlclRocmVhZHM7CkBAIC0xMDEsOSArMTAxLDkgQEAgdm9pZCBydW5UZXN0KAogICAg ICAgICAgICAgICAgICAgICB1bnNpZ25lZCByZXN1bHQ7CiAgICAgICAgICAgICAgICAgICAgIHVu c2lnbmVkIHNob3VsZE5vdGlmeSA9IGZhbHNlOwogICAgICAgICAgICAgICAgICAgICB7Ci0gICAg ICAgICAgICAgICAgICAgICAgICBzdGQ6OnVuaXF1ZV9sb2NrPFVuY2hlY2tlZExvY2s+IGxvY2tl cihsb2NrKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIExvY2tlciBsb2NrZXIgeyBsb2NrIH07 CiAgICAgICAgICAgICAgICAgICAgICAgICB3YWl0KAotICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGVtcHR5Q29uZGl0aW9uLCBsb2NrZXIsIAorICAgICAgICAgICAgICAgICAgICAgICAgICAg IGVtcHR5Q29uZGl0aW9uLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgIFsmXSAoKSB7CiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmICh2ZXJib3NlKQogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgZGF0YUxvZyh0b1N0cmluZyhUaHJlYWQ6OmN1cnJlbnQo KSwgIjogQ2hlY2tpbmcgY29uc3VtcHRpb24gcHJlZGljYXRlIHdpdGggc2hvdWxkQ29udGludWUg PSAiLCBzaG91bGRDb250aW51ZSwgIiwgcXVldWUuc2l6ZSgpID09ICIsIHF1ZXVlLnNpemUoKSwg IlxuIikpOwpAQCAtMTM0LDkgKzEzNCw5IEBAIHZvaWQgcnVuVGVzdCgKICAgICAgICAgICAgICAg ICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbnVtTWVzc2FnZXNQZXJQcm9kdWNlcjsgKytpKSB7 CiAgICAgICAgICAgICAgICAgICAgIGJvb2wgc2hvdWxkTm90aWZ5ID0gZmFsc2U7CiAgICAgICAg ICAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICAgICAgICAgIHN0ZDo6dW5pcXVlX2xvY2s8 VW5jaGVja2VkTG9jaz4gbG9ja2VyKGxvY2spOworICAgICAgICAgICAgICAgICAgICAgICAgTG9j a2VyIGxvY2tlciB7IGxvY2sgfTsKICAgICAgICAgICAgICAgICAgICAgICAgIHdhaXQoCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgZnVsbENvbmRpdGlvbiwgbG9ja2VyLAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGZ1bGxDb25kaXRpb24sCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgWyZdICgpIHsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgKHZlcmJv c2UpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkYXRhTG9nKHRvU3RyaW5n KFRocmVhZDo6Y3VycmVudCgpLCAiOiBDaGVja2luZyBwcm9kdWN0aW9uIHByZWRpY2F0ZSB3aXRo IHNob3VsZENvbnRpbnVlID0gIiwgc2hvdWxkQ29udGludWUsICIsIHF1ZXVlLnNpemUoKSA9PSAi LCBxdWV1ZS5zaXplKCksICJcbiIpKTsK