226196 2021-05-24 16:11:04 -0700 When running with --reportTotalPhaseTimes=1, we should also log the max time in a phase 2021-05-24 17:04:34 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rmorisset rmorisset ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1763303 0 rmorisset 2021-05-24 16:11:04 -0700 When seeing that we spend a lot of time in a given phase, it can be helpful to know whether it is because of an outlier or not. It matters especially for the DFG, as the GC is stopped whenever a DFG phase is running. 1763306 1 429584 rmorisset 2021-05-24 16:13:28 -0700 Created attachment 429584 Patch 1763340 2 ews-feeder 2021-05-24 17:03:54 -0700 Committed r277984 (238097@main): <https://commits.webkit.org/238097@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429584. 1763342 3 webkit-bug-importer 2021-05-24 17:04:34 -0700 <rdar://problem/78426364> 429584 2021-05-24 16:13:28 -0700 2021-05-24 17:03:55 -0700 Patch patch226196 text/plain 2173 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDUwMDY0YmE1ZTZkZC4uNmRmZDMzNWM3OTRhIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMS0wNS0yNCAgUm9i aW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUuY29tPgorCisgICAgICAgIFdoZW4gcnVubmlu ZyB3aXRoIC0tcmVwb3J0VG90YWxQaGFzZVRpbWVzPTEsIHdlIHNob3VsZCBhbHNvIGxvZyB0aGUg bWF4IHRpbWUgaW4gYSBwaGFzZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjI2MTk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSXQgaXMgZXNwZWNpYWxseSB1c2VmdWwgd2hlbiBsb29raW5nIGF0IERGRyBw aGFzZXMsIHNpbmNlIHRoZSBHQyBtYXkgaGF2ZSB0byB3YWl0IGZvciB0aGVtIHRvIGZpbmlzaC4K KworICAgICAgICAqIHRvb2xzL0NvbXBpbGVyVGltaW5nU2NvcGUuY3BwOgorCiAyMDIxLTA1LTIw ICBUdW9tYXMgS2Fya2thaW5lbiAgPHR1b21hcy53ZWJraXRAYXBwbGUuY29tPgogCiAgICAgICAg ICR2bSBzaG91bGQgaGF2ZSBhIGZ1bmN0aW9uIGZvciBjaGVja2luZyBpZiBBU2FuIGlzIGVuYWJs ZWQgc2ltaWxhciB0byAkdm0uYXNzZXJ0RW5hYmxlZApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3Rvb2xzL0NvbXBpbGVyVGltaW5nU2NvcGUuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL3Rvb2xzL0NvbXBpbGVyVGltaW5nU2NvcGUuY3BwCmluZGV4IGIwZDhhYTJjN2M1NC4u ZTAzMjhiNjZkZWM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdG9vbHMvQ29t cGlsZXJUaW1pbmdTY29wZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0Nv bXBpbGVyVGltaW5nU2NvcGUuY3BwCkBAIC00OSwxMSArNDksMTIgQEAgcHVibGljOgogICAgICAg ICBmb3IgKGF1dG8mIHR1cGxlIDogdG90YWxzKSB7CiAgICAgICAgICAgICBpZiAoU3RyaW5nKHN0 ZDo6Z2V0PDA+KHR1cGxlKSkgPT0gU3RyaW5nKGNvbXBpbGVyTmFtZSkgJiYgU3RyaW5nKHN0ZDo6 Z2V0PDE+KHR1cGxlKSkgPT0gU3RyaW5nKG5hbWUpKSB7CiAgICAgICAgICAgICAgICAgc3RkOjpn ZXQ8Mj4odHVwbGUpICs9IGR1cmF0aW9uOworICAgICAgICAgICAgICAgIHN0ZDo6Z2V0PDM+KHR1 cGxlKSA9IHN0ZDo6bWF4KHN0ZDo6Z2V0PDM+KHR1cGxlKSwgZHVyYXRpb24pOwogICAgICAgICAg ICAgICAgIHJldHVybiBzdGQ6OmdldDwyPih0dXBsZSk7CiAgICAgICAgICAgICB9CiAgICAgICAg IH0KIAotICAgICAgICB0b3RhbHMuYXBwZW5kKHsgY29tcGlsZXJOYW1lLCBuYW1lLCBkdXJhdGlv biB9KTsKKyAgICAgICAgdG90YWxzLmFwcGVuZCh7IGNvbXBpbGVyTmFtZSwgbmFtZSwgZHVyYXRp b24sIGR1cmF0aW9uIH0pOwogICAgICAgICByZXR1cm4gZHVyYXRpb247CiAgICAgfQogCkBAIC02 MSwxMiArNjIsMTIgQEAgcHVibGljOgogICAgIHsKICAgICAgICAgZm9yIChhdXRvJiB0dXBsZSA6 IHRvdGFscykgewogICAgICAgICAgICAgZGF0YUxvZ0xuKAotICAgICAgICAgICAgICAgICJbIiwg c3RkOjpnZXQ8MD4odHVwbGUpLCAiXSAiLCBzdGQ6OmdldDwxPih0dXBsZSksICIgdG90YWwgbXM6 ICIsIHN0ZDo6Z2V0PDI+KHR1cGxlKS5taWxsaXNlY29uZHMoKSk7CisgICAgICAgICAgICAgICAg IlsiLCBzdGQ6OmdldDwwPih0dXBsZSksICJdICIsIHN0ZDo6Z2V0PDE+KHR1cGxlKSwgIiB0b3Rh bCBtczogIiwgc3RkOjpnZXQ8Mj4odHVwbGUpLm1pbGxpc2Vjb25kcygpLCAiIG1heCBtczogIiwg c3RkOjpnZXQ8Mz4odHVwbGUpLm1pbGxpc2Vjb25kcygpKTsKICAgICAgICAgfQogICAgIH0KICAg ICAKIHByaXZhdGU6Ci0gICAgVmVjdG9yPHN0ZDo6dHVwbGU8Y29uc3QgY2hhciosIGNvbnN0IGNo YXIqLCBTZWNvbmRzPj4gdG90YWxzOworICAgIFZlY3RvcjxzdGQ6OnR1cGxlPGNvbnN0IGNoYXIq LCBjb25zdCBjaGFyKiwgU2Vjb25kcywgU2Vjb25kcz4+IHRvdGFsczsKICAgICBMb2NrIGxvY2s7 CiB9OwogCg==