226192 2021-05-24 15:36:48 -0700 [GStreamer] Stop using UncheckedLock in VideoRenderRequestScheduler 2021-05-24 20:24:03 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez achristensen bugs-noreply calvaris cgarcia darin eric.carlson ews-watchlist ggaren glenn gustavo jer.noble mcatanzaro menard philipj pnormand sam sergio vjaquez oldest_to_newest 1763286 0 cdumez 2021-05-24 15:36:48 -0700 Stop using UncheckedLock in VideoRenderRequestScheduler to benefit from Clang thread safety analysis. 1763287 1 429576 cdumez 2021-05-24 15:37:51 -0700 Created attachment 429576 Patch 1763315 2 429586 cdumez 2021-05-24 16:30:29 -0700 Created attachment 429586 Patch 1763411 3 ews-feeder 2021-05-24 20:23:59 -0700 Committed r277993 (238106@main): <https://commits.webkit.org/238106@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429586. 429576 2021-05-24 15:37:51 -0700 2021-05-24 16:30:26 -0700 Patch bug-226192-20210524153751.patch text/plain 2444 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3OTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzhjMGUwNjEzZjZiZjIx OWRmZjhkNWE4ZDkyYzJmYWNlYzhlZDdiMi4uNzcwYWIyMjhlMWE0OTczMDE2OWE2OTk0YWMwNDg1 OTBhNWM3N2IzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA1LTI0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW0dTdHJlYW1lcl0gU3RvcCB1 c2luZyBVbmNoZWNrZWRMb2NrIGluIFZpZGVvUmVuZGVyUmVxdWVzdFNjaGVkdWxlcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2MTkyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3RvcCB1c2luZyBVbmNo ZWNrZWRMb2NrIGluIFZpZGVvUmVuZGVyUmVxdWVzdFNjaGVkdWxlciB0byBiZW5lZml0IGZyb20g Q2xhbmcgdGhyZWFkIHNhZmV0eQorICAgICAgICBhbmFseXNpcy4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9WaWRlb1NpbmtHU3RyZWFtZXIuY3BwOgorICAgICAgICAo VmlkZW9SZW5kZXJSZXF1ZXN0U2NoZWR1bGVyOjpzdGFydCk6CisgICAgICAgIChWaWRlb1JlbmRl clJlcXVlc3RTY2hlZHVsZXI6OnN0b3ApOgorICAgICAgICAoVmlkZW9SZW5kZXJSZXF1ZXN0U2No ZWR1bGVyOjpkcmFpbik6CisgICAgICAgIChWaWRlb1JlbmRlclJlcXVlc3RTY2hlZHVsZXI6OnJl cXVlc3RSZW5kZXIpOgorCiAyMDIxLTA1LTI0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5j b20+CiAKICAgICAgICAgU3RvcCB1c2luZyBVbmNoZWNrZWRMb2NrIGluIE5vZGUncyBzX2V2ZW50 VGFyZ2V0RGF0YU1hcExvY2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9WaWRlb1NpbmtHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1ZpZGVvU2lua0dTdHJlYW1lci5jcHAKaW5kZXgg NTdhNzJhYzU4MGNlY2YxNmEwZTNhYjgwZmNmMzllMzk1ZmQwODhhYy4uYjMxYjhiOGMwNGRjYTc3 ZmM0NTU1MDgxZjhmZThkZGZkYWIxNzMwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1ZpZGVvU2lua0dTdHJlYW1lci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1ZpZGVvU2lua0dTdHJlYW1l ci5jcHAKQEAgLTcxLDI2ICs3MSwyNiBAQCBjbGFzcyBWaWRlb1JlbmRlclJlcXVlc3RTY2hlZHVs ZXIgewogcHVibGljOgogICAgIHZvaWQgc3RhcnQoKQogICAgIHsKLSAgICAgICAgTG9ja2VyIGxv Y2tlciB7IG1fc2FtcGxlTXV0ZXggfTsKKyAgICAgICAgTG9ja2VyIGxvY2tlciB7IG1fc2FtcGxl TG9jayB9OwogICAgICAgICBtX3VubG9ja2VkID0gZmFsc2U7CiAgICAgfQogCiAgICAgdm9pZCBz dG9wKCkKICAgICB7Ci0gICAgICAgIExvY2tlciBsb2NrZXIgeyBtX3NhbXBsZU11dGV4IH07Cisg ICAgICAgIExvY2tlciBsb2NrZXIgeyBtX3NhbXBsZUxvY2sgfTsKICAgICAgICAgbV9zYW1wbGUg PSBudWxscHRyOwogICAgICAgICBtX3VubG9ja2VkID0gdHJ1ZTsKICAgICB9CiAKICAgICB2b2lk IGRyYWluKCkKICAgICB7Ci0gICAgICAgIExvY2tlciBsb2NrZXIgeyBtX3NhbXBsZU11dGV4IH07 CisgICAgICAgIExvY2tlciBsb2NrZXIgeyBtX3NhbXBsZUxvY2sgfTsKICAgICAgICAgbV9zYW1w bGUgPSBudWxscHRyOwogICAgIH0KIAogICAgIGJvb2wgcmVxdWVzdFJlbmRlcihXZWJLaXRWaWRl b1NpbmsqIHNpbmssIEdzdEJ1ZmZlciogYnVmZmVyKQogICAgIHsKLSAgICAgICAgTG9ja2VyIGxv Y2tlciB7IG1fc2FtcGxlTXV0ZXggfTsKKyAgICAgICAgTG9ja2VyIGxvY2tlciB7IG1fc2FtcGxl TG9jayB9OwogICAgICAgICBpZiAobV91bmxvY2tlZCkKICAgICAgICAgICAgIHJldHVybiB0cnVl OwogCkBAIC0xMDcsOCArMTA3LDggQEAgcHVibGljOgogICAgIH0KIAogcHJpdmF0ZToKLSAgICBV bmNoZWNrZWRMb2NrIG1fc2FtcGxlTXV0ZXg7Ci0gICAgR1JlZlB0cjxHc3RTYW1wbGU+IG1fc2Ft cGxlOworICAgIExvY2sgbV9zYW1wbGVMb2NrOworICAgIEdSZWZQdHI8R3N0U2FtcGxlPiBtX3Nh bXBsZSBXVEZfR1VBUkRFRF9CWV9MT0NLKG1fc2FtcGxlTG9jayk7CiAKICAgICAvLyBJZiB0aGlz IGlzIHRydWUgYWxsIHByb2Nlc3Npbmcgc2hvdWxkIGZpbmlzaCBBU0FQCiAgICAgLy8gVGhpcyBp cyBuZWNlc3NhcnkgYmVjYXVzZSB0aGVyZSBjb3VsZCBiZSBhIHJhY2UgYmV0d2Vlbgo= 429586 2021-05-24 16:30:29 -0700 2021-05-24 20:24:01 -0700 Patch bug-226192-20210524163028.patch text/plain 3038 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3OTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2U4ZDlkMmI4ZjhiNjY5 OTRiN2U1MjczZDdmMWI2YTcxM2ZmZjUzZC4uYTkwN2M4ZWMwZDdhOTNmZmZkMmZiMTc1YzAwMTJi ODc4OTBjOWU5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA1LTI0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW0dTdHJlYW1lcl0gU3RvcCB1 c2luZyBVbmNoZWNrZWRMb2NrIGluIFZpZGVvUmVuZGVyUmVxdWVzdFNjaGVkdWxlcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2MTkyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3RvcCB1c2luZyBVbmNo ZWNrZWRMb2NrIGluIFZpZGVvUmVuZGVyUmVxdWVzdFNjaGVkdWxlciB0byBiZW5lZml0IGZyb20g Q2xhbmcgdGhyZWFkIHNhZmV0eQorICAgICAgICBhbmFseXNpcy4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9WaWRlb1NpbmtHU3RyZWFtZXIuY3BwOgorICAgICAgICAo VmlkZW9SZW5kZXJSZXF1ZXN0U2NoZWR1bGVyOjpzdGFydCk6CisgICAgICAgIChWaWRlb1JlbmRl clJlcXVlc3RTY2hlZHVsZXI6OnN0b3ApOgorICAgICAgICAoVmlkZW9SZW5kZXJSZXF1ZXN0U2No ZWR1bGVyOjpkcmFpbik6CisgICAgICAgIChWaWRlb1JlbmRlclJlcXVlc3RTY2hlZHVsZXI6OnJl cXVlc3RSZW5kZXIpOgorCiAyMDIxLTA1LTI0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5j b20+CiAKICAgICAgICAgU3RvcCB1c2luZyBVbmNoZWNrZWRMb2NrIGluIGh0bWwvY2FudmFzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvVmlk ZW9TaW5rR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9WaWRlb1NpbmtHU3RyZWFtZXIuY3BwCmluZGV4IDU3YTcyYWM1ODBjZWNmMTZhMGUz YWI4MGZjZjM5ZTM5NWZkMDg4YWMuLmQwMTQ3M2Q3OGMzMzU5NmU4NWY2YWVmZTU4NWZmZTYzOGM5 MzVkN2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9WaWRlb1NpbmtHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9WaWRlb1NpbmtHU3RyZWFtZXIuY3BwCkBAIC03MSwzNSArNzEs MzggQEAgY2xhc3MgVmlkZW9SZW5kZXJSZXF1ZXN0U2NoZWR1bGVyIHsKIHB1YmxpYzoKICAgICB2 b2lkIHN0YXJ0KCkKICAgICB7Ci0gICAgICAgIExvY2tlciBsb2NrZXIgeyBtX3NhbXBsZU11dGV4 IH07CisgICAgICAgIExvY2tlciBsb2NrZXIgeyBtX3NhbXBsZUxvY2sgfTsKICAgICAgICAgbV91 bmxvY2tlZCA9IGZhbHNlOwogICAgIH0KIAogICAgIHZvaWQgc3RvcCgpCiAgICAgewotICAgICAg ICBMb2NrZXIgbG9ja2VyIHsgbV9zYW1wbGVNdXRleCB9OworICAgICAgICBMb2NrZXIgbG9ja2Vy IHsgbV9zYW1wbGVMb2NrIH07CiAgICAgICAgIG1fc2FtcGxlID0gbnVsbHB0cjsKICAgICAgICAg bV91bmxvY2tlZCA9IHRydWU7CiAgICAgfQogCiAgICAgdm9pZCBkcmFpbigpCiAgICAgewotICAg ICAgICBMb2NrZXIgbG9ja2VyIHsgbV9zYW1wbGVNdXRleCB9OworICAgICAgICBMb2NrZXIgbG9j a2VyIHsgbV9zYW1wbGVMb2NrIH07CiAgICAgICAgIG1fc2FtcGxlID0gbnVsbHB0cjsKICAgICB9 CiAKICAgICBib29sIHJlcXVlc3RSZW5kZXIoV2ViS2l0VmlkZW9TaW5rKiBzaW5rLCBHc3RCdWZm ZXIqIGJ1ZmZlcikKICAgICB7Ci0gICAgICAgIExvY2tlciBsb2NrZXIgeyBtX3NhbXBsZU11dGV4 IH07Ci0gICAgICAgIGlmIChtX3VubG9ja2VkKQotICAgICAgICAgICAgcmV0dXJuIHRydWU7Cisg ICAgICAgIEdSZWZQdHI8R3N0U2FtcGxlPiBzYW1wbGU7CisgICAgICAgIHsKKyAgICAgICAgICAg IExvY2tlciBsb2NrZXIgeyBtX3NhbXBsZUxvY2sgfTsKKyAgICAgICAgICAgIGlmIChtX3VubG9j a2VkKQorICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwogCi0gICAgICAgIG1fc2FtcGxlID0g d2Via2l0VmlkZW9TaW5rUmVxdWVzdFJlbmRlcihzaW5rLCBidWZmZXIpOwotICAgICAgICBpZiAo IW1fc2FtcGxlKQotICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICAgICAgbV9zYW1w bGUgPSB3ZWJraXRWaWRlb1NpbmtSZXF1ZXN0UmVuZGVyKHNpbmssIGJ1ZmZlcik7CisgICAgICAg ICAgICBpZiAoIW1fc2FtcGxlKQorICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKworICAg ICAgICAgICAgc2FtcGxlID0gc3RkOjpleGNoYW5nZShtX3NhbXBsZSwgbnVsbHB0cik7CisgICAg ICAgIH0KIAotICAgICAgICBhdXRvIHNhbXBsZSA9IFdURk1vdmUobV9zYW1wbGUpOwotICAgICAg ICBsb2NrZXIudW5sb2NrRWFybHkoKTsKICAgICAgICAgaWYgKExJS0VMWShHU1RfSVNfU0FNUExF KHNhbXBsZS5nZXQoKSkpKQogICAgICAgICAgICAgd2Via2l0VmlkZW9TaW5rUmVwYWludFJlcXVl c3RlZChzaW5rLCBzYW1wbGUuZ2V0KCkpOwogCkBAIC0xMDcsOCArMTEwLDggQEAgcHVibGljOgog ICAgIH0KIAogcHJpdmF0ZToKLSAgICBVbmNoZWNrZWRMb2NrIG1fc2FtcGxlTXV0ZXg7Ci0gICAg R1JlZlB0cjxHc3RTYW1wbGU+IG1fc2FtcGxlOworICAgIExvY2sgbV9zYW1wbGVMb2NrOworICAg IEdSZWZQdHI8R3N0U2FtcGxlPiBtX3NhbXBsZSBXVEZfR1VBUkRFRF9CWV9MT0NLKG1fc2FtcGxl TG9jayk7CiAKICAgICAvLyBJZiB0aGlzIGlzIHRydWUgYWxsIHByb2Nlc3Npbmcgc2hvdWxkIGZp bmlzaCBBU0FQCiAgICAgLy8gVGhpcyBpcyBuZWNlc3NhcnkgYmVjYXVzZSB0aGVyZSBjb3VsZCBi ZSBhIHJhY2UgYmV0d2Vlbgo=