226191 2021-05-24 15:19:59 -0700 Stop using UncheckedLock in Node's s_eventTargetDataMapLock 2021-05-25 16:22:50 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen darin esprehn+autocc ews-watchlist ggaren kangil.han kkinnunen sam webkit-bug-importer oldest_to_newest 1763275 0 cdumez 2021-05-24 15:19:59 -0700 Stop using UncheckedLock in Node's s_eventTargetDataMapLock. This is a step towards phasing out UncheckedLock in favor of Lock which supports Clang Thread Safety Analysis. 1763278 1 429574 cdumez 2021-05-24 15:21:44 -0700 Created attachment 429574 Patch 1763717 2 cdumez 2021-05-25 15:59:21 -0700 ping review? I'd love to make some progress phasing out UncheckedLock. 1763720 3 429574 ggaren 2021-05-25 16:00:25 -0700 Comment on attachment 429574 Patch r=me 1763742 4 ews-feeder 2021-05-25 16:19:52 -0700 Committed r278058 (238142@main): <https://commits.webkit.org/238142@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429574. 1763743 5 webkit-bug-importer 2021-05-25 16:22:50 -0700 <rdar://problem/78482128> 429574 2021-05-24 15:21:44 -0700 2021-05-25 16:19:53 -0700 Patch bug-226191-20210524152144.patch text/plain 2111 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3OTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2U4ZDlkMmI4ZjhiNjY5 OTRiN2U1MjczZDdmMWI2YTcxM2ZmZjUzZC4uNzhjMGUwNjEzZjZiZjIxOWRmZjhkNWE4ZDkyYzJm YWNlYzhlZDdiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA1LTI0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU3RvcCB1c2luZyBVbmNoZWNr ZWRMb2NrIGluIE5vZGUncyBzX2V2ZW50VGFyZ2V0RGF0YU1hcExvY2sKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjE5MQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0b3AgdXNpbmcgVW5jaGVja2VkTG9j ayBpbiBOb2RlJ3Mgc19ldmVudFRhcmdldERhdGFNYXBMb2NrLiBUaGlzIGlzIGEgc3RlcCB0b3dh cmRzIHBoYXNpbmcKKyAgICAgICAgb3V0IFVuY2hlY2tlZExvY2sgaW4gZmF2b3Igb2YgTG9jayB3 aGljaCBzdXBwb3J0cyBDbGFuZyBUaHJlYWQgU2FmZXR5IEFuYWx5c2lzLgorCisgICAgICAgIE5v dGUgdGhhdCBJIGhhZCB0byBmYWN0b3IgdGhlIGNvZGUgYSBsaXR0bGUgZGlmZmVyZW50bHkgYmVj YXVzZSBDbGFuZyBUaHJlYWQgU2FmZXR5IEFuYWx5c2lzCisgICAgICAgIGRvZXNuJ3Qgc3VwcG9y dCBjb25kaXRpb25hbCBsb2NraW5nLgorCisgICAgICAgICogZG9tL05vZGUuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Tm9kZTo6ZXZlbnRUYXJnZXREYXRhQ29uY3VycmVudGx5KToKKwogMjAyMS0w NS0yNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFN0b3AgdXNp bmcgVW5jaGVja2VkTG9jayBpbiBodG1sL2NhbnZhcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZG9tL05vZGUuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCmluZGV4IGEyZTVj YTNmMTIxNjgzODA5ODMyNDBmZmJhMWU0ZmRhNzAzMjVmNGUuLmZkYWJjZDNlN2I4OTJlNTAxZDg3 OTQzMmFjNDZjM2Q3MTNmOGViMDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2Rl LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKQEAgLTIyMTEsNyArMjIxMSw3 IEBAIHN0YXRpYyBFdmVudFRhcmdldERhdGFNYXAmIGV2ZW50VGFyZ2V0RGF0YU1hcCgpCiAgICAg cmV0dXJuIG1hcDsKIH0KIAotc3RhdGljIFVuY2hlY2tlZExvY2sgc19ldmVudFRhcmdldERhdGFN YXBMb2NrOworc3RhdGljIExvY2sgc19ldmVudFRhcmdldERhdGFNYXBMb2NrOwogCiBFdmVudFRh cmdldERhdGEqIE5vZGU6OmV2ZW50VGFyZ2V0RGF0YSgpCiB7CkBAIC0yMjI3LDcgKzIyMjcsMTAg QEAgRXZlbnRUYXJnZXREYXRhKiBOb2RlOjpldmVudFRhcmdldERhdGFDb25jdXJyZW50bHkoKQog ICAgIC8vIHdvcmxkIGlzIHN0b3BwZWQuIFdlIGRvbid0IGhhdmUgdG8gaG9sZCB0aGUgbG9jayB3 aGVuIHRoZSB3b3JsZCBpcyBzdG9wcGVkLCBiZWNhdXNlIGEgc3RvcHBlZCB3b3JsZAogICAgIC8v IG1lYW5zIHRoYXQgd2Ugd2lsbCBuZXZlciBtdXRhdGUgdGhlIGV2ZW50IHRhcmdldCBkYXRhIG1h cC4KICAgICBKU0M6OlZNKiB2bSA9IGNvbW1vblZNT3JOdWxsKCk7Ci0gICAgTG9ja2VyIGxvY2tl ciB7IHZtICYmIHZtLT5oZWFwLndvcmxkSXNSdW5uaW5nKCkgPyAmc19ldmVudFRhcmdldERhdGFN YXBMb2NrIDogbnVsbHB0ciB9OworICAgIGlmICh2bSAmJiB2bS0+aGVhcC53b3JsZElzUnVubmlu ZygpKSB7CisgICAgICAgIExvY2tlciBsb2NrZXIgeyBzX2V2ZW50VGFyZ2V0RGF0YU1hcExvY2sg fTsKKyAgICAgICAgcmV0dXJuIGhhc0V2ZW50VGFyZ2V0RGF0YSgpID8gZXZlbnRUYXJnZXREYXRh TWFwKCkuZ2V0KHRoaXMpIDogbnVsbHB0cjsKKyAgICB9CiAgICAgcmV0dXJuIGhhc0V2ZW50VGFy Z2V0RGF0YSgpID8gZXZlbnRUYXJnZXREYXRhTWFwKCkuZ2V0KHRoaXMpIDogbnVsbHB0cjsKIH0K IAo=