226189 2021-05-24 15:11:53 -0700 _WKRemoteObjectRegistry should not call completion handlers if block signatures don't match or can't be found 2021-05-25 18:19:19 -0700 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified macOS 11 RESOLVED FIXED InRadar P2 Normal --- 1 julian_a_gonzalez webkit-unassigned achristensen beidson cdumez ggaren rniwa sam oldest_to_newest 1763270 0 julian_a_gonzalez 2021-05-24 15:11:53 -0700 There is code in _WKRemoteObjectRegistry's _invokeMethod() to check reply blocks that does not fire if block signatures are incompatible (or there is no expected block signature). In this case, we'll perform the invocation with a nil reply block (at least in Release builds), which can cause crashes. <rdar://problem/70004926> 1763274 1 429572 julian_a_gonzalez 2021-05-24 15:16:39 -0700 Created attachment 429572 Patch 1763277 2 julian_a_gonzalez 2021-05-24 15:21:07 -0700 Rebasing. 1763294 3 429580 julian_a_gonzalez 2021-05-24 15:51:16 -0700 Created attachment 429580 Patch 1763783 4 429580 cdumez 2021-05-25 17:39:54 -0700 Comment on attachment 429580 Patch r=me 1763797 5 ews-feeder 2021-05-25 18:19:17 -0700 Committed r278071 (238150@main): <https://commits.webkit.org/238150@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429580. 429572 2021-05-24 15:16:39 -0700 2021-05-24 15:51:15 -0700 Patch bug-226189-20210524151638.patch text/plain 2223 julian_a_gonzalez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3NjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDNiZWNlZmZlNzU2NTQxYzhh YjMyNmRlYmQzYjBkNDlhNGFjMmRmMzMuLmUyY2E2MGI1ODg5OTk4YjY3NWYzZWVjNTU0MmI1Nzdj Mzg0MTI2MTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDUtMjQgIEp1bGlhbiBH b256YWxleiAgPGp1bGlhbl9hX2dvbnphbGV6QGFwcGxlLmNvbT4KKworICAgICAgICBfV0tSZW1v dGVPYmplY3RSZWdpc3RyeSBzaG91bGQgbm90IGNhbGwgY29tcGxldGlvbiBoYW5kbGVycyBpZiBi bG9jayBzaWduYXR1cmVzIGRvbid0IG1hdGNoIG9yIGNhbid0IGJlIGZvdW5kCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjYxODkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBfV0tSZW1vdGVPYmplY3RSZWdp c3RyeSBhbHJlYWR5IGVuZm9yY2VzIGNvbXBsZXRpb24gaGFuZGxlcnMgdG8gbm90IGJlIG5pbCwK KyAgICAgICAgc28gY29tcGxldGUgdGhhdCBlbmZvcmNlbWVudCBieSBkcm9wcGluZyBpbnZvY2F0 aW9ucyB3aGVyZSBibG9jayBzaWduYXR1cmVzIGFyZW4ndCBhdmFpbGFibGUKKyAgICAgICAgb3Ig ZG9uJ3QgbWF0Y2guIFRoaXMgaGFzIG5vdCByZXByb2R1Y2VkIGJ1dCBjb21wbGV0ZXMgb3VyIGhh cmRlbmluZyBlZmZvcnRzLgorCisgICAgICAgICogU2hhcmVkL0FQSS9Db2NvYS9fV0tSZW1vdGVP YmplY3RSZWdpc3RyeS5tbToKKyAgICAgICAgKC1bX1dLUmVtb3RlT2JqZWN0UmVnaXN0cnkgX2lu dm9rZU1ldGhvZDpdKToKKwogMjAyMS0wNS0xOCAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWlkQGFw cGxlLmNvbT4KIAogICAgICAgICBBbGxvdyBsb2dnaW5nIG1pbmltYWwgaW5mbyBhYm91dCB1cGxv YWRpbmcgbWVkaWEgZmlsZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0FQSS9D b2NvYS9fV0tSZW1vdGVPYmplY3RSZWdpc3RyeS5tbSBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0FQ SS9Db2NvYS9fV0tSZW1vdGVPYmplY3RSZWdpc3RyeS5tbQppbmRleCAwNWY0NDg3ZTgxYzVlMGRk MThlZmRkOGNmZGNlOWJkYzRkYWU2MThlLi4yZjllOTIzNTQ3NDU0N2IyNzI5MDU1ZDJlYzZkNmUz YmJlZGRjOTFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9BUEkvQ29jb2EvX1dL UmVtb3RlT2JqZWN0UmVnaXN0cnkubW0KKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvQVBJL0Nv Y29hL19XS1JlbW90ZU9iamVjdFJlZ2lzdHJ5Lm1tCkBAIC0yNzAsMTMgKzI3MCwxMyBAQCAtICh2 b2lkKV9pbnZva2VNZXRob2Q6KGNvbnN0IFdlYktpdDo6UmVtb3RlT2JqZWN0SW52b2NhdGlvbiYp cmVtb3RlT2JqZWN0SW52b2NhdAogICAgICAgICAgICAgaWYgKGV4cGVjdGVkQmxvY2tTaWduYXR1 cmUuaXNOdWxsKCkpIHsKICAgICAgICAgICAgICAgICBOU0xvZyhAIl9pbnZva2VNZXRob2Q6IEZh aWxlZCB0byB2YWxpZGF0ZSByZXBseSBibG9jayBzaWduYXR1cmU6IGNvdWxkIG5vdCBmaW5kIGxv Y2FsIHNpZ25hdHVyZSIpOwogICAgICAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwot ICAgICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAg ICAgICAgIH0KIAogICAgICAgICAgICAgaWYgKCFibG9ja1NpZ25hdHVyZXNBcmVDb21wYXRpYmxl KHdpcmVCbG9ja1NpZ25hdHVyZSwgZXhwZWN0ZWRCbG9ja1NpZ25hdHVyZSkpIHsKICAgICAgICAg ICAgICAgICBOU0xvZyhAIl9pbnZva2VNZXRob2Q6IEZhaWxlZCB0byB2YWxpZGF0ZSByZXBseSBi bG9jayBzaWduYXR1cmU6ICVzICE9ICVzIiwgd2lyZUJsb2NrU2lnbmF0dXJlLnV0ZjgoKS5kYXRh KCksIGV4cGVjdGVkQmxvY2tTaWduYXR1cmUudXRmOCgpLmRhdGEoKSk7CiAgICAgICAgICAgICAg ICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgICAgICAgICAgICAgY29udGludWU7CisgICAg ICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgfQogCiAgICAgICAgICAgICBSZXRhaW5Q dHI8X1dLUmVtb3RlT2JqZWN0UmVnaXN0cnk+IHJlbW90ZU9iamVjdFJlZ2lzdHJ5ID0gc2VsZjsK 429580 2021-05-24 15:51:16 -0700 2021-05-25 18:19:18 -0700 Patch bug-226189-20210524155116.patch text/plain 2147 julian_a_gonzalez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3OTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ1NmNhZGM2NDk4YjJkYWEy NjdhYmUzMDQzMGM2ZjQxYjEyMzY0N2EuLmE1YzljOWNhMzk1NDU4NmNkNmFjZDdmNDRkOTI3NGIx NDczNDY4MjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDUtMjQgIEp1bGlhbiBH b256YWxleiAgPGp1bGlhbl9hX2dvbnphbGV6QGFwcGxlLmNvbT4KKworICAgICAgICBfV0tSZW1v dGVPYmplY3RSZWdpc3RyeSBzaG91bGQgbm90IGNhbGwgY29tcGxldGlvbiBoYW5kbGVycyBpZiBi bG9jayBzaWduYXR1cmVzIGRvbid0IG1hdGNoIG9yIGNhbid0IGJlIGZvdW5kCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjYxODkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBfV0tSZW1vdGVPYmplY3RSZWdp c3RyeSBhbHJlYWR5IGVuZm9yY2VzIGNvbXBsZXRpb24gaGFuZGxlcnMgdG8gbm90IGJlIG5pbCwK KyAgICAgICAgc28gY29tcGxldGUgdGhhdCBlbmZvcmNlbWVudCBieSBkcm9wcGluZyBpbnZvY2F0 aW9ucyB3aGVyZSBibG9jayBzaWduYXR1cmVzIGFyZW4ndCBhdmFpbGFibGUKKyAgICAgICAgb3Ig ZG9uJ3QgbWF0Y2guIFRoaXMgaGFzIG5vdCByZXByb2R1Y2VkIGJ1dCBjb21wbGV0ZXMgb3VyIGhh cmRlbmluZyBlZmZvcnRzLgorCisgICAgICAgICogU2hhcmVkL0FQSS9Db2NvYS9fV0tSZW1vdGVP YmplY3RSZWdpc3RyeS5tbToKKyAgICAgICAgKC1bX1dLUmVtb3RlT2JqZWN0UmVnaXN0cnkgX2lu dm9rZU1ldGhvZDpdKToKKwogMjAyMS0wNS0yNCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5j b20+CiAKICAgICAgICAgUmVtb3ZlIFN0cmluZ0J1aWxkZXI6OmFwcGVuZExpdGVyYWwKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0FQSS9Db2NvYS9fV0tSZW1vdGVPYmplY3RSZWdp c3RyeS5tbSBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0FQSS9Db2NvYS9fV0tSZW1vdGVPYmplY3RS ZWdpc3RyeS5tbQppbmRleCA2YmJhMGE5NGUyNDM4MGI4NDk5ODk1ZWI0NzAzM2I5OWE2ZjAwOWM4 Li5iOThmMTQ0ZWVmNDMyYTQzOTY3Mjk2YTMxNTAyYzNmZTVkMTgzZDUzIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1NoYXJlZC9BUEkvQ29jb2EvX1dLUmVtb3RlT2JqZWN0UmVnaXN0cnkubW0K KysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvQVBJL0NvY29hL19XS1JlbW90ZU9iamVjdFJlZ2lz dHJ5Lm1tCkBAIC0yNzYsMTMgKzI3NiwxMyBAQCAtICh2b2lkKV9pbnZva2VNZXRob2Q6KGNvbnN0 IFdlYktpdDo6UmVtb3RlT2JqZWN0SW52b2NhdGlvbiYpcmVtb3RlT2JqZWN0SW52b2NhdAogICAg ICAgICBpZiAoZXhwZWN0ZWRCbG9ja1NpZ25hdHVyZS5pc051bGwoKSkgewogICAgICAgICAgICAg TlNMb2coQCJfaW52b2tlTWV0aG9kOiBGYWlsZWQgdG8gdmFsaWRhdGUgcmVwbHkgYmxvY2sgc2ln bmF0dXJlOiBjb3VsZCBub3QgZmluZCBsb2NhbCBzaWduYXR1cmUiKTsKICAgICAgICAgICAgIEFT U0VSVF9OT1RfUkVBQ0hFRCgpOwotICAgICAgICAgICAgY29udGludWU7CisgICAgICAgICAgICBy ZXR1cm47CiAgICAgICAgIH0KIAogICAgICAgICBpZiAoIWJsb2NrU2lnbmF0dXJlc0FyZUNvbXBh dGlibGUod2lyZUJsb2NrU2lnbmF0dXJlLCBleHBlY3RlZEJsb2NrU2lnbmF0dXJlKSkgewogICAg ICAgICAgICAgTlNMb2coQCJfaW52b2tlTWV0aG9kOiBGYWlsZWQgdG8gdmFsaWRhdGUgcmVwbHkg YmxvY2sgc2lnbmF0dXJlOiAlcyAhPSAlcyIsIHdpcmVCbG9ja1NpZ25hdHVyZS51dGY4KCkuZGF0 YSgpLCBleHBlY3RlZEJsb2NrU2lnbmF0dXJlLnV0ZjgoKS5kYXRhKCkpOwogICAgICAgICAgICAg QVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAg IHJldHVybjsKICAgICAgICAgfQogCiAgICAgICAgIFJldGFpblB0cjxfV0tSZW1vdGVPYmplY3RS ZWdpc3RyeT4gcmVtb3RlT2JqZWN0UmVnaXN0cnkgPSBzZWxmOwo=