226184 2021-05-24 12:33:52 -0700 Remove deprecated API usage in PageClientImplMac 2021-05-24 16:48:20 -0700 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 akeerthi webkit-unassigned bdakin dana.estra hi thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1763215 0 akeerthi 2021-05-24 12:33:52 -0700 `[NSWindow convertScreenToBase:]` and `[NSWindow convertBaseToScreen:]` have been deprecated since macOS 10.7. 1763237 1 429561 dana.estra 2021-05-24 14:03:46 -0700 Created attachment 429561 Patch 1763245 2 429561 hi 2021-05-24 14:17:32 -0700 Comment on attachment 429561 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429561&action=review r=me, nice! > Source/WebKit/UIProcess/mac/PageClientImplMac.mm:447 > + NSPoint windowCoord = [[m_view window] convertPointFromScreen:point]; NIT: I think you can `m_view.window` :) > Source/WebKit/UIProcess/mac/PageClientImplMac.mm:455 > + tempRect.origin = [[m_view window] convertPointToScreen:tempRect.origin]; ditto (:447) 1763292 3 429579 dana.estra 2021-05-24 15:48:59 -0700 Created attachment 429579 Removed deprecated API usage in PageClientImplMac and implemented edit from review 1763321 4 ews-feeder 2021-05-24 16:47:35 -0700 Committed r277983 (238096@main): <https://commits.webkit.org/238096@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429579. 1763322 5 webkit-bug-importer 2021-05-24 16:48:20 -0700 <rdar://problem/78425683> 429561 2021-05-24 14:03:46 -0700 2021-05-24 15:48:55 -0700 Patch bug-226184-20210524170345.patch text/plain 1966 dana.estra U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3OTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ5MGZmMTY1ZTE5NzE0MDU1 NTE4YmEzMmM1YzI0ZjI3ZWRkZWZhMDIuLjdkOWEwZWM1MDk3YWViMGRkMzVmMDA1MDJhNTFhNGM3 NzgxNjNiMTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDUtMjQgIERhbmEgRXN0 cmEgIDxkZXN0cmFAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBkZXByZWNhdGVkIEFQSSB1 c2FnZSBpbiBQYWdlQ2xpZW50SW1wbE1hYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjI2MTg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAq IFVJUHJvY2Vzcy9tYWMvUGFnZUNsaWVudEltcGxNYWMubW06CisgICAgICAgIChXZWJLaXQ6OlBh Z2VDbGllbnRJbXBsOjpzY3JlZW5Ub1Jvb3RWaWV3KToKKyAgICAgICAgKFdlYktpdDo6UGFnZUNs aWVudEltcGw6OnJvb3RWaWV3VG9TY3JlZW4pOgorCiAyMDIxLTA1LTIzICBDaHJpcyBEdW1leiAg PGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBDaGVja2VkTG9jayB0aGUgZGVmYXVs dCBMb2NrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvUGFnZUNsaWVu dEltcGxNYWMubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvUGFnZUNsaWVudEltcGxN YWMubW0KaW5kZXggMzcwMzUxMzU4MmM3NzFiOTBiODhkZDhjMTY5Mjg2MzAzY2JkMGRiNi4uZjMx ZTU4ZDlhYWM3MGJhZjQ3MTUxNGU4Y2ViMDkzNGQwM2E4Y2FiOSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvbWFjL1BhZ2VDbGllbnRJbXBsTWFjLm1tCisrKyBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL21hYy9QYWdlQ2xpZW50SW1wbE1hYy5tbQpAQCAtNDQ0LDkgKzQ0NCw3 IEBAIHZvaWQgUGFnZUNsaWVudEltcGw6OnBpbm5lZFN0YXRlRGlkQ2hhbmdlKCkKICAgICAKIElu dFBvaW50IFBhZ2VDbGllbnRJbXBsOjpzY3JlZW5Ub1Jvb3RWaWV3KGNvbnN0IEludFBvaW50JiBw b2ludCkKIHsKLSAgICBBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9OU19CRUdJTgotICAgIE5T UG9pbnQgd2luZG93Q29vcmQgPSBbW21fdmlldyB3aW5kb3ddIGNvbnZlcnRTY3JlZW5Ub0Jhc2U6 cG9pbnRdOwotICAgIEFMTE9XX0RFUFJFQ0FURURfREVDTEFSQVRJT05TX0VORAorICAgIE5TUG9p bnQgd2luZG93Q29vcmQgPSBbW21fdmlldyB3aW5kb3ddIGNvbnZlcnRQb2ludEZyb21TY3JlZW46 cG9pbnRdOwogICAgIHJldHVybiBJbnRQb2ludChbbV92aWV3IGNvbnZlcnRQb2ludDp3aW5kb3dD b29yZCBmcm9tVmlldzpuaWxdKTsKIH0KICAgICAKQEAgLTQ1NCw5ICs0NTIsNyBAQCBJbnRSZWN0 IFBhZ2VDbGllbnRJbXBsOjpyb290Vmlld1RvU2NyZWVuKGNvbnN0IEludFJlY3QmIHJlY3QpCiB7 CiAgICAgTlNSZWN0IHRlbXBSZWN0ID0gcmVjdDsKICAgICB0ZW1wUmVjdCA9IFttX3ZpZXcgY29u dmVydFJlY3Q6dGVtcFJlY3QgdG9WaWV3Om5pbF07Ci0gICAgQUxMT1dfREVQUkVDQVRFRF9ERUNM QVJBVElPTlNfQkVHSU4KLSAgICB0ZW1wUmVjdC5vcmlnaW4gPSBbW21fdmlldyB3aW5kb3ddIGNv bnZlcnRCYXNlVG9TY3JlZW46dGVtcFJlY3Qub3JpZ2luXTsKLSAgICBBTExPV19ERVBSRUNBVEVE X0RFQ0xBUkFUSU9OU19FTkQKKyAgICB0ZW1wUmVjdC5vcmlnaW4gPSBbW21fdmlldyB3aW5kb3dd IGNvbnZlcnRQb2ludFRvU2NyZWVuOnRlbXBSZWN0Lm9yaWdpbl07CiAgICAgcmV0dXJuIGVuY2xv c2luZ0ludFJlY3QodGVtcFJlY3QpOwogfQogCg== 429579 2021-05-24 15:48:59 -0700 2021-05-24 16:47:35 -0700 Removed deprecated API usage in PageClientImplMac and implemented edit from review bug-226184-20210524184857.patch text/plain 1960 dana.estra U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3OTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ5MGZmMTY1ZTE5NzE0MDU1 NTE4YmEzMmM1YzI0ZjI3ZWRkZWZhMDIuLjE1OGExZmZlN2Y4NTZlNjIwZDc0N2NmNWIxNGJmMzFm OThmMzc0NzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDUtMjQgIERhbmEgRXN0 cmEgIDxkZXN0cmFAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBkZXByZWNhdGVkIEFQSSB1 c2FnZSBpbiBQYWdlQ2xpZW50SW1wbE1hYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjI2MTg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGV2aW4gUm91 c3NvLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvbWFjL1BhZ2VDbGllbnRJbXBsTWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpQYWdl Q2xpZW50SW1wbDo6c2NyZWVuVG9Sb290Vmlldyk6CisgICAgICAgIChXZWJLaXQ6OlBhZ2VDbGll bnRJbXBsOjpyb290Vmlld1RvU2NyZWVuKToKKwogMjAyMS0wNS0yMyAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgQ2hlY2tlZExvY2sgdGhlIGRlZmF1bHQg TG9jawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1BhZ2VDbGllbnRJ bXBsTWFjLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1BhZ2VDbGllbnRJbXBsTWFj Lm1tCmluZGV4IDM3MDM1MTM1ODJjNzcxYjkwYjg4ZGQ4YzE2OTI4NjMwM2NiZDBkYjYuLjNkZTYw MTcwZjYwNTM0NWY4MmY3ZTQ0ZTIyM2YyMzFiMTM5YzBmNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL21hYy9QYWdlQ2xpZW50SW1wbE1hYy5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9tYWMvUGFnZUNsaWVudEltcGxNYWMubW0KQEAgLTQ0NCw5ICs0NDQsNyBA QCB2b2lkIFBhZ2VDbGllbnRJbXBsOjpwaW5uZWRTdGF0ZURpZENoYW5nZSgpCiAgICAgCiBJbnRQ b2ludCBQYWdlQ2xpZW50SW1wbDo6c2NyZWVuVG9Sb290Vmlldyhjb25zdCBJbnRQb2ludCYgcG9p bnQpCiB7Ci0gICAgQUxMT1dfREVQUkVDQVRFRF9ERUNMQVJBVElPTlNfQkVHSU4KLSAgICBOU1Bv aW50IHdpbmRvd0Nvb3JkID0gW1ttX3ZpZXcgd2luZG93XSBjb252ZXJ0U2NyZWVuVG9CYXNlOnBv aW50XTsKLSAgICBBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9OU19FTkQKKyAgICBOU1BvaW50 IHdpbmRvd0Nvb3JkID0gW21fdmlldy53aW5kb3cgY29udmVydFBvaW50RnJvbVNjcmVlbjpwb2lu dF07CiAgICAgcmV0dXJuIEludFBvaW50KFttX3ZpZXcgY29udmVydFBvaW50OndpbmRvd0Nvb3Jk IGZyb21WaWV3Om5pbF0pOwogfQogICAgIApAQCAtNDU0LDkgKzQ1Miw3IEBAIEludFJlY3QgUGFn ZUNsaWVudEltcGw6OnJvb3RWaWV3VG9TY3JlZW4oY29uc3QgSW50UmVjdCYgcmVjdCkKIHsKICAg ICBOU1JlY3QgdGVtcFJlY3QgPSByZWN0OwogICAgIHRlbXBSZWN0ID0gW21fdmlldyBjb252ZXJ0 UmVjdDp0ZW1wUmVjdCB0b1ZpZXc6bmlsXTsKLSAgICBBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFU SU9OU19CRUdJTgotICAgIHRlbXBSZWN0Lm9yaWdpbiA9IFtbbV92aWV3IHdpbmRvd10gY29udmVy dEJhc2VUb1NjcmVlbjp0ZW1wUmVjdC5vcmlnaW5dOwotICAgIEFMTE9XX0RFUFJFQ0FURURfREVD TEFSQVRJT05TX0VORAorICAgIHRlbXBSZWN0Lm9yaWdpbiA9IFttX3ZpZXcud2luZG93IGNvbnZl cnRQb2ludFRvU2NyZWVuOnRlbXBSZWN0Lm9yaWdpbl07CiAgICAgcmV0dXJuIGVuY2xvc2luZ0lu dFJlY3QodGVtcFJlY3QpOwogfQogCg==