22618 2008-12-02 22:01:14 -0800 QtWebKit MinGW does not link 2008-12-18 06:38:37 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 laszlo.gombos webkit-unassigned hausmann vestbo oldest_to_newest 101148 0 laszlo.gombos 2008-12-02 22:01:14 -0800 Building QtWebKit on Windows fails to link. I installed the latest Qt release (qt-win-opensource-4.4.3-mingw.exe) - MinGW was downloaded and installed by the Qt installer - and followed the instructions from http://trac.webkit.org/wiki/BuildingQtOnWindows. There are several problems with QtWebKit on MinGW, will list the most obvious ones a./ ENABLE_OFFLINE_WEB_APPLICATIONS and ENABLE_DOM_STORAGE are enabled even though ENABLE_DATABASE is disabled. This is a problem, because ENABLE_OFFLINE_WEB_APPLICATIONS and ENABLE_DOM_STORAGE are dependent on ENABLE_DATABASE. This will eventually lead to a link-time failure. b./ ENABLE_DATABASE is deliberately turned off if QtWebKit is not built inside an Qt release In some instances (e.g. when SQLITE3SRCDIR is defined or building inside Qt) QtWebKit build can pick up sqlite3.c and link it in. I would like to propose to extend this functionality to the Win MingGW build as well, since the Qt release comes with an sqlite3.c source. 101149 1 25700 laszlo.gombos 2008-12-02 22:03:35 -0800 Created attachment 25700 Fix The included patch fixes the following problems/adds the following features: - Try to detect if sqlite3.c is available as part of a Qt installation, or specified by SQLITE3SRCDIR - When not building inside Qt only disable ENABLE_DATABASE on windows, if sqlite3.c is not available (instead of all the time) - When ENABLE_DATABASE is disabled, disable ENABLE_OFFLINE_WEB_APPLICATIONS and ENABLE_DOM_STORAGE as well, not only ENABLE_ICONDATABASE - ENABLE_DATABASE is now disabled by default if ENABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_DOM_STORAGE and ENABLE_ICONDATABASE all disabled (I have not changed however the default values for NABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_DOM_STORAGE and ENABLE_ICONDATABASE features.) - Consolidated build logic so that there is only one code branch where sqlite3.c gets added to the source list. In addition copied SQLITE DEFINES from sqlite.pro, these were not there before. 102876 2 25700 hausmann 2008-12-18 05:53:28 -0800 Comment on attachment 25700 Fix Good catch, thanks for the cleanups! 102877 3 vestbo 2008-12-18 06:38:37 -0800 Landed in r39372 25700 2008-12-02 22:03:35 -0800 2008-12-18 05:53:28 -0800 Fix patch_22618.txt text/plain 4331 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODkxNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTEgQEAKKzIwMDgtMTItMDIgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjYxOAorCisg ICAgICAgIEZpeCBNaW5HVyBRdFdlYktpdCBsaW5raW5nIHByb2JsZW1zICsgb3RoZXIgY2hhbmdl cyB0byBtYWtlIAorICAgICAgICBRdFdlYktpdCBidWlsZCBzeXN0ZW0gbW9yZSByb2J1c3QuCisg ICAgICAgICogV2ViQ29yZS5wcm86CisKIDIwMDgtMTItMDIgIENocmlzIEZsZWl6YWNoICA8Y2Zs ZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWcgMjI1OTY6IFNvbWUgZWxlbWVudHMgZG9u J3QgcmVwb3J0IEFYQmxvY2tRdW90ZUxldmVsCkluZGV4OiBXZWJDb3JlL1dlYkNvcmUucHJvCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvV2ViQ29yZS5wcm8JKHJldmlzaW9uIDM4OTEwKQorKysgV2Vi Q29yZS9XZWJDb3JlLnBybwkod29ya2luZyBjb3B5KQpAQCAtNDcsNyArNDcsNiBAQCBmcmVlYnNk LSo6IERFRklORVMgKz0gSEFWRV9QVEhSRUFEX05QX0gKIAogREVGSU5FUyArPSBCVUlMRF9XRUJL SVQKIAotIUNPTkZJRyhRVERJUl9idWlsZCk6d2luMzItKjogREVGSU5FUyArPSBFTkFCTEVfSUNP TkRBVEFCQVNFPTAgRU5BQkxFX0RBVEFCQVNFPTAKIHdpbjMyLSo6IERFRklORVMgKz0gX0hBU19U UjE9MAogd2luY2UqIHsKICMgICAgREVGSU5FUyArPSBFTkFCTEVfU1ZHPTAgRU5BQkxFX1hQQVRI PTAgRU5BQkxFX1hCTD0wIFwKQEAgLTY2LDEyICs2NSwzNiBAQCB3aW4zMi1nKysgewogICAgIFFN QUtFX0xJQkRJUl9QT1NUICs9ICQkc3BsaXQoVE1QUEFUSCwiOyIpCiB9CiAKKyMgVHJ5IHRvIGxv Y2F0ZSBzcWxpdGUzIHNvdXJjZQorQ09ORklHKFFURElSX2J1aWxkKSB7CisgICAgU1FMSVRFM1NS Q0RJUiA9ICQkUVRfU09VUkNFX1RSRUUvc3JjLzNyZHBhcnR5L3NxbGl0ZS8KK30gZWxzZSB7Cisg ICAgU1FMSVRFM1NSQ0RJUiA9ICQkKFNRTElURTNTUkNESVIpCisgICAgaXNFbXB0eShTUUxJVEUz U1JDRElSKSB7CisgICAgICAgIFNRTElURTNTUkNESVIgPSAkJFtRVF9JTlNUQUxMX1BSRUZJWF0v c3JjLzNyZHBhcnR5L3NxbGl0ZS8KKyAgICB9IAorfQorCiAjIE9wdGlvbmFsIGNvbXBvbmVudHMg KGxvb2sgZm9yIGRlZnMgaW4gY29uZmlnLmggYW5kIGluY2x1ZGVkIGZpbGVzISkKLSFjb250YWlu cyhERUZJTkVTLCBFTkFCTEVfREFTSEJPQVJEX1NVUFBPUlQ9Lik6IERFRklORVMgKz0gRU5BQkxF X0RBU0hCT0FSRF9TVVBQT1JUPTAKKworIyB0dXJuIG9mZiBkYXRhYmFzZSBzdXBwb3J0IGlmIHdl IGRvIG5vdCBoYXZlIHNxbGl0ZTMgc3VwcG9ydCAKKyFDT05GSUcoUVRESVJfYnVpbGQpOndpbjMy LSo6IWV4aXN0cyggJCR7U1FMSVRFM1NSQ0RJUn0vc3FsaXRlMy5jICk6IERFRklORVMgKz0gRU5B QkxFX0RBVEFCQVNFPTAgRU5BQkxFX0lDT05EQVRBQkFTRT0wIEVOQUJMRV9PRkZMSU5FX1dFQl9B UFBMSUNBVElPTlM9MCBFTkFCTEVfRE9NX1NUT1JBR0U9MAorCiAhY29udGFpbnMoREVGSU5FUywg RU5BQkxFX09GRkxJTkVfV0VCX0FQUExJQ0FUSU9OUz0uKTogREVGSU5FUyArPSBFTkFCTEVfT0ZG TElORV9XRUJfQVBQTElDQVRJT05TPTEKICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfRE9NX1NU T1JBR0U9Lik6IERFRklORVMgKz0gRU5BQkxFX0RPTV9TVE9SQUdFPTEKLSFjb250YWlucyhERUZJ TkVTLCBFTkFCTEVfREFUQUJBU0U9Lik6IERFRklORVMgKz0gRU5BQkxFX0RBVEFCQVNFPTEKICFj b250YWlucyhERUZJTkVTLCBFTkFCTEVfSUNPTkRBVEFCQVNFPS4pOiBERUZJTkVTICs9IEVOQUJM RV9JQ09OREFUQUJBU0U9MQorCisjIHR1cm4gb24gZGF0YWJhc2Ugc3VwcG9ydCBpZiBhbnkgb2Yg dGhlIGRlcGVuZGVudCBmZWF0dXJlcyBhcmUgdHVybmVkIG9uCishY29udGFpbnMoREVGSU5FUywg RU5BQkxFX0RBVEFCQVNFPTEpIHsKKyAgY29udGFpbnMoREVGSU5FUywgRU5BQkxFX0lDT05EQVRB QkFTRT0xKXwoREVGSU5FUywgRU5BQkxFX0RPTV9TVE9SQUdFPTEpfChERUZJTkVTLCBFTkFCTEVf T0ZGTElORV9XRUJfQVBQTElDQVRJT05TPTEpIHsKKyAgICBERUZJTkVTICs9IEVOQUJMRV9EQVRB QkFTRT0xCisgIH0KK30KKworIyBpZiBkYXRhYmFzZSBzdXBwb3J0IGlzIG5vdCBvbiBieSBub3cs IHR1cm4gaXQgb2ZmIAorIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9EQVRBQkFTRT0uKTogREVG SU5FUyArPSBFTkFCTEVfREFUQUJBU0U9MAorCishY29udGFpbnMoREVGSU5FUywgRU5BQkxFX0RB U0hCT0FSRF9TVVBQT1JUPS4pOiBERUZJTkVTICs9IEVOQUJMRV9EQVNIQk9BUkRfU1VQUE9SVD0w CiAhY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1hQQVRIPS4pOiBERUZJTkVTICs9IEVOQUJMRV9Y UEFUSD0xCiAjIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9YQkw9Lik6IERFRklORVMgKz0gRU5B QkxFX1hCTD0xCiAhY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1dNTD0uKTogREVGSU5FUyArPSBF TkFCTEVfV01MPTAKQEAgLTExOTEsMjUgKzEyMTQsMjEgQEAgY29udGFpbnMoREVGSU5FUywgRU5B QkxFX0RBU0hCT0FSRF9TVVBQTwogY29udGFpbnMoREVGSU5FUywgRU5BQkxFX0RBVEFCQVNFPTEp IHsKICAgICBGRUFUVVJFX0RFRklORVNfSkFWQVNDUklQVCArPSBFTkFCTEVfREFUQUJBU0U9MQog Ci0gICAgQ09ORklHKFFURElSX2J1aWxkKSB7Ci0gICAgICAgICMgc29tZSB3aGF0IGNvcGllZCBm cm9tIHNyYy9wbHVnaW5zL3NxbGRyaXZlcnMvc3FsaXRlL3NxbGl0ZS5wcm8KLSAgICAgICAgc3lz dGVtLXNxbGl0ZSB7Ci0gICAgICAgICAgICBMSUJTICo9ICQkUVRfTEZMQUdTX1NRTElURQotICAg ICAgICAgICAgUU1BS0VfQ1hYRkxBR1MgKj0gJCRRVF9DRkxBR1NfU1FMSVRFCi0gICAgICAgIH0g ZWxzZSB7Ci0gICAgICAgICAgICBDT05GSUcocmVsZWFzZSwgZGVidWd8cmVsZWFzZSk6REVGSU5F UyAqPSBOREVCVUcKLSAgICAgICAgICAgIElOQ0xVREVQQVRIICs9ICQkUVRfU09VUkNFX1RSRUUv c3JjLzNyZHBhcnR5L3NxbGl0ZS8KLSAgICAgICAgICAgIFNPVVJDRVMgKz0gJCRRVF9TT1VSQ0Vf VFJFRS9zcmMvM3JkcGFydHkvc3FsaXRlL3NxbGl0ZTMuYwotICAgICAgICB9CisgICAgIyBzb21l d2hhdCBjb3BpZWQgZnJvbSBzcmMvcGx1Z2lucy9zcWxkcml2ZXJzL3NxbGl0ZS9zcWxpdGUucHJv CisgICAgQ09ORklHKFFURElSX2J1aWxkKTpzeXN0ZW0tc3FsaXRlIHsKKyAgICAgICAgTElCUyAq PSAkJFFUX0xGTEFHU19TUUxJVEUKKyAgICAgICAgUU1BS0VfQ1hYRkxBR1MgKj0gJCRRVF9DRkxB R1NfU1FMSVRFCiAgICAgfSBlbHNlIHsKLSAgICAgICAgU1FMSVRFM1NSQ0RJUiA9ICQkKFNRTElU RTNTUkNESVIpCi0gICAgICAgIGlzRW1wdHkoU1FMSVRFM1NSQ0RJUikgewotICAgICAgICAgICAg SU5DTFVERVBBVEggKz0gJCRbUVRfSU5TVEFMTF9QUkVGSVhdL3NyYy8zcmRwYXJ0eS9zcWxpdGUv Ci0gICAgICAgICAgICBMSUJTICs9IC1sc3FsaXRlMwotICAgICAgICB9IGVsc2UgeworICAgICAg ICBleGlzdHMoICQke1NRTElURTNTUkNESVJ9L3NxbGl0ZTMuYyApICB7CisgICAgICAgICAgICAj IHdlIGhhdmUgc291cmNlIC0gdXNlIGl0CiAgICAgICAgICAgICBDT05GSUcocmVsZWFzZSwgZGVi dWd8cmVsZWFzZSk6REVGSU5FUyAqPSBOREVCVUcKKyAgICAgICAgICAgIERFRklORVMgKz0gU1FM SVRFX0NPUkUgU1FMSVRFX09NSVRfTE9BRF9FWFRFTlNJT04gU1FMSVRFX09NSVRfQ09NUExFVEUg CiAgICAgICAgICAgICBJTkNMVURFUEFUSCArPSAkJHtTUUxJVEUzU1JDRElSfQogICAgICAgICAg ICAgU09VUkNFUyArPSAkJHtTUUxJVEUzU1JDRElSfS9zcWxpdGUzLmMKKyAgICAgICAgfSBlbHNl IHsKKyAgICAgICAgICAgICMgZmFsbCBiYWNrIHRvIHBsYXRmb3JtIGxpYnJhcnkKKyAgICAgICAg ICAgIElOQ0xVREVQQVRIICs9ICQkW1FUX0lOU1RBTExfUFJFRklYXS9zcmMvM3JkcGFydHkvc3Fs aXRlLworICAgICAgICAgICAgTElCUyArPSAtbHNxbGl0ZTMKICAgICAgICAgfQogICAgIH0KIAo=