226167 2021-05-24 00:57:16 -0700 GCC complains about a memcpy in SmallSet.h 2023-11-15 07:43:49 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Local Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 estea webkit-unassigned benjamin cdumez cmarcelo darin estea ews-watchlist mcatanzaro webkit-bug-importer oldest_to_newest 1763049 0 estea 2021-05-24 00:57:16 -0700 GCC complains about a memcpy in SmallSet.h It seems that it contains an object with no trivial copy-assignment. We'd rather eplace the memcpy with assignments of the private members. Error: WTF/Headers/wtf/SmallSet.h:70:15: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘class WTF::SmallSet<WTF::UniquedStringImpl*’ with no trivial copy-assignment [-Wclass-memaccess] 70 | memcpy(this, &other, sizeof(SmallSet)); | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ WTF/Headers/wtf/SmallSet.h:44:7: note: ‘class WTF::SmallSet<WTF::UniquedStringImpl*>’ declared here 44 | class SmallSet { 1763051 1 429512 estea 2021-05-24 01:01:53 -0700 Created attachment 429512 Patch 1765351 2 webkit-bug-importer 2021-05-31 00:58:16 -0700 <rdar://problem/78679329> 1992519 3 429512 mcatanzaro 2023-11-14 10:58:23 -0800 Comment on attachment 429512 Patch Found this when searching for -Wclass-memaccess warnings. It will need to be rebased because I added void casts at some point to suppress this warning. Your solution is better. 1992778 4 429512 darin 2023-11-15 07:43:49 -0800 Comment on attachment 429512 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429512&action=review > Source/WTF/wtf/SmallSet.h:72 > + this->m_size = other.m_size; > + this->m_capacity = other.m_capacity; > + this->m_inline = other.m_inline; We can also omit the "this->" here. 429512 2021-05-24 01:01:53 -0700 2023-11-14 10:58:23 -0800 Patch bug-226167-20210524110152.patch text/plain 1288 estea U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3OTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDE2M2RjNjY5ZGRjMGNiMDRmMjhiYjll OWNlOTBmMmVmNTg1NmU1YzAuLjk0ZjdhZTU4MGYyZTg0NGFlYjM1NTJlZWY2ZWZhYjQyZWJhNjQ3 NTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDUtMjQgIEVsZW5pIE1hcmlhIFN0ZWEgIDxl c3RlYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFJlcGxhY2VkIHRoZSBtZW1jcHkgaW4gU21hbGxT ZXQuaCBvZiBXVEYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyNjE2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEdDQyBjb21wbGFpbnMgZm9yIHRoZSBtZW1jcHkgb2YgdGhlIFNtYWxsU2V0IGNsYXNzLiBJ dCBzZWVtcyB0aGF0CisgICAgICAgIGl0IGNvbnRhaW5zIGFuIG9iamVjdCB3aXRoIG5vIHRyaXZp YWwgY29weS1hc3NpZ25tZW50LiBSZXBsYWNlZCB0aGUKKyAgICAgICAgbWVtY3B5IHdpdGggYXNz aWdubWVudHMgb2YgdGhlIHByaXZhdGUgbWVtYmVycy4KKworICAgICAgICAqIHd0Zi9TbWFsbFNl dC5oOgorCiAyMDIxLTA1LTIzICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAg ICAgICAgTWFrZSBDaGVja2VkTG9jayB0aGUgZGVmYXVsdCBMb2NrCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV1RGL3d0Zi9TbWFsbFNldC5oIGIvU291cmNlL1dURi93dGYvU21hbGxTZXQuaAppbmRleCA0 NTIzNzEzMmRkODljMzg0NWFkMTk5OWJmNjBkMjhjZDUwYWE5M2JjLi5iNDk5MDMzNzY2MzgxM2Mx YTU0NmI2YzgzY2FlMWNhZWQ4NTExMWUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9TbWFs bFNldC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1NtYWxsU2V0LmgKQEAgLTY3LDcgKzY3LDkgQEAg cHVibGljOgogCiAgICAgU21hbGxTZXQoU21hbGxTZXQmJiBvdGhlcikKICAgICB7Ci0gICAgICAg IG1lbWNweSh0aGlzLCAmb3RoZXIsIHNpemVvZihTbWFsbFNldCkpOworICAgICAgICB0aGlzLT5t X3NpemUgPSBvdGhlci5tX3NpemU7CisgICAgICAgIHRoaXMtPm1fY2FwYWNpdHkgPSBvdGhlci5t X2NhcGFjaXR5OworICAgICAgICB0aGlzLT5tX2lubGluZSA9IG90aGVyLm1faW5saW5lOwogICAg ICAgICBvdGhlci5pbml0aWFsaXplKCk7CiAgICAgfQogCg==