226165 2021-05-24 00:36:49 -0700 [CoordinatedGraphics] Handle null native surface handle for surfaceless rendering 2021-05-24 23:15:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zan zan cmarcelo ews-watchlist gyuyoung.kim luiz pnormand ryuan.choi sergio webkit-bug-importer zdobersek zeno oldest_to_newest 1763044 0 zan 2021-05-24 00:36:49 -0700 [CoordinatedGraphics] Handle null native window handle for surfaceless rendering 1763046 1 429509 zan 2021-05-24 00:42:31 -0700 Created attachment 429509 Patch 1763135 2 429509 pnormand 2021-05-24 08:20:10 -0700 Comment on attachment 429509 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429509&action=review > Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:74 > + if (m_context) { Nit: this could be reversed and early return. 1763442 3 ews-feeder 2021-05-24 23:14:53 -0700 Committed r277998 (238111@main): <https://commits.webkit.org/238111@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429509. 1763443 4 webkit-bug-importer 2021-05-24 23:15:19 -0700 <rdar://problem/78439250> 429509 2021-05-24 00:42:31 -0700 2021-05-24 23:14:54 -0700 Patch bug-226165-20210524094229.patch text/plain 2911 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3OTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ5MGZmMTY1ZTE5NzE0MDU1 NTE4YmEzMmM1YzI0ZjI3ZWRkZWZhMDIuLjc1MDliYzMxMjM5N2VkYjM3NmY2OWZmZjc5ZWZiMzZh MTJlNDM1Y2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjEtMDUtMjQgIFphbiBEb2Jl cnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtDb29yZGluYXRlZEdyYXBo aWNzXSBIYW5kbGUgbnVsbCBuYXRpdmUgc3VyZmFjZSBoYW5kbGUgZm9yIHN1cmZhY2VsZXNzIHJl bmRlcmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjI2MTY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg RHVyaW5nIFRocmVhZGVkQ29tcG9zaXRvciBpbml0aWFsaXphdGlvbiwgYSBudWxsIG5hdGl2ZSBz dXJmYWNlIGhhbmRsZQorICAgICAgICB3b3VsZCByZXByZXNlbnQgYSBzdXJmYWNlbGVzcyByZW5k ZXJpbmcgdGFyZ2V0LiBBc3N1bWluZyBjb3JyZXNwb25kaW5nCisgICAgICAgIGRyaXZlciBzdXBw b3J0IGZvciB0aGlzIGJlaGF2aW9yLCB0aGUgR0wgY29udGV4dCBjcmVhdGlvbiB3b3VsZCBzdGls bAorICAgICAgICBzdWNjZWVkIGFuZCBjb21wb3NpdGlvbiBjb3VsZCBiZSBwZXJmb3JtZWQuCisK KyAgICAgICAgVG8gc3VwcG9ydCB0aGlzIGJlaGF2aW9yLCB0aGUgR0wgY29udGV4dCBpcyBub3cg c3Bhd25lZCBmaXJzdCwgYW5kIGlmCisgICAgICAgIHN1Y2Nlc3NmdWwsIHRoZSBzY2VuZSBpcyBz ZXQgYXMgYWN0aXZlLiBCdXQgaW4gY2FzZSBvZiBhIG51bGwgbmF0aXZlCisgICAgICAgIHN1cmZh Y2UgKGkuZS4gc3VyZmFjZWxlc3MgcmVuZGVyaW5nKSwgdGhlIHBhaW50aW5nIGhhcyB0byBiZSBt aXJyb3JlZAorICAgICAgICBieSBkZWZhdWx0IGJlY2F1c2Ugb2YgdGhlIE9wZW5HTCBjb29yZGlu YXRlIHN5c3RlbSBiZWluZyB0aGUgaW1tZWRpYXRlCisgICAgICAgIGNvb3JkaW5hdGUgc3lzdGVt IGluc2lkZSB3aGljaCB3ZSBlbmQgdXAgd29ya2luZy4KKworICAgICAgICAqIFNoYXJlZC9Db29y ZGluYXRlZEdyYXBoaWNzL3RocmVhZGVkY29tcG9zaXRvci9UaHJlYWRlZENvbXBvc2l0b3IuY3Bw OgorICAgICAgICAoV2ViS2l0OjptX2Rpc3BsYXlSZWZyZXNoTW9uaXRvcik6CisgICAgICAgIChX ZWJLaXQ6OlRocmVhZGVkQ29tcG9zaXRvcjo6Y3JlYXRlR0xDb250ZXh0KToKKwogMjAyMS0wNS0y MyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgQ2hlY2tl ZExvY2sgdGhlIGRlZmF1bHQgTG9jawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQv Q29vcmRpbmF0ZWRHcmFwaGljcy90aHJlYWRlZGNvbXBvc2l0b3IvVGhyZWFkZWRDb21wb3NpdG9y LmNwcCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3MvdGhyZWFkZWRj b21wb3NpdG9yL1RocmVhZGVkQ29tcG9zaXRvci5jcHAKaW5kZXggYzhiOWI4Y2M5MTE2MDc1NjQ4 YjY4NjU4NDA0MjlkYzljZjE5ZDgxNy4uOTk1Mzk3ZmNkZmU1M2YzOWJjOTAyYzJmZTY3ZWE0ZDU4 MGYwZWM0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvQ29vcmRpbmF0ZWRHcmFw aGljcy90aHJlYWRlZGNvbXBvc2l0b3IvVGhyZWFkZWRDb21wb3NpdG9yLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L1NoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNzL3RocmVhZGVkY29tcG9zaXRvci9U aHJlYWRlZENvbXBvc2l0b3IuY3BwCkBAIC03MCw5ICs3MCwxMiBAQCBUaHJlYWRlZENvbXBvc2l0 b3I6OlRocmVhZGVkQ29tcG9zaXRvcihDbGllbnQmIGNsaWVudCwgVGhyZWFkZWREaXNwbGF5UmVm cmVzaE1vbgogICAgICAgICBtX3NjZW5lID0gYWRvcHRSZWYobmV3IENvb3JkaW5hdGVkR3JhcGhp Y3NTY2VuZSh0aGlzKSk7CiAgICAgICAgIG1fbmF0aXZlU3VyZmFjZUhhbmRsZSA9IG1fY2xpZW50 Lm5hdGl2ZVN1cmZhY2VIYW5kbGVGb3JDb21wb3NpdGluZygpOwogCi0gICAgICAgIG1fc2NlbmUt PnNldEFjdGl2ZSghIW1fbmF0aXZlU3VyZmFjZUhhbmRsZSk7Ci0gICAgICAgIGlmIChtX25hdGl2 ZVN1cmZhY2VIYW5kbGUpCi0gICAgICAgICAgICBjcmVhdGVHTENvbnRleHQoKTsKKyAgICAgICAg Y3JlYXRlR0xDb250ZXh0KCk7CisgICAgICAgIGlmIChtX2NvbnRleHQpIHsKKyAgICAgICAgICAg IGlmICghbV9uYXRpdmVTdXJmYWNlSGFuZGxlKQorICAgICAgICAgICAgICAgIG1fcGFpbnRGbGFn cyB8PSBUZXh0dXJlTWFwcGVyOjpQYWludGluZ01pcnJvcmVkOworICAgICAgICAgICAgbV9zY2Vu ZS0+c2V0QWN0aXZlKHRydWUpOworICAgICAgICB9CiAgICAgfSk7CiB9CiAKQEAgLTg0LDggKzg3 LDYgQEAgdm9pZCBUaHJlYWRlZENvbXBvc2l0b3I6OmNyZWF0ZUdMQ29udGV4dCgpCiB7CiAgICAg QVNTRVJUKCFSdW5Mb29wOjppc01haW4oKSk7CiAKLSAgICBBU1NFUlQobV9uYXRpdmVTdXJmYWNl SGFuZGxlKTsKLQogICAgIC8vIEdMTmF0aXZlV2luZG93VHlwZSBkZXBlbmRzIG9uIHRoZSBFR0wg aW1wbGVtZW50YXRpb246IHJlaW50ZXJwcmV0X2Nhc3Qgd29ya3MKICAgICAvLyBmb3IgcG9pbnRl cnMgKG9ubHkgaWYgdGhleSBhcmUgNjQtYml0IHdpZGUgYW5kIG5vdCBmb3Igb3RoZXIgY2FzZXMp LCBhbmQgc3RhdGljX2Nhc3QgZm9yCiAgICAgLy8gbnVtZXJpYyB0eXBlcyAoYW5kIHdoZW4gbmVl ZGVkIHRoZXkgZ2V0IGV4dGVuZGVkIHRvIDY0LWJpdCkgYnV0IG5vdCBmb3IgcG9pbnRlcnMuIFVz aW5nCg==