226155 2021-05-23 08:35:34 -0700 Remove some now invalid tests in testmasm. 2021-05-23 22:01:21 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1762911 0 mark.lam 2021-05-23 08:35:34 -0700 The ARM64E tests were checking that cageConditionallyAndUntag() would fail to produce a caged pointer if fed invalid values. These tests are no longer feasible because on ARM64E, feeding cageConditionallyAndUntag() invalid values will now result in a crash. This patch removes these tests. 1762912 1 429465 mark.lam 2021-05-23 08:38:18 -0700 Created attachment 429465 proposed patch. 1763010 2 429465 ysuzuki 2021-05-23 21:21:20 -0700 Comment on attachment 429465 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=429465&action=review r=me > Source/JavaScriptCore/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Let’s add description that is pasted in the bugzilla. That is helpful to folks who will see this patch later :) 1763014 3 429465 mark.lam 2021-05-23 21:53:02 -0700 Comment on attachment 429465 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=429465&action=review Thanks for the review. >> Source/JavaScriptCore/ChangeLog:6 >> + Reviewed by NOBODY (OOPS!). > > Let’s add description that is pasted in the bugzilla. That is helpful to folks who will see this patch later :) Oops. Will do. 1763015 4 mark.lam 2021-05-23 22:00:18 -0700 Landed in r277942: <http://trac.webkit.org/r277942>. 1763017 5 webkit-bug-importer 2021-05-23 22:01:21 -0700 <rdar://problem/78384961> 429465 2021-05-23 08:38:18 -0700 2021-05-23 21:21:20 -0700 proposed patch. bug-226155.patch text/plain 2587 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc3OTMwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDIxLTA1LTIzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW1vdmUgc29tZSBub3cgaW52YWxpZCB0ZXN0cyBpbiB0ZXN0bWFzbS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjE1NQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL3Rlc3RtYXNtLmNw cDoKKyAgICAgICAgKEpTQzo6dGVzdENhZ2VQcmVzZXJ2ZXNQQUNGYWlsdXJlQml0KToKKwogMjAy MS0wNS0yMiAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIHNp bmdsZXRvbiB0aHVua3MgZm9yIHZpcnR1YWwgY2FsbHMuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvYXNzZW1ibGVyL3Rlc3RtYXNtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYXNzZW1ibGVyL3Rlc3RtYXNtLmNwcAkocmV2aXNpb24gMjc3OTMwKQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci90ZXN0bWFzbS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDE3LTIwMjAgQXBwbGUgSW5j LiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDE3LTIwMjEgQXBwbGUg SW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2Ug aW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0 aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25z CkBAIC0yNDYwLDcgKzI0NjAsMTAgQEAgc3RhdGljIHZvaWQgdGVzdENhZ2VQcmVzZXJ2ZXNQQUNG YWlsdXJlQgogICAgIFJFTEVBU0VfQVNTRVJUKCFHaWdhY2FnZTo6ZGlzYWJsaW5nUHJpbWl0aXZl R2lnYWNhZ2VJc0ZvcmJpZGRlbigpKTsKICAgICBhdXRvIGNhZ2UgPSBjb21waWxlKFtdIChDQ2Fs bEhlbHBlcnMmIGppdCkgewogICAgICAgICBlbWl0RnVuY3Rpb25Qcm9sb2d1ZShqaXQpOwotICAg ICAgICBqaXQuY2FnZUNvbmRpdGlvbmFsbHlBbmRVbnRhZyhHaWdhY2FnZTo6UHJpbWl0aXZlLCBH UFJJbmZvOjphcmd1bWVudEdQUjAsIEdQUkluZm86OmFyZ3VtZW50R1BSMSwgR1BSSW5mbzo6YXJn dW1lbnRHUFIyKTsKKyAgICAgICAgY29uc3RleHByIEdQUlJlZyBzdG9yYWdlR1BSID0gR1BSSW5m bzo6YXJndW1lbnRHUFIwOworICAgICAgICBjb25zdGV4cHIgR1BSUmVnIGxlbmd0aEdQUiA9IEdQ UkluZm86OmFyZ3VtZW50R1BSMTsKKyAgICAgICAgY29uc3RleHByIEdQUlJlZyBzY3JhdGNoR1BS ID0gR1BSSW5mbzo6YXJndW1lbnRHUFIyOworICAgICAgICBqaXQuY2FnZUNvbmRpdGlvbmFsbHlB bmRVbnRhZyhHaWdhY2FnZTo6UHJpbWl0aXZlLCBzdG9yYWdlR1BSLCBsZW5ndGhHUFIsIHNjcmF0 Y2hHUFIpOwogICAgICAgICBqaXQubW92ZShHUFJJbmZvOjphcmd1bWVudEdQUjAsIEdQUkluZm86 OnJldHVyblZhbHVlR1BSKTsKICAgICAgICAgZW1pdEZ1bmN0aW9uRXBpbG9ndWUoaml0KTsKICAg ICAgICAgaml0LnJldCgpOwpAQCAtMjQ3MywxMiArMjQ3Niw3IEBAIHN0YXRpYyB2b2lkIHRlc3RD YWdlUHJlc2VydmVzUEFDRmFpbHVyZUIKICAgICBDSEVDS19OT1RfRVEoR2lnYWNhZ2U6OmNhZ2Vk KEdpZ2FjYWdlOjpQcmltaXRpdmUsIG5vdENhZ2VkUHRyKSwgbm90Q2FnZWRQdHIpOwogICAgIHZv aWQqIHRhZ2dlZE5vdENhZ2VkUHRyID0gdGFnQXJyYXlQdHIobm90Q2FnZWRQdHIsIDEpOwogCi0g ICAgaWYgKGlzQVJNNjRFKCkpIHsKLSAgICAgICAgQ0hFQ0tfTk9UX0VRKGludm9rZTx2b2lkKj4o Y2FnZSwgdGFnZ2VkUHRyLCAyKSwgcHRyKTsKLSAgICAgICAgQ0hFQ0tfTk9UX0VRKGludm9rZTx2 b2lkKj4oY2FnZSwgdGFnZ2VkTm90Q2FnZWRQdHIsIDEpLCBwdHIpOwotICAgICAgICB2b2lkKiBj YWdlZFRhZ2dlZE5vdENhZ2VkUHRyID0gaW52b2tlPHZvaWQqPihjYWdlLCB0YWdnZWROb3RDYWdl ZFB0ciwgMSk7Ci0gICAgICAgIENIRUNLX05PVF9FUShjYWdlZFRhZ2dlZE5vdENhZ2VkUHRyLCBy ZW1vdmVBcnJheVB0clRhZyhjYWdlZFRhZ2dlZE5vdENhZ2VkUHRyKSk7Ci0gICAgfSBlbHNlCisg ICAgaWYgKCFpc0FSTTY0RSgpKQogICAgICAgICBDSEVDS19FUShpbnZva2U8dm9pZCo+KGNhZ2Us IHRhZ2dlZFB0ciwgMiksIHB0cik7CiAKICAgICBDSEVDS19FUShpbnZva2U8dm9pZCo+KGNhZ2Us IHRhZ2dlZFB0ciwgMSksIHB0cik7Cg==