226135 2021-05-21 22:02:09 -0700 Remove WTF::holdLock() / WTF::holdLockIf() 2021-05-22 08:45:33 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen benjamin cmarcelo darin ddkilzer esprehn+autocc ews-watchlist ggaren kangil.han keith_miller kkinnunen mark.lam msaboff saam sam tzagallo webkit-bug-importer oldest_to_newest 1762758 0 cdumez 2021-05-21 22:02:09 -0700 Remove WTF::holdLock() / WTF::holdLockIf() because they are not compatible with Clang Thread Safety Analysis. All call sites have been converted to use the Locker constructor directly. 1762760 1 429401 cdumez 2021-05-21 22:04:09 -0700 Created attachment 429401 Patch 1762777 2 ews-feeder 2021-05-21 23:39:52 -0700 Committed r277914 (238047@main): <https://commits.webkit.org/238047@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429401. 1762778 3 webkit-bug-importer 2021-05-21 23:40:16 -0700 <rdar://problem/78344289> 1762805 4 keith_miller 2021-05-22 06:26:03 -0700 Out of curiosity, why is it incompatible? You'd think and r-value reference would be the same as as the r-value constructor? 1762815 5 cdumez 2021-05-22 08:45:33 -0700 (In reply to Keith Miller from comment #4) > Out of curiosity, why is it incompatible? You'd think and r-value reference > would be the same as as the r-value constructor? Not sure which r-value constructor you're referring to. The Locker<CheckedLock> specialization in CheckedLock.h does not have a move or copy constructor. AFAIK, this isn't supposed by clang thread safety analysis (https://clang.llvm.org/docs/ThreadSafetyAnalysis.html). 429401 2021-05-21 22:04:09 -0700 2021-05-21 23:39:54 -0700 Patch bug-226135-20210521220408.patch text/plain 5048 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3OTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi ZWI0ZmJjYWNhMTU4YTdjN2NhOTFjNDVlODIxYmIzNjNjMzU1NmE1Li5hOWJjYmZlM2QwMmU0Nzk1 ZjhlYjI1YzJmYjhjMGI2YWY5Nzg2NjczIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMS0wNS0yMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgor CisgICAgICAgIFJlbW92ZSBXVEY6OmhvbGRMb2NrKCkgLyBXVEY6OmhvbGRMb2NrSWYoKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2MTM1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIFdURjo6 aG9sZExvY2soKSAvIFdURjo6aG9sZExvY2tJZigpIGJlY2F1c2UgdGhleSBhcmUgbm90IGNvbXBh dGlibGUgd2l0aAorICAgICAgICBDbGFuZyBUaHJlYWQgU2FmZXR5IEFuYWx5c2lzLiBBbGwgY2Fs bCBzaXRlcyBoYXZlIGJlZW4gY29udmVydGVkIHRvIHVzZSB0aGUgTG9ja2VyCisgICAgICAgIGNv bnN0cnVjdG9yIGRpcmVjdGx5LgorCisgICAgICAgICogaGVhcC9Mb2NrRHVyaW5nTWFya2luZy5o OgorICAgICAgICAoSlNDOjpsb2NrRHVyaW5nTWFya2luZyk6CisKIDIwMjEtMDUtMjEgIENocmlz IER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBTdG9wIHVzaW5nIGhvbGRMb2Nr KCkgaW4gSlNDIGFzIGl0IGlzIG5vdCBjb21wYXRpYmxlIHdpdGggQ2xhbmcgdGhyZWFkIHNhZmV0 eSBhbmFseXNpcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RG L0NoYW5nZUxvZwppbmRleCBkMDUzYjM4NGEwY2RmYzNjYTZjMDAzNjA1ODNlNzNhYjllNGVhNzdm Li40OWI5NWMwZjAxZGI2N2M5ZGRmYzdlNWJiOTEyYjZiMmQwNTFjY2ZmIDEwMDY0NAotLS0gYS9T b3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDIxLTA1LTIxICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAg ICAgICAgUmVtb3ZlIFdURjo6aG9sZExvY2soKSAvIFdURjo6aG9sZExvY2tJZigpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjYxMzUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgV1RGOjpob2xk TG9jaygpIC8gV1RGOjpob2xkTG9ja0lmKCkgYmVjYXVzZSB0aGV5IGFyZSBub3QgY29tcGF0aWJs ZSB3aXRoCisgICAgICAgIENsYW5nIFRocmVhZCBTYWZldHkgQW5hbHlzaXMuIEFsbCBjYWxsIHNp dGVzIGhhdmUgYmVlbiBjb252ZXJ0ZWQgdG8gdXNlIHRoZSBMb2NrZXIKKyAgICAgICAgY29uc3Ry dWN0b3IgZGlyZWN0bHkuCisKKyAgICAgICAgKiB3dGYvTG9ja2VyLmg6CisKIDIwMjEtMDUtMjEg IENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgQ2hlY2tlZENv bmRpdGlvbiBpbiBtb3JlIHBsYWNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGU5Y2MxZWEzMmRkZjhiYmVjMzlm ZTMzNTM2MzE3NzU3YjBhZTJmYzAuLjI3OTU2YThjZTMxNDJiZjcxY2JjZGJkYWZiNzRhNDQwZTI3 NDU1MGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAyMS0wNS0yMSAgQ2hyaXMgRHVt ZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBXVEY6OmhvbGRMb2NrKCkg LyBXVEY6OmhvbGRMb2NrSWYoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjI2MTM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUmVtb3ZlIFdURjo6aG9sZExvY2soKSAvIFdURjo6aG9sZExvY2tJZigpIGJl Y2F1c2UgdGhleSBhcmUgbm90IGNvbXBhdGlibGUgd2l0aAorICAgICAgICBDbGFuZyBUaHJlYWQg U2FmZXR5IEFuYWx5c2lzLiBBbGwgY2FsbCBzaXRlcyBoYXZlIGJlZW4gY29udmVydGVkIHRvIHVz ZSB0aGUgTG9ja2VyCisgICAgICAgIGNvbnN0cnVjdG9yIGRpcmVjdGx5LgorCisgICAgICAgICog ZG9tL05vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZTo6ZXZlbnRUYXJnZXREYXRhQ29u Y3VycmVudGx5KToKKwogMjAyMS0wNS0yMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29t PgogCiAgICAgICAgIEZpeCBsb2NraW5nIGlzc3VlIGZvciBBdWRpb0Rlc3RpbmF0aW9uQ29jb2E6 Om1faXNQbGF5aW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Mb2Nr RHVyaW5nTWFya2luZy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTG9ja0R1cmluZ01h cmtpbmcuaAppbmRleCBhM2VjYTVlYzRiZWM2MDY1YmRkZTFmNDE5MzIxMjBiM2FhYjliOTIzLi5m YzI0NjhmNmY0MjI4ZGI0OTEyN2E2Y2ZiNjAxNjdhOWRmYTJmMjU4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Mb2NrRHVyaW5nTWFya2luZy5oCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9oZWFwL0xvY2tEdXJpbmdNYXJraW5nLmgKQEAgLTM1LDcgKzM1LDcgQEAg bmFtZXNwYWNlIEpTQyB7CiB0ZW1wbGF0ZTx0eXBlbmFtZSBMb2NrVHlwZT4KIGF1dG8gbG9ja0R1 cmluZ01hcmtpbmcoSGVhcCYgaGVhcCwgTG9ja1R5cGUmIHBhc3NlZExvY2spCiB7Ci0gICAgcmV0 dXJuIGhvbGRMb2NrSWYocGFzc2VkTG9jaywgaGVhcC5tdXRhdG9yU2hvdWxkQmVGZW5jZWQoKSk7 CisgICAgcmV0dXJuIExvY2tlciB7IGhlYXAubXV0YXRvclNob3VsZEJlRmVuY2VkKCkgPyAmcGFz c2VkTG9jayA6IG51bGxwdHIgfTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgSlNDCmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL3d0Zi9Mb2NrZXIuaCBiL1NvdXJjZS9XVEYvd3RmL0xvY2tlci5oCmluZGV4 IDFmMzMxMTAzN2E5ZDQ1MTI3MGI4ZDc5NzJhZWNmZmU5ZGRiMmVjZGEuLjhiMGUxOTJiNWViYTRi ODg3NjNhODQ0ZDFlYzBjYmExNGMwYzk4OGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0xv Y2tlci5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0xvY2tlci5oCkBAIC0xMzYsMjQgKzEzNiw2IEBA IHByaXZhdGU6CiAgICAgVCogbV9sb2NrYWJsZTsKIH07CiAKLS8vIFVzZSB0aGlzIGxvY2sgc2Nv cGUgbGlrZSBzbzoKLS8vIGF1dG8gbG9ja2VyID0gaG9sZExvY2sobG9jayk7Ci10ZW1wbGF0ZTx0 eXBlbmFtZSBMb2NrVHlwZT4KLUxvY2tlcjxMb2NrVHlwZT4gaG9sZExvY2soTG9ja1R5cGUmKSBX QVJOX1VOVVNFRF9SRVRVUk47Ci10ZW1wbGF0ZTx0eXBlbmFtZSBMb2NrVHlwZT4KLUxvY2tlcjxM b2NrVHlwZT4gaG9sZExvY2soTG9ja1R5cGUmIGxvY2spCi17Ci0gICAgcmV0dXJuIExvY2tlcjxM b2NrVHlwZT4obG9jayk7Ci19Ci0KLXRlbXBsYXRlPHR5cGVuYW1lIExvY2tUeXBlPgotTG9ja2Vy PExvY2tUeXBlPiBob2xkTG9ja0lmKExvY2tUeXBlJiwgYm9vbCBwcmVkaWNhdGUpIFdBUk5fVU5V U0VEX1JFVFVSTjsKLXRlbXBsYXRlPHR5cGVuYW1lIExvY2tUeXBlPgotTG9ja2VyPExvY2tUeXBl PiBob2xkTG9ja0lmKExvY2tUeXBlJiBsb2NrLCBib29sIHByZWRpY2F0ZSkKLXsKLSAgICByZXR1 cm4gTG9ja2VyPExvY2tUeXBlPihwcmVkaWNhdGUgPyAmbG9jayA6IG51bGxwdHIpOwotfQotCiB0 ZW1wbGF0ZTx0eXBlbmFtZSBMb2NrVHlwZT4KIExvY2tlcjxMb2NrVHlwZT4gdHJ5SG9sZExvY2so TG9ja1R5cGUmKSBXQVJOX1VOVVNFRF9SRVRVUk47CiB0ZW1wbGF0ZTx0eXBlbmFtZSBMb2NrVHlw ZT4KQEAgLTE4Nyw2ICsxNjksNCBAQCB1c2luZyBXVEY6OkFic3RyYWN0TG9ja2VyOwogdXNpbmcg V1RGOjpMb2NrZXI7CiB1c2luZyBXVEY6Ok5vTG9ja2luZ05lY2Vzc2FyeVRhZzsKIHVzaW5nIFdU Rjo6Tm9Mb2NraW5nTmVjZXNzYXJ5OwotdXNpbmcgV1RGOjpob2xkTG9jazsKLXVzaW5nIFdURjo6 aG9sZExvY2tJZjsKIHVzaW5nIFdURjo6RHJvcExvY2tGb3JTY29wZTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcApp bmRleCA5MTY5M2I0MjljM2UyZTIxNmM3NGM2MWI2MTQ2YmUzNDYxZTk0OTUyLi43ZWFlM2ExMWFl Y2ZiMmFhZDk5ZmYxOTJiNDU4N2Q5Njc1Y2ZkZmI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9kb20vTm9kZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCkBAIC0yMjI3 LDcgKzIyMjcsNyBAQCBFdmVudFRhcmdldERhdGEqIE5vZGU6OmV2ZW50VGFyZ2V0RGF0YUNvbmN1 cnJlbnRseSgpCiAgICAgLy8gd29ybGQgaXMgc3RvcHBlZC4gV2UgZG9uJ3QgaGF2ZSB0byBob2xk IHRoZSBsb2NrIHdoZW4gdGhlIHdvcmxkIGlzIHN0b3BwZWQsIGJlY2F1c2UgYSBzdG9wcGVkIHdv cmxkCiAgICAgLy8gbWVhbnMgdGhhdCB3ZSB3aWxsIG5ldmVyIG11dGF0ZSB0aGUgZXZlbnQgdGFy Z2V0IGRhdGEgbWFwLgogICAgIEpTQzo6Vk0qIHZtID0gY29tbW9uVk1Pck51bGwoKTsKLSAgICBh dXRvIGxvY2tlciA9IGhvbGRMb2NrSWYoc19ldmVudFRhcmdldERhdGFNYXBMb2NrLCB2bSAmJiB2 bS0+aGVhcC53b3JsZElzUnVubmluZygpKTsKKyAgICBMb2NrZXIgbG9ja2VyIHsgdm0gJiYgdm0t PmhlYXAud29ybGRJc1J1bm5pbmcoKSA/ICZzX2V2ZW50VGFyZ2V0RGF0YU1hcExvY2sgOiBudWxs cHRyIH07CiAgICAgcmV0dXJuIGhhc0V2ZW50VGFyZ2V0RGF0YSgpID8gZXZlbnRUYXJnZXREYXRh TWFwKCkuZ2V0KHRoaXMpIDogbnVsbHB0cjsKIH0KIAo=