226129 2021-05-21 18:14:32 -0700 Fix locking issue for AudioDestinationCocoa::m_isPlaying 2021-05-21 21:25:20 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez cdumez eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1762704 0 cdumez 2021-05-21 18:14:32 -0700 Fix locking issue for AudioDestinationCocoa::m_isPlaying. The AudioDestinationCocoa::isPlaying() getter fails to lock. isPlaying() may get called from the main thread and the audio rendering thread. 1762705 1 429381 cdumez 2021-05-21 18:18:29 -0700 Created attachment 429381 Patch 1762745 2 429394 cdumez 2021-05-21 20:14:10 -0700 Created attachment 429394 Patch 1762750 3 ews-feeder 2021-05-21 21:24:32 -0700 Committed r277910 (238043@main): <https://commits.webkit.org/238043@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429394. 1762751 4 webkit-bug-importer 2021-05-21 21:25:20 -0700 <rdar://problem/78342090> 429381 2021-05-21 18:18:29 -0700 2021-05-21 20:14:08 -0700 Patch bug-226129-20210521181828.patch text/plain 2957 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3OTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTlkMmI2NzMzYmY4Mjc5 MGU3NjNkZDAwYzQ1NjNjOTUxNWJhZTBiZC4uMzRlMWQ4NjI0MTEzMTBlNDAxOWNlZmYzNzNhNzI2 ZTJiNmY2NGMyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA1LTIxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGxvY2tpbmcgaXNzdWUg Zm9yIEF1ZGlvRGVzdGluYXRpb25Db2NvYTo6bV9pc1BsYXlpbmcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjEyOQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBsb2NraW5nIGlzc3VlIGZvciBBdWRp b0Rlc3RpbmF0aW9uQ29jb2E6Om1faXNQbGF5aW5nLiBUaGUgQXVkaW9EZXN0aW5hdGlvbkNvY29h Ojppc1BsYXlpbmcoKQorICAgICAgICBnZXR0ZXIgZmFpbHMgdG8gbG9jay4gaXNQbGF5aW5nKCkg bWF5IGdldCBjYWxsZWQgZnJvbSB0aGUgbWFpbiB0aHJlYWQgYW5kIHRoZSBhdWRpbyByZW5kZXJp bmcKKyAgICAgICAgdGhyZWFkLiBTaW5jZSB3ZSBjYW5ub3QgZ3JhYiBhIGxvY2sgb24gdGhlIHJl bmRlcmluZyB0aHJlYWQsIHVzZSBzdGQ6OmF0b21pYzxib29sPiB0eXBlIGZvcgorICAgICAgICBt X2lzUGxheWluZy4KKworICAgICAgICAqIHBsYXRmb3JtL2F1ZGlvL2NvY29hL0F1ZGlvRGVzdGlu YXRpb25Db2NvYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0Rlc3RpbmF0aW9uQ29jb2E6 OnNldElzUGxheWluZyk6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0Rlc3RpbmF0aW9uQ29jb2E6 OnJlbmRlck9uUmVuZGVyaW5nVGhlYWRJZlBsYXlpbmcpOgorICAgICAgICAqIHBsYXRmb3JtL2F1 ZGlvL2NvY29hL0F1ZGlvRGVzdGluYXRpb25Db2NvYS5oOgorCiAyMDIxLTA1LTIxICBEaWVnbyBQ aW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CiAKICAgICAgICAgU2V0IENhbnZhc0ltYWdl U21vb3RoaW5nLmltYWdlU21vb3RoaW5nUXVhbGl0eSB2YWx1ZSB0byAnbG93JyBhcyBkZWZhdWx0 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9jb2NvYS9BdWRpb0Rl c3RpbmF0aW9uQ29jb2EuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vY29jb2Ev QXVkaW9EZXN0aW5hdGlvbkNvY29hLmNwcAppbmRleCBlNTg5MTRkOThjOTZhOTA3YzE1Zjk2M2Y3 N2I4NDEyYTE5NzZmZDgzLi5kZmM0MzhlMWI0MTY3NzMwMmI1MTRmNzY1MDNlMTQ2Y2RkMTU4ODQ4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9jb2NvYS9BdWRpb0Rl c3RpbmF0aW9uQ29jb2EuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2Nv Y29hL0F1ZGlvRGVzdGluYXRpb25Db2NvYS5jcHAKQEAgLTE1MSwxMyArMTUxLDExIEBAIHZvaWQg QXVkaW9EZXN0aW5hdGlvbkNvY29hOjpzdG9wUmVuZGVyaW5nKENvbXBsZXRpb25IYW5kbGVyPHZv aWQoYm9vbCk+JiYgY29tcGxlCiB2b2lkIEF1ZGlvRGVzdGluYXRpb25Db2NvYTo6c2V0SXNQbGF5 aW5nKGJvb2wgaXNQbGF5aW5nKQogewogICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7Ci0gICAg ewotICAgICAgICBhdXRvIGxvY2tlciA9IGhvbGRMb2NrKG1faXNQbGF5aW5nTG9jayk7Ci0gICAg ICAgIGlmIChtX2lzUGxheWluZyA9PSBpc1BsYXlpbmcpCi0gICAgICAgICAgICByZXR1cm47CiAK LSAgICAgICAgbV9pc1BsYXlpbmcgPSBpc1BsYXlpbmc7Ci0gICAgfQorICAgIGlmIChtX2lzUGxh eWluZyA9PSBpc1BsYXlpbmcpCisgICAgICAgIHJldHVybjsKKworICAgIG1faXNQbGF5aW5nID0g aXNQbGF5aW5nOwogCiAgICAgewogICAgICAgICBMb2NrZXIgbG9ja2VyIHsgbV9jYWxsYmFja0xv Y2sgfTsKQEAgLTIzOCw4ICsyMzYsNyBAQCBPU1N0YXR1cyBBdWRpb0Rlc3RpbmF0aW9uQ29jb2E6 OnJlbmRlcihkb3VibGUgc2FtcGxlVGltZSwgdWludDY0X3QgaG9zdFRpbWUsIFVJbgogCiB2b2lk IEF1ZGlvRGVzdGluYXRpb25Db2NvYTo6cmVuZGVyT25SZW5kZXJpbmdUaGVhZElmUGxheWluZyhz aXplX3QgZnJhbWVzVG9SZW5kZXIpCiB7Ci0gICAgYXV0byBsb2NrZXIgPSB0cnlIb2xkTG9jayht X2lzUGxheWluZ0xvY2spOwotICAgIGlmIChsb2NrZXIgJiYgbV9pc1BsYXlpbmcpCisgICAgaWYg KG1faXNQbGF5aW5nKQogICAgICAgICByZW5kZXJPblJlbmRlcmluZ1RoZWFkKGZyYW1lc1RvUmVu ZGVyKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vY29j b2EvQXVkaW9EZXN0aW5hdGlvbkNvY29hLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRp by9jb2NvYS9BdWRpb0Rlc3RpbmF0aW9uQ29jb2EuaAppbmRleCA1ZDEyMzkyYmU4MWU3MGIyZmMw ZTIzNjYzZjUwMzU0NmQ0NzQxOGVjLi42OTkwNTM0YTUzYjNjYTJhNTExNzcxYmIzNGEzOTYzYTIy MmUyZDRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9jb2NvYS9B dWRpb0Rlc3RpbmF0aW9uQ29jb2EuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRp by9jb2NvYS9BdWRpb0Rlc3RpbmF0aW9uQ29jb2EuaApAQCAtOTYsOCArOTYsNyBAQCBwcml2YXRl OgogCiAgICAgZmxvYXQgbV9jb250ZXh0U2FtcGxlUmF0ZTsKIAotICAgIExvY2sgbV9pc1BsYXlp bmdMb2NrOwotICAgIGJvb2wgbV9pc1BsYXlpbmcgeyBmYWxzZSB9OworICAgIHN0ZDo6YXRvbWlj PGJvb2w+IG1faXNQbGF5aW5nOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo= 429394 2021-05-21 20:14:10 -0700 2021-05-21 21:24:33 -0700 Patch bug-226129-20210521201409.patch text/plain 2958 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3OTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmIwNWNhYjAwNjRmMjM3 YmU4YzU0YTBkMTY1YWFiNGNmMDJlNTA0OC4uZTljYzFlYTMyZGRmOGJiZWMzOWZlMzM1MzYzMTc3 NTdiMGFlMmZjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA1LTIxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGxvY2tpbmcgaXNzdWUg Zm9yIEF1ZGlvRGVzdGluYXRpb25Db2NvYTo6bV9pc1BsYXlpbmcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjEyOQorCisgICAgICAgIFJldmlld2Vk IGJ5IEplciBOb2JsZS4KKworICAgICAgICBGaXggbG9ja2luZyBpc3N1ZSBmb3IgQXVkaW9EZXN0 aW5hdGlvbkNvY29hOjptX2lzUGxheWluZy4gVGhlIEF1ZGlvRGVzdGluYXRpb25Db2NvYTo6aXNQ bGF5aW5nKCkKKyAgICAgICAgZ2V0dGVyIGZhaWxzIHRvIGxvY2suIGlzUGxheWluZygpIG1heSBn ZXQgY2FsbGVkIGZyb20gdGhlIG1haW4gdGhyZWFkIGFuZCB0aGUgYXVkaW8gcmVuZGVyaW5nCisg ICAgICAgIHRocmVhZC4gU2luY2Ugd2UgY2Fubm90IGdyYWIgYSBsb2NrIG9uIHRoZSByZW5kZXJp bmcgdGhyZWFkLCB1c2Ugc3RkOjphdG9taWM8Ym9vbD4gdHlwZSBmb3IKKyAgICAgICAgbV9pc1Bs YXlpbmcuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9jb2NvYS9BdWRpb0Rlc3RpbmF0aW9u Q29jb2EuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9EZXN0aW5hdGlvbkNvY29hOjpzZXRJ c1BsYXlpbmcpOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9EZXN0aW5hdGlvbkNvY29hOjpyZW5k ZXJPblJlbmRlcmluZ1RoZWFkSWZQbGF5aW5nKToKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9j b2NvYS9BdWRpb0Rlc3RpbmF0aW9uQ29jb2EuaDoKKwogMjAyMS0wNS0yMSAgQ2hyaXMgRHVtZXog IDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFN0b3AgdXNpbmcgaG9sZExvY2soKSBpbiBX ZWJDb3JlIGFzIGl0IGlzIG5vdCBjb21wYXRpYmxlIHdpdGggQ2xhbmcgdGhyZWFkIHNhZmV0eSBh bmFseXNpcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vY29jb2Ev QXVkaW9EZXN0aW5hdGlvbkNvY29hLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlv L2NvY29hL0F1ZGlvRGVzdGluYXRpb25Db2NvYS5jcHAKaW5kZXggYjRjYzEzZGJkYjhlZjNjYmRk YmY2OTVjYTYyNmQ5MmU0MTBhNmMzZi4uYzBlMDhjYTk1NmU1ZTg1NDA3OTBiNWJjNzRhMzlmZTZh NDljNzIzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vY29jb2Ev QXVkaW9EZXN0aW5hdGlvbkNvY29hLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9h dWRpby9jb2NvYS9BdWRpb0Rlc3RpbmF0aW9uQ29jb2EuY3BwCkBAIC0xNTEsMTMgKzE1MSwxMSBA QCB2b2lkIEF1ZGlvRGVzdGluYXRpb25Db2NvYTo6c3RvcFJlbmRlcmluZyhDb21wbGV0aW9uSGFu ZGxlcjx2b2lkKGJvb2wpPiYmIGNvbXBsZQogdm9pZCBBdWRpb0Rlc3RpbmF0aW9uQ29jb2E6OnNl dElzUGxheWluZyhib29sIGlzUGxheWluZykKIHsKICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkp OwotICAgIHsKLSAgICAgICAgTG9ja2VyIGxvY2tlciB7IG1faXNQbGF5aW5nTG9jayB9OwotICAg ICAgICBpZiAobV9pc1BsYXlpbmcgPT0gaXNQbGF5aW5nKQotICAgICAgICAgICAgcmV0dXJuOwog Ci0gICAgICAgIG1faXNQbGF5aW5nID0gaXNQbGF5aW5nOwotICAgIH0KKyAgICBpZiAobV9pc1Bs YXlpbmcgPT0gaXNQbGF5aW5nKQorICAgICAgICByZXR1cm47CisKKyAgICBtX2lzUGxheWluZyA9 IGlzUGxheWluZzsKIAogICAgIHsKICAgICAgICAgTG9ja2VyIGxvY2tlciB7IG1fY2FsbGJhY2tM b2NrIH07CkBAIC0yMzgsOCArMjM2LDcgQEAgT1NTdGF0dXMgQXVkaW9EZXN0aW5hdGlvbkNvY29h OjpyZW5kZXIoZG91YmxlIHNhbXBsZVRpbWUsIHVpbnQ2NF90IGhvc3RUaW1lLCBVSW4KIAogdm9p ZCBBdWRpb0Rlc3RpbmF0aW9uQ29jb2E6OnJlbmRlck9uUmVuZGVyaW5nVGhlYWRJZlBsYXlpbmco c2l6ZV90IGZyYW1lc1RvUmVuZGVyKQogewotICAgIGF1dG8gbG9ja2VyID0gdHJ5SG9sZExvY2so bV9pc1BsYXlpbmdMb2NrKTsKLSAgICBpZiAobG9ja2VyICYmIG1faXNQbGF5aW5nKQorICAgIGlm IChtX2lzUGxheWluZykKICAgICAgICAgcmVuZGVyT25SZW5kZXJpbmdUaGVhZChmcmFtZXNUb1Jl bmRlcik7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2Nv Y29hL0F1ZGlvRGVzdGluYXRpb25Db2NvYS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVk aW8vY29jb2EvQXVkaW9EZXN0aW5hdGlvbkNvY29hLmgKaW5kZXggNWQxMjM5MmJlODFlNzBiMmZj MGUyMzY2M2Y1MDM1NDZkNDc0MThlYy4uNjk5MDUzNGE1M2IzY2EyYTUxMTc3MWJiMzRhMzk2M2Ey MjJlMmQ0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vY29jb2Ev QXVkaW9EZXN0aW5hdGlvbkNvY29hLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVk aW8vY29jb2EvQXVkaW9EZXN0aW5hdGlvbkNvY29hLmgKQEAgLTk2LDggKzk2LDcgQEAgcHJpdmF0 ZToKIAogICAgIGZsb2F0IG1fY29udGV4dFNhbXBsZVJhdGU7CiAKLSAgICBMb2NrIG1faXNQbGF5 aW5nTG9jazsKLSAgICBib29sIG1faXNQbGF5aW5nIHsgZmFsc2UgfTsKKyAgICBzdGQ6OmF0b21p Yzxib29sPiBtX2lzUGxheWluZzsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK