226120 2021-05-21 16:16:04 -0700 All Netflix playback fails after r277740 2021-05-21 19:07:26 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=225920 InRadar P2 Normal --- 1 eric.carlson sam sam webkit-bug-importer oldest_to_newest 1762643 0 eric.carlson 2021-05-21 16:16:04 -0700 All Netflix playback fails with error S7399-1260 after r277740 1762645 1 webkit-bug-importer 2021-05-21 16:19:19 -0700 <rdar://problem/78333782> 1762701 2 sam 2021-05-21 18:04:55 -0700 I think I spotted the issue. Missing ! in CDMInstanceFairPlayStreamingAVFObjC.mm: auto keyIDVector = base64Decode(keyIDString); - if (keyIDVector) + if (!keyIDVector) return false; Testing a fix now. 1762711 3 429382 sam 2021-05-21 18:35:34 -0700 Created attachment 429382 Patch 1762712 4 sam 2021-05-21 18:36:06 -0700 Is there anyway to test this code path currently? 1762719 5 ews-feeder 2021-05-21 19:07:24 -0700 Committed r277905 (238038@main): <https://commits.webkit.org/238038@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429382. 429382 2021-05-21 18:35:34 -0700 2021-05-21 19:07:25 -0700 Patch bug-226120-20210521183533.patch text/plain 1467 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3NzkwMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA1LTIxICBTYW0gV2Vp bmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KKworICAgICAgICBBbGwgTmV0ZmxpeCBwbGF5YmFjayBm YWlscyBhZnRlciByMjc3NzQwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjYxMjAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc4MzMzNzgyPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvQ0RNSW5zdGFuY2VGYWlyUGxheVN0cmVhbWluZ0FW Rk9iakMubW06CisgICAgICAgIChXZWJDb3JlOjpDRE1JbnN0YW5jZVNlc3Npb25GYWlyUGxheVN0 cmVhbWluZ0FWRk9iakM6OnVwZGF0ZUxpY2Vuc2UpOgorICAgICAgICBBZGQgbWlzc2luZyAhLgor CiAyMDIxLTA1LTIxICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CiAKICAg ICAgICAgU2V0IENhbnZhc0ltYWdlU21vb3RoaW5nLmltYWdlU21vb3RoaW5nUXVhbGl0eSB2YWx1 ZSB0byAnbG93JyBhcyBkZWZhdWx0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9hdmZvdW5kYXRpb24vb2JqYy9DRE1JbnN0YW5jZUZhaXJQbGF5U3RyZWFtaW5nQVZGT2Jq Qy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZv dW5kYXRpb24vb2JqYy9DRE1JbnN0YW5jZUZhaXJQbGF5U3RyZWFtaW5nQVZGT2JqQy5tbQkocmV2 aXNpb24gMjc3OTAyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3Vu ZGF0aW9uL29iamMvQ0RNSW5zdGFuY2VGYWlyUGxheVN0cmVhbWluZ0FWRk9iakMubW0JKHdvcmtp bmcgY29weSkKQEAgLTg1MSw3ICs4NTEsNyBAQCB2b2lkIENETUluc3RhbmNlU2Vzc2lvbkZhaXJQ bGF5U3RyZWFtaW5nCiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgICAgICAg ICBhdXRvIGtleUlEVmVjdG9yID0gYmFzZTY0RGVjb2RlKGtleUlEU3RyaW5nKTsKLSAgICAgICAg ICAgIGlmIChrZXlJRFZlY3RvcikKKyAgICAgICAgICAgIGlmICgha2V5SURWZWN0b3IpCiAgICAg ICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgICAgICAgICBhdXRvIGtleUlEID0gU2hh cmVkQnVmZmVyOjpjcmVhdGUoV1RGTW92ZSgqa2V5SURWZWN0b3IpKTsK