22612 2008-12-02 17:25:29 -0800 Add test to verify type enforcement in DOM setters 2008-12-19 13:18:52 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pam abarth abarth oldest_to_newest 101127 0 pam 2008-12-02 17:25:29 -0800 Another test. 101129 1 25695 pam 2008-12-02 17:28:18 -0800 Created attachment 25695 New test + result This test could be made much more comprehensive, but to be honest, I don't know enough about underlying DOM structure to know what ought to be possible and what not. These are the only two examples we actually encountered in the wild. 101209 2 darin 2008-12-03 09:11:27 -0800 (In reply to comment #1) > This test could be made much more comprehensive, but to be honest, I don't know > enough about underlying DOM structure to know what ought to be possible and > what not. Our usual approach is to make a more comprehensive test without worrying unduly about whether the current behavior is correct or not -- a regression test has lots of value even if it has to be revised later once we understand what's correct and what's not. So my approach if I was writing a test would be to make a long list of functions and make a test that covers them as completely as possible. I'll review this soon; although someone else is welcome to. Still wading through a lot of correspondence after my return from "vacation". 101327 3 25695 darin 2008-12-04 09:16:23 -0800 Comment on attachment 25695 New test + result For a test like this, the preferred form is to have the entire test in a .js file and let the make-js-test-wrappers test create a boilerplate wrapper. It's a little strange to have this test only these two specific setters. It would be way better to have something that made an attempt to be exhaustive. r=me 102790 4 abarth 2008-12-17 11:22:50 -0800 Will land. 102796 5 pam 2008-12-17 11:55:52 -0800 Sorry for leaving this on the queue. I was hoping to write a more complete test, but I've since gotten mired in other things and won't be getting back to this for a bit. So you're welcome to land it; I'll improve it later. 102807 6 abarth 2008-12-17 13:41:21 -0800 LayoutTests/ChangeLog: locally modified LayoutTests/fast/dom/null-document-xmlhttprequest-open.html: locally modified LayoutTests/fast/dom/xmlhttprequest-invalid-values.html: locally modified M LayoutTests/ChangeLog A fast/dom/setter-type-enforcement-expected.txt A fast/dom/setter-type-enforcement.html Committed r39363 A fast/dom/setter-type-enforcement-expected.txt A fast/dom/setter-type-enforcement.html M LayoutTests/ChangeLog r39363 = 6e34f4ececac5729488eae7cb0d6359322c15107 (trunk) 102811 7 abarth 2008-12-17 13:42:38 -0800 No worries. It makes me feel useful to clean out some things in the commit queue. 102904 8 pam 2008-12-18 09:58:12 -0800 > A fast/dom/setter-type-enforcement-expected.txt > A fast/dom/setter-type-enforcement.html > M LayoutTests/ChangeLog Moved the tests from root level into LayoutTests/fast/dom/ in r39375. 102955 9 abarth 2008-12-18 19:14:30 -0800 Test fails on buildbot. I thought it passed on my machine, but I might have been mistaken. Here's the diff: --- layout-test-results/fast/dom/setter-type-enforcement-expected.txt 2008-12-18 18:04:24.000000000 -0800 +++ layout-test-results/fast/dom/setter-type-enforcement-actual.txt 2008-12-18 18:04:24.000000000 -0800 @@ -8,12 +8,6 @@ PASS successfullyParsed is true TEST COMPLETE - -Tests type enforcement on DOM setters. - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - PASS document.body = nodelist; threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3. PASS table.tHead = nodelist; threw exception Error: NOT_FOUND_ERR: DOM Exception 8. PASS successfullyParsed is true 103003 10 pam 2008-12-19 10:58:04 -0800 (In reply to comment #9) > Test fails on buildbot. I thought it passed on my machine, but I might have > been mistaken. Patching error. Both the test and the expected results in the repository were doubled copies of the patch attached here. See http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/setter-type-enforcement.html?rev=39375 http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/setter-type-enforcement-expected.txt?rev=39375 I'll resubmit corrected copies. 103004 11 pam 2008-12-19 11:12:02 -0800 Resubmitted in r39410. 103017 12 abarth 2008-12-19 13:18:52 -0800 (In reply to comment #10) > Patching error. Both the test and the expected results in the repository were > doubled copies of the patch attached here. See Oops. Sorry about that. I must have screwed up my pre-submit git rebase somehow. 25695 2008-12-02 17:28:18 -0800 2008-12-04 09:16:23 -0800 New test + result 22612a.txt text/plain 2152 pam SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4OTI3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTIt MDIgIFBhbWVsYSBHcmVlbmUgIDxwYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMjYxMgorICAgICAgICBBZGQgdGVzdCB0byB2ZXJpZnkgdHlwZSBlbmZv cmNlbWVudCBpbiBET00gc2V0dGVycy4KKworICAgICAgICAqIGZhc3QvZG9tL3NldHRlci10eXBl LWVuZm9yY2VtZW50LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20vc2V0 dGVyLXR5cGUtZW5mb3JjZW1lbnQuaHRtbDogQWRkZWQuCisKIDIwMDgtMTItMDIgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2 ZSBIeWF0dApJbmRleDogZmFzdC9kb20vc2V0dGVyLXR5cGUtZW5mb3JjZW1lbnQtZXhwZWN0ZWQu dHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIGZhc3QvZG9tL3NldHRlci10eXBlLWVuZm9yY2VtZW50LWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMCkKKysrIGZhc3QvZG9tL3NldHRlci10eXBlLWVuZm9yY2VtZW50 LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMSBAQAorVGVzdHMgdHlwZSBl bmZvcmNlbWVudCBvbiBET00gc2V0dGVycy4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEg c2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgor CisKK1BBU1MgZG9jdW1lbnQuYm9keSA9IG5vZGVsaXN0OyB0aHJldyBleGNlcHRpb24gRXJyb3I6 IEhJRVJBUkNIWV9SRVFVRVNUX0VSUjogRE9NIEV4Y2VwdGlvbiAzLgorUEFTUyB0YWJsZS50SGVh ZCA9IG5vZGVsaXN0OyB0aHJldyBleGNlcHRpb24gRXJyb3I6IE5PVF9GT1VORF9FUlI6IERPTSBF eGNlcHRpb24gOC4KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01Q TEVURQorCkluZGV4OiBmYXN0L2RvbS9zZXR0ZXItdHlwZS1lbmZvcmNlbWVudC5odG1sCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIGZhc3QvZG9tL3NldHRlci10eXBlLWVuZm9yY2VtZW50Lmh0bWwJKHJldmlzaW9u IDApCisrKyBmYXN0L2RvbS9zZXR0ZXItdHlwZS1lbmZvcmNlbWVudC5odG1sCShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDI2IEBACis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0 IiBocmVmPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9 Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9k eT4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisK KzxzY3JpcHQ+CitkZXNjcmlwdGlvbigiVGVzdHMgdHlwZSBlbmZvcmNlbWVudCBvbiBET00gc2V0 dGVycy4iKTsKKworLy8gTm9kZUxpc3QgaXMgbm90IGEgTm9kZSwgc28gZG9jdW1lbnQuYm9keSBj YW4ndCBiZSBzZXQgdG8gb25lLgordmFyIG5vZGVsaXN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNC eU5hbWUoJ3NpbGx5cGFudHMnKTsKK3Nob3VsZFRocm93KCJkb2N1bWVudC5ib2R5ID0gbm9kZWxp c3Q7Iik7CisKKy8vIE5vZGVMaXN0IGlzIGFsc28gbm90IGFuIEhUTUxUYWJsZVNlY3Rpb25FbGVt ZW50LgordmFyIHRhYmxlID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgndGFibGUnKTsKK3Nob3Vs ZFRocm93KCJ0YWJsZS50SGVhZCA9IG5vZGVsaXN0OyIpOworCit2YXIgc3VjY2Vzc2Z1bGx5UGFy c2VkID0gdHJ1ZTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10 ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgorCg==