226106 2021-05-21 13:27:51 -0700 [Cocoa] Expand IOKit method filters to cover items encountered during testing 2021-05-21 15:33:30 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham pvollan webkit-bug-importer oldest_to_newest 1762557 0 bfulgham 2021-05-21 13:27:51 -0700 As we gather more telemetry from systems running with IOKit method filters, we have identified additional methods that are needed for normal use cases. Per our plan, we will unblock those cases and consider further hardening in an follow-up patch once have worked with framework teams to reduce these needs. 1762574 1 webkit-bug-importer 2021-05-21 14:04:59 -0700 <rdar://problem/78327511> 1762576 2 429337 bfulgham 2021-05-21 14:06:20 -0700 Created attachment 429337 Patch 1762590 3 429337 pvollan 2021-05-21 14:23:58 -0700 Comment on attachment 429337 Patch Great! R=me. 1762605 4 429337 pvollan 2021-05-21 14:53:27 -0700 Comment on attachment 429337 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429337&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:294 > + 39 > + 40 Should these be under IOSurfaceRootUserClient instead? 1762606 5 429337 pvollan 2021-05-21 14:55:11 -0700 Comment on attachment 429337 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429337&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:447 > + 38 Is 42 also needed here? 1762609 6 429337 bfulgham 2021-05-21 15:04:50 -0700 Comment on attachment 429337 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429337&action=review >> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:294 >> + 40 > > Should these be under IOSurfaceRootUserClient instead? No -- these were shown in telemetry to be used by AGXDeviceUserClient, but not by IOSurfaceRootUserClient. >> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:447 >> + 38 > > Is 42 also needed here? No -- but it is needed for AGXDeviceUserClient, whoops! I'll fix that before landing. 1762610 7 429348 bfulgham 2021-05-21 15:05:25 -0700 Created attachment 429348 Patch for landing 1762620 8 ews-feeder 2021-05-21 15:33:29 -0700 Committed r277894 (238030@main): <https://commits.webkit.org/238030@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429348. 429337 2021-05-21 14:06:20 -0700 2021-05-21 15:05:23 -0700 Patch bug-226106-20210521140619.patch text/plain 2213 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3ODgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDY2MjIzNWNjYzM1Yjg0YThl NGUzM2E1OGI2ZWNjMGMxMjBiMjU4YmMuLjU0NzcwNDdiNjdkNWEzMmVhOTc3MjQ1OTU2YjBmMzdi YmEwMTFmNzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDUtMjEgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBFeHBhbmQgSU9L aXQgbWV0aG9kIGZpbHRlcnMgdG8gY292ZXIgaXRlbXMgZW5jb3VudGVyZWQgZHVyaW5nIHRlc3Rp bmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjEw NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzgzMjc1MTE+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsb3cgYWRkaXRpb25hbCBJT0tpdCBtZXRo b2RzIGJhc2VkIG9uIHRlc3RpbmcgcmVzdWx0cyBhbmQgdGhlIG1ldGhvZCB2YWx1ZXMgd2UgaGl0 IGR1cmluZyBub3JtYWwgb3BlcmF0aW9ucy4KKworICAgICAgICAqIFJlc291cmNlcy9TYW5kYm94 UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYjoKKyAgICAgICAgKiBX ZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluOgorCiAyMDIxLTA1LTIxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBVbmFibGUgdG8g dXBsb2FkIGZpbGVzIHRoYXQgYXJlIHN0b3JlZCBpbiB0aGUgY2xvdWQgKHdpdGhvdXQgYSBsb2Nh bCBjb3B5KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2Zp bGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IgYi9Tb3VyY2UvV2ViS2l0L1Jl c291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5z YgppbmRleCAxM2U2ZmFkOTNhMTMxYzU5OGQxMjFiYTU2MzJmMjkzMzQ0NWNmNjhiLi4xZDRmNjE1 Mjk2NTYyMDQyNTUzMTg0ZjM2MjAzNzhkYzU0MmU4NGMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29u dGVudC5zYgorKysgYi9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9z L2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgpAQCAtMjkwLDYgKzI5MCw4IEBACiAgICAg ICAgICAgICAgICAgICAgICAgICAyNwogICAgICAgICAgICAgICAgICAgICAgICAgMzYKICAgICAg ICAgICAgICAgICAgICAgICAgIDM4CisgICAgICAgICAgICAgICAgICAgICAgICAzOQorICAgICAg ICAgICAgICAgICAgICAgICAgNDAKICAgICAgICAgICAgICAgICAgICAgICAgIDQ0CiAgICAgICAg ICAgICAgICAgICAgICkKICAgICAgICAgICAgICAgICApCkBAIC00NDIsNiArNDQ0LDcgQEAKICAg ICAgICAgICAgICAgICAgICAgMzQKICAgICAgICAgICAgICAgICAgICAgMzUKICAgICAgICAgICAg ICAgICAgICAgMzYKKyAgICAgICAgICAgICAgICAgICAgMzgKICAgICAgICAgICAgICAgICApCiAg ICAgICAgICAgICApCiAgICAgICAgICkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbiBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgppbmRleCA5OWJhYWU2OTc1Mjk3MDJiMzU3MjEw YzEwMzJmYzAxMzQ5NTY4MmFlLi4yYmFmMjMwODNjMzcyMTcwYTdlMDQyZDczZDk2ZjFmZTAxZTlm ZWJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlBy b2Nlc3Muc2IuaW4KKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQ cm9jZXNzLnNiLmluCkBAIC0xNjUsNiArMTY1LDcgQEAKICAgICAgICAgICAgICAgICAyNjMKICAg ICAgICAgICAgICAgICAyNjUKICAgICAgICAgICAgICAgICAyNjcKKyAgICAgICAgICAgICAgICAy NjgKICAgICAgICAgICAgICAgICA1MTIKICAgICAgICAgICAgICkKICNlbmRpZgo= 429348 2021-05-21 15:05:25 -0700 2021-05-21 15:33:30 -0700 Patch for landing bug-226106-20210521150524.patch text/plain 2242 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3ODgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDY2MjIzNWNjYzM1Yjg0YThl NGUzM2E1OGI2ZWNjMGMxMjBiMjU4YmMuLjNlZGQzMjVjZWZjZjA3MjcyMmRjN2M5MjEyNmZkOTAz NjM0M2U2MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDUtMjEgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBFeHBhbmQgSU9L aXQgbWV0aG9kIGZpbHRlcnMgdG8gY292ZXIgaXRlbXMgZW5jb3VudGVyZWQgZHVyaW5nIHRlc3Rp bmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjEw NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzgzMjc1MTE+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgUGVyIEFybmUgVm9sbGFuLgorCisgICAgICAgIEFsbG93IGFkZGl0aW9uYWwgSU9LaXQgbWV0 aG9kcyBiYXNlZCBvbiB0ZXN0aW5nIHJlc3VsdHMgYW5kIHRoZSBtZXRob2QgdmFsdWVzIHdlIGhp dCBkdXJpbmcgbm9ybWFsIG9wZXJhdGlvbnMuCisKKyAgICAgICAgKiBSZXNvdXJjZXMvU2FuZGJv eFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2I6CisgICAgICAgICog V2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbjoKKwogMjAyMS0wNS0yMSAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gVW5hYmxlIHRv IHVwbG9hZCBmaWxlcyB0aGF0IGFyZSBzdG9yZWQgaW4gdGhlIGNsb3VkICh3aXRob3V0IGEgbG9j YWwgY29weSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9m aWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiIGIvU291cmNlL1dlYktpdC9S ZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQu c2IKaW5kZXggMTNlNmZhZDkzYTEzMWM1OThkMTIxYmE1NjMyZjI5MzM0NDVjZjY4Yi4uMzc4YTBj MmNmOGFkMzcxMjc3YTEwZmU2OGZmMDQ4Y2UwYjAwZGFiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNv bnRlbnQuc2IKKysrIGIvU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lv cy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IKQEAgLTI5MCw2ICsyOTAsOSBAQAogICAg ICAgICAgICAgICAgICAgICAgICAgMjcKICAgICAgICAgICAgICAgICAgICAgICAgIDM2CiAgICAg ICAgICAgICAgICAgICAgICAgICAzOAorICAgICAgICAgICAgICAgICAgICAgICAgMzkKKyAgICAg ICAgICAgICAgICAgICAgICAgIDQwCisgICAgICAgICAgICAgICAgICAgICAgICA0MgogICAgICAg ICAgICAgICAgICAgICAgICAgNDQKICAgICAgICAgICAgICAgICAgICAgKQogICAgICAgICAgICAg ICAgICkKQEAgLTQ0Miw2ICs0NDUsNyBAQAogICAgICAgICAgICAgICAgICAgICAzNAogICAgICAg ICAgICAgICAgICAgICAzNQogICAgICAgICAgICAgICAgICAgICAzNgorICAgICAgICAgICAgICAg ICAgICAzOAogICAgICAgICAgICAgICAgICkKICAgICAgICAgICAgICkKICAgICAgICAgKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNi LmluIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmlu CmluZGV4IDk5YmFhZTY5NzUyOTcwMmIzNTcyMTBjMTAzMmZjMDEzNDk1NjgyYWUuLjJiYWYyMzA4 M2MzNzIxNzBhN2UwNDJkNzNkOTZmMWZlMDFlOWZlYmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgorKysgYi9Tb3VyY2UvV2Vi S2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4KQEAgLTE2NSw2ICsxNjUs NyBAQAogICAgICAgICAgICAgICAgIDI2MwogICAgICAgICAgICAgICAgIDI2NQogICAgICAgICAg ICAgICAgIDI2NworICAgICAgICAgICAgICAgIDI2OAogICAgICAgICAgICAgICAgIDUxMgogICAg ICAgICAgICAgKQogI2VuZGlmCg==