226103 2021-05-21 12:53:57 -0700 Adopt CheckedLock / CheckedCondition in CDMProxy 2021-05-21 14:16:22 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen darin eric.carlson ews-watchlist glenn jer.noble peng.liu6 philipj sam sergio webkit-bug-importer youennf oldest_to_newest 1762531 0 cdumez 2021-05-21 12:53:57 -0700 Adopt CheckedLock / CheckedCondition in CDMProxy to benefit from Clang Thread Safety Analysis. 1762532 1 429328 cdumez 2021-05-21 12:55:08 -0700 Created attachment 429328 Patch 1762582 2 ews-feeder 2021-05-21 14:15:56 -0700 Committed r277887 (238024@main): <https://commits.webkit.org/238024@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429328. 1762583 3 webkit-bug-importer 2021-05-21 14:16:22 -0700 <rdar://problem/78328213> 429328 2021-05-21 12:55:08 -0700 2021-05-21 14:15:58 -0700 Patch bug-226103-20210521125508.patch text/plain 4889 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3ODc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjVlZmUxNTY4NTNiOGY5 MjhlMWVhNjdmZGM5MDIxNzA2NjQzOTlmMi4uZGY4Zjg0N2U2ZmI5YjJkN2Y0Yjc4OWE0YjA2ZDA4 MWUzOGJmMWNlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA1LTIxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQWRvcHQgQ2hlY2tlZExvY2sg LyBDaGVja2VkQ29uZGl0aW9uIGluIENETVByb3h5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjYxMDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZG9wdCBDaGVja2VkTG9jayAvIENoZWNrZWRDb25kaXRp b24gaW4gQ0RNUHJveHkgdG8gYmVuZWZpdCBmcm9tIENsYW5nIFRocmVhZCBTYWZldHkKKyAgICAg ICAgQW5hbHlzaXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lbmNyeXB0ZWRtZWRpYS9DRE1Qcm94 eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDRE1Qcm94eTo6dXBkYXRlS2V5U3RvcmUpOgorICAg ICAgICAoV2ViQ29yZTo6Q0RNUHJveHk6OmtleUhhbmRsZSBjb25zdCk6CisgICAgICAgIChXZWJD b3JlOjpDRE1Qcm94eTo6dHJ5V2FpdEZvcktleUhhbmRsZSBjb25zdCk6CisgICAgICAgIChXZWJD b3JlOjpDRE1Qcm94eTo6a2V5QXZhaWxhYmxlIGNvbnN0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9l bmNyeXB0ZWRtZWRpYS9DRE1Qcm94eS5oOgorCiAyMDIxLTA1LTIxICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIENoZWNrZWRMb2NrIG1vcmUgaW4gY2FzZXMg d2hlcmUgd2UgdHJ5LWxvY2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Vu Y3J5cHRlZG1lZGlhL0NETVByb3h5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VuY3J5 cHRlZG1lZGlhL0NETVByb3h5LmNwcAppbmRleCAzOGFiZjA2YTRjNGY3NmJkYzE3MDk4MDk4MzBj ZTFkNzBlYWM4ZDc5Li5mZTMwZmYwZTk3YWM4MDNhZjNhYzFlMzE2NGRkNjc0NTJlMjAzNTJkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lbmNyeXB0ZWRtZWRpYS9DRE1Qcm94 eS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZW5jcnlwdGVkbWVkaWEvQ0RNUHJv eHkuY3BwCkBAIC0yMzYsNyArMjM2LDcgQEAgQ0RNSW5zdGFuY2VTZXNzaW9uOjpLZXlTdGF0dXNW ZWN0b3IgS2V5U3RvcmU6OmNvbnZlcnRUb0pTS2V5U3RhdHVzVmVjdG9yKCkgY29uc3QKIAogdm9p ZCBDRE1Qcm94eTo6dXBkYXRlS2V5U3RvcmUoY29uc3QgS2V5U3RvcmUmIG5ld0tleVN0b3JlKQog ewotICAgIGF1dG8gbG9ja2VyID0gaG9sZExvY2sobV9rZXlzTXV0ZXgpOworICAgIExvY2tlciBs b2NrZXIgeyBtX2tleXNMb2NrIH07CiAgICAgbV9rZXlTdG9yZS5tZXJnZShuZXdLZXlTdG9yZSk7 CiAgICAgTE9HKEVNRSwgIkVNRSAtIENETVByb3h5IC0gdXBkYXRpbmcga2V5IHN0b3JlIGZyb20g YSBzZXNzaW9uIHVwZGF0ZSIpOwogICAgIG1fa2V5c0NvbmRpdGlvbi5ub3RpZnlBbGwoKTsKQEAg LTI1Niw3ICsyNTYsNyBAQCB2b2lkIENETVByb3h5OjpzZXRJbnN0YW5jZShDRE1JbnN0YW5jZVBy b3h5KiBpbnN0YW5jZSkKIAogUmVmUHRyPEtleUhhbmRsZT4gQ0RNUHJveHk6OmtleUhhbmRsZShj b25zdCBLZXlJRFR5cGUmIGtleUlEKSBjb25zdAogewotICAgIGF1dG8gbG9ja2VyID0gaG9sZExv Y2sobV9rZXlzTXV0ZXgpOworICAgIExvY2tlciBsb2NrZXIgeyBtX2tleXNMb2NrIH07CiAgICAg QVNTRVJUKG1fa2V5U3RvcmUuY29udGFpbnNLZXlJRChrZXlJRCkpOwogICAgIHJldHVybiBtX2tl eVN0b3JlLmtleUhhbmRsZShrZXlJRCk7CiB9CkBAIC0yOTUsOSArMjk1LDEwIEBAIE9wdGlvbmFs PFJlZjxLZXlIYW5kbGU+PiBDRE1Qcm94eTo6dHJ5V2FpdEZvcktleUhhbmRsZShjb25zdCBLZXlJ RFR5cGUmIGtleUlELCBXCiAgICAgTE9HKEVNRSwgIkVNRSAtIENETVByb3h5IC0gdHJ5aW5nIHRv IHdhaXQgZm9yIGtleSBJRCAlcyIsIHZlY3RvclRvSGV4U3RyaW5nKGtleUlEKS5hc2NpaSgpLmRh dGEoKSk7CiAgICAgYm9vbCB3YXNLZXlBdmFpbGFibGUgPSBmYWxzZTsKICAgICB7Ci0gICAgICAg IGF1dG8gbG9ja2VyID0gaG9sZExvY2sobV9rZXlzTXV0ZXgpOworICAgICAgICBMb2NrZXIgbG9j a2VyIHsgbV9rZXlzTG9jayB9OwogCi0gICAgICAgIG1fa2V5c0NvbmRpdGlvbi53YWl0Rm9yKG1f a2V5c011dGV4LCBDRE1Qcm94eTo6TWF4S2V5V2FpdFRpbWVTZWNvbmRzLCBbdGhpcywga2V5SUQs IGNsaWVudCA9IFdURk1vdmUoY2xpZW50KSwgJndhc0tleUF2YWlsYWJsZV0oKSB7CisgICAgICAg IG1fa2V5c0NvbmRpdGlvbi53YWl0Rm9yKG1fa2V5c0xvY2ssIENETVByb3h5OjpNYXhLZXlXYWl0 VGltZVNlY29uZHMsIFt0aGlzLCBrZXlJRCwgY2xpZW50ID0gV1RGTW92ZShjbGllbnQpLCAmd2Fz S2V5QXZhaWxhYmxlXSgpIHsKKyAgICAgICAgICAgIGFzc2VydElzSGVsZChtX2tleXNMb2NrKTsK ICAgICAgICAgICAgIGlmICghY2xpZW50IHx8IGNsaWVudC0+aXNBYm9ydGluZygpKQogICAgICAg ICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICAgICAgd2FzS2V5QXZhaWxhYmxlID0ga2V5 QXZhaWxhYmxlVW5sb2NrZWQoa2V5SUQpOwpAQCAtMzIyLDcgKzMyMyw3IEBAIGJvb2wgQ0RNUHJv eHk6OmtleUF2YWlsYWJsZVVubG9ja2VkKGNvbnN0IEtleUlEVHlwZSYga2V5SUQpIGNvbnN0CiAK IGJvb2wgQ0RNUHJveHk6OmtleUF2YWlsYWJsZShjb25zdCBLZXlJRFR5cGUmIGtleUlEKSBjb25z dAogewotICAgIGF1dG8gbG9ja2VyID0gaG9sZExvY2sobV9rZXlzTXV0ZXgpOworICAgIExvY2tl ciBsb2NrZXIgeyBtX2tleXNMb2NrIH07CiAgICAgcmV0dXJuIGtleUF2YWlsYWJsZVVubG9ja2Vk KGtleUlEKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZW5jcnlw dGVkbWVkaWEvQ0RNUHJveHkuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VuY3J5cHRlZG1l ZGlhL0NETVByb3h5LmgKaW5kZXggYjQ0ZjE1ODliZGQxYzZjYjBhNTUxNTcwNWViNTFjMTA4OTYz MGE2My4uNzA4ODU4ZWU5ODI4OTFkYjY1NGY2NGVlMzE5ZGZlOGY0ODYxMzdhMSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZW5jcnlwdGVkbWVkaWEvQ0RNUHJveHkuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lbmNyeXB0ZWRtZWRpYS9DRE1Qcm94eS5oCkBAIC0z NSw4ICszNSw4IEBACiAjaW5jbHVkZSAiTWVkaWFQbGF5ZXJQcml2YXRlLmgiCiAjaW5jbHVkZSAi U2hhcmVkQnVmZmVyLmgiCiAjaW5jbHVkZSA8d3RmL0JveFB0ci5oPgorI2luY2x1ZGUgPHd0Zi9D aGVja2VkQ29uZGl0aW9uLmg+CiAjaW5jbHVkZSA8d3RmL0NoZWNrZWRMb2NrLmg+Ci0jaW5jbHVk ZSA8d3RmL0NvbmRpdGlvbi5oPgogCiAjaWYgRU5BQkxFKFRIVU5ERVIpCiAjaW5jbHVkZSAiQ0RN T3BlbkNETVR5cGVzLmgiCkBAIC0xNjIsNyArMTYyLDcgQEAgcHVibGljOgogcHJvdGVjdGVkOgog ICAgIFJlZlB0cjxLZXlIYW5kbGU+IGtleUhhbmRsZShjb25zdCBLZXlJRFR5cGUmKSBjb25zdDsK ICAgICBib29sIGtleUF2YWlsYWJsZShjb25zdCBLZXlJRFR5cGUmKSBjb25zdDsKLSAgICBib29s IGtleUF2YWlsYWJsZVVubG9ja2VkKGNvbnN0IEtleUlEVHlwZSYpIGNvbnN0OworICAgIGJvb2wg a2V5QXZhaWxhYmxlVW5sb2NrZWQoY29uc3QgS2V5SURUeXBlJikgY29uc3QgV1RGX1JFUVVJUkVT X0xPQ0sobV9rZXlzTG9jayk7CiAgICAgT3B0aW9uYWw8UmVmPEtleUhhbmRsZT4+IHRyeVdhaXRG b3JLZXlIYW5kbGUoY29uc3QgS2V5SURUeXBlJiwgV2Vha1B0cjxDRE1Qcm94eURlY3J5cHRpb25D bGllbnQ+JiYpIGNvbnN0OwogICAgIE9wdGlvbmFsPFJlZjxLZXlIYW5kbGU+PiBnZXRPcldhaXRG b3JLZXlIYW5kbGUoY29uc3QgS2V5SURUeXBlJiwgV2Vha1B0cjxDRE1Qcm94eURlY3J5cHRpb25D bGllbnQ+JiYpIGNvbnN0OwogICAgIE9wdGlvbmFsPEtleUhhbmRsZVZhbHVlVmFyaWFudD4gZ2V0 T3JXYWl0Rm9yS2V5VmFsdWUoY29uc3QgS2V5SURUeXBlJiwgV2Vha1B0cjxDRE1Qcm94eURlY3J5 cHRpb25DbGllbnQ+JiYpIGNvbnN0OwpAQCAtMTc0LDExICsxNzQsMTEgQEAgcHJpdmF0ZToKICAg ICBtdXRhYmxlIENoZWNrZWRMb2NrIG1faW5zdGFuY2VMb2NrOwogICAgIENETUluc3RhbmNlUHJv eHkqIG1faW5zdGFuY2UgV1RGX0dVQVJERURfQllfTE9DSyhtX2luc3RhbmNlTG9jayk7CiAKLSAg ICBtdXRhYmxlIExvY2sgbV9rZXlzTXV0ZXg7Ci0gICAgbXV0YWJsZSBDb25kaXRpb24gbV9rZXlz Q29uZGl0aW9uOworICAgIG11dGFibGUgQ2hlY2tlZExvY2sgbV9rZXlzTG9jazsKKyAgICBtdXRh YmxlIENoZWNrZWRDb25kaXRpb24gbV9rZXlzQ29uZGl0aW9uOwogICAgIC8vIEZJWE1FOiBEdXBs aWNhdGVkIGtleSBzdG9yZXMgaW4gdGhlIGluc3RhbmNlIGFuZCB0aGUgcHJveHkgYXJlIHByb2Jh Ymx5IG5vdCBuZWVkZWQsIGJ1dCBzaW1wbGlmaWVkCiAgICAgLy8gdGhlIGluaXRpYWwgaW1wbGVt ZW50YXRpb24gaW4gdGVybXMgb2YgdGhyZWFkaW5nIGludmFyaWFudHMuCi0gICAgS2V5U3RvcmUg bV9rZXlTdG9yZTsKKyAgICBLZXlTdG9yZSBtX2tleVN0b3JlIFdURl9HVUFSREVEX0JZX0xPQ0so bV9rZXlzTG9jayk7CiB9OwogCiBjbGFzcyBDRE1Qcm94eUZhY3Rvcnkgewo=