226101 2021-05-21 12:40:32 -0700 Adopt CheckedLock in NetworkCache::Storage::TraverseOperation 2021-05-21 14:20:26 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen cgarcia darin ews-watchlist ggaren kkinnunen koivisto sam webkit-bug-importer youennf oldest_to_newest 1762521 0 cdumez 2021-05-21 12:40:32 -0700 Adopt CheckedLock in NetworkCache::Storage::TraverseOperation to benefit from Clang Thread Safety Analysis. 1762522 1 429324 cdumez 2021-05-21 12:42:03 -0700 Created attachment 429324 Patch 1762584 2 ews-feeder 2021-05-21 14:19:39 -0700 Committed r277888 (238025@main): <https://commits.webkit.org/238025@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429324. 1762586 3 webkit-bug-importer 2021-05-21 14:20:26 -0700 <rdar://problem/78328445> 429324 2021-05-21 12:42:03 -0700 2021-05-21 14:19:40 -0700 Patch bug-226101-20210521124203.patch text/plain 3941 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3ODc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAzOTk3YTY5OTRjNjk2MDUy ZTVhM2JjNjY3N2E5ZmI1MGY3YTYyMDEuLjM2ZmRmYzZhYTFmYjJjZDhkN2MzZGEwYjAwMGVmODZl MGMxOTY3Y2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDUtMjEgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBBZG9wdCBDaGVja2VkTG9jayBpbiBO ZXR3b3JrQ2FjaGU6OlN0b3JhZ2U6OlRyYXZlcnNlT3BlcmF0aW9uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjYxMDEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZG9wdCBDaGVja2VkTG9jayBpbiBOZXR3 b3JrQ2FjaGU6OlN0b3JhZ2U6OlRyYXZlcnNlT3BlcmF0aW9uIHRvIGJlbmVmaXQgZnJvbSBDbGFu ZworICAgICAgICBUaHJlYWQgU2FmZXR5IEFuYWx5c2lzLgorCisgICAgICAgICogTmV0d29ya1By b2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3RvcmFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5l dHdvcmtDYWNoZTo6U3RvcmFnZTo6VHJhdmVyc2VPcGVyYXRpb246OldURl9HVUFSREVEX0JZX0xP Q0spOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6OlN0b3JhZ2U6OnRyYXZlcnNlKToK KwogMjAyMS0wNS0yMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAg IEFkb3B0IENoZWNrZWRMb2NrIGluIE1lZGlhRm9ybWF0UmVhZGVyIGFuZCBmaXggdGhyZWFkaW5n IGJ1ZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3 b3JrQ2FjaGVTdG9yYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUv TmV0d29ya0NhY2hlU3RvcmFnZS5jcHAKaW5kZXggMDhlMjIwNmJmMzI0YmQxY2M3NzdiODYwZDFl MjE4MjY3OTFmMmY3Yi4uZjU4NzQ1MjU3ZjI4M2UzNmY4MDdmZjg1OGRkNGI4ODgzYTU1YjNhYyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2Fj aGVTdG9yYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL05l dHdvcmtDYWNoZVN0b3JhZ2UuY3BwCkBAIC0zMiw5ICszMiw5IEBACiAjaW5jbHVkZSAiTmV0d29y a0NhY2hlRmlsZVN5c3RlbS5oIgogI2luY2x1ZGUgIk5ldHdvcmtDYWNoZUlPQ2hhbm5lbC5oIgog I2luY2x1ZGUgPG11dGV4PgotI2luY2x1ZGUgPHd0Zi9Db25kaXRpb24uaD4KKyNpbmNsdWRlIDx3 dGYvQ2hlY2tlZENvbmRpdGlvbi5oPgorI2luY2x1ZGUgPHd0Zi9DaGVja2VkTG9jay5oPgogI2lu Y2x1ZGUgPHd0Zi9GaWxlU3lzdGVtLmg+Ci0jaW5jbHVkZSA8d3RmL0xvY2suaD4KICNpbmNsdWRl IDx3dGYvUGFnZUJsb2NrLmg+CiAjaW5jbHVkZSA8d3RmL1JhbmRvbU51bWJlci5oPgogI2luY2x1 ZGUgPHd0Zi9SdW5Mb29wLmg+CkBAIC0xNjIsOSArMTYyLDkgQEAgcHVibGljOgogICAgIGNvbnN0 IE9wdGlvblNldDxUcmF2ZXJzZUZsYWc+IGZsYWdzOwogICAgIGNvbnN0IFRyYXZlcnNlSGFuZGxl ciBoYW5kbGVyOwogCi0gICAgTG9jayBhY3RpdmVNdXRleDsKLSAgICBDb25kaXRpb24gYWN0aXZl Q29uZGl0aW9uOwotICAgIHVuc2lnbmVkIGFjdGl2ZUNvdW50IHsgMCB9OworICAgIENoZWNrZWRM b2NrIGFjdGl2ZUxvY2s7CisgICAgQ2hlY2tlZENvbmRpdGlvbiBhY3RpdmVDb25kaXRpb247Cisg ICAgdW5zaWduZWQgYWN0aXZlQ291bnQgV1RGX0dVQVJERURfQllfTE9DSyhhY3RpdmVMb2NrKSB7 IDAgfTsKIH07CiAKIHN0YXRpYyBTdHJpbmcgbWFrZUNhY2hlUGF0aChjb25zdCBTdHJpbmcmIGJh c2VDYWNoZVBhdGgpCkBAIC05ODQsNyArOTg0LDcgQEAgdm9pZCBTdG9yYWdlOjp0cmF2ZXJzZShj b25zdCBTdHJpbmcmIHR5cGUsIE9wdGlvblNldDxUcmF2ZXJzZUZsYWc+IGZsYWdzLCBUcmF2ZXIK ICAgICAgICAgICAgIGlmICh0cmF2ZXJzZU9wZXJhdGlvbi5mbGFncyAmIFRyYXZlcnNlRmxhZzo6 U2hhcmVDb3VudCkKICAgICAgICAgICAgICAgICBib2R5U2hhcmVDb3VudCA9IG1fYmxvYlN0b3Jh Z2Uuc2hhcmVDb3VudChibG9iUGF0aEZvclJlY29yZFBhdGgocmVjb3JkUGF0aCkpOwogCi0gICAg ICAgICAgICBzdGQ6OnVuaXF1ZV9sb2NrPExvY2s+IGxvY2sodHJhdmVyc2VPcGVyYXRpb24uYWN0 aXZlTXV0ZXgpOworICAgICAgICAgICAgTG9ja2VyIGxvY2sgeyB0cmF2ZXJzZU9wZXJhdGlvbi5h Y3RpdmVMb2NrIH07CiAgICAgICAgICAgICArK3RyYXZlcnNlT3BlcmF0aW9uLmFjdGl2ZUNvdW50 OwogCiAgICAgICAgICAgICBhdXRvIGNoYW5uZWwgPSBJT0NoYW5uZWw6Om9wZW4ocmVjb3JkUGF0 aCwgSU9DaGFubmVsOjpUeXBlOjpSZWFkKTsKQEAgLTEwMDgsMjAgKzEwMDgsMjIgQEAgdm9pZCBT dG9yYWdlOjp0cmF2ZXJzZShjb25zdCBTdHJpbmcmIHR5cGUsIE9wdGlvblNldDxUcmF2ZXJzZUZs YWc+IGZsYWdzLCBUcmF2ZXIKICAgICAgICAgICAgICAgICAgICAgdHJhdmVyc2VPcGVyYXRpb24u aGFuZGxlcigmcmVjb3JkLCBpbmZvKTsKICAgICAgICAgICAgICAgICB9CiAKLSAgICAgICAgICAg ICAgICBhdXRvIGxvY2tlciA9IGhvbGRMb2NrKHRyYXZlcnNlT3BlcmF0aW9uLmFjdGl2ZU11dGV4 KTsKKyAgICAgICAgICAgICAgICBMb2NrZXIgbG9ja2VyIHsgdHJhdmVyc2VPcGVyYXRpb24uYWN0 aXZlTG9jayB9OwogICAgICAgICAgICAgICAgIC0tdHJhdmVyc2VPcGVyYXRpb24uYWN0aXZlQ291 bnQ7CiAgICAgICAgICAgICAgICAgdHJhdmVyc2VPcGVyYXRpb24uYWN0aXZlQ29uZGl0aW9uLm5v dGlmeU9uZSgpOwogICAgICAgICAgICAgfSk7CiAKICAgICAgICAgICAgIHN0YXRpYyBjb25zdCB1 bnNpZ25lZCBtYXhpbXVtUGFyYWxsZWxSZWFkQ291bnQgPSA1OwotICAgICAgICAgICAgdHJhdmVy c2VPcGVyYXRpb24uYWN0aXZlQ29uZGl0aW9uLndhaXQobG9jaywgWyZ0cmF2ZXJzZU9wZXJhdGlv bl0geworICAgICAgICAgICAgdHJhdmVyc2VPcGVyYXRpb24uYWN0aXZlQ29uZGl0aW9uLndhaXQo dHJhdmVyc2VPcGVyYXRpb24uYWN0aXZlTG9jaywgWyZ0cmF2ZXJzZU9wZXJhdGlvbl0geworICAg ICAgICAgICAgICAgIGFzc2VydElzSGVsZCh0cmF2ZXJzZU9wZXJhdGlvbi5hY3RpdmVMb2NrKTsK ICAgICAgICAgICAgICAgICByZXR1cm4gdHJhdmVyc2VPcGVyYXRpb24uYWN0aXZlQ291bnQgPD0g bWF4aW11bVBhcmFsbGVsUmVhZENvdW50OwogICAgICAgICAgICAgfSk7CiAgICAgICAgIH0pOwog ICAgICAgICB7CiAgICAgICAgICAgICAvLyBXYWl0IGZvciBhbGwgcmVhZHMgdG8gZmluaXNoLgot ICAgICAgICAgICAgc3RkOjp1bmlxdWVfbG9jazxMb2NrPiBsb2NrKHRyYXZlcnNlT3BlcmF0aW9u LmFjdGl2ZU11dGV4KTsKLSAgICAgICAgICAgIHRyYXZlcnNlT3BlcmF0aW9uLmFjdGl2ZUNvbmRp dGlvbi53YWl0KGxvY2ssIFsmdHJhdmVyc2VPcGVyYXRpb25dIHsKKyAgICAgICAgICAgIExvY2tl ciBsb2NrZXIgeyB0cmF2ZXJzZU9wZXJhdGlvbi5hY3RpdmVMb2NrIH07CisgICAgICAgICAgICB0 cmF2ZXJzZU9wZXJhdGlvbi5hY3RpdmVDb25kaXRpb24ud2FpdCh0cmF2ZXJzZU9wZXJhdGlvbi5h Y3RpdmVMb2NrLCBbJnRyYXZlcnNlT3BlcmF0aW9uXSB7CisgICAgICAgICAgICAgICAgYXNzZXJ0 SXNIZWxkKHRyYXZlcnNlT3BlcmF0aW9uLmFjdGl2ZUxvY2spOwogICAgICAgICAgICAgICAgIHJl dHVybiAhdHJhdmVyc2VPcGVyYXRpb24uYWN0aXZlQ291bnQ7CiAgICAgICAgICAgICB9KTsKICAg ICAgICAgfQo=