226100 2021-05-21 12:25:28 -0700 Adopt CheckedLock in MediaFormatReader and fix threading bug 2021-05-21 14:05:36 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen darin eric.carlson ews-watchlist glenn jer.noble kkinnunen peng.liu6 philipj sergio webkit-bug-importer youennf oldest_to_newest 1762519 0 cdumez 2021-05-21 12:25:28 -0700 Adopt CheckedLock in MediaFormatReader and fix threading bug found by Clang Thread Safety Analysis. 1762520 1 429323 cdumez 2021-05-21 12:27:27 -0700 Created attachment 429323 Patch 1762573 2 ews-feeder 2021-05-21 14:04:50 -0700 Committed r277885 (238022@main): <https://commits.webkit.org/238022@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429323. 1762575 3 webkit-bug-importer 2021-05-21 14:05:36 -0700 <rdar://problem/78327545> 429323 2021-05-21 12:27:27 -0700 2021-05-21 14:04:52 -0700 Patch bug-226100-20210521122726.patch text/plain 5863 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3ODcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAzZmZkOTVjNzBlMzFlNjcz YTU2Mjc1YzE1ODg5NTUzMTBmNGVhZGQuLjBkZmVkYTBiNjY0YWRlYmVmYTEwN2Q3NGI4YTRjYjQ3 MGY2ZGIyNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMjEtMDUtMjEgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBBZG9wdCBDaGVja2VkTG9jayBpbiBN ZWRpYUZvcm1hdFJlYWRlciBhbmQgZml4IHRocmVhZGluZyBidWcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjEwMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkb3B0IENoZWNrZWRMb2NrIGluIE1lZGlh Rm9ybWF0UmVhZGVyIGFuZCBmaXggdGhyZWFkaW5nIGJ1ZyBmb3VuZCBieSBDbGFuZyBUaHJlYWQg U2FmZXR5CisgICAgICAgIEFuYWx5c2lzLiBJbiBwYXJ0aWN1bGFyLCBwYXJzZUJ5dGVTb3VyY2Uo KSB3YXMgZmFpbGluZyB0byBncmFiIHRoZSBsb2NrIGJlZm9yZSB1cGRhdGluZworICAgICAgICBt X3BhcnNlVHJhY2tzU3RhdHVzIGluIG9uZSBvZiBpdHMgYnJhbmNoZXMuCisKKyAgICAgICAgKiBT aGFyZWQvbWFjL01lZGlhRm9ybWF0UmVhZGVyL01lZGlhRm9ybWF0UmVhZGVyLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6TWVkaWFGb3JtYXRSZWFkZXI6OnBhcnNlQnl0ZVNvdXJjZSk6CisgICAgICAg IChXZWJLaXQ6Ok1lZGlhRm9ybWF0UmVhZGVyOjpkaWRQYXJzZVRyYWNrcyk6CisgICAgICAgIChX ZWJLaXQ6Ok1lZGlhRm9ybWF0UmVhZGVyOjpkaWRQcm92aWRlTWVkaWFEYXRhKToKKyAgICAgICAg KFdlYktpdDo6TWVkaWFGb3JtYXRSZWFkZXI6OmZpbmlzaFBhcnNpbmcpOgorICAgICAgICAoV2Vi S2l0OjpNZWRpYUZvcm1hdFJlYWRlcjo6Y29weVByb3BlcnR5KToKKyAgICAgICAgKFdlYktpdDo6 TWVkaWFGb3JtYXRSZWFkZXI6OmNvcHlUcmFja0FycmF5KToKKyAgICAgICAgKiBTaGFyZWQvbWFj L01lZGlhRm9ybWF0UmVhZGVyL01lZGlhRm9ybWF0UmVhZGVyLmg6CisKIDIwMjEtMDUtMjEgIENo cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBBZG9wdCBDaGVja2VkTG9j ayBpbiBSZW1vdGVJbWFnZUJ1ZmZlclByb3h5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1No YXJlZC9tYWMvTWVkaWFGb3JtYXRSZWFkZXIvTWVkaWFGb3JtYXRSZWFkZXIuY3BwIGIvU291cmNl L1dlYktpdC9TaGFyZWQvbWFjL01lZGlhRm9ybWF0UmVhZGVyL01lZGlhRm9ybWF0UmVhZGVyLmNw cAppbmRleCBkOTQwMDBiYTM1ZTgzMjU2OGY5YTE5OWMzYzg5MDFkYWFiNjA2ZmEyLi4wZGVhMDk2 ZDlhYTA3YWJhOWI2YWRjMzRiNzQxN2JiNWI1ZjM2NTg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1NoYXJlZC9tYWMvTWVkaWFGb3JtYXRSZWFkZXIvTWVkaWFGb3JtYXRSZWFkZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL21hYy9NZWRpYUZvcm1hdFJlYWRlci9NZWRpYUZvcm1h dFJlYWRlci5jcHAKQEAgLTEwMCw2ICsxMDAsNyBAQCB2b2lkIE1lZGlhRm9ybWF0UmVhZGVyOjpw YXJzZUJ5dGVTb3VyY2UoUmV0YWluUHRyPE1UUGx1Z2luQnl0ZVNvdXJjZVJlZj4mJiBieXRlUwog ICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxDb250ZW50VHlwZT4gY29udGVudFR5cGUoInZpZGVv L3dlYm0iX3MpOwogICAgIGF1dG8gcGFyc2VyID0gU291cmNlQnVmZmVyUGFyc2VyV2ViTTo6Y3Jl YXRlKGNvbnRlbnRUeXBlKTsKICAgICBpZiAoIXBhcnNlcikgeworICAgICAgICBMb2NrZXIgbG9j a2VyIHsgbV9wYXJzZVRyYWNrc0xvY2sgfTsKICAgICAgICAgbV9wYXJzZVRyYWNrc1N0YXR1cyA9 IGtNVFBsdWdpbkZvcm1hdFJlYWRlckVycm9yX0FsbG9jYXRpb25GYWlsdXJlOwogICAgICAgICBy ZXR1cm47CiAgICAgfQpAQCAtMTMxLDcgKzEzMiw3IEBAIHZvaWQgTWVkaWFGb3JtYXRSZWFkZXI6 OnBhcnNlQnl0ZVNvdXJjZShSZXRhaW5QdHI8TVRQbHVnaW5CeXRlU291cmNlUmVmPiYmIGJ5dGVT CiAgICAgICAgIGRpZFByb3ZpZGVNZWRpYURhdGEoV1RGTW92ZShtZWRpYVNhbXBsZSksIHRyYWNr SUQsIG1lZGlhVHlwZSk7CiAgICAgfSk7CiAKLSAgICBhdXRvIGxvY2tlciA9IGhvbGRMb2NrKG1f cGFyc2VUcmFja3NMb2NrKTsKKyAgICBMb2NrZXIgbG9ja2VyIHsgbV9wYXJzZVRyYWNrc0xvY2sg fTsKICAgICBtX2J5dGVTb3VyY2UgPSBXVEZNb3ZlKGJ5dGVTb3VyY2UpOwogICAgIG1fcGFyc2VU cmFja3NTdGF0dXMgPSBXVEY6Om51bGxvcHQ7CiAgICAgbV9kdXJhdGlvbiA9IE1lZGlhVGltZTo6 aW52YWxpZFRpbWUoKTsKQEAgLTE0OSw3ICsxNTAsNyBAQCB2b2lkIE1lZGlhRm9ybWF0UmVhZGVy OjpkaWRQYXJzZVRyYWNrcyhTb3VyY2VCdWZmZXJQcml2YXRlQ2xpZW50OjpJbml0aWFsaXphdGlv bgogewogICAgIEFTU0VSVCghaXNNYWluUnVuTG9vcCgpKTsKIAotICAgIGF1dG8gbG9ja2VyID0g aG9sZExvY2sobV9wYXJzZVRyYWNrc0xvY2spOworICAgIExvY2tlciBsb2NrZXIgeyBtX3BhcnNl VHJhY2tzTG9jayB9OwogICAgIEFTU0VSVCghbV9wYXJzZVRyYWNrc1N0YXR1cyk7CiAgICAgQVNT RVJUKG1fZHVyYXRpb24uaXNJbnZhbGlkKCkpOwogICAgIEFTU0VSVChtX3RyYWNrUmVhZGVycy5p c0VtcHR5KCkpOwpAQCAtMTkyLDcgKzE5Myw3IEBAIHZvaWQgTWVkaWFGb3JtYXRSZWFkZXI6OmRp ZFByb3ZpZGVNZWRpYURhdGEoUmVmPE1lZGlhU2FtcGxlPiYmIG1lZGlhU2FtcGxlLCB1aW50CiB7 CiAgICAgQVNTRVJUKCFpc01haW5SdW5Mb29wKCkpOwogCi0gICAgYXV0byBsb2NrZXIgPSBob2xk TG9jayhtX3BhcnNlVHJhY2tzTG9jayk7CisgICAgTG9ja2VyIGxvY2tlciB7IG1fcGFyc2VUcmFj a3NMb2NrIH07CiAgICAgYXV0byB0cmFja0luZGV4ID0gbV90cmFja1JlYWRlcnMuZmluZE1hdGNo aW5nKFsmXShhdXRvJiB0cmFjaykgewogICAgICAgICByZXR1cm4gdHJhY2stPnRyYWNrSUQoKSA9 PSB0cmFja0lEOwogICAgIH0pOwpAQCAtMjA2LDcgKzIwNyw3IEBAIHZvaWQgTWVkaWFGb3JtYXRS ZWFkZXI6OmZpbmlzaFBhcnNpbmcoUmVmPFNvdXJjZUJ1ZmZlclBhcnNlcj4mJiBwYXJzZXIpCiAg ICAgQVNTRVJUKCFpc01haW5SdW5Mb29wKCkpOwogICAgIEFMV0FZU19MT0coTE9HSURFTlRJRklF Uik7CiAKLSAgICBhdXRvIGxvY2tlciA9IGhvbGRMb2NrKG1fcGFyc2VUcmFja3NMb2NrKTsKKyAg ICBMb2NrZXIgbG9ja2VyIHsgbV9wYXJzZVRyYWNrc0xvY2sgfTsKICAgICBBU1NFUlQobV9wYXJz ZVRyYWNrc1N0YXR1cy5oYXNWYWx1ZSgpKTsKIAogICAgIGZvciAoYXV0byYgdHJhY2tSZWFkZXIg OiBtX3RyYWNrUmVhZGVycykKQEAgLTIzMCw4ICsyMzEsOSBAQCB2b2lkIE1lZGlhRm9ybWF0UmVh ZGVyOjpmaW5pc2hQYXJzaW5nKFJlZjxTb3VyY2VCdWZmZXJQYXJzZXI+JiYgcGFyc2VyKQogCiBP U1N0YXR1cyBNZWRpYUZvcm1hdFJlYWRlcjo6Y29weVByb3BlcnR5KENGU3RyaW5nUmVmIGtleSwg Q0ZBbGxvY2F0b3JSZWYgYWxsb2NhdG9yLCB2b2lkKiB2YWx1ZUNvcHkpCiB7Ci0gICAgYXV0byBs b2NrZXIgPSBob2xkTG9jayhtX3BhcnNlVHJhY2tzTG9jayk7CisgICAgTG9ja2VyIGxvY2tlciB7 IG1fcGFyc2VUcmFja3NMb2NrIH07CiAgICAgbV9wYXJzZVRyYWNrc0NvbmRpdGlvbi53YWl0KG1f cGFyc2VUcmFja3NMb2NrLCBbJl0geworICAgICAgICBhc3NlcnRJc0hlbGQobV9wYXJzZVRyYWNr c0xvY2spOwogICAgICAgICByZXR1cm4gbV9wYXJzZVRyYWNrc1N0YXR1cy5oYXNWYWx1ZSgpOwog ICAgIH0pOwogCkBAIC0yNTEsOCArMjUzLDkgQEAgT1NTdGF0dXMgTWVkaWFGb3JtYXRSZWFkZXI6 OmNvcHlQcm9wZXJ0eShDRlN0cmluZ1JlZiBrZXksIENGQWxsb2NhdG9yUmVmIGFsbG9jYXQKIAog T1NTdGF0dXMgTWVkaWFGb3JtYXRSZWFkZXI6OmNvcHlUcmFja0FycmF5KENGQXJyYXlSZWYqIHRy YWNrQXJyYXlDb3B5KQogewotICAgIGF1dG8gbG9ja2VyID0gaG9sZExvY2sobV9wYXJzZVRyYWNr c0xvY2spOworICAgIExvY2tlciBsb2NrZXIgeyBtX3BhcnNlVHJhY2tzTG9jayB9OwogICAgIG1f cGFyc2VUcmFja3NDb25kaXRpb24ud2FpdChtX3BhcnNlVHJhY2tzTG9jaywgWyZdIHsKKyAgICAg ICAgYXNzZXJ0SXNIZWxkKG1fcGFyc2VUcmFja3NMb2NrKTsKICAgICAgICAgcmV0dXJuIG1fcGFy c2VUcmFja3NTdGF0dXMuaGFzVmFsdWUoKTsKICAgICB9KTsKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9TaGFyZWQvbWFjL01lZGlhRm9ybWF0UmVhZGVyL01lZGlhRm9ybWF0UmVhZGVyLmgg Yi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9tYWMvTWVkaWFGb3JtYXRSZWFkZXIvTWVkaWFGb3JtYXRS ZWFkZXIuaAppbmRleCA0ZWVjYWM2MzJjYjJmMzM3NWM0ODA1ZmQyMDBjY2Q4YjMxMDBhNTIwLi5j NzZlYmM0NDg2YTUzNTE0OWE1MjNjOGIwN2Q3OWQxMjg2ZWI1NDM4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1NoYXJlZC9tYWMvTWVkaWFGb3JtYXRSZWFkZXIvTWVkaWFGb3JtYXRSZWFkZXIu aAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9tYWMvTWVkaWFGb3JtYXRSZWFkZXIvTWVkaWFG b3JtYXRSZWFkZXIuaApAQCAtMjksOCArMjksOCBAQAogCiAjaW5jbHVkZSAiQ29yZU1lZGlhV3Jh cHBlZC5oIgogI2luY2x1ZGUgPFdlYkNvcmUvU291cmNlQnVmZmVyUHJpdmF0ZUNsaWVudC5oPgot I2luY2x1ZGUgPHd0Zi9Db25kaXRpb24uaD4KLSNpbmNsdWRlIDx3dGYvTG9jay5oPgorI2luY2x1 ZGUgPHd0Zi9DaGVja2VkQ29uZGl0aW9uLmg+CisjaW5jbHVkZSA8d3RmL0NoZWNrZWRMb2NrLmg+ CiAjaW5jbHVkZSA8d3RmL0xvZ2dlci5oPgogCiBERUNMQVJFX0NPUkVfTUVESUFfVFJBSVRTKEZv cm1hdFJlYWRlcik7CkBAIC03OCwxMiArNzgsMTIgQEAgcHJpdmF0ZToKICAgICAKICAgICBjb25z dCB2b2lkKiBsb2dJZGVudGlmaWVyKCkgY29uc3QgeyByZXR1cm4gbV9sb2dJZGVudGlmaWVyOyB9 CiAKLSAgICBSZXRhaW5QdHI8TVRQbHVnaW5CeXRlU291cmNlUmVmPiBtX2J5dGVTb3VyY2U7Ci0g ICAgQ29uZGl0aW9uIG1fcGFyc2VUcmFja3NDb25kaXRpb247Ci0gICAgTG9jayBtX3BhcnNlVHJh Y2tzTG9jazsKLSAgICBNZWRpYVRpbWUgbV9kdXJhdGlvbjsKLSAgICBPcHRpb25hbDxPU1N0YXR1 cz4gbV9wYXJzZVRyYWNrc1N0YXR1czsKLSAgICBWZWN0b3I8UmVmPE1lZGlhVHJhY2tSZWFkZXI+ PiBtX3RyYWNrUmVhZGVyczsKKyAgICBSZXRhaW5QdHI8TVRQbHVnaW5CeXRlU291cmNlUmVmPiBt X2J5dGVTb3VyY2UgV1RGX0dVQVJERURfQllfTE9DSyhtX3BhcnNlVHJhY2tzTG9jayk7CisgICAg Q2hlY2tlZENvbmRpdGlvbiBtX3BhcnNlVHJhY2tzQ29uZGl0aW9uOworICAgIENoZWNrZWRMb2Nr IG1fcGFyc2VUcmFja3NMb2NrOworICAgIE1lZGlhVGltZSBtX2R1cmF0aW9uIFdURl9HVUFSREVE X0JZX0xPQ0sobV9wYXJzZVRyYWNrc0xvY2spOworICAgIE9wdGlvbmFsPE9TU3RhdHVzPiBtX3Bh cnNlVHJhY2tzU3RhdHVzIFdURl9HVUFSREVEX0JZX0xPQ0sobV9wYXJzZVRyYWNrc0xvY2spOwor ICAgIFZlY3RvcjxSZWY8TWVkaWFUcmFja1JlYWRlcj4+IG1fdHJhY2tSZWFkZXJzIFdURl9HVUFS REVEX0JZX0xPQ0sobV9wYXJzZVRyYWNrc0xvY2spOwogICAgIFJlZlB0cjxjb25zdCBMb2dnZXI+ IG1fbG9nZ2VyOwogICAgIGNvbnN0IHZvaWQqIG1fbG9nSWRlbnRpZmllcjsKIH07Cg==