22610 2008-12-02 16:46:40 -0800 We should plant shift right immediate instructions, 2008-12-02 18:21:12 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 barraclough barraclough oldest_to_newest 101111 0 barraclough 2008-12-02 16:46:40 -0800 when JIT generating for op_rshift, and the second operand is an immediate. 101113 1 25690 barraclough 2008-12-02 16:47:42 -0800 Created attachment 25690 The patch 101118 2 25690 ggaren 2008-12-02 16:57:07 -0800 Comment on attachment 25690 The patch > + __ sarl_i8r(JSImmediate::getTruncatedUInt32(value) & 0x1f, X86::eax); Let's put a comment here, like, "Prohibit shifting by more than 31." r=me 101135 3 barraclough 2008-12-02 18:21:12 -0800 Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/jit/JIT.cpp Transmitting file data .. Committed revision 38928. 25690 2008-12-02 16:47:42 -0800 2008-12-02 16:57:07 -0800 The patch patch.shifty.txt text/plain 2835 barraclough SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4OTI1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMTIt MDIgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBsYW50IHNoaWZ0IHJpZ2h0 IGltbWVkaWF0ZSBpbnN0cnVjdGlvbnMsIHdoaWNoIGFyZSBhd2Vzb21lLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2MTAKKyAgICAgICAgfjUlIG9u IHRoZSB2OC1jcnlwdG8gdGVzdC4KKworICAgICAgICAqIGppdC9KSVQuY3BwOgorICAgICAgICAo SlNDOjpKSVQ6OnByaXZhdGVDb21waWxlTWFpblBhc3MpOgorICAgICAgICAoSlNDOjpKSVQ6OnBy aXZhdGVDb21waWxlU2xvd0Nhc2VzKToKKwogMjAwOC0xMi0wMiAgR2VvZmZyZXkgR2FyZW4gIDxn Z2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4 OiBqaXQvSklULmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBqaXQvSklULmNwcAkocmV2aXNpb24gMzg5MjQp CisrKyBqaXQvSklULmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTgxMiwxMSArMTgxMiwxOSBAQCB2 b2lkIEpJVDo6cHJpdmF0ZUNvbXBpbGVNYWluUGFzcygpCiAgICAgICAgICAgICBicmVhazsKICAg ICAgICAgfQogICAgICAgICBjYXNlIG9wX3JzaGlmdDogewotICAgICAgICAgICAgZW1pdEdldFZp cnR1YWxSZWdpc3RlcnMoaW5zdHJ1Y3Rpb25baSArIDJdLnUub3BlcmFuZCwgWDg2OjplYXgsIGlu c3RydWN0aW9uW2kgKyAzXS51Lm9wZXJhbmQsIFg4Njo6ZWN4LCBpKTsKLSAgICAgICAgICAgIGVt aXRKdW1wU2xvd0Nhc2VJZk5vdEltbU51bShYODY6OmVheCwgaSk7Ci0gICAgICAgICAgICBlbWl0 SnVtcFNsb3dDYXNlSWZOb3RJbW1OdW0oWDg2OjplY3gsIGkpOwotICAgICAgICAgICAgZW1pdEZh c3RBcml0aEltbVRvSW50KFg4Njo6ZWN4KTsKLSAgICAgICAgICAgIF9fIHNhcmxfQ0xyKFg4Njo6 ZWF4KTsKKyAgICAgICAgICAgIHVuc2lnbmVkIHNyYzEgPSBpbnN0cnVjdGlvbltpICsgMl0udS5v cGVyYW5kOworICAgICAgICAgICAgdW5zaWduZWQgc3JjMiA9IGluc3RydWN0aW9uW2kgKyAzXS51 Lm9wZXJhbmQ7CisgICAgICAgICAgICBpZiAoSlNWYWx1ZSogdmFsdWUgPSBnZXRDb25zdGFudElt bWVkaWF0ZU51bWVyaWNBcmcoc3JjMikpIHsKKyAgICAgICAgICAgICAgICBlbWl0R2V0VmlydHVh bFJlZ2lzdGVyKHNyYzEsIFg4Njo6ZWF4LCBpKTsKKyAgICAgICAgICAgICAgICBlbWl0SnVtcFNs b3dDYXNlSWZOb3RJbW1OdW0oWDg2OjplYXgsIGkpOworICAgICAgICAgICAgICAgIF9fIHNhcmxf aThyKEpTSW1tZWRpYXRlOjpnZXRUcnVuY2F0ZWRVSW50MzIodmFsdWUpICYgMHgxZiwgWDg2Ojpl YXgpOworICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICBlbWl0R2V0VmlydHVh bFJlZ2lzdGVycyhzcmMxLCBYODY6OmVheCwgc3JjMiwgWDg2OjplY3gsIGkpOworICAgICAgICAg ICAgICAgIGVtaXRKdW1wU2xvd0Nhc2VJZk5vdEltbU51bShYODY6OmVheCwgaSk7CisgICAgICAg ICAgICAgICAgZW1pdEp1bXBTbG93Q2FzZUlmTm90SW1tTnVtKFg4Njo6ZWN4LCBpKTsKKyAgICAg ICAgICAgICAgICBlbWl0RmFzdEFyaXRoSW1tVG9JbnQoWDg2OjplY3gpOworICAgICAgICAgICAg ICAgIF9fIHNhcmxfQ0xyKFg4Njo6ZWF4KTsKKyAgICAgICAgICAgIH0KICAgICAgICAgICAgIGVt aXRGYXN0QXJpdGhQb3RlbnRpYWxseVJlVGFnSW1tZWRpYXRlKFg4Njo6ZWF4KTsKICAgICAgICAg ICAgIGVtaXRQdXRWaXJ0dWFsUmVnaXN0ZXIoaW5zdHJ1Y3Rpb25baSArIDFdLnUub3BlcmFuZCk7 CiAgICAgICAgICAgICBpICs9IDQ7CkBAIC0yNDE0LDEwICsyNDIyLDE2IEBAIHZvaWQgSklUOjpw cml2YXRlQ29tcGlsZVNsb3dDYXNlcygpCiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQog ICAgICAgICBjYXNlIG9wX3JzaGlmdDogeworICAgICAgICAgICAgdW5zaWduZWQgc3JjMiA9IGlu c3RydWN0aW9uW2kgKyAzXS51Lm9wZXJhbmQ7CiAgICAgICAgICAgICBfXyBsaW5rKGl0ZXItPmZy b20sIF9fIGxhYmVsKCkpOwotICAgICAgICAgICAgX18gbGluaygoKytpdGVyKS0+ZnJvbSwgX18g bGFiZWwoKSk7CisgICAgICAgICAgICBpZiAoZ2V0Q29uc3RhbnRJbW1lZGlhdGVOdW1lcmljQXJn KHNyYzIpKQorICAgICAgICAgICAgICAgIGVtaXRQdXRDVElBcmdGcm9tVmlydHVhbFJlZ2lzdGVy KHNyYzIsIDQsIFg4Njo6ZWN4KTsKKyAgICAgICAgICAgIGVsc2UgeworICAgICAgICAgICAgICAg IF9fIGxpbmsoKCsraXRlciktPmZyb20sIF9fIGxhYmVsKCkpOworICAgICAgICAgICAgICAgIGVt aXRQdXRDVElBcmcoWDg2OjplY3gsIDQpOworICAgICAgICAgICAgfQorCiAgICAgICAgICAgICBl bWl0UHV0Q1RJQXJnKFg4Njo6ZWF4LCAwKTsKLSAgICAgICAgICAgIGVtaXRQdXRDVElBcmcoWDg2 OjplY3gsIDQpOwogICAgICAgICAgICAgZW1pdENUSUNhbGwoaSwgSW50ZXJwcmV0ZXI6OmN0aV9v cF9yc2hpZnQpOwogICAgICAgICAgICAgZW1pdFB1dFZpcnR1YWxSZWdpc3RlcihpbnN0cnVjdGlv bltpICsgMV0udS5vcGVyYW5kKTsKICAgICAgICAgICAgIGkgKz0gNDsK