226095 2021-05-21 11:31:23 -0700 Adopt CheckedLock in AudioMediaStreamTrackRendererUnit 2021-05-21 14:29:20 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=225603 https://bugs.webkit.org/show_bug.cgi?id=226056 InRadar P2 Normal --- 1 cdumez cdumez achristensen darin eric.carlson ews-watchlist ggaren glenn hta jer.noble peng.liu6 philipj sam sergio tommyw webkit-bug-importer youennf oldest_to_newest 1762495 0 cdumez 2021-05-21 11:31:23 -0700 Adopt CheckedLock in AudioMediaStreamTrackRendererUnit. 1762498 1 429315 cdumez 2021-05-21 11:33:41 -0700 Created attachment 429315 Patch 1762592 2 ews-feeder 2021-05-21 14:28:08 -0700 Committed r277889 (238026@main): <https://commits.webkit.org/238026@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429315. 1762594 3 webkit-bug-importer 2021-05-21 14:29:20 -0700 <rdar://problem/78328816> 429315 2021-05-21 11:33:41 -0700 2021-05-21 14:28:10 -0700 Patch bug-226095-20210521113340.patch text/plain 5485 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3ODcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWJiZDFjNjRjYjJmMTcy MDlkNTFiZTBkNDU3Y2IwYmRkZjNhNmM0Yi4uNzdjOTAzM2ZlYjIyM2MyNDJmNjI1MWU2N2ZkNDQ5 ZjM5MjdmNzkyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIxLTA1LTIxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQWRvcHQgQ2hlY2tlZExvY2sg aW4gQXVkaW9NZWRpYVN0cmVhbVRyYWNrUmVuZGVyZXJVbml0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjYwOTUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZG9wdCBDaGVja2VkTG9jayBpbiBBdWRpb01l ZGlhU3RyZWFtVHJhY2tSZW5kZXJlclVuaXQgdG8gYmVuZWZpdCBmcm9tIENsYW5nIFRocmVhZCBT YWZldHkKKyAgICAgICAgQW5hbHlzaXMuIEFsc28gcmVuYW1lIHZhcmlhYmxlcyBmb3IgY2xhcml0 eSBhbmQgZml4ZXMgYSBidWcgd2hlcmUgd2UgZmFpbGVkIHRvIGdyYWIgdGhlCisgICAgICAgIGxv Y2sgYmVmb3JlIGNoZWNraW5nIG1fc2hvdWxkVXBkYXRlUmVuZGVyU291cmNlcyBvbiB0aGUgcmVu ZGVyIHRocmVhZCAoZXZlbiB0aG91Z2ggdGhlCisgICAgICAgIHZhcmlhYmxlIGdldHMgdXBkYXRl ZCBvbiB0aGUgbWFpbiB0aHJlYWQpLgorCisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0v Y29jb2EvQXVkaW9NZWRpYVN0cmVhbVRyYWNrUmVuZGVyZXJVbml0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkF1ZGlvTWVkaWFTdHJlYW1UcmFja1JlbmRlcmVyVW5pdDo6YWRkU291cmNlKToKKyAg ICAgICAgKFdlYkNvcmU6OkF1ZGlvTWVkaWFTdHJlYW1UcmFja1JlbmRlcmVyVW5pdDo6cmVtb3Zl U291cmNlKToKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvTWVkaWFTdHJlYW1UcmFja1JlbmRlcmVy VW5pdDo6dXBkYXRlUmVuZGVyU291cmNlc0lmTmVjZXNzYXJ5KToKKyAgICAgICAgKFdlYkNvcmU6 OkF1ZGlvTWVkaWFTdHJlYW1UcmFja1JlbmRlcmVyVW5pdDo6cmVuZGVyKToKKyAgICAgICAgKiBw bGF0Zm9ybS9tZWRpYXN0cmVhbS9jb2NvYS9BdWRpb01lZGlhU3RyZWFtVHJhY2tSZW5kZXJlclVu aXQuaDoKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvTWVkaWFTdHJlYW1UcmFja1JlbmRlcmVyVW5p dDo6V1RGX0dVQVJERURfQllfTE9DSyk6CisgICAgICAgICgpOiBEZWxldGVkLgorCiAyMDIxLTA1 LTIxICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CiAKICAgICAgICAgZ3JpZCB0cmFjayBz aXplIHNob3VsZCByZWplY3QgdW5pdGxlc3MgbGVuZ3RoCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9jb2NvYS9BdWRpb01lZGlhU3RyZWFtVHJhY2tSZW5k ZXJlclVuaXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vY29jb2Ev QXVkaW9NZWRpYVN0cmVhbVRyYWNrUmVuZGVyZXJVbml0LmNwcAppbmRleCA0MGMzMDZiYWY0Y2Rm MjkxZjg5ZjIwNTNlNjhmYWRhYWVkYWU1ZWY1Li41ZGNlYTFhNDA4NmUyMGUxNTdlYmJjZDcxOWJj MzY2MDg5MDRiNjBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0 cmVhbS9jb2NvYS9BdWRpb01lZGlhU3RyZWFtVHJhY2tSZW5kZXJlclVuaXQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2NvY29hL0F1ZGlvTWVkaWFTdHJlYW1U cmFja1JlbmRlcmVyVW5pdC5jcHAKQEAgLTg5LDkgKzg5LDkgQEAgdm9pZCBBdWRpb01lZGlhU3Ry ZWFtVHJhY2tSZW5kZXJlclVuaXQ6OmFkZFNvdXJjZShSZWY8QXVkaW9TYW1wbGVEYXRhU291cmNl PiYmIHMKICAgICBtX3NvdXJjZXMuYWRkKFdURk1vdmUoc291cmNlKSk7CiAKICAgICB7Ci0gICAg ICAgIGF1dG8gbG9ja2VyID0gaG9sZExvY2sobV9zb3VyY2VzTG9jayk7Ci0gICAgICAgIG1fc291 cmNlc0NvcHkgPSBjb3B5VG9WZWN0b3IobV9zb3VyY2VzKTsKLSAgICAgICAgbV9zaG91bGRVcGRh dGVSZW5kZXJTb3VyY2VzID0gdHJ1ZTsKKyAgICAgICAgTG9ja2VyIGxvY2tlciB7IG1fcGVuZGlu Z1JlbmRlclNvdXJjZXNMb2NrIH07CisgICAgICAgIG1fcGVuZGluZ1JlbmRlclNvdXJjZXMgPSBj b3B5VG9WZWN0b3IobV9zb3VyY2VzKTsKKyAgICAgICAgbV9oYXNQZW5kaW5nUmVuZGVyU291cmNl cyA9IHRydWU7CiAgICAgfQogCiAgICAgaWYgKHNob3VsZFN0YXJ0KQpAQCAtMTA4LDkgKzEwOCw5 IEBAIHZvaWQgQXVkaW9NZWRpYVN0cmVhbVRyYWNrUmVuZGVyZXJVbml0OjpyZW1vdmVTb3VyY2Uo QXVkaW9TYW1wbGVEYXRhU291cmNlJiBzb3VyCiAgICAgc2hvdWxkU3RvcCAmPSBtX3NvdXJjZXMu aXNFbXB0eSgpOwogCiAgICAgewotICAgICAgICBhdXRvIGxvY2tlciA9IGhvbGRMb2NrKG1fc291 cmNlc0xvY2spOwotICAgICAgICBtX3NvdXJjZXNDb3B5ID0gY29weVRvVmVjdG9yKG1fc291cmNl cyk7Ci0gICAgICAgIG1fc2hvdWxkVXBkYXRlUmVuZGVyU291cmNlcyA9IHRydWU7CisgICAgICAg IExvY2tlciBsb2NrZXIgeyBtX3BlbmRpbmdSZW5kZXJTb3VyY2VzTG9jayB9OworICAgICAgICBt X3BlbmRpbmdSZW5kZXJTb3VyY2VzID0gY29weVRvVmVjdG9yKG1fc291cmNlcyk7CisgICAgICAg IG1faGFzUGVuZGluZ1JlbmRlclNvdXJjZXMgPSB0cnVlOwogICAgIH0KIAogICAgIGlmIChzaG91 bGRTdG9wKQpAQCAtMTM5LDE4ICsxMzksMjcgQEAgdm9pZCBBdWRpb01lZGlhU3RyZWFtVHJhY2tS ZW5kZXJlclVuaXQ6OnJldHJpZXZlRm9ybWF0RGVzY3JpcHRpb24oQ29tcGxldGlvbkhhbmQKICAg ICBtX2ludGVybmFsVW5pdC0+cmV0cmlldmVGb3JtYXREZXNjcmlwdGlvbihXVEZNb3ZlKGNhbGxi YWNrKSk7CiB9CiAKK3ZvaWQgQXVkaW9NZWRpYVN0cmVhbVRyYWNrUmVuZGVyZXJVbml0Ojp1cGRh dGVSZW5kZXJTb3VyY2VzSWZOZWNlc3NhcnkoKQoreworICAgIGlmICghbV9wZW5kaW5nUmVuZGVy U291cmNlc0xvY2sudHJ5TG9jaygpKQorICAgICAgICByZXR1cm47CisKKyAgICBMb2NrZXIgbG9j a2VyIHsgQWRvcHRMb2NrVGFnIHsgfSwgbV9wZW5kaW5nUmVuZGVyU291cmNlc0xvY2sgfTsKKyAg ICBpZiAoIW1faGFzUGVuZGluZ1JlbmRlclNvdXJjZXMpCisgICAgICAgIHJldHVybjsKKworICAg IG1fcmVuZGVyU291cmNlcyA9IFdURk1vdmUobV9wZW5kaW5nUmVuZGVyU291cmNlcyk7CisgICAg bV9oYXNQZW5kaW5nUmVuZGVyU291cmNlcyA9IGZhbHNlOworfQorCiB2b2lkIEF1ZGlvTWVkaWFT dHJlYW1UcmFja1JlbmRlcmVyVW5pdDo6cmVuZGVyKHNpemVfdCBzYW1wbGVDb3VudCwgQXVkaW9C dWZmZXJMaXN0JiBpb0RhdGEsIHVpbnQ2NF90IHNhbXBsZVRpbWUsIGRvdWJsZSBob3N0VGltZSwg QXVkaW9Vbml0UmVuZGVyQWN0aW9uRmxhZ3MmIGFjdGlvbkZsYWdzKQogewogICAgIC8vIEZvciBw ZXJmb3JtYW5jZSByZWFzb25zLCB3ZSBmb3JiaWQgaGVhcCBhbGxvY2F0aW9ucyB3aGlsZSBkb2lu ZyByZW5kZXJpbmcgb24gdGhlIGF1ZGlvIHRocmVhZC4KICAgICBGb3JiaWRNYWxsb2NVc2VGb3JD dXJyZW50VGhyZWFkU2NvcGUgZm9yYmlkTWFsbG9jVXNlOwogCiAgICAgQVNTRVJUKCFpc01haW5U aHJlYWQoKSk7Ci0gICAgaWYgKG1fc2hvdWxkVXBkYXRlUmVuZGVyU291cmNlcykgewotICAgICAg ICBpZiAoYXV0byBsb2NrZXIgPSB0cnlIb2xkTG9jayhtX3NvdXJjZXNMb2NrKSkgewotICAgICAg ICAgICAgbV9yZW5kZXJTb3VyY2VzID0gV1RGTW92ZShtX3NvdXJjZXNDb3B5KTsKLSAgICAgICAg ICAgIG1fc2hvdWxkVXBkYXRlUmVuZGVyU291cmNlcyA9IGZhbHNlOwotICAgICAgICB9Ci0gICAg fQorCisgICAgdXBkYXRlUmVuZGVyU291cmNlc0lmTmVjZXNzYXJ5KCk7CiAKICAgICBpZiAobV9y ZW5kZXJTb3VyY2VzLmlzRW1wdHkoKSkgewogICAgICAgICBhY3Rpb25GbGFncyA9IGtBdWRpb1Vu aXRSZW5kZXJBY3Rpb25fT3V0cHV0SXNTaWxlbmNlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vY29jb2EvQXVkaW9NZWRpYVN0cmVhbVRyYWNrUmVuZGVy ZXJVbml0LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9jb2NvYS9BdWRp b01lZGlhU3RyZWFtVHJhY2tSZW5kZXJlclVuaXQuaAppbmRleCBlNWVmZGYwMzI2YjJjNjg3OTVm YjdmZTZkNTdlYzc1ZmEyMGMyYWU2Li5jNjM0NGYxNzhkOTliNzY0MWRmNWI4YTI0ZDExYWU5Mjk5 ZmUyNmUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9j b2NvYS9BdWRpb01lZGlhU3RyZWFtVHJhY2tSZW5kZXJlclVuaXQuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9jb2NvYS9BdWRpb01lZGlhU3RyZWFtVHJhY2tSZW5k ZXJlclVuaXQuaApAQCAtMjgsNiArMjgsNyBAQAogI2lmIEVOQUJMRShNRURJQV9TVFJFQU0pCiAK ICNpbmNsdWRlICJBdWRpb01lZGlhU3RyZWFtVHJhY2tSZW5kZXJlckludGVybmFsVW5pdC5oIgor I2luY2x1ZGUgPHd0Zi9DaGVja2VkTG9jay5oPgogI2luY2x1ZGUgPHd0Zi9Gb3J3YXJkLmg+CiAj aW5jbHVkZSA8d3RmL0hhc2hTZXQuaD4KICNpbmNsdWRlIDx3dGYvVW5pcXVlUmVmLmg+CkBAIC02 NCwxMiArNjUsMTMgQEAgcHJpdmF0ZToKICAgICB2b2lkIHN0b3AoKTsKIAogICAgIHZvaWQgY3Jl YXRlQXVkaW9Vbml0SWZOZWVkZWQoKTsKKyAgICB2b2lkIHVwZGF0ZVJlbmRlclNvdXJjZXNJZk5l Y2Vzc2FyeSgpOwogCiAgICAgSGFzaFNldDxSZWY8QXVkaW9TYW1wbGVEYXRhU291cmNlPj4gbV9z b3VyY2VzOwotICAgIFZlY3RvcjxSZWY8QXVkaW9TYW1wbGVEYXRhU291cmNlPj4gbV9zb3VyY2Vz Q29weTsKKyAgICBWZWN0b3I8UmVmPEF1ZGlvU2FtcGxlRGF0YVNvdXJjZT4+IG1fcGVuZGluZ1Jl bmRlclNvdXJjZXMgV1RGX0dVQVJERURfQllfTE9DSyhtX3BlbmRpbmdSZW5kZXJTb3VyY2VzTG9j ayk7CiAgICAgVmVjdG9yPFJlZjxBdWRpb1NhbXBsZURhdGFTb3VyY2U+PiBtX3JlbmRlclNvdXJj ZXM7Ci0gICAgYm9vbCBtX3Nob3VsZFVwZGF0ZVJlbmRlclNvdXJjZXMgeyBmYWxzZSB9OwotICAg IExvY2sgbV9zb3VyY2VzTG9jazsKKyAgICBib29sIG1faGFzUGVuZGluZ1JlbmRlclNvdXJjZXMg V1RGX0dVQVJERURfQllfTE9DSyhtX3BlbmRpbmdSZW5kZXJTb3VyY2VzTG9jaykgeyBmYWxzZSB9 OworICAgIENoZWNrZWRMb2NrIG1fcGVuZGluZ1JlbmRlclNvdXJjZXNMb2NrOwogICAgIFVuaXF1 ZVJlZjxBdWRpb01lZGlhU3RyZWFtVHJhY2tSZW5kZXJlckludGVybmFsVW5pdD4gbV9pbnRlcm5h bFVuaXQ7CiB9OwogCg==