226073 2021-05-21 03:17:17 -0700 Compile error when ANGLE is used on Linux 2021-05-21 07:58:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Local Build Unspecified Linux RESOLVED FIXED InRadar P2 Normal --- 1 estea webkit-unassigned aperez bugs-noreply estea mcatanzaro webkit-bug-importer oldest_to_newest 1762350 0 estea 2021-05-21 03:17:17 -0700 In platform/graphics/nicosia/texmap/NicosiaGCGLLayer.cpp: Function paintRenderingResultsToCanvas expects a reference, but a pointer is passed instead causing compile errors when ANGLE is used. 1762352 1 429279 estea 2021-05-21 03:27:24 -0700 Created attachment 429279 Patch 1762412 2 ews-feeder 2021-05-21 07:54:42 -0700 Committed r277861 (238003@main): <https://commits.webkit.org/238003@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429279. 1762413 3 webkit-bug-importer 2021-05-21 07:55:17 -0700 <rdar://problem/78310259> 1762414 4 429279 mcatanzaro 2021-05-21 07:58:18 -0700 Comment on attachment 429279 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429279&action=review > Source/WebCore/ChangeLog:4 > + Function paintRenderingResultsToCanvas expects a reference, not a > + pointer. Fixed the compile error. In the future: the first line of the changelog is normally the bug title. You can write your commit message underneath the reviewed by line, below. 429279 2021-05-21 03:27:24 -0700 2021-05-21 07:54:43 -0700 Patch bug-226073-20210521132723.patch text/plain 1986 estea U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3ODUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGYxZTVhYTExM2JmZjY0 ZGQyMTZhZGZkODAxMWNkZjVhMjFlOWExYi4uNDMxMTQyNTcyOWRmYjcyNWE4MDNkNjZiN2QyMWQw OTU3YmJlYmQ5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA1LTIxICBFbGVu aSBNYXJpYSBTdGVhICA8ZXN0ZWFAaWdhbGlhLmNvbT4KKworICAgICAgICBGdW5jdGlvbiBwYWlu dFJlbmRlcmluZ1Jlc3VsdHNUb0NhbnZhcyBleHBlY3RzIGEgcmVmZXJlbmNlLCBub3QgYQorICAg ICAgICBwb2ludGVyLiBGaXhlZCB0aGUgY29tcGlsZSBlcnJvci4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjA3MworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvbmljb3Np YS90ZXhtYXAvTmljb3NpYUdDR0xMYXllci5jcHA6CisgICAgICAgIChOaWNvc2lhOjpHQ0dMTGF5 ZXI6OnN3YXBCdWZmZXJzSWZOZWVkZWQpOgorCiAyMDIxLTA1LTIwICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IGxvY2tpbmcgaW4gUGxhdGZvcm1DQUxheWVy CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9uaWNvc2lhL3Rl eG1hcC9OaWNvc2lhR0NHTExheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL25pY29zaWEvdGV4bWFwL05pY29zaWFHQ0dMTGF5ZXIuY3BwCmluZGV4IGM3NzhiYjMwMjM2 MGRiYTlhY2NkY2M5MmRhMWIwM2E3YTVmZTE5NTIuLmE0NDYwZjkwNjMwNzQ3YThmODM3MmFhMDk4 NDhlNDk2ZTZiNTQxMzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL25pY29zaWEvdGV4bWFwL05pY29zaWFHQ0dMTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL25pY29zaWEvdGV4bWFwL05pY29zaWFHQ0dMTGF5ZXIuY3Bw CkBAIC04MSwxMSArODEsMTEgQEAgdm9pZCBHQ0dMTGF5ZXI6OnN3YXBCdWZmZXJzSWZOZWVkZWQo KQogICAgIEludFNpemUgdGV4dHVyZVNpemUobV9jb250ZXh0Lm1fY3VycmVudFdpZHRoLCBtX2Nv bnRleHQubV9jdXJyZW50SGVpZ2h0KTsKICAgICBUZXh0dXJlTWFwcGVyR0w6OkZsYWdzIGZsYWdz ID0gbV9jb250ZXh0LmNvbnRleHRBdHRyaWJ1dGVzKCkuYWxwaGEgPyBUZXh0dXJlTWFwcGVyR0w6 OlNob3VsZEJsZW5kIDogMDsKICNpZiBVU0UoQU5HTEUpCi0gICAgYXV0byBpbWFnZUJ1ZmZlciA9 IEltYWdlQnVmZmVyOjpjcmVhdGUodGV4dHVyZVNpemUsIFJlbmRlcmluZ01vZGU6OlVuYWNjZWxl cmF0ZWQsIDEsIERlc3RpbmF0aW9uQ29sb3JTcGFjZTo6U1JHQiwgUGl4ZWxGb3JtYXQ6OkJHUkE4 KTsKKyAgICBSZWZQdHI8V2ViQ29yZTo6SW1hZ2VCdWZmZXI+IGltYWdlQnVmZmVyID0gSW1hZ2VC dWZmZXI6OmNyZWF0ZSh0ZXh0dXJlU2l6ZSwgUmVuZGVyaW5nTW9kZTo6VW5hY2NlbGVyYXRlZCwg MSwgRGVzdGluYXRpb25Db2xvclNwYWNlOjpTUkdCLCBQaXhlbEZvcm1hdDo6QkdSQTgpOwogICAg IGlmICghaW1hZ2VCdWZmZXIpCiAgICAgICAgIHJldHVybjsKIAotICAgIG1fY29udGV4dC5wYWlu dFJlbmRlcmluZ1Jlc3VsdHNUb0NhbnZhcyhpbWFnZUJ1ZmZlci5nZXQoKSk7CisgICAgbV9jb250 ZXh0LnBhaW50UmVuZGVyaW5nUmVzdWx0c1RvQ2FudmFzKCppbWFnZUJ1ZmZlci5nZXQoKSk7CiAg ICAgUmVmUHRyPEltYWdlPiBpbWFnZSA9IGltYWdlQnVmZmVyLT5jb3B5SW1hZ2UoRG9udENvcHlC YWNraW5nU3RvcmUpOwogICAgIGlmICghaW1hZ2UpCiAgICAgICAgIHJldHVybjsK