226059 2021-05-20 17:29:42 -0700 Add missing locks in Language.cpp 2021-05-20 18:29:24 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=226040 https://bugs.webkit.org/show_bug.cgi?id=226038 InRadar P2 Normal --- 1 cdumez cdumez achristensen benjamin cmarcelo darin ddkilzer ews-watchlist ggaren kkinnunen sam webkit-bug-importer oldest_to_newest 1762239 0 cdumez 2021-05-20 17:29:42 -0700 Add missing locks in Language.cpp. This was found via Clang Thread Safety Analysis. 1762240 1 429248 cdumez 2021-05-20 17:34:00 -0700 Created attachment 429248 Patch 1762255 2 ews-feeder 2021-05-20 18:28:26 -0700 Committed r277843 (237985@main): <https://commits.webkit.org/237985@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429248. 1762256 3 webkit-bug-importer 2021-05-20 18:29:24 -0700 <rdar://problem/78287852> 429248 2021-05-20 17:34:00 -0700 2021-05-20 18:28:28 -0700 Patch bug-226059-20210520173359.patch text/plain 3241 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3ODM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDI2NDZlYTk2Mjk1ZTg3Njk5OWIxMjZl OTM1ODk2NmVmMGFlNjM1ODguLmIwZWMxMGI2YjFhZTcwYzBkYmZmMTYzNTIzOWQxMjc2YzY5MjUy ODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjEtMDUtMjAgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgbWlzc2luZyBsb2NrcyBpbiBMYW5ndWFnZS5jcHAK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjA1OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBtaXNz aW5nIGxvY2tzIGluIExhbmd1YWdlLmNwcC4gVGhpcyB3YXMgZm91bmQgdmlhIENsYW5nIFRocmVh ZCBTYWZldHkgQW5hbHlzaXMuCisgICAgICAgIFNvbWUgb2YgdGhlIG92ZXJyaWRlVXNlclByZWZl cnJlZExhbmd1YWdlcygpIGNhbGwgc2l0ZXMgd2VyZSBmYWlsaW5nIHRvIGdyYWIgdGhlCisgICAg ICAgIGxvY2sgZmlyc3QuCisKKyAgICAgICAgQWxzbyB1c2UgTmV2ZXJEZXN0cm95ZWQgaW4gcHJl ZmVycmVkTGFuZ3VhZ2VzT3ZlcnJpZGUoKSBpbnN0ZWFkIG9mIExhenlOZXZlckRlc3Ryb3llZAor ICAgICAgICB3aXRoIHN0ZDo6Y2FsbF9vbmNlLiBBbGwgY2FsbCBzaXRlcyBhcmUgYWxyZWFkeSBn cmFiYmluZyBhIGxvY2sgc28gdGhlcmUgaXMgbm8gbmVlZAorICAgICAgICBmb3IgZXh0cmEgc3lu Y2hyb25pemF0aW9uLgorCisgICAgICAgICogd3RmL0xhbmd1YWdlLmNwcDoKKyAgICAgICAgKFdU Rjo6V1RGX1JFUVVJUkVTX0xPQ0spOgorICAgICAgICAoV1RGOjp1c2VyUHJlZmVycmVkTGFuZ3Vh Z2VzT3ZlcnJpZGUpOgorICAgICAgICAoV1RGOjpvdmVycmlkZVVzZXJQcmVmZXJyZWRMYW5ndWFn ZXMpOgorICAgICAgICAoV1RGOjp1c2VyUHJlZmVycmVkTGFuZ3VhZ2VzKToKKyAgICAgICAgKFdU Rjo6cHJlZmVycmVkTGFuZ3VhZ2VzT3ZlcnJpZGUpOiBEZWxldGVkLgorCiAyMDIxLTA1LTE5ICBB bGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRk IHN1cHBvcnQgZm9yIE5hdmlnYXRpb24gVGltaW5nIExldmVsIDIKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XVEYvd3RmL0xhbmd1YWdlLmNwcCBiL1NvdXJjZS9XVEYvd3RmL0xhbmd1YWdlLmNwcAppbmRl eCAxNzJkMDk4Yjg0ZDU2MDgxNGE0OWZiN2RhYjhhZjNkOGZlOWE1ODQyLi5iZTYyNThkODU3ZTU5 ODhmOTY5ODM5MDIwMmJjYzkzYzNjMTc4MjBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9M YW5ndWFnZS5jcHAKKysrIGIvU291cmNlL1dURi93dGYvTGFuZ3VhZ2UuY3BwCkBAIC0yNiw2ICsy Niw3IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSA8d3RmL0xhbmd1YWdlLmg+CiAK KyNpbmNsdWRlIDx3dGYvQ2hlY2tlZExvY2suaD4KICNpbmNsdWRlIDx3dGYvSGFzaE1hcC5oPgog I2luY2x1ZGUgPHd0Zi9OZXZlckRlc3Ryb3llZC5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0 cmluZy5oPgpAQCAtMzYsNyArMzcsMTIgQEAKIAogbmFtZXNwYWNlIFdURiB7CiAKLXN0YXRpYyBM b2NrIHVzZXJQcmVmZXJyZWRMYW5ndWFnZXNNdXRleDsKK3N0YXRpYyBDaGVja2VkTG9jayBwcmVm ZXJyZWRMYW5ndWFnZXNPdmVycmlkZUxvY2s7CitzdGF0aWMgVmVjdG9yPFN0cmluZz4mIHByZWZl cnJlZExhbmd1YWdlc092ZXJyaWRlKCkgV1RGX1JFUVVJUkVTX0xPQ0socHJlZmVycmVkTGFuZ3Vh Z2VzT3ZlcnJpZGVMb2NrKQoreworICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxWZWN0b3I8U3Ry aW5nPj4gb3ZlcnJpZGU7CisgICAgcmV0dXJuIG92ZXJyaWRlOworfQogCiB0eXBlZGVmIEhhc2hN YXA8dm9pZCosIExhbmd1YWdlQ2hhbmdlT2JzZXJ2ZXJGdW5jdGlvbj4gT2JzZXJ2ZXJNYXA7CiBz dGF0aWMgT2JzZXJ2ZXJNYXAmIG9ic2VydmVyTWFwKCkKQEAgLTc4LDI0ICs4NCwxOCBAQCBTdHJp bmcgZGVmYXVsdExhbmd1YWdlKCkKICAgICByZXR1cm4gZW1wdHlTdHJpbmcoKTsKIH0KIAotc3Rh dGljIFZlY3RvcjxTdHJpbmc+JiBwcmVmZXJyZWRMYW5ndWFnZXNPdmVycmlkZSgpCi17Ci0gICAg c3RhdGljIExhenlOZXZlckRlc3Ryb3llZDxWZWN0b3I8U3RyaW5nPj4gb3ZlcnJpZGU7Ci0gICAg c3RhdGljIHN0ZDo6b25jZV9mbGFnIG9uY2VLZXk7Ci0gICAgc3RkOjpjYWxsX29uY2Uob25jZUtl eSwgWyZdIHsKLSAgICAgICAgb3ZlcnJpZGUuY29uc3RydWN0KCk7Ci0gICAgfSk7Ci0gICAgcmV0 dXJuIG92ZXJyaWRlOwotfQotCiBWZWN0b3I8U3RyaW5nPiB1c2VyUHJlZmVycmVkTGFuZ3VhZ2Vz T3ZlcnJpZGUoKQogeworICAgIExvY2tlciBsb2NrZXIgeyBwcmVmZXJyZWRMYW5ndWFnZXNPdmVy cmlkZUxvY2sgfTsKICAgICByZXR1cm4gcHJlZmVycmVkTGFuZ3VhZ2VzT3ZlcnJpZGUoKTsKIH0K IAogdm9pZCBvdmVycmlkZVVzZXJQcmVmZXJyZWRMYW5ndWFnZXMoY29uc3QgVmVjdG9yPFN0cmlu Zz4mIG92ZXJyaWRlKQogewotICAgIHByZWZlcnJlZExhbmd1YWdlc092ZXJyaWRlKCkgPSBvdmVy cmlkZTsKKyAgICB7CisgICAgICAgIExvY2tlciBsb2NrZXIgeyBwcmVmZXJyZWRMYW5ndWFnZXNP dmVycmlkZUxvY2sgfTsKKyAgICAgICAgcHJlZmVycmVkTGFuZ3VhZ2VzT3ZlcnJpZGUoKSA9IG92 ZXJyaWRlOworICAgIH0KICAgICBsYW5ndWFnZURpZENoYW5nZSgpOwogfQogCkBAIC0xMTEsNyAr MTExLDcgQEAgc3RhdGljIFZlY3RvcjxTdHJpbmc+IGlzb2xhdGVkQ29weShjb25zdCBWZWN0b3I8 U3RyaW5nPiYgc3RyaW5ncykKIFZlY3RvcjxTdHJpbmc+IHVzZXJQcmVmZXJyZWRMYW5ndWFnZXMo KQogewogICAgIHsKLSAgICAgICAgYXV0byBsb2NrZXIgPSBob2xkTG9jayh1c2VyUHJlZmVycmVk TGFuZ3VhZ2VzTXV0ZXgpOworICAgICAgICBMb2NrZXIgbG9ja2VyIHsgcHJlZmVycmVkTGFuZ3Vh Z2VzT3ZlcnJpZGVMb2NrIH07CiAgICAgICAgIFZlY3RvcjxTdHJpbmc+JiBvdmVycmlkZSA9IHBy ZWZlcnJlZExhbmd1YWdlc092ZXJyaWRlKCk7CiAgICAgICAgIGlmICghb3ZlcnJpZGUuaXNFbXB0 eSgpKQogICAgICAgICAgICAgcmV0dXJuIGlzb2xhdGVkQ29weShvdmVycmlkZSk7Cg==