226048 2021-05-20 15:47:47 -0700 [iOS][FCR] <select> options are unnecessarily truncated 2021-05-20 19:37:51 -0700 1 1 1 Unclassified WebKit Forms Other iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 akeerthi akeerthi cdumez thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1762183 0 akeerthi 2021-05-20 15:47:47 -0700 ... 1762185 1 akeerthi 2021-05-20 15:48:03 -0700 <rdar://problem/76008154> 1762186 2 429234 akeerthi 2021-05-20 15:49:46 -0700 Created attachment 429234 Patch 1762221 3 429234 thorton 2021-05-20 17:02:06 -0700 Comment on attachment 429234 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429234&action=review > Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:477 > +#define UIMenuOptionsPrivateRemoveLineLimitForChildren (1 << 6) I think you want a WK prefix here? Or maybe it's OK and the compiler won't whine if it has the real one because it's a #define? Also, does UIKit ignore the random flag bit if it /doesn't/ have this change? 1762262 4 akeerthi 2021-05-20 19:15:03 -0700 (In reply to Tim Horton from comment #3) > Comment on attachment 429234 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=429234&action=review > > > Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:477 > > +#define UIMenuOptionsPrivateRemoveLineLimitForChildren (1 << 6) > > I think you want a WK prefix here? Or maybe it's OK and the compiler won't > whine if it has the real one because it's a #define? Yeah, it's fine because it's a #define. (Wenson suggested this approach) > Also, does UIKit ignore the random flag bit if it /doesn't/ have this change? It's ignored. I verified the change has no effect if the corresponding UIKit change is not present. 1762272 5 ews-feeder 2021-05-20 19:37:50 -0700 Committed r277846 (237988@main): <https://commits.webkit.org/237988@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429234. 429234 2021-05-20 15:49:46 -0700 2021-05-20 19:37:50 -0700 Patch bug-226048-20210520184945.patch text/plain 2539 akeerthi U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3NjAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ2ZWQwYjFkNDQ2ZTBlZGIy MjA0NjMyZGE4NTE1ZmY5YjQ5MTAyMDguLjhlYTllZGQ1M2FiMmRkOGYzNmU3OGE1YzQ2ZjI2NDNi ZmIyYmQ1ZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDUtMjAgIEFkaXR5YSBL ZWVydGhpICA8YWtlZXJ0aGlAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdW0ZDUl0gPHNlbGVj dD4gb3B0aW9ucyBhcmUgdW5uZWNlc3NhcmlseSB0cnVuY2F0ZWQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjA0OAorICAgICAgICA8cmRhcjovL3By b2JsZW0vNzYwMDgxNTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRm9ybVNlbGVjdFBpY2tlci5tbToKKyAg ICAgICAgKC1bV0tTZWxlY3RQaWNrZXIgY3JlYXRlTWVudV0pOgorCisgICAgICAgIFVJTWVudSdz IGN1cnJlbnRseSBsaW1pdCBhY3Rpb24gdGl0bGVzIHRvIHR3byBsaW5lcy4gVXNlIFNQSSB0byBy ZW1vdmUKKyAgICAgICAgdGhlIGxpbWl0IGFuZCBhdm9pZCB1bm5lY2Vzc2FyeSB0cnVuY2F0aW9u LgorCiAyMDIxLTA1LTE5ICBBZGl0eWEgS2VlcnRoaSAgPGFrZWVydGhpQGFwcGxlLmNvbT4KIAog ICAgICAgICBbaU9TXVtGQ1JdIDxzZWxlY3QgbXVsdGlwbGU+IHBpY2tlciBzaG91bGQgY29sbGFw c2Ugc2VjdGlvbnMgd2hlbiB0YXBwaW5nIGFueXdoZXJlIG9uIGEgZ3JvdXAgaGVhZGVyCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGb3JtU2VsZWN0UGlj a2VyLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRm9ybVNlbGVjdFBp Y2tlci5tbQppbmRleCBmNDE0Y2M0ZDYyZGE3NzhhMzc0NTcwYTY5ODE3ZTI1OTNmY2QzM2QxLi42 MTk1MjdiNTljODIyZGJhMzZjMGU2ZmQyYzQyODZhOWIzOTNlMDgzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGb3JtU2VsZWN0UGlja2VyLm1tCisrKyBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0Zvcm1TZWxlY3RQaWNrZXIubW0K QEAgLTQ3Myw2ICs0NzMsOSBAQCBzdGF0aWMgY29uc3QgZmxvYXQgR3JvdXBPcHRpb25UZXh0Q29s b3JBbHBoYSA9IDAuNTsKIAogI3ByYWdtYSBtYXJrIC0gRm9ybSBDb250cm9sIFJlZnJlc2gKIAor Ly8gRklYTUU6IFJlbW92ZSBvbmNlIDxyZGFyOi8vcHJvYmxlbS83NjQzMDM3Nj4gaXMgaW4gYW4g U0RLLgorI2RlZmluZSBVSU1lbnVPcHRpb25zUHJpdmF0ZVJlbW92ZUxpbmVMaW1pdEZvckNoaWxk cmVuICgxIDw8IDYpCisKIEBpbXBsZW1lbnRhdGlvbiBXS1NlbGVjdFBpY2tlciB7CiAgICAgX193 ZWFrIFdLQ29udGVudFZpZXcgKl92aWV3OwogICAgIENHUG9pbnQgX2ludGVyYWN0aW9uUG9pbnQ7 CkBAIC01ODIsNyArNTg1LDcgQEAgc3RhdGljIGNvbnN0IGZsb2F0IEdyb3VwT3B0aW9uVGV4dENv bG9yQWxwaGEgPSAwLjU7CiAgICAgICAgICAgICAgICAgY3VycmVudEluZGV4Kys7CiAgICAgICAg ICAgICB9CiAKLSAgICAgICAgICAgIFVJTWVudSAqZ3JvdXBNZW51ID0gW1VJTWVudSBtZW51V2l0 aFRpdGxlOmdyb3VwVGV4dCBpbWFnZTpuaWwgaWRlbnRpZmllcjpuaWwgb3B0aW9uczpVSU1lbnVP cHRpb25zRGlzcGxheUlubGluZSBjaGlsZHJlbjpncm91cGVkSXRlbXNdOworICAgICAgICAgICAg VUlNZW51ICpncm91cE1lbnUgPSBbVUlNZW51IG1lbnVXaXRoVGl0bGU6Z3JvdXBUZXh0IGltYWdl Om5pbCBpZGVudGlmaWVyOm5pbCBvcHRpb25zOihVSU1lbnVPcHRpb25zRGlzcGxheUlubGluZSB8 IFVJTWVudU9wdGlvbnNQcml2YXRlUmVtb3ZlTGluZUxpbWl0Rm9yQ2hpbGRyZW4pIGNoaWxkcmVu Omdyb3VwZWRJdGVtc107CiAgICAgICAgICAgICBbaXRlbXMgYWRkT2JqZWN0Omdyb3VwTWVudV07 CiAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgfQpAQCAtNTkzLDcgKzU5Niw3IEBAIHN0 YXRpYyBjb25zdCBmbG9hdCBHcm91cE9wdGlvblRleHRDb2xvckFscGhhID0gMC41OwogICAgICAg ICBjdXJyZW50SW5kZXgrKzsKICAgICB9CiAKLSAgICByZXR1cm4gW1VJTWVudSBtZW51V2l0aFRp dGxlOkAiIiBjaGlsZHJlbjppdGVtc107CisgICAgcmV0dXJuIFtVSU1lbnUgbWVudVdpdGhUaXRs ZTpAIiIgaW1hZ2U6bmlsIGlkZW50aWZpZXI6bmlsIG9wdGlvbnM6VUlNZW51T3B0aW9uc1ByaXZh dGVSZW1vdmVMaW5lTGltaXRGb3JDaGlsZHJlbiBjaGlsZHJlbjppdGVtc107CiB9CiAKIC0gKFVJ QWN0aW9uICopYWN0aW9uRm9yT3B0aW9uSXRlbTooY29uc3QgT3B0aW9uSXRlbSYpb3B0aW9uIHdp dGhJbmRleDooTlNJbnRlZ2VyKW9wdGlvbkluZGV4Cg==