226042 2021-05-20 14:23:30 -0700 Video player enters a bad state after trying to enter picture-in-picture on YouTube.com videos 2021-05-21 14:12:31 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 peng.liu6 peng.liu6 dbates eric.carlson jer.noble webkit-bug-importer oldest_to_newest 1762134 0 peng.liu6 2021-05-20 14:23:30 -0700 Video player enters a bad state after trying to enter picture-in-picture on YouTube.com videos 1762138 1 peng.liu6 2021-05-20 14:27:54 -0700 <rdar://76733650> 1762139 2 429222 peng.liu6 2021-05-20 14:28:16 -0700 Created attachment 429222 Patch 1762485 3 429222 dbates 2021-05-21 10:52:21 -0700 Comment on attachment 429222 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429222&action=review > Source/WebCore/ChangeLog:9 > + always true. This patch fixes that. Consider explaining about std::optional 1762580 4 ews-feeder 2021-05-21 14:12:29 -0700 Committed r277886 (238023@main): <https://commits.webkit.org/238023@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429222. 429222 2021-05-20 14:28:16 -0700 2021-05-21 14:12:30 -0700 Patch bug-226042-20210520142815.patch text/plain 2154 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3Nzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmUyMWVkYzJkNGNkZDgx Yjc3MDI0ZWJlMzhlZDhhOTdhYTI2YzgwMi4uZjM5Yjg4Y2EwMjE1MGFiYWI0MTc2OThjMTI3OWNk YmYwMDgzNzE5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA1LTIwICBQZW5n IExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAgICAgVmlkZW8gcGxheWVyIGVudGVy cyBhIGJhZCBzdGF0ZSBhZnRlciB0cnlpbmcgdG8gZW50ZXIgcGljdHVyZS1pbi1waWN0dXJlIG9u IFlvdVR1YmUuY29tIHZpZGVvcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjI2MDQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGhlIHF1aXJrIGBzaG91bGREaXNhYmxlRW5kRnVsbHNjcmVlbkV2ZW50V2hl bkVudGVyaW5nUGljdHVyZUluUGljdHVyZUZyb21GdWxsYCB3YXMKKyAgICAgICAgYWx3YXlzIHRy dWUuIFRoaXMgcGF0Y2ggZml4ZXMgdGhhdC4KKworICAgICAgICAqIHBhZ2UvUXVpcmtzLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlF1aXJrczo6c2hvdWxkRGlzYWJsZUVuZEZ1bGxzY3JlZW5FdmVu dFdoZW5FbnRlcmluZ1BpY3R1cmVJblBpY3R1cmVGcm9tRnVsbHNjcmVlblF1aXJrIGNvbnN0KToK KwogMjAyMS0wNS0yMCAgUGVuZyBMaXUgIDxwZW5nLmxpdTZAYXBwbGUuY29tPgogCiAgICAgICAg IEFpclBsYXkgaWNvbiBvZiB0aGUgVmltZW8uY29tIHZpZGVvIHBsYXllciBpcyBtaXNzaW5nIGFm dGVyIHJlbG9hZGluZyB0aGUgcGFnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9R dWlya3MuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuY3BwCmluZGV4IDM5YjBlNjIx MjIzNmE0ZDg0MmU5ZWJmN2RmYjYxMDVkZjcwYzhjOTAuLmU3MGIyYmZmZmJiZmUxOWNmYjgxMDUw MWFiMzJmZDczMGNkMmE5MWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtz LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5jcHAKQEAgLTE0MjUsMTAgKzE0 MjUsOSBAQCBib29sIFF1aXJrczo6c2hvdWxkRGlzYWJsZUVuZEZ1bGxzY3JlZW5FdmVudFdoZW5F bnRlcmluZ1BpY3R1cmVJblBpY3R1cmVGcm9tRnVsbAogCiAgICAgaWYgKCFtX3Nob3VsZERpc2Fi bGVFbmRGdWxsc2NyZWVuRXZlbnRXaGVuRW50ZXJpbmdQaWN0dXJlSW5QaWN0dXJlRnJvbUZ1bGxz Y3JlZW5RdWlyaykgewogICAgICAgICBhdXRvIGhvc3QgPSBtX2RvY3VtZW50LT50b3BEb2N1bWVu dCgpLnVybCgpLmhvc3QoKTsKLSAgICAgICAgbV9zaG91bGREaXNhYmxlRW5kRnVsbHNjcmVlbkV2 ZW50V2hlbkVudGVyaW5nUGljdHVyZUluUGljdHVyZUZyb21GdWxsc2NyZWVuUXVpcmsgPSBlcXVh bExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZShob3N0LCAidHJhaWxlcnMuYXBwbGUuY29tIik7Ci0K ICAgICAgICAgYXV0byBkb21haW4gPSBSZWdpc3RyYWJsZURvbWFpbihtX2RvY3VtZW50LT50b3BE b2N1bWVudCgpLnVybCgpKTsKLSAgICAgICAgbV9zaG91bGREaXNhYmxlRW5kRnVsbHNjcmVlbkV2 ZW50V2hlbkVudGVyaW5nUGljdHVyZUluUGljdHVyZUZyb21GdWxsc2NyZWVuUXVpcmsgPSBtX3No b3VsZERpc2FibGVFbmRGdWxsc2NyZWVuRXZlbnRXaGVuRW50ZXJpbmdQaWN0dXJlSW5QaWN0dXJl RnJvbUZ1bGxzY3JlZW5RdWlyayB8fCBkb21haW4gPT0gImVzcG4uY29tIl9zOworCisgICAgICAg IG1fc2hvdWxkRGlzYWJsZUVuZEZ1bGxzY3JlZW5FdmVudFdoZW5FbnRlcmluZ1BpY3R1cmVJblBp Y3R1cmVGcm9tRnVsbHNjcmVlblF1aXJrID0gZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2Uo aG9zdCwgInRyYWlsZXJzLmFwcGxlLmNvbSIpIHx8IGRvbWFpbiA9PSAiZXNwbi5jb20iX3M7CiAg ICAgfQogCiAgICAgcmV0dXJuICptX3Nob3VsZERpc2FibGVFbmRGdWxsc2NyZWVuRXZlbnRXaGVu RW50ZXJpbmdQaWN0dXJlSW5QaWN0dXJlRnJvbUZ1bGxzY3JlZW5RdWlyazsK