226027 2021-05-20 10:29:40 -0700 The test of SmallSet.cpp should pass the right HashTrait to the HashSet it uses as a reference 2021-05-20 12:34:42 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 225848 1 rmorisset rmorisset amir_mark mark.lam webkit-bug-importer oldest_to_newest 1762020 0 rmorisset 2021-05-20 10:29:40 -0700 SmallSet allows all values except for the max value. So we test it on small values, including 0. HashSet by default forbids 0, so it made the test crash. We can trivially fix it by passing UnsignedWithZeroKeyHashTraits, which allows everything which is not max() or max()-1 1762023 1 429185 rmorisset 2021-05-20 10:31:22 -0700 Created attachment 429185 Patch 1762024 2 rmorisset 2021-05-20 10:32:28 -0700 rdar://78217299 1762030 3 rmorisset 2021-05-20 10:35:07 -0700 *** Bug 225978 has been marked as a duplicate of this bug. *** 1762057 4 429185 mark.lam 2021-05-20 11:33:28 -0700 Comment on attachment 429185 Patch r=me 1762058 5 mark.lam 2021-05-20 11:34:58 -0700 (In reply to Robin Morisset from comment #0) > SmallSet allows all values except for the max value. > So we test it on small values, including 0. > > HashSet by default forbids 0, so it made the test crash. > We can trivially fix it by passing UnsignedWithZeroKeyHashTraits, which > allows everything which is not max() or max()-1 You should put this explanation in the ChangeLog. 1762077 6 429202 rmorisset 2021-05-20 12:09:51 -0700 Created attachment 429202 Patch for landing 1762089 7 ews-feeder 2021-05-20 12:34:40 -0700 Committed r277817 (237964@main): <https://commits.webkit.org/237964@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429202. 429185 2021-05-20 10:31:22 -0700 2021-05-20 12:09:51 -0700 Patch patch226027 text/plain 1374 rmorisset ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmZjVm ZGFmZmM0ZGUuLjI4NDc2ODVjOGU4YiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA1LTIwICBSb2JpbiBNb3Jp c3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlIHRlc3Qgb2YgU21hbGxT ZXQuY3BwIHNob3VsZCBwYXNzIHRoZSByaWdodCBIYXNoVHJhaXQgdG8gdGhlIEhhc2hTZXQgaXQg dXNlcyBhcyBhIHJlZmVyZW5jZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjI2MDI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRml4IG1pc3NpbmcgSGFzaFRyYWl0IGluIHRoZSB0ZXN0IG9mIHd0Zi9TbWFs bFNldC5jcHAKKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1NtYWxsU2V0LmNw cDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OnRlc3RTbWFsbFNldE9mVW5zaWduZWQpOgorCiAy MDIxLTA1LTE5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgRHJv cCAiZ2V0IiBwcmVmaXggZnJvbSBTUUxpdGVTdGF0ZW1lbnQgbWVtYmVyIGZ1bmN0aW9ucyBhcyB3 ZWxsIGFzIG91dC1wYXJhbWV0ZXJzCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dURi9TbWFsbFNldC5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9TbWFs bFNldC5jcHAKaW5kZXggOGYxYmYwNDU4MmQxLi4wNmU1ZGY5NTQ0MDEgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1NtYWxsU2V0LmNwcAorKysgYi9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dURi9TbWFsbFNldC5jcHAKQEAgLTI3LDYgKzI3LDcgQEAKIAogI2lu Y2x1ZGUgIlRlc3QuaCIKICNpbmNsdWRlIDx3dGYvSGFzaFNldC5oPgorI2luY2x1ZGUgPHd0Zi9I YXNoVHJhaXRzLmg+CiAjaW5jbHVkZSA8d3RmL1NtYWxsU2V0Lmg+CiAjaW5jbHVkZSA8d3RmL1Zl Y3Rvci5oPgogCkBAIC02Niw3ICs2Nyw3IEBAIHZvaWQgdGVzdFNtYWxsU2V0T2ZVbnNpZ25lZCh1 bnNpZ25lZCBuKQogICAgIH0KIAogICAgIHVuc2lnbmVkIGNvdW50ID0gMDsKLSAgICBIYXNoU2V0 PFQ+IHJlZmVyZW5jZVNldDsKKyAgICBIYXNoU2V0PFQsIEludEhhc2g8VD4sIFdURjo6VW5zaWdu ZWRXaXRoWmVyb0tleUhhc2hUcmFpdHM8VD4+IHJlZmVyZW5jZVNldDsKICAgICBmb3IgKHVuc2ln bmVkIGkgOiBzZXQpIHsKICAgICAgICAgcmVmZXJlbmNlU2V0LmFkZChpKTsKICAgICAgICAgKytj b3VudDsK 429202 2021-05-20 12:09:51 -0700 2021-05-20 12:34:41 -0700 Patch for landing patch226027 text/plain 1617 rmorisset ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmZjVm ZGFmZmM0ZGUuLjg3ZDIxNGI5MDFkMiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA1LTIwICBSb2JpbiBNb3Jp c3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlIHRlc3Qgb2YgU21hbGxT ZXQuY3BwIHNob3VsZCBwYXNzIHRoZSByaWdodCBIYXNoVHJhaXQgdG8gdGhlIEhhc2hTZXQgaXQg dXNlcyBhcyBhIHJlZmVyZW5jZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjI2MDI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWFyayBMYW0uCisKKyAg ICAgICAgU21hbGxTZXQgYWxsb3dzIGFsbCB2YWx1ZXMgZXhjZXB0IGZvciB0aGUgbWF4IHZhbHVl LgorICAgICAgICBTbyB3ZSB0ZXN0IGl0IG9uIHNtYWxsIHZhbHVlcywgaW5jbHVkaW5nIDAuCisK KyAgICAgICAgSGFzaFNldCBieSBkZWZhdWx0IGZvcmJpZHMgMCwgc28gaXQgbWFkZSB0aGUgdGVz dCBjcmFzaC4KKyAgICAgICAgV2UgY2FuIHRyaXZpYWxseSBmaXggaXQgYnkgcGFzc2luZyBVbnNp Z25lZFdpdGhaZXJvS2V5SGFzaFRyYWl0cywgd2hpY2ggYWxsb3dzIGV2ZXJ5dGhpbmcgd2hpY2gg aXMgbm90IG1heCgpIG9yIG1heCgpLTEKKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMv V1RGL1NtYWxsU2V0LmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OnRlc3RTbWFsbFNldE9m VW5zaWduZWQpOgorCiAyMDIxLTA1LTE5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CiAKICAgICAgICAgRHJvcCAiZ2V0IiBwcmVmaXggZnJvbSBTUUxpdGVTdGF0ZW1lbnQgbWVtYmVy IGZ1bmN0aW9ucyBhcyB3ZWxsIGFzIG91dC1wYXJhbWV0ZXJzCmRpZmYgLS1naXQgYS9Ub29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9TbWFsbFNldC5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL1dURi9TbWFsbFNldC5jcHAKaW5kZXggOGYxYmYwNDU4MmQxLi4wNmU1ZGY5NTQ0MDEg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1NtYWxsU2V0LmNwcAor KysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9TbWFsbFNldC5jcHAKQEAgLTI3LDYg KzI3LDcgQEAKIAogI2luY2x1ZGUgIlRlc3QuaCIKICNpbmNsdWRlIDx3dGYvSGFzaFNldC5oPgor I2luY2x1ZGUgPHd0Zi9IYXNoVHJhaXRzLmg+CiAjaW5jbHVkZSA8d3RmL1NtYWxsU2V0Lmg+CiAj aW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgogCkBAIC02Niw3ICs2Nyw3IEBAIHZvaWQgdGVzdFNtYWxs U2V0T2ZVbnNpZ25lZCh1bnNpZ25lZCBuKQogICAgIH0KIAogICAgIHVuc2lnbmVkIGNvdW50ID0g MDsKLSAgICBIYXNoU2V0PFQ+IHJlZmVyZW5jZVNldDsKKyAgICBIYXNoU2V0PFQsIEludEhhc2g8 VD4sIFdURjo6VW5zaWduZWRXaXRoWmVyb0tleUhhc2hUcmFpdHM8VD4+IHJlZmVyZW5jZVNldDsK ICAgICBmb3IgKHVuc2lnbmVkIGkgOiBzZXQpIHsKICAgICAgICAgcmVmZXJlbmNlU2V0LmFkZChp KTsKICAgICAgICAgKytjb3VudDsK