225999 2021-05-19 18:00:06 -0700 CRASH: Null-pointer deref in MediaSessionManagerCocoa::setNowPlayingInfo() 2021-05-20 17:26:02 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=226058 InRadar P2 Normal --- 225183 1 jer.noble jer.noble eric.carlson ews-watchlist glenn jean-yves.avenard peng.liu6 philipj sergio webkit-bug-importer oldest_to_newest 1761802 0 jer.noble 2021-05-19 18:00:06 -0700 CRASH: Null-pointer deref in MediaSessionManagerCocoa::setNowPlayingInfo() 1761803 1 jer.noble 2021-05-19 18:00:32 -0700 <rdar://78232970> 1761804 2 429125 jer.noble 2021-05-19 18:02:14 -0700 Created attachment 429125 Patch 1761871 3 jean-yves.avenard 2021-05-20 02:25:02 -0700 Following https://bugs.webkit.org/show_bug.cgi?id=225183 ; nowPlayingInfo.artwork->imageData can never be null. 1761967 4 jer.noble 2021-05-20 08:37:04 -0700 (In reply to Jean-Yves Avenard [:jya] from comment #3) > Following https://bugs.webkit.org/show_bug.cgi?id=225183 ; > nowPlayingInfo.artwork->imageData can never be null. Unfortunately, we're still seeing crashes even after that change landed. If imageData can truly never be null, it should be a Ref<> and not a RefPtr<>, which would enforce this at compile time. 1761968 5 ews-feeder 2021-05-20 08:41:48 -0700 Committed r277784 (237945@main): <https://commits.webkit.org/237945@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429125. 429125 2021-05-19 18:02:14 -0700 2021-05-20 08:41:49 -0700 Patch bug-225999-20210519180213.patch text/plain 2016 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3Njc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2JjYWE2NzA2ZWI3MDMy N2VkYTVkMTI4NzNiNDE1YmVmYmVmNTNlMC4uOGE2OWIzYWU2MTQ5YThkYzMxODkyMjk3M2ZiNzll YTQwN2ZmMTgwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA1LTE5ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIENSQVNIOiBOdWxsLXBvaW50 ZXIgZGVyZWYgaW4gTWVkaWFTZXNzaW9uTWFuYWdlckNvY29hOjpzZXROb3dQbGF5aW5nSW5mbygp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU5OTkK KyAgICAgICAgPHJkYXI6Ly83ODIzMjk3MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBOdWxsLWNoZWNrIGBub3dQbGF5aW5nSW5mby5hcnR3b3JrLT5p bWFnZURhdGFgIGJlZm9yZSBkZXJlZmVyZW5jaW5nLgorCisgICAgICAgICogcGxhdGZvcm0vYXVk aW8vY29jb2EvTWVkaWFTZXNzaW9uTWFuYWdlckNvY29hLm1tOgorICAgICAgICAoV2ViQ29yZTo6 TWVkaWFTZXNzaW9uTWFuYWdlckNvY29hOjpzZXROb3dQbGF5aW5nSW5mbyk6CisKIDIwMjEtMDUt MTggIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY10gTVNF LWJhc2VkIHZpZGVvIHBhdXNlcyB3aGVuIHB1dCBpbiBiYWNrZ3JvdW5kOyBQaVAgY29udGV4dCBt ZW51IGRpc2FibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9j b2NvYS9NZWRpYVNlc3Npb25NYW5hZ2VyQ29jb2EubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9hdWRpby9jb2NvYS9NZWRpYVNlc3Npb25NYW5hZ2VyQ29jb2EubW0KaW5kZXggNTY1NDZlYmYw NzkxN2E0NGMwYjE4ZjUyZTlmNDc4N2YxYjQxNWY5MS4uNmEwYTQ3ZmEzMDJiYTY3ZDlkNTU5ODc5 N2I3NTk2MjBmMDg1ZDVmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVk aW8vY29jb2EvTWVkaWFTZXNzaW9uTWFuYWdlckNvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2F1ZGlvL2NvY29hL01lZGlhU2Vzc2lvbk1hbmFnZXJDb2NvYS5tbQpAQCAtMzA5 LDcgKzMwOSw3IEBAIHZvaWQgTWVkaWFTZXNzaW9uTWFuYWdlckNvY29hOjpzZXROb3dQbGF5aW5n SW5mbyhib29sIHNldEFzTm93UGxheWluZ0FwcGxpY2F0aW9uCiAgICAgICAgIGF1dG8gY2ZDdXJy ZW50VGltZSA9IGFkb3B0Q0YoQ0ZOdW1iZXJDcmVhdGUoa0NGQWxsb2NhdG9yRGVmYXVsdCwga0NG TnVtYmVyRG91YmxlVHlwZSwgJm5vd1BsYXlpbmdJbmZvLmN1cnJlbnRUaW1lKSk7CiAgICAgICAg IENGRGljdGlvbmFyeVNldFZhbHVlKGluZm8uZ2V0KCksIGtNUk1lZGlhUmVtb3RlTm93UGxheWlu Z0luZm9FbGFwc2VkVGltZSwgY2ZDdXJyZW50VGltZS5nZXQoKSk7CiAgICAgfQotICAgIGlmIChu b3dQbGF5aW5nSW5mby5hcnR3b3JrKSB7CisgICAgaWYgKG5vd1BsYXlpbmdJbmZvLmFydHdvcmsg JiYgbm93UGxheWluZ0luZm8uYXJ0d29yay0+aW1hZ2VEYXRhKSB7CiAgICAgICAgIGF1dG8gbnNB cnR3b3JrID0gbm93UGxheWluZ0luZm8uYXJ0d29yay0+aW1hZ2VEYXRhLT5jcmVhdGVOU0RhdGEo KTsKICAgICAgICAgQ0ZEaWN0aW9uYXJ5U2V0VmFsdWUoaW5mby5nZXQoKSwga01STWVkaWFSZW1v dGVOb3dQbGF5aW5nSW5mb0FydHdvcmtEYXRhLCBuc0FydHdvcmsuZ2V0KCkpOwogICAgICAgICBD RkRpY3Rpb25hcnlTZXRWYWx1ZShpbmZvLmdldCgpLCBrTVJNZWRpYVJlbW90ZU5vd1BsYXlpbmdJ bmZvQXJ0d29ya01JTUVUeXBlLCBub3dQbGF5aW5nSW5mby5hcnR3b3JrLT5taW1lVHlwZS5jcmVh dGVDRlN0cmluZygpLmdldCgpKTsK