225996 2021-05-19 17:05:22 -0700 [GPUProcess] It is not safe to call GraphicsContext::paintFrameForMedia() off the main thread 2021-05-19 22:06:39 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez eric.carlson ews-watchlist glenn jer.noble kkinnunen peng.liu6 philipj sergio simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1761778 0 cdumez 2021-05-19 17:05:22 -0700 It is not safe to call GraphicsContext::paintFrameForMedia() off the main thread in the GPUProcess. It relies on the MediaPlayer which is a main-thread object. 1761779 1 429114 cdumez 2021-05-19 17:09:38 -0700 Created attachment 429114 Patch 1761836 2 ews-feeder 2021-05-19 22:05:28 -0700 Committed r277774 (237935@main): <https://commits.webkit.org/237935@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429114. 1761838 3 webkit-bug-importer 2021-05-19 22:06:39 -0700 <rdar://problem/78241935> 429114 2021-05-19 17:09:38 -0700 2021-05-19 22:05:30 -0700 Patch bug-225996-20210519170937.patch text/plain 5812 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3NzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGUwOWVkMzk0MjZiMmJiZWI4 YTZiZjQ0OGRiZmU3MWFjOGE1OGQ3NjMuLjJhOWMyZGZlZTk5NDA2MDkyOGRiOTk2ZWYwOGZjOTBk MWFlZTgwNjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMjEtMDUtMTkgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBbR1BVUHJvY2Vzc10gSXQgaXMgbm90 IHNhZmUgdG8gY2FsbCBHcmFwaGljc0NvbnRleHQ6OnBhaW50RnJhbWVGb3JNZWRpYSgpIG9mZiB0 aGUgbWFpbiB0aHJlYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIyNTk5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEl0IGlzIG5vdCBzYWZlIHRvIGNhbGwgR3JhcGhpY3NDb250ZXh0OjpwYWludEZyYW1l Rm9yTWVkaWEoKSBvZmYgdGhlIG1haW4gdGhyZWFkIGJlY2F1c2UgaXQKKyAgICAgICAgcmVsaWVz IG9uIHRoZSBNZWRpYVBsYXllciAvIE1lZGlhUGxheWVyUHJpdmF0ZSBvYmplY3RzLCB3aGljaCBh cmUgbWFpbi10aHJlYWQgb2JqZWN0LiBNYWtpbmcKKyAgICAgICAgdGhpcyBmdW5jdGlvbiB0aHJl YWQtc2FmZSB3b3VsZCBiZSBhIHNpZ25pZmljYW50IGFtb3VudCBvZiB3b3JrLiBBcyBhIHJlc3Vs dCwgSSBhbSBzaW1wbHkKKyAgICAgICAgY2FsbGluZyBjYWxsT25NYWluVGhyZWFkQW5kV2FpdCgp IGluIFJlbW90ZVJlbmRlcmluZ0JhY2tlbmQ6OmFwcGx5TWVkaWFJdGVtKCkuIE5vdGUgdGhhdCB0 aGlzCisgICAgICAgIGNvZGUgcGF0aCBpcyBvbmx5IHVzZWQgd2hlbiBwYWludGluZyBhIHZpZGVv IHRvIGEgY2FudmFzLgorCisgICAgICAgICogR1BVUHJvY2Vzcy9ncmFwaGljcy9SZW1vdGVSZW5k ZXJpbmdCYWNrZW5kLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlUmVuZGVyaW5nQmFja2Vu ZDo6YXBwbHlNZWRpYUl0ZW0pOgorICAgICAgICBNYWtlIHN1cmUgd2UgY2FsbCBwYWludEZyYW1l Rm9yTWVkaWEoKSBvbiB0aGUgbWFpbiB0aHJlYWQuCisKKyAgICAgICAgKiBHUFVQcm9jZXNzL21l ZGlhL1JlbW90ZU1lZGlhUGxheWVyTWFuYWdlclByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6 UmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2VyUHJveHk6OmNyZWF0ZU1lZGlhUGxheWVyKToKKyAgICAg ICAgKFdlYktpdDo6UmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2VyUHJveHk6OmRlbGV0ZU1lZGlhUGxh eWVyKToKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2VyUHJveHk6Om1l ZGlhUGxheWVyKToKKyAgICAgICAgKiBHUFVQcm9jZXNzL21lZGlhL1JlbW90ZU1lZGlhUGxheWVy TWFuYWdlclByb3h5Lmg6CisgICAgICAgIERyb3AgbG9jayB0aGF0IGlzIG5vIGxvbmdlciBuZWVk ZWQgbm93IHRoYXQgbWVkaWFQbGF5ZXIoKSBpcyBhbHdheXMgY2FsbGVkIG9uIHRoZSBtYWluIHRo cmVhZC4KKwogMjAyMS0wNS0xOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAg ICAgICAgIFNpbXBsaWZ5IGFuZCBtYWtlIEluamVjdGVkQnVuZGxlOjppbml0aWFsaXplKCkgbW9y ZSByb2J1c3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9ncmFwaGljcy9S ZW1vdGVSZW5kZXJpbmdCYWNrZW5kLmNwcCBiL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9ncmFw aGljcy9SZW1vdGVSZW5kZXJpbmdCYWNrZW5kLmNwcAppbmRleCBjMzY2NWI2NDc0NmQ2NWYzMWNh MzU5NjMzMGMwOWU2ZDZkMDhiNzNiLi43Yjc3MjI1YmU1NWEwMjM2ODU5NGNiNmFlY2I0ODdlOTY1 ZmQ1NTk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvZ3JhcGhpY3MvUmVt b3RlUmVuZGVyaW5nQmFja2VuZC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL2dy YXBoaWNzL1JlbW90ZVJlbmRlcmluZ0JhY2tlbmQuY3BwCkBAIC0xMzIsMTEgKzEzMiwxMyBAQCBi b29sIFJlbW90ZVJlbmRlcmluZ0JhY2tlbmQ6OmFwcGx5TWVkaWFJdGVtKERpc3BsYXlMaXN0OjpJ dGVtSGFuZGxlIGl0ZW0sIEdyYXBoaQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBhdXRv JiBtZWRpYUl0ZW0gPSBpdGVtLmdldDxEaXNwbGF5TGlzdDo6UGFpbnRGcmFtZUZvck1lZGlhPigp OwotICAgIGF1dG8gcGxheWVyID0gbV9ncHVDb25uZWN0aW9uVG9XZWJQcm9jZXNzLT5yZW1vdGVN ZWRpYVBsYXllck1hbmFnZXJQcm94eSgpLm1lZGlhUGxheWVyKG1lZGlhSXRlbS5pZGVudGlmaWVy KCkpOwotICAgIGlmICghcGxheWVyKQotICAgICAgICByZXR1cm4gdHJ1ZTsKLQotICAgIGNvbnRl eHQucGFpbnRGcmFtZUZvck1lZGlhKCpwbGF5ZXIsIG1lZGlhSXRlbS5kZXN0aW5hdGlvbigpKTsK KyAgICBjYWxsT25NYWluUnVuTG9vcEFuZFdhaXQoWyYsIGdwdUNvbm5lY3Rpb25Ub1dlYlByb2Nl c3MgPSBtX2dwdUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3MsIG1lZGlhUGxheWVySWRlbnRpZmllciA9 IG1lZGlhSXRlbS5pZGVudGlmaWVyKCldIHsKKyAgICAgICAgYXV0byBwbGF5ZXIgPSBncHVDb25u ZWN0aW9uVG9XZWJQcm9jZXNzLT5yZW1vdGVNZWRpYVBsYXllck1hbmFnZXJQcm94eSgpLm1lZGlh UGxheWVyKG1lZGlhUGxheWVySWRlbnRpZmllcik7CisgICAgICAgIGlmICghcGxheWVyKQorICAg ICAgICAgICAgcmV0dXJuOworICAgICAgICAvLyBJdCBpcyBjdXJyZW50bHkgbm90IHNhZmUgdG8g Y2FsbCBwYWludEZyYW1lRm9yTWVkaWEoKSBvZmYgdGhlIG1haW4gdGhyZWFkLgorICAgICAgICBj b250ZXh0LnBhaW50RnJhbWVGb3JNZWRpYSgqcGxheWVyLCBtZWRpYUl0ZW0uZGVzdGluYXRpb24o KSk7CisgICAgfSk7CiAgICAgcmV0dXJuIHRydWU7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvR1BVUHJvY2Vzcy9tZWRpYS9SZW1vdGVNZWRpYVBsYXllck1hbmFnZXJQcm94eS5jcHAg Yi9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvbWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2Vy UHJveHkuY3BwCmluZGV4IGYwZGJkNTNlZjM2MDc5YzdlMmYzODkxNzZmMzAxNWMyZTM3YzQwOTMu LmIwMzAwMjUxZjgwMmU5NjYwODk1YTE5MDQwMWJhM2FmZjI0MDAyYTMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9tZWRpYS9SZW1vdGVNZWRpYVBsYXllck1hbmFnZXJQcm94 eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL21lZGlhL1JlbW90ZU1lZGlhUGxh eWVyTWFuYWdlclByb3h5LmNwcApAQCAtNjEsOCArNjEsNiBAQCB2b2lkIFJlbW90ZU1lZGlhUGxh eWVyTWFuYWdlclByb3h5OjpjcmVhdGVNZWRpYVBsYXllcihNZWRpYVBsYXllcklkZW50aWZpZXIg aWRlbgogewogICAgIEFTU0VSVChSdW5Mb29wOjppc01haW4oKSk7CiAgICAgQVNTRVJUKG1fZ3B1 Q29ubmVjdGlvblRvV2ViUHJvY2Vzcyk7Ci0KLSAgICBhdXRvIGxvY2tlciA9IGhvbGRMb2NrKG1f cHJveGllc0xvY2spOwogICAgIEFTU0VSVCghbV9wcm94aWVzLmNvbnRhaW5zKGlkZW50aWZpZXIp KTsKIAogICAgIGF1dG8gcHJveHkgPSBtYWtlVW5pcXVlPFJlbW90ZU1lZGlhUGxheWVyUHJveHk+ KCp0aGlzLCBpZGVudGlmaWVyLCBtX2dwdUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3MtPmNvbm5lY3Rp b24oKSwgZW5naW5lSWRlbnRpZmllciwgV1RGTW92ZShwcm94eUNvbmZpZ3VyYXRpb24pKTsKQEAg LTcyLDExICs3MCwxMCBAQCB2b2lkIFJlbW90ZU1lZGlhUGxheWVyTWFuYWdlclByb3h5OjpjcmVh dGVNZWRpYVBsYXllcihNZWRpYVBsYXllcklkZW50aWZpZXIgaWRlbgogdm9pZCBSZW1vdGVNZWRp YVBsYXllck1hbmFnZXJQcm94eTo6ZGVsZXRlTWVkaWFQbGF5ZXIoTWVkaWFQbGF5ZXJJZGVudGlm aWVyIGlkZW50aWZpZXIpCiB7CiAgICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKLSAgICB7 Ci0gICAgICAgIGF1dG8gbG9ja2VyID0gaG9sZExvY2sobV9wcm94aWVzTG9jayk7Ci0gICAgICAg IGlmIChhdXRvIHByb3h5ID0gbV9wcm94aWVzLnRha2UoaWRlbnRpZmllcikpCi0gICAgICAgICAg ICBwcm94eS0+aW52YWxpZGF0ZSgpOwotICAgIH0KKworICAgIGlmIChhdXRvIHByb3h5ID0gbV9w cm94aWVzLnRha2UoaWRlbnRpZmllcikpCisgICAgICAgIHByb3h5LT5pbnZhbGlkYXRlKCk7CisK ICAgICBpZiAobV9ncHVDb25uZWN0aW9uVG9XZWJQcm9jZXNzICYmIGFsbG93c0V4aXRVbmRlck1l bW9yeVByZXNzdXJlKCkpCiAgICAgICAgIG1fZ3B1Q29ubmVjdGlvblRvV2ViUHJvY2Vzcy0+Z3B1 UHJvY2VzcygpLnRyeUV4aXRJZlVudXNlZEFuZFVuZGVyTWVtb3J5UHJlc3N1cmUoKTsKIH0KQEAg LTE3MywxMCArMTcwLDkgQEAgYm9vbCBSZW1vdGVNZWRpYVBsYXllck1hbmFnZXJQcm94eTo6ZGlk UmVjZWl2ZVN5bmNQbGF5ZXJNZXNzYWdlKElQQzo6Q29ubmVjdGlvbiYKICAgICByZXR1cm4gZmFs c2U7CiB9CiAKLS8vIE1heSBnZXQgY2FsbGVkIG9uIGEgYmFja2dyb3VuZCB0aHJlYWQuCiBSZWZQ dHI8TWVkaWFQbGF5ZXI+IFJlbW90ZU1lZGlhUGxheWVyTWFuYWdlclByb3h5OjptZWRpYVBsYXll cihjb25zdCBNZWRpYVBsYXllcklkZW50aWZpZXImIGlkZW50aWZpZXIpCiB7Ci0gICAgYXV0byBs b2NrZXIgPSBob2xkTG9jayhtX3Byb3hpZXNMb2NrKTsKKyAgICBBU1NFUlQoUnVuTG9vcDo6aXNN YWluKCkpOwogICAgIGF1dG8gcmVzdWx0cyA9IG1fcHJveGllcy5maW5kKGlkZW50aWZpZXIpOwog ICAgIGlmIChyZXN1bHRzICE9IG1fcHJveGllcy5lbmQoKSkKICAgICAgICAgcmV0dXJuIHJlc3Vs dHMtPnZhbHVlLT5tZWRpYVBsYXllcigpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9HUFVQ cm9jZXNzL21lZGlhL1JlbW90ZU1lZGlhUGxheWVyTWFuYWdlclByb3h5LmggYi9Tb3VyY2UvV2Vi S2l0L0dQVVByb2Nlc3MvbWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2VyUHJveHkuaAppbmRl eCAwMDhkYTg3NTZhNzMyNzlhYjk5ZjZmNjA4MDJmNTcwYTIwZmY1ZWE0Li4zNThiYjkxMDljM2Nm MzdmY2IzZmQ1ZDNhN2E0MmNiMDE2ZTYyOTRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0dQ VVByb2Nlc3MvbWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2VyUHJveHkuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L0dQVVByb2Nlc3MvbWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2VyUHJveHku aApAQCAtODMsNyArODMsNiBAQCBwcml2YXRlOgogICAgIHZvaWQgY2xlYXJNZWRpYUNhY2hlRm9y T3JpZ2lucyhXZWJDb3JlOjpNZWRpYVBsYXllckVudW1zOjpNZWRpYUVuZ2luZUlkZW50aWZpZXIs IGNvbnN0IFN0cmluZyYmLCBIYXNoU2V0PFdlYkNvcmU6OlNlY3VyaXR5T3JpZ2luRGF0YT4mJik7 CiAgICAgdm9pZCBzdXBwb3J0c0tleVN5c3RlbShXZWJDb3JlOjpNZWRpYVBsYXllckVudW1zOjpN ZWRpYUVuZ2luZUlkZW50aWZpZXIsIGNvbnN0IFN0cmluZyYmLCBjb25zdCBTdHJpbmcmJiwgQ29t cGxldGlvbkhhbmRsZXI8dm9pZChib29sKT4mJik7CiAKLSAgICBMb2NrIG1fcHJveGllc0xvY2s7 CiAgICAgSGFzaE1hcDxXZWJDb3JlOjpNZWRpYVBsYXllcklkZW50aWZpZXIsIHN0ZDo6dW5pcXVl X3B0cjxSZW1vdGVNZWRpYVBsYXllclByb3h5Pj4gbV9wcm94aWVzOwogICAgIFdlYWtQdHI8R1BV Q29ubmVjdGlvblRvV2ViUHJvY2Vzcz4gbV9ncHVDb25uZWN0aW9uVG9XZWJQcm9jZXNzOwogCg==