225994 2021-05-19 16:34:47 -0700 [Modern Media Controls] don't add the language when generating a display name for a `TrackBase` if it's in the user's default language 2021-05-20 12:47:54 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED MOVED https://bugs.webkit.org/show_bug.cgi?id=225900 https://bugs.webkit.org/show_bug.cgi?id=226038 P2 Normal --- 1 hi hi eric.carlson ews-watchlist glenn hi jer.noble peng.liu6 philipj sergio oldest_to_newest 1761765 0 hi 2021-05-19 16:34:47 -0700 . 1761783 1 429117 hi 2021-05-19 17:12:17 -0700 Created attachment 429117 Patch 1762021 2 429117 eric.carlson 2021-05-20 10:30:32 -0700 Comment on attachment 429117 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429117&action=review > Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:587 > + if (language.isEmpty() || label.contains(language) || userPreferredLanguages().contains(trackLanguageIdentifier)) `userPreferredLanguages().contains` _should_ include all of the user's configured languages (modulo the change made last year), not just the preferred language, so either this test is wrong or the bug title is wrong. 1762050 3 429117 hi 2021-05-20 11:12:36 -0700 Comment on attachment 429117 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429117&action=review >> Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:587 >> + if (language.isEmpty() || label.contains(language) || userPreferredLanguages().contains(trackLanguageIdentifier)) > > `userPreferredLanguages().contains` _should_ include all of the user's configured languages (modulo the change made last year), not just the preferred language, so either this test is wrong or the bug title is wrong. I'm working on fixing this now :) 1762101 4 hi 2021-05-20 12:47:47 -0700 I'll handle this in <https://webkit.org/b/226038> 429117 2021-05-19 17:12:17 -0700 2021-05-20 12:47:54 -0700 Patch 225994.diff text/plain 1565 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlZDUwYTMxM2U3OGUuLmUyYzJjMmM4N2Y5MyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDEzIEBACisyMDIxLTA1LTE3ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNv bT4KKworICAgICAgICBbTW9kZXJuIE1lZGlhIENvbnRyb2xzXSBkb24ndCBhZGQgdGhlIGxhbmd1 YWdlIHdoZW4gZ2VuZXJhdGluZyBhIGRpc3BsYXkgbmFtZSBmb3IgYSBgVHJhY2tCYXNlYCBpZiBp dCdzIGluIHRoZSB1c2VyJ3MgZGVmYXVsdCBsYW5ndWFnZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1OTk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWdlL0NhcHRpb25Vc2VyUHJlZmVyZW5jZXNN ZWRpYUFGLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmJ1aWxkRGlzcGxheVN0cmluZ0ZvclRyYWNr QmFzZSk6CisKIDIwMjEtMDUtMTggIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAg ICAgICAgIE1vdmUgQ0ZTdHJpbmdSZWYgYW5kIE5TU3RyaW5nIHN1cHBvcnQgZnJvbSBTdHJpbmdC dWlsZGVyIGludG8gU3RyaW5nQ29uY2F0ZW5hdGVDRgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9DYXB0aW9uVXNlclByZWZlcmVuY2VzTWVkaWFBRi5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0NhcHRpb25Vc2VyUHJlZmVyZW5jZXNNZWRpYUFGLmNwcAppbmRleCAwMTE3N2IzMjA2 ZmEuLmJmZTc5MjgzY2Y3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9DYXB0aW9u VXNlclByZWZlcmVuY2VzTWVkaWFBRi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9DYXB0 aW9uVXNlclByZWZlcmVuY2VzTWVkaWFBRi5jcHAKQEAgLTU4NCw3ICs1ODQsNyBAQCBzdGF0aWMg dm9pZCBidWlsZERpc3BsYXlTdHJpbmdGb3JUcmFja0Jhc2UoU3RyaW5nQnVpbGRlciYgZGlzcGxh eU5hbWUsIGNvbnN0IFRyYQogICAgIFN0cmluZyBsYW5ndWFnZSA9IGxhbmd1YWdlQ0YuZ2V0KCk7 CiAKICAgICBpZiAoIWxhYmVsLmlzRW1wdHkoKSkgewotICAgICAgICBpZiAobGFuZ3VhZ2UuaXNF bXB0eSgpIHx8IGxhYmVsLmNvbnRhaW5zKGxhbmd1YWdlKSkKKyAgICAgICAgaWYgKGxhbmd1YWdl LmlzRW1wdHkoKSB8fCBsYWJlbC5jb250YWlucyhsYW5ndWFnZSkgfHwgdXNlclByZWZlcnJlZExh bmd1YWdlcygpLmNvbnRhaW5zKHRyYWNrTGFuZ3VhZ2VJZGVudGlmaWVyKSkKICAgICAgICAgICAg IGRpc3BsYXlOYW1lLmFwcGVuZChsYWJlbCk7CiAgICAgICAgIGVsc2UgewogICAgICAgICAgICAg UmV0YWluUHRyPENGRGljdGlvbmFyeVJlZj4gbG9jYWxlRGljdCA9IGFkb3B0Q0YoQ0ZMb2NhbGVD cmVhdGVDb21wb25lbnRzRnJvbUxvY2FsZUlkZW50aWZpZXIoa0NGQWxsb2NhdG9yRGVmYXVsdCwg bG9jYWxlSWRlbnRpZmllci5nZXQoKSkpOwo=