225979 2021-05-19 13:03:22 -0700 REGRESSION(r277505): Crash under WTF::Detail::CallableWrapper<WebKit::WebPageProxy::setUnderPageBackgroundColorOverride(WebCore::Color&&)::$_10, void>::call 2021-05-20 14:54:01 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 hi hi aestes hi thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1761664 0 hi 2021-05-19 13:03:22 -0700 . 1761665 1 hi 2021-05-19 13:03:38 -0700 <rdar://problem/78130098> 1761668 2 429089 hi 2021-05-19 13:09:19 -0700 Created attachment 429089 Patch 1762130 3 429089 thorton 2021-05-20 14:12:59 -0700 Comment on attachment 429089 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429089&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:1958 > + if (m_pageClient) > + didChangeBackgroundColor(); Hmm, I would expect it here if you had moved the dereferencing of m_pageClient here, but inside didChangeBackgroundColor if you didn't. Why this version? 1762131 4 429089 hi 2021-05-20 14:16:35 -0700 Comment on attachment 429089 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429089&action=review >> Source/WebKit/UIProcess/WebPageProxy.cpp:1958 >> + didChangeBackgroundColor(); > > Hmm, I would expect it here if you had moved the dereferencing of m_pageClient here, but inside didChangeBackgroundColor if you didn't. Why this version? No particular reason. Just trying to keep the diff smaller I suppose. I'll add `m_pageClient->didChangeBackgroundColor()` here instead. 1762132 5 429221 hi 2021-05-20 14:18:49 -0700 Created attachment 429221 Patch 1762157 6 ews-feeder 2021-05-20 14:54:00 -0700 Committed r277827 (237973@main): <https://commits.webkit.org/237973@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429221. 429089 2021-05-19 13:09:19 -0700 2021-05-20 14:18:49 -0700 Patch bug-225979-20210519140918.patch text/plain 1738 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggOTZjYzRiZjc1MDBkOGJiZmMyYTRjN2QwNjkxNjZmZDM4ZDZlYmVlMi4uZTdl YzgyYzc3ZTlkZjI2Yzg1NDQyZWRkNWY5YmJhNmFlNjRmY2Y2YSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNiBAQAorMjAyMS0wNS0xOSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTihyMjc3NTA1KTogQ3Jhc2ggdW5kZXIgV1RGOjpEZXRhaWw6OkNh bGxhYmxlV3JhcHBlcjxXZWJLaXQ6OldlYlBhZ2VQcm94eTo6c2V0VW5kZXJQYWdlQmFja2dyb3Vu ZENvbG9yT3ZlcnJpZGUoV2ViQ29yZTo6Q29sb3ImJik6OiRfMTAsIHZvaWQ+OjpjYWxsCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU5NzkKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzc4MTMwMDk4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6c2V0VW5kZXJQYWdlQmFja2dyb3VuZENvbG9yT3Zl cnJpZGUpOgorICAgICAgICBTZW1pLXNwZWN1bGF0aXZlIGZpeCBieSBjaGVja2luZyB0aGUgd2Vh a2x5LWhlbGQgYFBhZ2VDbGllbnRgIGJlZm9yZSBhdHRlbXB0aW5nIHRvIHVzZSBpdC4KKyAgICAg ICAgRGlzc2FzZW1ibHkgc3VnZ2VzdHMgdGhpcyBhcyB0aGUgY2F1c2UgYXMgdGhlIGludmFsaWQg YWNjZXNzIG9jY3VycyBlYXJseSBpbiB0aGUgbGFtYmRhLgorCiAyMDIxLTA1LTE5ICBTYW0gV2Vp bmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgQmFzZTY0IGVuY29kaW5n L2RlY29kaW5nIHRvIG1hdGNoIG1vcmUgbW9kZXJuIFdlYktpdCBjb252ZW50aW9ucwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggYWM4YzYxZDI5NDA4ODhlZjM4 NTVlYmQwMDE5ODU3ZmJiNjlmMTdkOC4uZjcxZTY1MzdhMzIwOTgxODMxYWFmNGE5ZTYwZWFkNThj NTE1Mzc1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCkBAIC0x OTU0LDcgKzE5NTQsOCBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6c2V0VW5kZXJQYWdlQmFja2dyb3Vu ZENvbG9yT3ZlcnJpZGUoQ29sb3ImJiBuZXdVbmRlclBhZ2VCYWNrZwogCiAgICAgICAgIG1faGFz UGVuZGluZ1VuZGVyUGFnZUJhY2tncm91bmRDb2xvck92ZXJyaWRlVG9EaXNwYXRjaCA9IGZhbHNl OwogCi0gICAgICAgIGRpZENoYW5nZUJhY2tncm91bmRDb2xvcigpOworICAgICAgICBpZiAobV9w YWdlQ2xpZW50KQorICAgICAgICAgICAgZGlkQ2hhbmdlQmFja2dyb3VuZENvbG9yKCk7CiAKICAg ICAgICAgaWYgKGhhc1J1bm5pbmdQcm9jZXNzKCkpCiAgICAgICAgICAgICBzZW5kKE1lc3NhZ2Vz OjpXZWJQYWdlOjpTZXRVbmRlclBhZ2VCYWNrZ3JvdW5kQ29sb3JPdmVycmlkZShtX3VuZGVyUGFn ZUJhY2tncm91bmRDb2xvck92ZXJyaWRlKSk7Cg== 429221 2021-05-20 14:18:49 -0700 2021-05-20 14:54:00 -0700 Patch 225979.diff text/plain 1748 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggOTZjYzRiZjc1MDBkOGJiZmMyYTRjN2QwNjkxNjZmZDM4ZDZlYmVlMi4uZTdl YzgyYzc3ZTlkZjI2Yzg1NDQyZWRkNWY5YmJhNmFlNjRmY2Y2YSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNiBAQAorMjAyMS0wNS0yMCAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTihyMjc3NTA1KTogQ3Jhc2ggdW5kZXIgV1RGOjpEZXRhaWw6OkNh bGxhYmxlV3JhcHBlcjxXZWJLaXQ6OldlYlBhZ2VQcm94eTo6c2V0VW5kZXJQYWdlQmFja2dyb3Vu ZENvbG9yT3ZlcnJpZGUoV2ViQ29yZTo6Q29sb3ImJik6OiRfMTAsIHZvaWQ+OjpjYWxsCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU5NzkKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzc4MTMwMDk4PgorCisgICAgICAgIFJldmlld2VkIGJ5IFRpbSBI b3J0b24uCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViUGFnZVByb3h5OjpzZXRVbmRlclBhZ2VCYWNrZ3JvdW5kQ29sb3JPdmVycmlk ZSk6CisgICAgICAgIFNlbWktc3BlY3VsYXRpdmUgZml4IGJ5IGNoZWNraW5nIHRoZSB3ZWFrbHkt aGVsZCBgUGFnZUNsaWVudGAgYmVmb3JlIGF0dGVtcHRpbmcgdG8gdXNlIGl0LgorICAgICAgICBE aXNzYXNlbWJseSBzdWdnZXN0cyB0aGlzIGFzIHRoZSBjYXVzZSBhcyB0aGUgaW52YWxpZCBhY2Nl c3Mgb2NjdXJzIGVhcmx5IGluIHRoZSBsYW1iZGEuCisKIDIwMjEtMDUtMTkgIFNhbSBXZWluaWcg IDx3ZWluaWdAYXBwbGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSBCYXNlNjQgZW5jb2RpbmcvZGVj b2RpbmcgdG8gbWF0Y2ggbW9yZSBtb2Rlcm4gV2ViS2l0IGNvbnZlbnRpb25zCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCBhYzhjNjFkMjk0MDg4OGVmMzg1NWVi ZDAwMTk4NTdmYmI2OWYxN2Q4Li5mNzFlNjUzN2EzMjA5ODE4MzFhYWY0YTllNjBlYWQ1OGM1MTUz NzVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTE5NTQs NyArMTk1NCw4IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpzZXRVbmRlclBhZ2VCYWNrZ3JvdW5kQ29s b3JPdmVycmlkZShDb2xvciYmIG5ld1VuZGVyUGFnZUJhY2tnCiAKICAgICAgICAgbV9oYXNQZW5k aW5nVW5kZXJQYWdlQmFja2dyb3VuZENvbG9yT3ZlcnJpZGVUb0Rpc3BhdGNoID0gZmFsc2U7CiAK LSAgICAgICAgZGlkQ2hhbmdlQmFja2dyb3VuZENvbG9yKCk7CisgICAgICAgIGlmIChtX3BhZ2VD bGllbnQpCisgICAgICAgICAgICBtX3BhZ2VDbGllbnQtPmRpZENoYW5nZUJhY2tncm91bmRDb2xv cigpOwogCiAgICAgICAgIGlmIChoYXNSdW5uaW5nUHJvY2VzcygpKQogICAgICAgICAgICAgc2Vu ZChNZXNzYWdlczo6V2ViUGFnZTo6U2V0VW5kZXJQYWdlQmFja2dyb3VuZENvbG9yT3ZlcnJpZGUo bV91bmRlclBhZ2VCYWNrZ3JvdW5kQ29sb3JPdmVycmlkZSkpOwo=