<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>225973</bug_id>
          
          <creation_ts>2021-05-19 10:09:09 -0700</creation_ts>
          <short_desc>Add null checks in FrameSelection::selectFrameElementInParentIfFullySelected</short_desc>
          <delta_ts>2021-05-20 10:43:44 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alex Christensen">achristensen</reporter>
          <assigned_to name="Alex Christensen">achristensen</assigned_to>
          <cc>ews-watchlist</cc>
    
    <cc>katherine_cheney</cc>
    
    <cc>mifenton</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1761573</commentid>
    <comment_count>0</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2021-05-19 10:09:09 -0700</bug_when>
    <thetext>Add null checks in FrameSelection::selectFrameElementInParentIfFullySelected</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1761574</commentid>
    <comment_count>1</comment_count>
      <attachid>429058</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2021-05-19 10:09:32 -0700</bug_when>
    <thetext>Created attachment 429058
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1761575</commentid>
    <comment_count>2</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2021-05-19 10:09:35 -0700</bug_when>
    <thetext>&lt;rdar://problem/78200977&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1761626</commentid>
    <comment_count>3</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2021-05-19 11:31:56 -0700</bug_when>
    <thetext>I&apos;ve been told this may have been fixed with https://trac.webkit.org/changeset/277600/webkit
Not sure if we still want this to be extra safe</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1762032</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-05-20 10:43:43 -0700</bug_when>
    <thetext>Committed r277799 (237956@main): &lt;https://commits.webkit.org/237956@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429058.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>429058</attachid>
            <date>2021-05-19 10:09:32 -0700</date>
            <delta_ts>2021-05-20 10:43:44 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-225973-20210519100932.patch</filename>
            <type>text/plain</type>
            <size>1681</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3NjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjhiNWExYTZhYWU3ZTY3
YTA2NGY2YTQyYjZkZjNlMjkxN2IzNGM4OC4uZTYyZWViMWUxZjMxNmY2MzVjYjA0NTc5NDRkMzU1
OGQ2YWIzN2JjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA1LTE5ICBBbGV4
IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRkIG51
bGwgY2hlY2tzIGluIEZyYW1lU2VsZWN0aW9uOjpzZWxlY3RGcmFtZUVsZW1lbnRJblBhcmVudElm
RnVsbHlTZWxlY3RlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MjI1OTczCisgICAgICAgIDxyZGFyOi8vNzgyMDA5Nzc+CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBlZGl0aW5nL0ZyYW1lU2VsZWN0aW9u
LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lU2VsZWN0aW9uOjpzZWxlY3RGcmFtZUVsZW1l
bnRJblBhcmVudElmRnVsbHlTZWxlY3RlZCk6CisKIDIwMjEtMDUtMTggIENocmlzIER1bWV6ICA8
Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIHN1cmUgU1FMaXRlU3RhdGVtZW50IG9i
amVjdHMgZ2V0IGRlc3Ryb3llZCBiZWZvcmUgdGhlIGRhdGFiYXNlIGlzIGNsb3NlZApkaWZmIC0t
Z2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAgYi9Tb3VyY2Uv
V2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmNwcAppbmRleCBjYjFiODZlNzliNzRiNmUz
OWQ4NTM5OTRmZDI3NWI0NjlkMDc5Zjg3Li5hZDMyMjI3NGFjMTI4YTEyMmMyZDMxNGZjNzA5MTE3
NTE1NjFiYjliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0
aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmNwcApA
QCAtMTkyMiw3ICsxOTIyLDEzIEBAIGJvb2wgRnJhbWVTZWxlY3Rpb246OmNvbnRhaW5zKGNvbnN0
IExheW91dFBvaW50JiBwb2ludCkgY29uc3QKIHZvaWQgRnJhbWVTZWxlY3Rpb246OnNlbGVjdEZy
YW1lRWxlbWVudEluUGFyZW50SWZGdWxseVNlbGVjdGVkKCkKIHsKICAgICAvLyBGaW5kIHRoZSBw
YXJlbnQgZnJhbWU7IGlmIHRoZXJlIGlzIG5vbmUsIHRoZW4gd2UgaGF2ZSBub3RoaW5nIHRvIGRv
LgotICAgIGF1dG8gcGFyZW50ID0gbWFrZVJlZlB0cihtX2RvY3VtZW50LT5mcmFtZSgpLT50cmVl
KCkucGFyZW50KCkpOworICAgIGF1dG8gZG9jdW1lbnQgPSBtYWtlUmVmUHRyKG1fZG9jdW1lbnQu
Z2V0KCkpOworICAgIGlmICghZG9jdW1lbnQpCisgICAgICAgIHJldHVybjsKKyAgICBhdXRvIGZy
YW1lID0gbWFrZVJlZlB0cihkb2N1bWVudC0+ZnJhbWUoKSk7CisgICAgaWYgKCFmcmFtZSkKKyAg
ICAgICAgcmV0dXJuOworICAgIGF1dG8gcGFyZW50ID0gbWFrZVJlZlB0cihmcmFtZS0+dHJlZSgp
LnBhcmVudCgpKTsKICAgICBpZiAoIXBhcmVudCkKICAgICAgICAgcmV0dXJuOwogICAgIFBhZ2Uq
IHBhZ2UgPSBtX2RvY3VtZW50LT5wYWdlKCk7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>