225951 2021-05-18 18:21:54 -0700 Fix flaky assertion hit under AudioSummingJunction::removeOutput() 2021-05-19 08:05:18 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez cdumez eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1761413 0 cdumez 2021-05-18 18:21:54 -0700 Fix flaky assertion hit under AudioSummingJunction::removeOutput(): Thread 16 Crashed:: offline renderer 0 com.apple.JavaScriptCore 0x0000000288d2449e WTFCrash + 14 (Assertions.cpp:305) 1 com.apple.JavaScriptCore 0x000000028a5251fb WTFCrashWithInfo(int, char const*, char const*, int) + 27 (Assertions.h:695) 2 com.apple.JavaScriptCore 0x0000000288d61cfb WTF::fastMalloc(unsigned long) + 235 (FastMalloc.cpp:524) 3 com.apple.WebCore 0x0000000269c0b1a5 WTF::FastMalloc::malloc(unsigned long) + 21 (FastMalloc.h:273) 4 com.apple.WebCore 0x000000026c1112e2 bool WTF::VectorBufferBase<WebCore::AudioNodeOutput*, WTF::FastMalloc>::allocateBuffer<(WTF::FailureAction)0>(unsigned long) + 178 (Vector.h:301) 5 com.apple.WebCore 0x000000026c1111f8 bool WTF::Vector<WebCore::AudioNodeOutput*, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>::reserveInitialCapacity<(WTF::FailureAction)0>(unsigned long) + 248 (Vector.h:1220) 6 com.apple.WebCore 0x000000026c11106d WTF::Vector<WebCore::AudioNodeOutput*, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>::reserveInitialCapacity(unsigned long) + 29 (Vector.h:765) 7 com.apple.WebCore 0x000000026c110f3e WTF::Mapper<WTF::Vector<WebCore::AudioNodeOutput*, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> WTF::copyToVectorOf<WebCore::AudioNodeOutput*, WTF::HashSet<WebCore::AudioNodeOutput*, WTF::DefaultHash<WebCore::AudioNodeOutput*>, WTF::HashTraits<WebCore::AudioNodeOutput*>, WTF::HashTableTraits> >(WTF::HashSet<WebCore::AudioNodeOutput*, WTF::DefaultHash<WebCore::AudioNodeOutput*>, WTF::HashTraits<WebCore::AudioNodeOutput*>, WTF::HashTableTraits> const&)::'lambda'(WebCore::AudioNodeOutput*&&), WTF::HashSet<WebCore::AudioNodeOutput*, WTF::DefaultHash<WebCore::AudioNodeOutput*>, WTF::HashTraits<WebCore::AudioNodeOutput*>, WTF::HashTableTraits> const&, void>::map(WTF::HashSet<WebCore::AudioNodeOutput*, WTF::DefaultHash<WebCore::AudioNodeOutput*>, WTF::HashTraits<WebCore::AudioNodeOutput*>, WTF::HashTableTraits> const&, WTF::Vector<WebCore::AudioNodeOutput*, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> WTF::copyToVectorOf<WebCore::AudioNodeOutput*, WTF::HashSet<WebCore::AudioNodeOutput*, WTF::DefaultHash<WebCore::AudioNodeOutput*>, WTF::HashTraits<WebCore::AudioNodeOutput*>, WTF::HashTableTraits> >(WTF::HashSet<WebCore::AudioNodeOutput*, WTF::DefaultHash<WebCore::AudioNodeOutput*>, WTF::HashTraits<WebCore::AudioNodeOutput*>, WTF::HashTableTraits> const&)::'lambda'(WebCore::AudioNodeOutput*&&) const&) + 94 (Vector.h:1657) 8 com.apple.WebCore 0x000000026c110ecb WTF::Vector<WTF::Mapper<WebCore::AudioNodeOutput*, WTF::HashSet<WebCore::AudioNodeOutput*, WTF::DefaultHash<WebCore::AudioNodeOutput*>, WTF::HashTraits<WebCore::AudioNodeOutput*>, WTF::HashTableTraits>, void>::DestinationItemType, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> WTF::map<WTF::Vector<WebCore::AudioNodeOutput*, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> WTF::copyToVectorOf<WebCore::AudioNodeOutput*, WTF::HashSet<WebCore::AudioNodeOutput*, WTF::DefaultHash<WebCore::AudioNodeOutput*>, WTF::HashTraits<WebCore::AudioNodeOutput*>, WTF::HashTableTraits> >(WTF::HashSet<WebCore::AudioNodeOutput*, WTF::DefaultHash<WebCore::AudioNodeOutput*>, WTF::HashTraits<WebCore::AudioNodeOutput*>, WTF::HashTableTraits> const&)::'lambda'(WebCore::AudioNodeOutput*&&), WTF::HashSet<WebCore::AudioNodeOutput*, WTF::DefaultHash<WebCore::AudioNodeOutput*>, WTF::HashTraits<WebCore::AudioNodeOutput*>, WTF::HashTableTraits> const&>(WTF::HashSet<WebCore::AudioNodeOutput*, WTF::DefaultHash<WebCore::AudioNodeOutput*>, WTF::HashTraits<WebCore::AudioNodeOutput*>, WTF::HashTableTraits>&&, WebCore::AudioNodeOutput*&&) + 75 (Vector.h:1683) 9 com.apple.WebCore 0x000000026c110e67 WTF::Vector<WebCore::AudioNodeOutput*, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> WTF::copyToVectorOf<WebCore::AudioNodeOutput*, WTF::HashSet<WebCore::AudioNodeOutput*, WTF::DefaultHash<WebCore::AudioNodeOutput*>, WTF::HashTraits<WebCore::AudioNodeOutput*>, WTF::HashTableTraits> >(WTF::HashSet<WebCore::AudioNodeOutput*, WTF::DefaultHash<WebCore::AudioNodeOutput*>, WTF::HashTraits<WebCore::AudioNodeOutput*>, WTF::HashTableTraits> const&) + 39 (Vector.h:1765) 10 com.apple.WebCore 0x000000026c0f7333 WTF::Vector<WTF::CopyToVectorResult<WTF::HashSet<WebCore::AudioNodeOutput*, WTF::DefaultHash<WebCore::AudioNodeOutput*>, WTF::HashTraits<WebCore::AudioNodeOutput*>, WTF::HashTableTraits> >::Type, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> WTF::copyToVector<WTF::HashSet<WebCore::AudioNodeOutput*, WTF::DefaultHash<WebCore::AudioNodeOutput*>, WTF::HashTraits<WebCore::AudioNodeOutput*>, WTF::HashTableTraits> >(WTF::HashSet<WebCore::AudioNodeOutput*, WTF::DefaultHash<WebCore::AudioNodeOutput*>, WTF::HashTraits<WebCore::AudioNodeOutput*>, WTF::HashTableTraits> const&) + 35 (Vector.h:1778) 11 com.apple.WebCore 0x000000026c0f74fa WebCore::AudioSummingJunction::removeOutput(WebCore::AudioNodeOutput&) + 330 (AudioSummingJunction.cpp:82) 12 com.apple.WebCore 0x000000026c0cbf36 WebCore::AudioNodeInput::disconnect(WebCore::AudioNodeOutput*) + 390 (AudioNodeInput.cpp:77) 1761414 1 429013 cdumez 2021-05-18 18:23:33 -0700 Created attachment 429013 Patch 1761532 2 ews-feeder 2021-05-19 08:04:43 -0700 Committed r277721 (237900@main): <https://commits.webkit.org/237900@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429013. 1761533 3 webkit-bug-importer 2021-05-19 08:05:18 -0700 <rdar://problem/78205636> 429013 2021-05-18 18:23:33 -0700 2021-05-19 08:04:44 -0700 Patch bug-225951-20210518182333.patch text/plain 1919 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3NjkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDE0OTg5OTFkMjk2NjFl ZGYzNjk3ZjQ1YWFlNzg5NmI3ZDBhMjk1Ni4uYTNjYmQ4Nzg3Njc4YmRjZGNkNzhlYjFiNTBjOTQ0 MDNiYWM5Y2YyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA1LTE4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGZsYWt5IGFzc2VydGlv biBoaXQgdW5kZXIgQXVkaW9TdW1taW5nSnVuY3Rpb246OnJlbW92ZU91dHB1dCgpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU5NTEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZW1wb3JhcmlseSBkaXNh YmxlIGFzc2VydGlvbiBwcmV2ZW50aW5nIGhlYXAgYWxsb2NhdGlvbnMgb24gdGhlIGF1ZGlvIHRo cmVhZAorICAgICAgICBpbiBBdWRpb1N1bW1pbmdKdW5jdGlvbjo6cmVtb3ZlT3V0cHV0KCkgYXMg aXQgaXMgZmxha2lseSBoaXR0aW5nIG9uIHRoZSBib3RzLgorCisgICAgICAgICogTW9kdWxlcy93 ZWJhdWRpby9BdWRpb1N1bW1pbmdKdW5jdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBdWRp b1N1bW1pbmdKdW5jdGlvbjo6cmVtb3ZlT3V0cHV0KToKKwogMjAyMS0wNS0xOCAgQ2hyaXMgRHVt ZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFtIYXJkZW5pbmddIENBUmluZ0J1ZmZl ciBzaG91bGQgdmFsaWRhdGUgdGhlIHN0b3JhZ2Ugc2l6ZSBiZWZvcmUgYWRvcHRpbmcgaXQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9TdW1taW5nSnVu Y3Rpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb1N1bW1pbmdK dW5jdGlvbi5jcHAKaW5kZXggYTRmOTZhMTNjZTAxODkxZmRmZDNjY2Y0YWU1OGZkNWJkOTkwNTBi My4uZjdlNzZiMjc4NTdlYWRiZTQ0ZWZhZGI4OTg2Yzg5NDYxNzZjMzQ1NiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb1N1bW1pbmdKdW5jdGlvbi5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb1N1bW1pbmdKdW5jdGlv bi5jcHAKQEAgLTc4LDkgKzc4LDEyIEBAIGJvb2wgQXVkaW9TdW1taW5nSnVuY3Rpb246OnJlbW92 ZU91dHB1dChBdWRpb05vZGVPdXRwdXQmIG91dHB1dCkKICAgICBpZiAoIW1fb3V0cHV0cy5yZW1v dmUoJm91dHB1dCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIGlmIChtX3BlbmRpbmdS ZW5kZXJpbmdPdXRwdXRzLmlzRW1wdHkoKSkKKyAgICBpZiAobV9wZW5kaW5nUmVuZGVyaW5nT3V0 cHV0cy5pc0VtcHR5KCkpIHsKKyAgICAgICAgLy8gSGVhcCBhbGxvY2F0aW9ucyBhcmUgZm9yYmlk ZGVuIG9uIHRoZSBhdWRpbyB0aHJlYWQgZm9yIHBlcmZvcm1hbmNlIHJlYXNvbnMgc28gd2UgbmVl ZCB0bworICAgICAgICAvLyBleHBsaWNpdGx5IGFsbG93IHRoZSBmb2xsb3dpbmcgYWxsb2NhdGlv bihzKS4KKyAgICAgICAgRGlzYWJsZU1hbGxvY1Jlc3RyaWN0aW9uc0ZvckN1cnJlbnRUaHJlYWRT Y29wZSBkaXNhYmxlTWFsbG9jUmVzdHJpY3Rpb25zOwogICAgICAgICBtX3BlbmRpbmdSZW5kZXJp bmdPdXRwdXRzID0gY29weVRvVmVjdG9yKG1fb3V0cHV0cyk7Ci0gICAgZWxzZQorICAgIH0gZWxz ZQogICAgICAgICBtX3BlbmRpbmdSZW5kZXJpbmdPdXRwdXRzLnJlbW92ZUZpcnN0KCZvdXRwdXQp OwogCiAgICAgbWFya1JlbmRlcmluZ1N0YXRlQXNEaXJ0eSgpOwo=