225938 2021-05-18 14:31:26 -0700 REGRESSION (r275013): Trying to navigate in a WKWebView from a command line tool crashes the Web Content process 2021-05-18 15:34:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton achristensen ggaren simon.fraser webkit-bug-importer oldest_to_newest 1761318 0 thorton 2021-05-18 14:31:26 -0700 REGRESSION (r275013): Trying to navigate in a WKWebView from a command line tool crashes the Web Content process 1761319 1 428981 thorton 2021-05-18 14:31:41 -0700 Created attachment 428981 Patch 1761320 2 thorton 2021-05-18 14:31:43 -0700 <rdar://problem/78029118> 1761323 3 428981 achristensen 2021-05-18 14:49:33 -0700 Comment on attachment 428981 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428981&action=review > Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:122 > + delegate.getClientBundleIdentifier(parameters.clientBundleIdentifier); It would be nice if you could make these not return-by-reference. This looks like it has no side effects, but it does. 1761324 4 thorton 2021-05-18 14:52:26 -0700 Agreed, this code could be much more clear. 1761344 5 ews-feeder 2021-05-18 15:34:19 -0700 Committed r277683 (237883@main): <https://commits.webkit.org/237883@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428981. 428981 2021-05-18 14:31:41 -0700 2021-05-18 15:34:20 -0700 Patch bug-225938-20210518143140.patch text/plain 3189 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE0Y2VjN2VlZWU5NWQzYWQw MzdlODFkM2NlN2Q3OTQ0OGQ1NTE3ZjkuLjE3ZjViOWNmOTI1MDBlN2QxYjVkZGFmY2I5ZjY3ODcz NzJiZGEwMjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMDUtMTggIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI3 NTAxMyk6IFRyeWluZyB0byBuYXZpZ2F0ZSBpbiBhIFdLV2ViVmlldyBmcm9tIGEgY29tbWFuZCBs aW5lIHRvb2wgY3Jhc2hlcyB0aGUgV2ViIENvbnRlbnQgcHJvY2VzcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1OTM4CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS83ODAyOTExOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFNoYXJlZC9FbnRyeVBvaW50VXRpbGl0aWVzL0NvY29hL1hQQ1NlcnZpY2Uv WFBDU2VydmljZUVudHJ5UG9pbnQuaDoKKyAgICAgICAgKFdlYktpdDo6WFBDU2VydmljZUluaXRp YWxpemVyKToKKyAgICAgICAgU29tZSBraW5kcyBvZiBwcm9jZXNzZXMgZG8gbm90IGhhdmUgYSBi dW5kbGUgaWRlbnRpZmllciwgc28gcmVxdWlyaW5nIG9uZQorICAgICAgICBpcyBzaW1wbHkgbm90 IGdvaW5nIHRvIHdvcmsuCisKKyAgICAgICAgQWxzbywgbWFrZSB0aGUgb3RoZXIgZXhpdCgpcyBp biB0aGlzIGZ1bmN0aW9uIHVzZSBDUkFTSCgpIGluc3RlYWQsIHNvCisgICAgICAgIHRoYXQgdGhl eSBtYWtlIHRyYWRpdGlvbmFsIGNyYXNoIGxvZ3MgaW5zdGVhZCBvZiBqdXN0IGV4aXRpbmcgd2l0 aCBhCisgICAgICAgIG5vbi16ZXJvIGVycm9yIGNvZGUgKHdoaWNoIGlzIG11Y2ggcXVpZXRlciku CisKIDIwMjEtMDUtMTEgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9y Zz4KIAogICAgICAgICBSZW1vdmUgeHBjX2Nvbm5lY3Rpb25fa2lsbApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9TaGFyZWQvRW50cnlQb2ludFV0aWxpdGllcy9Db2NvYS9YUENTZXJ2aWNlL1hQ Q1NlcnZpY2VFbnRyeVBvaW50LmggYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9FbnRyeVBvaW50VXRp bGl0aWVzL0NvY29hL1hQQ1NlcnZpY2UvWFBDU2VydmljZUVudHJ5UG9pbnQuaAppbmRleCA0NGY5 MDY4YzI3N2EwN2I5OGRkOWE0MTNkNWZlZWZkN2YzOGEyZDg0Li5lNmVlNjNkNWRjMGE1MDFiOGI3 MGM0ODAzZGYyN2Q1MmE3MTZjOTZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9F bnRyeVBvaW50VXRpbGl0aWVzL0NvY29hL1hQQ1NlcnZpY2UvWFBDU2VydmljZUVudHJ5UG9pbnQu aAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9FbnRyeVBvaW50VXRpbGl0aWVzL0NvY29hL1hQ Q1NlcnZpY2UvWFBDU2VydmljZUVudHJ5UG9pbnQuaApAQCAtMTA2LDM0ICsxMDYsMzQgQEAgdm9p ZCBYUENTZXJ2aWNlSW5pdGlhbGl6ZXIoT1NPYmplY3RQdHI8eHBjX2Nvbm5lY3Rpb25fdD4gY29u bmVjdGlvbiwgeHBjX29iamVjdF8KICAgICBJbml0aWFsaXplV2ViS2l0MigpOwogCiAgICAgaWYg KCFkZWxlZ2F0ZS5jaGVja0VudGl0bGVtZW50cygpKQotICAgICAgICBleGl0KEVYSVRfRkFJTFVS RSk7CisgICAgICAgIENSQVNIKCk7CiAKICAgICBBdXhpbGlhcnlQcm9jZXNzSW5pdGlhbGl6YXRp b25QYXJhbWV0ZXJzIHBhcmFtZXRlcnM7CiAgICAgaWYgKHByaW9yaXR5Qm9vc3RNZXNzYWdlKQog ICAgICAgICBwYXJhbWV0ZXJzLnByaW9yaXR5Qm9vc3RNZXNzYWdlID0gcHJpb3JpdHlCb29zdE1l c3NhZ2U7CiAKICAgICBpZiAoIWRlbGVnYXRlLmdldENvbm5lY3Rpb25JZGVudGlmaWVyKHBhcmFt ZXRlcnMuY29ubmVjdGlvbklkZW50aWZpZXIpKQotICAgICAgICBleGl0KEVYSVRfRkFJTFVSRSk7 CisgICAgICAgIENSQVNIKCk7CiAKICAgICBpZiAoIWRlbGVnYXRlLmdldENsaWVudElkZW50aWZp ZXIocGFyYW1ldGVycy5jbGllbnRJZGVudGlmaWVyKSkKLSAgICAgICAgZXhpdChFWElUX0ZBSUxV UkUpOworICAgICAgICBDUkFTSCgpOwogCi0gICAgaWYgKCFkZWxlZ2F0ZS5nZXRDbGllbnRCdW5k bGVJZGVudGlmaWVyKHBhcmFtZXRlcnMuY2xpZW50QnVuZGxlSWRlbnRpZmllcikpCi0gICAgICAg IGV4aXQoRVhJVF9GQUlMVVJFKTsKKyAgICAvLyBUaGUgaG9zdCBwcm9jZXNzIG1heSBub3QgaGF2 ZSBhIGJ1bmRsZSBpZGVudGlmaWVyIChlLmcuIGEgY29tbWFuZCBsaW5lIGFwcCksIHNvIGRvbid0 IHJlcXVpcmUgb25lLgorICAgIGRlbGVnYXRlLmdldENsaWVudEJ1bmRsZUlkZW50aWZpZXIocGFy YW1ldGVycy5jbGllbnRCdW5kbGVJZGVudGlmaWVyKTsKIAogICAgIGlmICghZGVsZWdhdGUuZ2V0 Q2xpZW50U0RLVmVyc2lvbihwYXJhbWV0ZXJzLmNsaWVudFNES1ZlcnNpb24pKQotICAgICAgICBl eGl0KEVYSVRfRkFJTFVSRSk7CisgICAgICAgIENSQVNIKCk7CiAKICAgICBXZWJDb3JlOjpQcm9j ZXNzSWRlbnRpZmllciBwcm9jZXNzSWRlbnRpZmllcjsKICAgICBpZiAoIWRlbGVnYXRlLmdldFBy b2Nlc3NJZGVudGlmaWVyKHByb2Nlc3NJZGVudGlmaWVyKSkKLSAgICAgICAgZXhpdChFWElUX0ZB SUxVUkUpOworICAgICAgICBDUkFTSCgpOwogICAgIHBhcmFtZXRlcnMucHJvY2Vzc0lkZW50aWZp ZXIgPSBwcm9jZXNzSWRlbnRpZmllcjsKIAogICAgIGlmICghZGVsZWdhdGUuZ2V0Q2xpZW50UHJv Y2Vzc05hbWUocGFyYW1ldGVycy51aVByb2Nlc3NOYW1lKSkKLSAgICAgICAgZXhpdChFWElUX0ZB SUxVUkUpOworICAgICAgICBDUkFTSCgpOwogCiAgICAgaWYgKCFkZWxlZ2F0ZS5nZXRFeHRyYUlu aXRpYWxpemF0aW9uRGF0YShwYXJhbWV0ZXJzLmV4dHJhSW5pdGlhbGl6YXRpb25EYXRhKSkKLSAg ICAgICAgZXhpdChFWElUX0ZBSUxVUkUpOworICAgICAgICBDUkFTSCgpOwogCiAgICAgLy8gU2V0 IHRoZSB0YXNrIGRlZmF1bHQgdm91Y2hlciB0byB0aGUgY3VycmVudCB2YWx1ZSAoYXMgcHJvcGFn YXRlZCBieSBYUEMpLgogICAgIHZvdWNoZXJfcmVwbGFjZV9kZWZhdWx0X3ZvdWNoZXIoKTsK