225934 2021-05-18 13:24:53 -0700 Clean up git svn mapping when git pull 2021-05-18 14:26:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zhifei_fang zhifei_fang dewei_zhu jbedard rniwa webkit-bug-importer zhifei_fang oldest_to_newest 1761274 0 zhifei_fang 2021-05-18 13:24:53 -0700 Clean up git svn mapping when git pull 1761275 1 428974 zhifei_fang 2021-05-18 13:25:04 -0700 Created attachment 428974 Patch 1761277 2 zhifei_fang 2021-05-18 13:28:05 -0700 There will be a time different when publish our commit to GitHub and our svn server. git svn will build a fake commit when it can not find the GitHub commit but find a svn revision, it won't include the identifier and it won't have any real commits point to it after the git pull, we should rebuild the svn map to make sure the revision point to the GitHub commit. 1761286 3 428974 rniwa 2021-05-18 13:36:26 -0700 Comment on attachment 428974 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428974&action=review > Websites/perf.webkit.org/tools/sync-commits.py:291 > + subprocess.check_call(['rm', '-rf', os.path.join(self._git_checkout, '.git/svn')]) Yikes. 1761315 4 ews-feeder 2021-05-18 14:25:52 -0700 Committed r277679 (237880@main): <https://commits.webkit.org/237880@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428974. 1761316 5 webkit-bug-importer 2021-05-18 14:26:19 -0700 <rdar://problem/78173466> 428974 2021-05-18 13:25:04 -0700 2021-05-18 14:25:53 -0700 Patch bug-225934-20210518132504.patch text/plain 1371 zhifei_fang U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3NjcxCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCBhY2ZlNDc3NjI1ZjQzMzA1Y2E3NzZjNzUxZjc2MmMzYWMxMTRiMjU2Li42MGRhMWM1ZDhj MGM5ZDljZjQ2ZDJiNDkxODFhODA0ZGJhMzBlM2YxIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMS0wNS0xOCAgWmhpZmVpIEZhbmcgIDx6aGlmZWlf ZmFuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQ2xlYW4gdXAgZ2l0IHN2biBtYXBwaW5nIHdoZW4g Z2l0IHB1bGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIyNTkzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogdG9vbHMvc3luYy1jb21taXRzLnB5OgorICAgICAgICAoR2l0UmVwb3NpdG9yeS5fZmV0Y2hf cmVtb3RlKToKKwogMjAyMS0wNS0xOCAgWmhpZmVpIEZhbmcgIDx6aGlmZWlfZmFuZ0BhcHBsZS5j b20+CiAKICAgICAgICAgQ29tbWl0cyB1cGRhdGVyIHNob3VsZCBpZ25vcmUgbnVsbCByZXZpc2lv biBpZGVudGlmaWVyCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvdG9vbHMv c3luYy1jb21taXRzLnB5IGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3Rvb2xzL3N5bmMtY29t bWl0cy5weQppbmRleCA3ZWNhNDk4ZTU3NzBmOTc0YmE2OTMwM2FiYmE2ODMzNDgzOGM3OTIzLi5k YmYxMzhhMzI4YzYzNzRlY2Y3MjRiYTdiODQ3ZDk4ZGY1OGU3M2RlIDEwMDc1NQotLS0gYS9XZWJz aXRlcy9wZXJmLndlYmtpdC5vcmcvdG9vbHMvc3luYy1jb21taXRzLnB5CisrKyBiL1dlYnNpdGVz L3BlcmYud2Via2l0Lm9yZy90b29scy9zeW5jLWNvbW1pdHMucHkKQEAgLTI4OCw2ICsyODgsNyBA QCBjbGFzcyBHaXRSZXBvc2l0b3J5KFJlcG9zaXRvcnkpOgogICAgIGRlZiBfZmV0Y2hfcmVtb3Rl KHNlbGYpOgogICAgICAgICBzZWxmLl9ydW5fZ2l0X2NvbW1hbmQoWydwdWxsJywgc2VsZi5fZ2l0 X3VybF0pCiAgICAgICAgIGlmIHNlbGYuX3JlcG9ydF9zdm5fcmV2aXNpb246CisgICAgICAgICAg ICBzdWJwcm9jZXNzLmNoZWNrX2NhbGwoWydybScsICctcmYnLCBvcy5wYXRoLmpvaW4oc2VsZi5f Z2l0X2NoZWNrb3V0LCAnLmdpdC9zdm4nKV0pCiAgICAgICAgICAgICBzZWxmLl9ydW5fZ2l0X2Nv bW1hbmQoWydzdm4nLCAnZmV0Y2gnXSkKIAogICAgIGRlZiBfZmV0Y2hfYWxsX2hhc2hlcyhzZWxm KToK