225898 2021-05-17 17:27:46 -0700 [lint-test-expectations] Change shebang to Python 3 2021-05-18 12:03:31 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=225925 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ews-watchlist glenn webkit-bug-importer oldest_to_newest 1760967 0 jbedard 2021-05-17 17:27:46 -0700 lint-test-expectations should be invoked with Python 3. 1760968 1 webkit-bug-importer 2021-05-17 17:28:09 -0700 <rdar://problem/78130334> 1760971 2 428898 jbedard 2021-05-17 17:35:12 -0700 Created attachment 428898 Patch 1761163 3 428898 aakash_jain 2021-05-18 08:40:44 -0700 Comment on attachment 428898 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428898&action=review > Tools/Scripts/webkitpy/common/version_check.py:-32 > -if sys.version < '2.7' or sys.version >= '2.8': Are we dropping support for 2.7? If so, it would a good idea to have exit early here if this code is run with python 2.7 (or atleast print a warning that python 2.7 is not supported anymore). 1761165 4 jbedard 2021-05-18 08:53:48 -0700 (In reply to Aakash Jain from comment #3) > Comment on attachment 428898 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=428898&action=review > > > Tools/Scripts/webkitpy/common/version_check.py:-32 > > -if sys.version < '2.7' or sys.version >= '2.8': > > Are we dropping support for 2.7? If so, it would a good idea to have exit > early here if this code is run with python 2.7 (or atleast print a warning > that python 2.7 is not supported anymore). I guess we can keep the "less than 2.7" check, the trouble is that this check applies to more than just this script. I object to enshrining version checks like this anyways, we support some versions of Python 3 right now, but even that depends on the script and platform (ie, windows supports Python 3.8+, Mac supports only supports up to Python 3.7) 1761183 5 428946 jbedard 2021-05-18 09:31:32 -0700 Created attachment 428946 Patch 1761230 6 ews-feeder 2021-05-18 12:03:30 -0700 Committed r277668 (237870@main): <https://commits.webkit.org/237870@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428946. 428898 2021-05-17 17:35:12 -0700 2021-05-18 09:31:30 -0700 Patch bug-225898-20210517173511.patch text/plain 2019 jbedard U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3NjE4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWNkZjYxNzYyZjljNjJlMjA0MzYyYzIxYzQ3ZmRmZTNl OTA1NzEwZC4uNTg5NTAwYWI5ZjcwNTYwMzQ0NWE5MmMzYmFiOGRkMDIzY2Y1ZDQxNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIxLTA1LTE3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKwor ICAgICAgICBbbGludC10ZXN0LWV4cGVjdGF0aW9uc10gQ2hhbmdlIHNoZWJhbmcgdG8gUHl0aG9u IDMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTg5 OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzgxMzAzMzQ+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2xpbnQtdGVzdC1leHBlY3Rh dGlvbnM6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vdmVyc2lvbl9jaGVjay5w eToKKwogMjAyMS0wNS0xNyAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAK ICAgICAgICAgW3dlYmtpdHNjbXB5XSBTdXBwb3J0IHRlc3Rpbmcgb24gbWFjaGluZXMgd2l0aG91 dCBzdm4gaW5zdGFsbGVkCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2xpbnQtdGVzdC1leHBl Y3RhdGlvbnMgYi9Ub29scy9TY3JpcHRzL2xpbnQtdGVzdC1leHBlY3RhdGlvbnMKaW5kZXggYzU2 ZWI3N2RiYjA0NjI4YTcxMTMzMGY0YTBjNjNkZmQ1NWY4MzQzYS4uOWI5NTVjNzAyYWJjZDc2N2Yx NjVjN2Y4MjYzNzYwNzM0ZmFmMzVkYiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9saW50LXRl c3QtZXhwZWN0YXRpb25zCisrKyBiL1Rvb2xzL1NjcmlwdHMvbGludC10ZXN0LWV4cGVjdGF0aW9u cwpAQCAtMSw0ICsxLDQgQEAKLSMhL3Vzci9iaW4vZW52IHB5dGhvbgorIyEvdXNyL2Jpbi9lbnYg cHl0aG9uMwogIyBDb3B5cmlnaHQgKEMpIDIwMTIgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNl cnZlZC4KICMKICMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBm b3Jtcywgd2l0aCBvciB3aXRob3V0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi92ZXJzaW9uX2NoZWNrLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v dmVyc2lvbl9jaGVjay5weQppbmRleCA4NDU0Yjc1MTg2NTc0ZGU5ZjE2ZGY3ZTU2OGJjM2ZmNTMw NjIxMTRkLi41NjEwMTk4YjYzYTdhZTQxNTVmMDVhZDI4NzMzMTcxNGRjNjE3N2RmIDEwMDY0NAot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi92ZXJzaW9uX2NoZWNrLnB5CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3ZlcnNpb25fY2hlY2sucHkKQEAgLTEsNCAr MSw1IEBACiAjIENvcHlyaWdodCAoYykgMjAxMSBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2Vy dmVkLgorIyBDb3B5cmlnaHQgKEMpIDIwMjEgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVk LgogIwogIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1z LCB3aXRoIG9yIHdpdGhvdXQKICMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVk IHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQpAQCAtMjgsNyArMjksMyBAQAogCiBm cm9tIF9fZnV0dXJlX18gaW1wb3J0IHByaW50X2Z1bmN0aW9uCiBpbXBvcnQgc3lzCi0KLWlmIHN5 cy52ZXJzaW9uIDwgJzIuNycgb3Igc3lzLnZlcnNpb24gPj0gJzIuOCc6Ci0gICAgcHJpbnQoIlVu c3VwcG9ydGVkIFB5dGhvbiB2ZXJzaW9uOiBXZWJLaXQgb25seSBzdXBwb3J0cyAyLjcueCwgYW5k IHlvdSdyZSBydW5uaW5nICVzLiIgJSBzeXMudmVyc2lvbi5zcGxpdCgpWzBdLCBmaWxlPXN5cy5z dGRlcnIpCi0gICAgc3lzLmV4aXQoMSkK 428946 2021-05-18 09:31:32 -0700 2021-05-18 12:03:30 -0700 Patch bug-225898-20210518093131.patch text/plain 1308 jbedard U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3NjU1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzdiNWU1ZTcxNmNkYzc4YWEyYmQ3NzFlMzYwMDhlM2Rm NjRjYjU2NC4uNTViM2EzMDMwMzNjZGM1ODY3OThmNDBhNjBmMzY1YWZjOGJiMmNmYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIxLTA1LTE4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKwor ICAgICAgICBbbGludC10ZXN0LWV4cGVjdGF0aW9uc10gQ2hhbmdlIHNoZWJhbmcgdG8gUHl0aG9u IDMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTg5 OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzgxMzAzMzQ+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2xpbnQtdGVzdC1leHBlY3Rh dGlvbnM6IENoYW5nZSBzaGViYW5nLCByZW1vdmUgdmVyc2lvbiBjaGVjay4KKwogMjAyMS0wNS0x NyAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbR1BV IFByb2Nlc3NdIE9iamVjdCBpZGVudGlmaWVycyB3aXRoIHRoZSBkZWxldGVkIHZhbHVlIHNob3Vs ZCBjYXVzZSBNRVNTQUdFX0NIRUNLcwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9saW50LXRl c3QtZXhwZWN0YXRpb25zIGIvVG9vbHMvU2NyaXB0cy9saW50LXRlc3QtZXhwZWN0YXRpb25zCmlu ZGV4IGM1NmViNzdkYmIwNDYyOGE3MTEzMzBmNGEwYzYzZGZkNTVmODM0M2EuLjM0NTFkZjNjODI1 NDQ3YTcxYjJmZGMyMjk1OTA2YmRjY2IwMzQ3MWYgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv bGludC10ZXN0LWV4cGVjdGF0aW9ucworKysgYi9Ub29scy9TY3JpcHRzL2xpbnQtdGVzdC1leHBl Y3RhdGlvbnMKQEAgLTEsNCArMSw0IEBACi0jIS91c3IvYmluL2VudiBweXRob24KKyMhL3Vzci9i aW4vZW52IHB5dGhvbjMKICMgQ29weXJpZ2h0IChDKSAyMDEyIEdvb2dsZSBJbmMuIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCiAjCiAjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBi aW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dApAQCAtMjksNyArMjksNiBAQAogCiBpbXBvcnQg c3lzCiAKLWZyb20gd2Via2l0cHkuY29tbW9uIGltcG9ydCB2ZXJzaW9uX2NoZWNrCiBmcm9tIHdl YmtpdHB5LmxheW91dF90ZXN0cyBpbXBvcnQgbGludF90ZXN0X2V4cGVjdGF0aW9ucwogCiAK